Opened 11 years ago
Last modified 11 years ago
#12110 closed Bug
[PR#104] Editor crash after deleting a table. — at Version 6
| Reported by: | Piotr Jasiun | Owned by: | Marek Lewandowski |
|---|---|---|---|
| Priority: | Normal | Milestone: | CKEditor 4.4.3 |
| Component: | General | Version: | 4.0 Beta |
| Keywords: | Cc: | mike@… |
Description (last modified by )
Scenario:
- Have an inline initialized editor
- In that editor add a table and ensure that it is the sole element in the editable container (nothing before and nothing after)
- Use the contextual menu to delete the table
- The editor is no longer working :(
Note: This can be reproduced also on the demo site: http://ckeditor.com/demo#inline
The fix: Just added a check to not remove the parent element of the table if that parent is the container.
PR: https://github.com/ckeditor/ckeditor-dev/pull/104
Related ticket: #12122
Change History (6)
comment:1 Changed 11 years ago by
| Status: | new → confirmed |
|---|---|
| Version: | → 4.0 Beta |
comment:3 Changed 11 years ago by
| Cc: | mike@… added |
|---|
comment:4 Changed 11 years ago by
| Owner: | set to Marek Lewandowski |
|---|---|
| Status: | confirmed → assigned |
comment:5 Changed 11 years ago by
| Status: | assigned → review |
|---|
Branch rebased and pushed tests to t/12110 at dev.
I've also removed parent.is( 'body' ) part in git:f3468044ab - as it seems to be redundant to me when checking editable.equals( parent ).
From my testing it does not break removing table directly in fullpage mode - as fullpage <body/> elmeent is still editable.
comment:6 Changed 11 years ago by
| Description: | modified (diff) |
|---|---|
| Milestone: | → CKEditor 4.4.3 |
Note: See
TracTickets for help on using
tickets.
Problem can be reproduced from CKEditor 4.0 beta.
Reminded me #9315 but they are rather not related.