#12129 closed Bug (duplicate)
config.fillEmptyBlocks does not accept callback
| Reported by: | Piotrek Koszuliński | Owned by: | Piotrek Koszuliński |
|---|---|---|---|
| Priority: | Normal | Milestone: | |
| Component: | General | Version: | |
| Keywords: | Cc: |
Description
This needs to be investigated. In 3.5 (#5404), when option was introduced it has been accepting callback. Then, at some point this change was made:
blockFilter( isOutput, editor.config.fillEmptyBlocks !== false );
And it's obviously wrong now. However, at some point also docs have been modified and the type of this setting is now Boolean (no Function). So perhaps it was an intentional change. In such case we should fix docs, not code.
Change History (3)
comment:1 Changed 11 years ago by
| Status: | new → confirmed |
|---|
comment:2 Changed 10 years ago by
| Owner: | set to Piotrek Koszuliński |
|---|---|
| Status: | confirmed → assigned |
comment:3 Changed 10 years ago by
| Milestone: | CKEditor 4.4.3 |
|---|---|
| Resolution: | → duplicate |
| Status: | assigned → closed |
Version 0, edited 10 years ago
by
(next)
Note: See
TracTickets for help on using
tickets.
Issue was introduced in git:ea074195, when porting v3 changes to v4. Therefore I assume that fillEmptyBlocks should still accept functions. It also turned out that this ticket is a DUP of #12129.