Setting to disable our custom menu

[Frederico Caldeira Knabben]

There should be a configurable way to not use our custom context menu at all, leaving the default browser context menu to work.

The solution is already proposed at #311. I think the "BrowserContextMenu" setting name is better because it follows the already present "BrowserContextMenuOnCtrl" name.

[Alfonso Martínez de Lizarrondo]

instead of adding another setting we could fix #1683 instead and get the same end result.

[Frederico Caldeira Knabben]

Replying to alfonsoml:

instead of adding another setting we could fix #1683 instead and get the same end result.

A dedicated setting for it, other than making it much simpler (to configure an to implement), sounds like a much more evident solution for this need.

#1683 sounds a bit ambiguous... what should happen if you right click on the text, and you have only "Image" in the ContextMenu setting? Should it display the browser context menu or nothing?

[Martin Kou]

Unfortunately, I have to reverse my Review+ because of some potential problems in the patch.

First problem... the patch causes the browser menu to appear automagically if the user upgraded from a previous FCKeditor version's fckconfig.js - FCKConfig.BrowserContextMenu == false evaluates to false when the option is undefined.

Second problem... the current approach doesn't allow the setting to be changed after FCKeditor has loaded. It might be better if the check is implemented at the context menu/click event handler, instead of at load time.

Much thanks to Alfonso for reporting these problems to me in the IRC channel.

[Frederico Caldeira Knabben]

Btw, please move the changelog entry to the "New Features" block before committing.

[Martin Kou]

Fixed with [2221].

Click here for more info about our SVN system.