Opened 16 years ago
Closed 16 years ago
#2883 closed Task (fixed)
Implement align commands.
| Reported by: | Martin Kou | Owned by: | Martin Kou |
|---|---|---|---|
| Priority: | Normal | Milestone: | CKEditor 3.0 |
| Component: | General | Version: | SVN (FCKeditor) - Retired |
| Keywords: | Review+ | Cc: |
Description
Need to implement the align commands and add them to the toolbar
Attachments (2)
Change History (8)
comment:1 Changed 16 years ago by
| Owner: | set to Martin Kou |
|---|---|
| Status: | new → assigned |
Changed 16 years ago by
| Attachment: | 2883.patch added |
|---|
comment:2 Changed 16 years ago by
| Keywords: | Review? added |
|---|
comment:3 Changed 16 years ago by
| Keywords: | Review- added; Review? removed |
|---|
This patch is being hard to apply. It contains the old code duplication issue you were having previously.
Now we have other dependencies on trunk. Can you please provide an updated and simplified patch?
Changed 16 years ago by
| Attachment: | 2883_2.patch added |
|---|
comment:4 Changed 16 years ago by
| Keywords: | Review? added; Review- removed |
|---|
Two things fixed apart from adding the justify plugin:
- Added CKEDITOR.editor::forceNextSelectionCheck() in selection plugin. The functions forces a selectionChanged event even though the selection's element path has not changed. Useful for toolbar buttons that doesn't change the element path but changes CSS styles like text-align and margin-left.
- Removed onSelectionSet function hook in selection plugin which is made obsolete by the patch in #2835.
comment:5 Changed 16 years ago by
| Keywords: | Review+ added; Review? removed |
|---|
Note: See
TracTickets for help on using
tickets.
The patch depends on #2864 and #2871. I've included them in my patch as well so there's no need to do a few patches at the same time to test.