Indenting list item remove subsequent item

[Josh Nisly]

• Open the replace by class example.

• Make the following content by using the Source button:

  <ul>
  	<li>
  		Item 1
  		<ul>
  			<li>
  				Item 2</li>
  			<li>
  				Item 3</li>
  		</ul>
  	</li>
  	<li>
  		Item 4<br />
  	</li>
  </ul>
  

• Place the cursor after the 3 in "Item 3".

• Choose increase indent. Expected result:

  <ul>
  	<li>
  		Item 1
  		<ul>
  			<li>
  				Item 2
  				<ul>
  					<li>
  						Item 3</li>
  				</ul>
  			</li>
  		</ul>
  	</li>
  	<li>
  		Item 4<br />
  	</li>
  </ul>
  

• Actual result:

  <ul>
  	<li>
  		Item 1
  		<ul>
  			<li>
  				Item 2</li>
  			<li>
  				Item 3</li>
  		</ul>
  	</li>
  </ul>
  

This can be reproduced with any of the nightly samples.

[Garry Yao]

Fixed with [3391]. Click here for more info about our SVN system.

[Garry Yao]

The trunk is broken caused by a logic error.

[Martin Kou]

Hmm... I was aware of the fact that your simplification removed the nearestListBlock check in the while loop. But I though it was ok since it still worked in the list indent/outdent cases. But the error comes out when you are indenting normal blocks instead.

There should be no need to restore to the old, longer code. You can just change it to the following and it will work:

            while ( nearestListBlock && !( nearestListBlock.type == CKEDITOR.NODE_ELEMENT && listNodeNames[ nearestListBlock.getName() ] ) )
                nearestListBlock = nearestListBlock.getParent();

[Josh Nisly]

Yes, in fact, that is the bug and fix reported here: #3398.