Opened 9 years ago

Closed 8 years ago

#3517 closed Bug (fixed)

"Match cyclic" field in Find & Replace dialog

Reported by: Tobiasz Cudnik Owned by: Tobiasz Cudnik
Priority: Normal Milestone: CKEditor 3.1
Component: General Version:
Keywords: Confirmed Review+ Cc:

Description

I'm not sure if i understand correctly what "Match cyclic" should do, but if this is something like "Wrap search" or "Search from beginning after file end" then it acts in opposite way.

TC

  1. Use following content:
    <p>
    	This is some <strong>sample text</strong>. You are using^ <a href="http://www.fckeditor.net/">CKEditor</a>.</p>
    
  2. Search "are" with "Match cyclic" checked on. Nothing happens.
  3. Search "are" again, now with "Match cyclic" checked OFF. Now the text will be found.

Reproduced using r3500 in FF3, IE8.

Attachments (2)

3517.patch (1.9 KB) - added by Tobiasz Cudnik 8 years ago.
3517_2.patch (1.0 KB) - added by Garry Yao 8 years ago.

Download all attachments as: .zip

Change History (10)

comment:1 Changed 9 years ago by Frederico Caldeira Knabben

Milestone: CKEditor 3.0CKEditor 3.1

comment:2 Changed 9 years ago by Garry Yao

Keywords: Confirmed added

The 'cyclic' option means to have effect only after your already reached document end once, yes, it's reasonable to have it work right from the beginning.

comment:3 Changed 8 years ago by Tobiasz Cudnik

Owner: set to Tobiasz Cudnik
Status: newassigned

Changed 8 years ago by Tobiasz Cudnik

Attachment: 3517.patch added

comment:4 Changed 8 years ago by Tobiasz Cudnik

Keywords: Review? added

Patch adds little recursion (the safe one) which allows to find searched text in first run, when searched text is before cursor and "match cyclic" is turned on.

comment:5 Changed 8 years ago by Garry Yao

Keywords: Review- added; Review? removed

The recursion once idea is great, while the codes could be further simplified.

Changed 8 years ago by Garry Yao

Attachment: 3517_2.patch added

comment:6 Changed 8 years ago by Tobiasz Cudnik

Keywords: Review? added; Review- removed

I was missing this neat Array.prototype trick, thanks.

I'm adding Review? for 3517_2.patch.

comment:7 Changed 8 years ago by Garry Yao

Keywords: Review+ added; Review? removed

comment:8 Changed 8 years ago by Tobiasz Cudnik

Resolution: fixed
Status: assignedclosed

Fixed with [4193].

Note: See TracTickets for help on using tickets.
© 2003 – 2017 CKSource – Frederico Knabben. All rights reserved. | Terms of use | Privacy policy