Opened 8 years ago

Closed 8 years ago

Last modified 8 years ago

#3639 closed Bug (fixed)

Button size inconsistency

Reported by: Garry Yao Owned by: Tobiasz Cudnik
Priority: Normal Milestone: CKEditor 3.0
Component: UI : Dialogs Version:
Keywords: Kama Confirmed Review+ Cc:

Description

The size of different dialog buttons should be the same.

Attachments (6)

IE6.png (673 bytes) - added by Garry Yao 8 years ago.
Screenshot of IE6
FF3.png (2.2 KB) - added by Garry Yao 8 years ago.
Screenshot of FF3
3639.patch (917 bytes) - added by Artur Formella 8 years ago.
3639_2.patch (2.6 KB) - added by Tobiasz Cudnik 8 years ago.
IE6+Standards_Too_Large.png (28.5 KB) - added by Frederico Caldeira Knabben 8 years ago.
IE6+Patch Screenshot.
3639_3.patch (3.1 KB) - added by Tobiasz Cudnik 8 years ago.

Download all attachments as: .zip

Change History (15)

Changed 8 years ago by Garry Yao

Attachment: IE6.png added

Screenshot of IE6

Changed 8 years ago by Garry Yao

Attachment: FF3.png added

Screenshot of FF3

Changed 8 years ago by Artur Formella

Attachment: 3639.patch added

comment:1 Changed 8 years ago by Artur Formella

Keywords: Confirmed Review? added

comment:2 Changed 8 years ago by Tobiasz Cudnik

Keywords: Review- added; Review? removed

Still not wide enough in IE7 quirks (using IE8) - screenshot.

comment:3 Changed 8 years ago by Tobiasz Cudnik

Owner: set to Tobiasz Cudnik
Status: newassigned

Changed 8 years ago by Tobiasz Cudnik

Attachment: 3639_2.patch added

comment:4 Changed 8 years ago by Tobiasz Cudnik

Keywords: Review? added; Review- removed

comment:5 Changed 8 years ago by Frederico Caldeira Knabben

Keywords: Review- added; Review? removed

With the IE6+Standards combination, the buttons are too large. I'm attaching a screenshot of it.

In Safari, the sizes are also not good. Their height is wrong.

Ok with other browsers, including IE6+Quirks.

Changed 8 years ago by Frederico Caldeira Knabben

Attachment: IE6+Standards_Too_Large.png added

IE6+Patch Screenshot.

Changed 8 years ago by Tobiasz Cudnik

Attachment: 3639_3.patch added

comment:6 Changed 8 years ago by Tobiasz Cudnik

Keywords: Review? added; Review- removed

comment:7 Changed 8 years ago by Artur Formella

Keywords: Review+ added; Review? removed

Looks good...

comment:8 Changed 8 years ago by Tobiasz Cudnik

Resolution: fixed
Status: assignedclosed

Fixed with [3799].

comment:9 Changed 8 years ago by Alfonso Martínez de Lizarrondo

I don't know why the float:right was added for webkit, but now all the buttons in the dialogs are right aligned for Safari and Chrome: #4748

Note: See TracTickets for help on using tickets.
© 2003 – 2017 CKSource – Frederico Knabben. All rights reserved. | Terms of use | Privacy policy