Opened 15 years ago

Closed 15 years ago

Last modified 15 years ago

#4275 closed Bug (invalid)

CKEditor's tool bar is chopped off in IE7/IE8,

Reported by: Senthil Owned by: Tobiasz Cudnik
Priority: Must have (possibly next milestone) Milestone: CKEditor 3.1
Component: General Version:
Keywords: Oracle Cc: Pranav Senthil

Description

Patch delivered for Ticket #4237 (CKEditor's ToolBar is chopped off in Safari browser 3.x) is still not fixing the reported problem. So creating a new ticket as developer has asked to do so. Attaching the screenshot and sample file to replicate the problem.

Attachments (4)

config.js (839 bytes) - added by Senthil 15 years ago.
toolbar_chopped_off.jpg (144.7 KB) - added by Senthil 15 years ago.
replacebycode.2.html (3.0 KB) - added by Senthil 15 years ago.
replacebycode.html (3.0 KB) - added by Senthil 15 years ago.

Download all attachments as: .zip

Change History (10)

Changed 15 years ago by Senthil

Attachment: config.js added

Changed 15 years ago by Senthil

Attachment: toolbar_chopped_off.jpg added

Changed 15 years ago by Senthil

Attachment: replacebycode.2.html added

Changed 15 years ago by Senthil

Attachment: replacebycode.html added

comment:1 Changed 15 years ago by Garry Yao

Keywords: Confirmed added

It's enough to spread #4237's fix to all browsers to have this fixed.

comment:2 Changed 15 years ago by Garry Yao

Beside the mentioned issue, we should also notice that the background of toolbar is incorrectly fixed with 'arrows', probably due to the sprites.

comment:3 in reply to:  2 Changed 15 years ago by Garry Yao

Replying to garry.yao:

Beside the mentioned issue, we should also notice that the background of toolbar is incorrectly fixed with 'arrows', probably due to the sprites.

Ah, just see it's already been reported at #4276 as a separated issue.

comment:4 Changed 15 years ago by Tobiasz Cudnik

Owner: set to Tobiasz Cudnik
Status: newassigned

comment:5 Changed 15 years ago by Tobiasz Cudnik

Keywords: Confirmed removed
Resolution: invalid
Status: assignedclosed

I'm sorry but this is not a bug. It's about wrong toolbar config usage (or at least it's behavior understanding).

Toolbar is supposed to be wrapped on item groups, not item separators. In attached config there are only 3 groups, where each contains couple of separators. Editor width is very narrow and it should be wide at least as longest toolbar item group.

Browsers handle this situation in different ways, that's why IE just keeps it without break (which is correct) but they are out of viewport. FF forces to wrap them, but this results in garbaged layout (like visible sprites reported as #4276 but also as incorrect toolbar background, which shouldn't be an image).

This issue is something different than #4237, as problem there was wrapping of item groups.

If you change those "-" separators to groups, all will work fine. Here is the code.

config.toolbar =
[
	['Source','Image','Maximize','Preview','Print'], ['Cut','Copy','Paste'], ['Undo','Redo'], ['Find','Replace'], ['HorizontalRule','Table','imageUPLOAD','Link','Unlink','SpecialChar'],
	['Format','Font','FontSize'], ['Bold','Italic','Underline','Strike'],
	['JustifyLeft','JustifyCenter','JustifyRight','JustifyBlock'], ['NumberedList','BulletedList','Outdent','Indent'], ['TextColor','BGColor']
];

comment:6 Changed 15 years ago by Garry Yao

I see the same reason with Tobias, though this might not be a good user experience at the moment. Ideally editor width should dominate everything and toolbar group should be smart enough to adapt to it( e.g. cropp off extra items ) while this is out the scope of this ticket.

Note: See TracTickets for help on using tickets.
© 2003 – 2022, CKSource sp. z o.o. sp.k. All rights reserved. | Terms of use | Privacy policy