Opened 14 years ago

Last modified 8 years ago

#5094 confirmed New Feature

Dialog API: Custom alignment of radio buttons and their labels

Reported by: Martin Røssland Owned by:
Priority: Normal Milestone:
Component: UI : Dialogs Version: 3.0
Keywords: IBM HasPatch Cc: satya_minnekanti@…

Description

I have not found a good way to adjust the alignment of the radio buttons. The radio buttons is outputted as table cells in a single table row, that makes it impossible to use css to display them in an vertical list (Internet Explorer).

It would be great to have the following options for the radio element:

  • Vertical or horizontal display of radio buttons
  • Whether to display the labels above, below, in front of or behind the radio buttons.

Attachments (1)

radiobutton.JPG (27.7 KB) - added by Henrik Helmø Larsen 11 years ago.
An example of vertical allignment for radiobuttons

Download all attachments as: .zip

Change History (15)

comment:1 Changed 14 years ago by Frederico Caldeira Knabben

Resolution: invalid
Status: newclosed

CKEditor has no option to insert a list of radio options as you're describing. I think you are using the editor inside another system which has a plugin for it. In that case, there is nothing we can do here for you and you should contact the plugin developer.

Please correct me if I'm wrong.

comment:2 Changed 14 years ago by Martin Røssland

Resolution: invalid
Status: closedreopened

Sorry, maybe I should have been a little bit more specific.

I'm extending the link dialog with new link types (as a new plugin). Instead of having a select of different link types, I want to use radio buttons instead.

When using your UI framework, you define the different radio buttons as items on a radio element (please correct me if I'm wrong). My problem is that I have no way of changing how the radio buttons is outputted (please correct me again if I'm wrong). What I basically want is to have a vertical list instead of an horizontal list.

comment:3 Changed 14 years ago by Frederico Caldeira Knabben

Keywords: Confirmed added

Ah... much clearer now... we're talking about the dialog API here.

You're right, currently this is not possible.

comment:4 Changed 13 years ago by Jakub Ś

This issue was duplicated in #8104.

comment:5 Changed 13 years ago by Satya Minnekanti

Cc: satya_minnekanti@… added
Keywords: IBM added

comment:6 Changed 13 years ago by Jakub Ś

This issue was duplicated in #8329

Version 0, edited 13 years ago by Jakub Ś (next)

comment:8 Changed 13 years ago by Jakub Ś

Keywords: HasPatch added
Status: reopenedconfirmed

comment:10 Changed 13 years ago by Henrik Helmø Larsen

IE9 may have a problem when laying out the dialog - see case #8364.

comment:12 Changed 12 years ago by Jakub Ś

Keywords: Confirmed removed
Version: 3.13.0

When this feature will be implemented please check @Helmo2 issue #8364. His findings might be useful.

comment:13 Changed 11 years ago by Henrik Helmø Larsen

It has now been 17 months since I reported this issue - though not a bug it is a minor feature (2 lines of code)... I have now upgraded to 4.0.1 and it has not been added yet! Are there any plans for adding this? BW, Helmø

comment:14 in reply to:  13 Changed 11 years ago by Frederico Caldeira Knabben

Replying to Helmø:

A good way to speed up things is by proposing real and well coded fixes through GitHub pull requests over the ckeditor-dev repository: https://github.com/ckeditor/ckeditor-dev

comment:15 Changed 11 years ago by Henrik Helmø Larsen

You are right - I am sorry...

I have visited the pull request on GitHub.com - but cannot figure out how to submit a new item? Here comes a guide to other users with the same problem as me:

In order to layout radiobuttons vertical instead of (hardcoded) horizontal do the following: Open plugin.js in the dialogui folder in plugins. Finde the following line of code (line 416 of version 4.0.1):

new CKEDITOR.ui.dialog.hbox( dialog, children, inputHtmlList, html );

Replace it with the following code:

//Ability to support both vbox and hbox layout (backward compatible)
if ( elementDefinition.buttonLayout == 'vertical' )
  new CKEDITOR.ui.dialog.vbox( dialog, children, inputHtmlList, html );
else
  new CKEDITOR.ui.dialog.hbox( dialog, children, inputHtmlList, html );

When setting up a radio button compontent insert the following line to layout vertical:

buttonLayout : 'vertical'

Here is an example:

{
  type : 'radio',
  id : 'radioLink',
  label : 'Insert link to:',
  items : radioButtons,
  buttonLayout : 'vertical',
  setup : function( data ) {
          ...

Changed 11 years ago by Henrik Helmø Larsen

Attachment: radiobutton.JPG added

An example of vertical allignment for radiobuttons

comment:16 Changed 11 years ago by Nikola Petkanski

I made a pull request with the code quoted in this ticket:

comment:17 Changed 8 years ago by Anna Tomanek

Summary: UI: Radio element - alignment of radio buttons and its labelsDialog API: Custom alignment of radio buttons and their labels
Note: See TracTickets for help on using tickets.
© 2003 – 2022, CKSource sp. z o.o. sp.k. All rights reserved. | Terms of use | Privacy policy