Opened 14 years ago
Closed 13 years ago
#5500 closed Bug (fixed)
Missing attributes of Text Field
| Reported by: | Garry Yao | Owned by: | Garry Yao |
|---|---|---|---|
| Priority: | Normal | Milestone: | CKEditor 3.5.1 |
| Component: | General | Version: | 3.1 |
| Keywords: | IE | Cc: |
Description
Environment
All IE versions
Reproducing Procedures
- Open any of the sample page;
- Insert a text field with all fields filled;
- Switch to 'Source' mode and switch back;
- Open 'Text Field' dialog through context menu;
- Actual Result: 'Value' field value is missing.
Attachments (3)
Change History (18)
comment:1 Changed 14 years ago by
| Keywords: | IE Confirmed added |
|---|
Changed 14 years ago by
| Attachment: | 5500.patch added |
|---|
comment:2 Changed 14 years ago by
| Keywords: | Review? added |
|---|---|
| Owner: | set to Minh Nguyen |
| Status: | new → assigned |
comment:3 Changed 13 years ago by
| Keywords: | IE added; IEConfirmed removed |
|---|---|
| Milestone: | → CKEditor 3.5.1 |
comment:4 Changed 13 years ago by
WFM on trunk using the patch from #6646. Let's wait for that ticket to be resolved.
Changed 13 years ago by
| Attachment: | 5500_2.patch added |
|---|
comment:5 Changed 13 years ago by
This problem (related to input element r/w in IE7) is not related to #6646, affects both textfield and button dialogs.
comment:6 Changed 13 years ago by
| Owner: | changed from Minh Nguyen to Garry Yao |
|---|
comment:7 Changed 13 years ago by
| Status: | review → review_failed |
|---|
- The patch fixes the problem on native IE7 while fails on IE9's IE7 mode.
- Creating a button on a native IE7 results in a JS error.
- [IE9's IE7 mode] Create a button. Open the button dialog through a context menu. The value field is empty.
- Let's avoid changing the id of dialog fields for backwards compatibility.
Changed 13 years ago by
| Attachment: | 5500_3.patch added |
|---|
comment:8 Changed 13 years ago by
| Status: | review_failed → review |
|---|
The field is badly named, prefer a correction over back-compat here.
comment:9 Changed 13 years ago by
| Status: | review → review_passed |
|---|
comment:10 Changed 13 years ago by
| Resolution: | → fixed |
|---|---|
| Status: | review_passed → closed |
Fixed with [6314].
comment:11 Changed 13 years ago by
| Resolution: | fixed |
|---|---|
| Status: | closed → reopened |
Replying to garry.yao:
Environment
All IE versions
Reproducing Procedures
- Open any of the sample page;
- Insert a text field with all fields filled;
- Switch to 'Source' mode and switch back;
- Open 'Text Field' dialog through context menu;
- Actual Result: 'Value' field value is missing.
After switching to Source andv back to wysiwyg, Value field, still is cleared (IE6/7)
comment:12 Changed 13 years ago by
Update to comment 11 - Setting of cleared field is Password. I think, when user enters default value into content, it should be present for both Password ot Text fields (as the dialog window allows).
comment:13 Changed 13 years ago by
Setting a default value for a Password field doesn't make sense. I think that a new ticket should be opened to disable that possibility.
comment:14 Changed 13 years ago by
Under Opera, Firefox, Chrome - password default value is remembered. CKEditor should work similar under all browsers, that is why I reopened this ticket.
@Alfonso - I added new ticket #7042 as You suggested, so the discussion will continue there.
comment:15 Changed 13 years ago by
| Resolution: | → fixed |
|---|---|
| Status: | reopened → closed |
Always avoid open fixed (committed) ticket for regressions, this's even not a regression.
we had missed return value in case the type of input is 'text'