Opened 7 years ago

Closed 7 years ago

#5500 closed Bug (fixed)

Missing attributes of Text Field

Reported by: Garry Yao Owned by: Garry Yao
Priority: Normal Milestone: CKEditor 3.5.1
Component: General Version: 3.1
Keywords: IE Cc:

Description

Environment

All IE versions

Reproducing Procedures

  1. Open any of the sample page;
  2. Insert a text field with all fields filled;
  3. Switch to 'Source' mode and switch back;
  4. Open 'Text Field' dialog through context menu;
  • Actual Result: 'Value' field value is missing.

Attachments (3)

5500.patch (438 bytes) - added by Minh Nguyen 7 years ago.
we had missed return value in case the type of input is 'text'
5500_2.patch (4.4 KB) - added by Garry Yao 7 years ago.
5500_3.patch (4.9 KB) - added by Garry Yao 7 years ago.

Download all attachments as: .zip

Change History (18)

comment:1 Changed 7 years ago by Minh Nguyen

Keywords: IE Confirmed added

Changed 7 years ago by Minh Nguyen

Attachment: 5500.patch added

we had missed return value in case the type of input is 'text'

comment:2 Changed 7 years ago by Minh Nguyen

Keywords: Review? added
Owner: set to Minh Nguyen
Status: newassigned

comment:3 Changed 7 years ago by Wiktor Walc

Keywords: IE added; IEConfirmed removed
Milestone: CKEditor 3.5.1

comment:4 Changed 7 years ago by Sa'ar Zac Elias

WFM on trunk using the patch from #6646. Let's wait for that ticket to be resolved.

Changed 7 years ago by Garry Yao

Attachment: 5500_2.patch added

comment:5 Changed 7 years ago by Garry Yao

This problem (related to input element r/w in IE7) is not related to #6646, affects both textfield and button dialogs.

comment:6 Changed 7 years ago by Garry Yao

Owner: changed from Minh Nguyen to Garry Yao

comment:7 Changed 7 years ago by Sa'ar Zac Elias

Status: reviewreview_failed
  • The patch fixes the problem on native IE7 while fails on IE9's IE7 mode.
  • Creating a button on a native IE7 results in a JS error.
  • [IE9's IE7 mode] Create a button. Open the button dialog through a context menu. The value field is empty.
  • Let's avoid changing the id of dialog fields for backwards compatibility.

Changed 7 years ago by Garry Yao

Attachment: 5500_3.patch added

comment:8 Changed 7 years ago by Garry Yao

Status: review_failedreview

The field is badly named, prefer a correction over back-compat here.

comment:9 Changed 7 years ago by Sa'ar Zac Elias

Status: reviewreview_passed

comment:10 Changed 7 years ago by Garry Yao

Resolution: fixed
Status: review_passedclosed

Fixed with [6314].

comment:11 in reply to:  description Changed 7 years ago by Krzysztof Studnik

Resolution: fixed
Status: closedreopened

Replying to garry.yao:

Environment

All IE versions

Reproducing Procedures

  1. Open any of the sample page;
  2. Insert a text field with all fields filled;
  3. Switch to 'Source' mode and switch back;
  4. Open 'Text Field' dialog through context menu;
  • Actual Result: 'Value' field value is missing.

After switching to Source andv back to wysiwyg, Value field, still is cleared (IE6/7)

comment:12 Changed 7 years ago by Krzysztof Studnik

Update to comment 11 - Setting of cleared field is Password. I think, when user enters default value into content, it should be present for both Password ot Text fields (as the dialog window allows).

comment:13 Changed 7 years ago by Alfonso Martínez de Lizarrondo

Setting a default value for a Password field doesn't make sense. I think that a new ticket should be opened to disable that possibility.

comment:14 Changed 7 years ago by Krzysztof Studnik

Under Opera, Firefox, Chrome - password default value is remembered. CKEditor should work similar under all browsers, that is why I reopened this ticket.
@Alfonso - I added new ticket #7042 as You suggested, so the discussion will continue there.

comment:15 Changed 7 years ago by Garry Yao

Resolution: fixed
Status: reopenedclosed

Always avoid open fixed (committed) ticket for regressions, this's even not a regression.

Note: See TracTickets for help on using tickets.
© 2003 – 2017 CKSource – Frederico Knabben. All rights reserved. | Terms of use | Privacy policy