Opened 7 years ago

Closed 7 years ago

#5767 closed Bug (fixed)

List plugin: appendBogus should only be called for empty list items

Reported by: Arne Owned by: Garry Yao
Priority: Normal Milestone: CKEditor 3.4.2
Component: Core : Lists Version: 3.0
Keywords: Firefox Safari Cc:

Description

When building the list in the

createList function

the method

listItem.appendBogus()

is called for all but IE browsers. As the comment states this is done to render the list item at full height. But this is only necessary if the list item (or the elements inside the list item) are empty. If there is content in the elements the content will give height to the list item.

Suggestion: Only add bogus elements when the list item(and its elements) are empty.

Attachments (1)

5767.patch (2.1 KB) - added by Garry Yao 7 years ago.

Download all attachments as: .zip

Change History (10)

comment:1 Changed 7 years ago by Garry Yao

You see any side effects bring by our default behavior?

comment:2 in reply to:  1 Changed 7 years ago by Arne

Replying to garry.yao:

You see any side effects bring by our default behavior?

No, I have not observed any behavioral/rendering side effects.

comment:3 Changed 7 years ago by Frederico Caldeira Knabben

Resolution: wontfix
Status: newclosed

The current code is made that way to make things simple, and has no impact on the editor usage or performance.

We may think about change it if we face an issue related to it. Please feel free to reopen the ticket in that case.

Changed 7 years ago by Garry Yao

Attachment: 5767.patch added

comment:4 Changed 7 years ago by Garry Yao

Component: GeneralCore : Lists
Keywords: Confirmed Firefox Safari added
Milestone: CKEditor 3.4
Resolution: wontfix
Status: closedreopened
Version: 3.0

Unfortunately #5445 is an evidence for this problem.

comment:5 Changed 7 years ago by Garry Yao

Keywords: Review? added

comment:6 Changed 7 years ago by Garry Yao

Owner: set to Garry Yao
Status: reopenednew

comment:7 Changed 7 years ago by Frederico Caldeira Knabben

Milestone: CKEditor 3.4CKEditor 3.5

comment:8 Changed 7 years ago by Sa'ar Zac Elias

Supposed to be fixed by #6133.

comment:9 Changed 7 years ago by Sa'ar Zac Elias

Keywords: Safari added; Safari? removed
Resolution: fixed
Status: reviewclosed

Fixed by #6133.

Note: See TracTickets for help on using tickets.
© 2003 – 2017 CKSource – Frederico Knabben. All rights reserved. | Terms of use | Privacy policy