Opened 14 years ago
Closed 14 years ago
#5767 closed Bug (fixed)
List plugin: appendBogus should only be called for empty list items
| Reported by: | Arne | Owned by: | Garry Yao |
|---|---|---|---|
| Priority: | Normal | Milestone: | CKEditor 3.4.2 |
| Component: | Core : Lists | Version: | 3.0 |
| Keywords: | Firefox Safari | Cc: |
Description
When building the list in the
createList function
the method
listItem.appendBogus()
is called for all but IE browsers. As the comment states this is done to render the list item at full height. But this is only necessary if the list item (or the elements inside the list item) are empty. If there is content in the elements the content will give height to the list item.
Suggestion: Only add bogus elements when the list item(and its elements) are empty.
Attachments (1)
Change History (10)
comment:1 follow-up: 2 Changed 14 years ago by
comment:2 Changed 14 years ago by
Replying to garry.yao:
You see any side effects bring by our default behavior?
No, I have not observed any behavioral/rendering side effects.
comment:3 Changed 14 years ago by
| Resolution: | → wontfix |
|---|---|
| Status: | new → closed |
The current code is made that way to make things simple, and has no impact on the editor usage or performance.
We may think about change it if we face an issue related to it. Please feel free to reopen the ticket in that case.
Changed 14 years ago by
| Attachment: | 5767.patch added |
|---|
comment:4 Changed 14 years ago by
| Component: | General → Core : Lists |
|---|---|
| Keywords: | Confirmed Firefox Safari added |
| Milestone: | → CKEditor 3.4 |
| Resolution: | wontfix |
| Status: | closed → reopened |
| Version: | → 3.0 |
Unfortunately #5445 is an evidence for this problem.
comment:5 Changed 14 years ago by
| Keywords: | Review? added |
|---|
comment:6 Changed 14 years ago by
| Owner: | set to Garry Yao |
|---|---|
| Status: | reopened → new |
comment:7 Changed 14 years ago by
| Milestone: | CKEditor 3.4 → CKEditor 3.5 |
|---|
comment:9 Changed 14 years ago by
| Keywords: | Safari added; Safari? removed |
|---|---|
| Resolution: | → fixed |
| Status: | review → closed |
Fixed by #6133.
You see any side effects bring by our default behavior?