#5780 closed Bug (fixed)
Text selection disappears when open the link dialog
Reported by: | Issy | Owned by: | Garry Yao |
---|---|---|---|
Priority: | Must have (possibly next milestone) | Milestone: | CKEditor 3.3.1 |
Component: | UI : Dialogs | Version: | 3.3 |
Keywords: | Confirmed Firefox Safari Review+ | Cc: | aren@… |
Description
I select a text to make a link. Then I open the link dialog and the mark usually disappears. This is a link displayed in the editor, instead of the selected text is linked. I have the problem with Firefox 3.6. You can check this on the CKEditor demo page.
Attachments (1)
Change History (23)
comment:1 Changed 15 years ago by
Keywords: | Confirmed added; link selection dialog removed |
---|---|
Milestone: | CKEditor 3.3 → CKEditor 3.4 |
comment:2 Changed 15 years ago by
Keywords: | Firefox added |
---|
Providing a cleaner way to reproduce:
Environment
Firefox
Reproducing Procedures
- Open the 'replacebyclass' sample page, make the following selection;
<p> This is s[om]e <strong>sample text</strong>. You are using <a href="http://ckeditor.com/">CKEditor</a>.</p>
- Click on 'Link' button to open dialog;
- Actual Result: The grey mark on document is lost which indicate the selection is lost in editor.
comment:3 Changed 15 years ago by
Owner: | set to Garry Yao |
---|---|
Status: | new → assigned |
Changed 15 years ago by
Attachment: | 5780.patch added |
---|
comment:4 Changed 15 years ago by
Keywords: | Safari Review? added |
---|
range::getEnclosedNode is no longer DOM destructive thus no longer breaks text selection.
comment:5 Changed 15 years ago by
Priority: | Normal → High |
---|
comment:6 Changed 15 years ago by
Milestone: | CKEditor 3.4 → CKEditor 3.3.1 |
---|
comment:8 Changed 15 years ago by
Cc: | aren@… added |
---|
comment:10 Changed 15 years ago by
Keywords: | Review+ added; Review? removed |
---|
comment:11 Changed 15 years ago by
Resolution: | → fixed |
---|---|
Status: | assigned → closed |
Fixed with [5558] with design tests update.
comment:12 follow-up: 13 Changed 15 years ago by
Resolution: | fixed |
---|---|
Status: | closed → reopened |
Just uploaded the updated version of CKeditor and the bug is still there in FF3.6.3.
When I select a text to make it clickable, the url apears next to the text.
(cleared cache etc)
comment:13 Changed 15 years ago by
Replying to MikeVrind:
Just uploaded the updated version of CKeditor and the bug is still there in FF3.6.3.
When I select a text to make it clickable, the url apears next to the text.
(cleared cache etc)
Sorry, bug also present in IE8 and Chrome 5.0.375
comment:14 Changed 15 years ago by
I'm not able to reproduce it. Do you have this issue in our online demo? can you provide the precise steps to reproduce it?
comment:15 Changed 15 years ago by
Yes, issues are still happening in the online demo. It's reproducible in all browsers I try (Chrome 5, Chrome 6dev, Firefox 3.6, IE7, IE8, Safari 4..).
It is sporadic. Highlight text, enter in URL, press Ok and it inserts the hyperlink as the URL you typed (e.g. <a href="http://google.com">google.com</a>. As I said, it is sporadic, so it may take 1 try or it may take 10.
comment:16 Changed 15 years ago by
I've tried for about 5 minutes to make it fail with Firefox 3.6 and IE8 and all the times it has worked correctly.
comment:17 Changed 15 years ago by
Resolution: | → fixed |
---|---|
Status: | reopened → closed |
In any case, please do not reopen this ticket for this issue, as it's closed and committed aready. Please open a new one if you have more information about it.
comment:18 Changed 14 years ago by
This is also happening to me. Every single time I select some text, it becomes unleslected when using the paragraph formatting dropdown, changing text to a link, etc.
Firefox 3.6.17, 3.6.18 on CKEditor version: 3.54.
Here is a demo showing you how link button is breaking: http://screencast.com/t/lvyePQDI9A
Here is a demo showing you how the paragraph formatting dropdown is breaking: http://screencast.com/t/wBo3O7aoj
comment:19 Changed 14 years ago by
I noticed that edits to the ticket do not get emailed, so please note that I have provided demonstration links in the above message.
comment:21 Changed 14 years ago by
@syn4k - please feel free to create a new ticket with your findings. This issue has been fixed once in milestone CKEditor 3.3.1, using the attached patch, so reopening this ticket would just cause a mess.
comment:22 Changed 14 years ago by
Thank you. I have done this at http://dev.ckeditor.com/ticket/8160
Confirmed with Firefox. With IE it shows an error an error the first time and then it also inserts the link text.