Opened 13 years ago

Closed 13 years ago

#6781 closed Bug (fixed)

[IE7] Dialogs are broken with RTL and office2003 and v2 skins

Reported by: Sa'ar Zac Elias Owned by: Tobiasz Cudnik
Priority: Normal Milestone: CKEditor 3.4.3
Component: UI : Skins Version: 3.4.2
Keywords: IE Cc:

Description

Dialog layout is broken in IE8's IE7 mode, when using RTL and the office2003 and v2. A regression of the 3.4.2.

Attachments (2)

6781.png (17.5 KB) - added by Sa'ar Zac Elias 13 years ago.
6781.patch (828 bytes) - added by Tobiasz Cudnik 13 years ago.

Download all attachments as: .zip

Change History (14)

Changed 13 years ago by Sa'ar Zac Elias

Attachment: 6781.png added

comment:1 Changed 13 years ago by Tobiasz Cudnik

Owner: set to Tobiasz Cudnik
Status: newassigned

comment:2 Changed 13 years ago by Tobiasz Cudnik

Regression of [5897].

Changed 13 years ago by Tobiasz Cudnik

Attachment: 6781.patch added

comment:3 Changed 13 years ago by Tobiasz Cudnik

Status: assignedreview

comment:4 Changed 13 years ago by Sa'ar Zac Elias

Status: reviewreview_failed

The patch doesn't fix the bug for me [IE8's IE7 mode].

comment:5 Changed 13 years ago by Tobiasz Cudnik

Are you sure it's not a cache issue? I completely cannot reproduce it with the patch applied using both IE8/IE7 and IE7.

comment:6 Changed 13 years ago by Garry Yao

Confirmed in IE7 standards on both trunk and 3.5.x

comment:7 Changed 13 years ago by Garry Yao

Patch works, but once start dragging, buttons in the footer disappears.

comment:8 Changed 13 years ago by Tobiasz Cudnik

Disappearing buttons are a different regression, which is now covered by #6798.

comment:9 Changed 13 years ago by Wiktor Walc

The attached patch works for me as well.

comment:10 Changed 13 years ago by Tobiasz Cudnik

Status: review_failedreview

comment:11 Changed 13 years ago by Sa'ar Zac Elias

Status: reviewreview_passed

Ugh, my bad.. I've applied the patch on the wrong place. Sorry for that.

comment:12 Changed 13 years ago by Tobiasz Cudnik

Resolution: fixed
Status: review_passedclosed

Fixed with [6187].

Note: See TracTickets for help on using tickets.
© 2003 – 2022, CKSource sp. z o.o. sp.k. All rights reserved. | Terms of use | Privacy policy