Opened 7 years ago

Closed 3 years ago

#6883 closed Bug (duplicate)

Table Dialog error when clicking OK button if multiple table cells are selected

Reported by: Brian Shiver Owned by:
Priority: Normal Milestone:
Component: General Version: 3.0
Keywords: Cc: satya_minnekanti@…

Description (last modified by Frederico Caldeira Knabben)

It is possible to get a "Uncaught TypeError: Cannot call method 'appendChild' of undefined" [Chrome] error ("k.$ is undefined" in Firefox) when clicking the OK button in the table dialog if the user selected multiple table cells before launching the table dialog. This bug affects all major browsers.

To reproduce:

  1. Click the table dialog toolbar button and press the "Ok" button to insert a new table.
  2. Select multiple cells in the new table by either clicking and dragging or Ctrl-clicking multiple cells.
  3. Press the table dialog toolbar button again.
  4. Press the "Ok" button in the table dialog.

Results:

If you check the console you will see the described error, and the Table Dialog will stay in open.

Change History (9)

comment:1 Changed 7 years ago by Sa'ar Zac Elias

Keywords: Table Dialog removed
Status: newconfirmed
Version: 3.53.2.2

Not a 3.5 bug though; IIRC there's a ticket for that already but I can't find it.

comment:2 Changed 6 years ago by Satya Minnekanti

Cc: satya_minnekanti@… added

comment:3 Changed 5 years ago by Frederico Caldeira Knabben

Description: modified (diff)

comment:4 Changed 5 years ago by Frederico Caldeira Knabben

Resolution: worksforme
Status: confirmedclosed

I'm not able to reproduce it any more with trunk.

comment:5 Changed 5 years ago by Jakub Ś

Resolution: worksforme
Status: closedreopened

This is still reproducible:

  1. Clear editor contents.
  2. Click the table dialog toolbar button and press the "Ok" button to insert a new table.
  3. Fill table cells with sample text like "dd"
  4. Select multiple cells in the new table by either clicking and dragging or Ctrl-clicking multiple cells.
  5. Press the table dialog toolbar button again.
  6. Press the "Ok" button in the table dialog.

Message: this.$ is undefined
Line: 201
URI: /trunk/_source/core/dom/element.js

comment:6 Changed 5 years ago by Jakub Ś

Status: reopenedconfirmed

comment:7 Changed 5 years ago by Frederico Caldeira Knabben

My fault, I was using the context menu to open Table Properties.

The same thing happens if you click the "Insert Horizontal Line" button at step 5 of the above tc.

It is related to the insertion of elements over a multi-cells selections.

The right approach would be shrinking the selection to the cell touched by the start of the selection before proceeding with the insertion.

comment:8 Changed 4 years ago by Jakub Ś

Version: 3.2.23.0

#10811 was marked as duplicate.

This issue has become critical in CKE 4.x. Same TC starting from CKEditor 4.0 beta causes infinite loop and page crashes.

comment:9 Changed 3 years ago by Piotrek Koszuliński

Resolution: duplicate
Status: confirmedclosed

We fixed this in 4.3.1 - #11183.

Note: See TracTickets for help on using tickets.
© 2003 – 2017 CKSource – Frederico Knabben. All rights reserved. | Terms of use | Privacy policy