Copy/Paste Word List should preserve list properties

[Lynne Kues]

Copy a list formatted as follows from Word. Paste into CKEditor.

A.	Test
B.	Test
C.	Test
        a.	111
        b.	111
        c.	1111
F.	test

The list properties (i.e., number type, start number) are not preserved. The <liststyle> plugin supports these properties and should preserve these on paste.

[Krzysztof Studnik]

Pasting under IE - result in WYSIWYG

1.A Test
2.B Test
3.C Test
   1.111
   2.111
   3.1111
4.F test

[Garry Yao]

Expecting the following result simply because in-consequent numbering is not well supported in CSS:

A.dddd
B.dddd
C.dddd 
 a.dddd
 b.dd
 c.dd
D.ddddd

[Garry Yao]

New patch addresses most of the current pains from list pasting:

1. Using "value" attribute (on list item) to present inconsequent list numbering, though it's currently deprecated on XHTML1.0 strict.
2. "list-style-type" pulled up to list root node when possible.

[Garry Yao]

Test case

[Wiktor Walc]

The "value" attribute is copied to the next list item when adding a new entry to the list. In the attached test case, the last item "F" is duplicated when creating more list items:

A.	Test
B.	Test
C.	Test
        a.	111
        b.	111
        c.	1111
F.	test
F.	test
F.	test

[Garry Yao]

Replying to wwalc:

The "value" attribute is copie...

As a enter key issue is encountered here, let's leave this a separate ticket.

[Wiktor Walc]

Separate ticket created: #7330

[Frederico Caldeira Knabben]

With FF, the patch makes no difference and the list is not pasted as a list.

With IE, it's much better, but still not perfect. I'll add a new TC file that reflects the reporter TC. Empty D and E items are also added.

[Frederico Caldeira Knabben]

Word file for test.

[Sa'ar Zac Elias]

The following file fails to be parsed: ​http://dev.ckeditor.com/attachment/ticket/6662/This%20is%20a%20line%20of%20text.doc

[Garry Yao]

Replying to fredck:

With FF, the patch makes no difference and the list is not pasted as a list.

#6662 has to be checked.

With IE, it's much better, but still not perfect. I'll add a new TC file that reflects the reporter TC. Empty D and E items are also added.

It's interesting how you created that list but you've just ​cheated IE, other browsers works just well, so, an IE bug.

Replying to Saare: WFM in both IE and FF4?

[Frederico Caldeira Knabben]

Replying to garry.yao:

#6662 has to be checked.

At this point #6662 needs to be fully fixed first, otherwise we're not able to check this ticket with FF.

It's interesting how you created that list but you've just ​cheated IE, other browsers works just well, so, an IE bug.

I've just used the only feature I've found in Word to continue the list from a different counting number: Right-Click the list item > Set Numbering Value... > Check Continue from previous List > Check Advance value (skip numbers ) > Set value to: F.

It looks like MS Word sends the skipped items as well. Is there any chance for us to identify and ignore them?

[Garry Yao]

It looks like there's no way to tell the difference with plain empty list bullet, see if others get some idea.

[Garry Yao]

Ask for another review as #6662 is now fixed.

I've just used the only feature I've found in Word to continue the list from a different counting number...

If you check the ticket TC doc file, it doesn't have this issue, so it looks like there's something to do with the way of editing the list, anyway I don't think we can find a solution here.

[Sa'ar Zac Elias]

Can't we use the "mso-hide: all" style?

[Frederico Caldeira Knabben]

Replying to Saare:

Can't we use the "mso-hide: all" style?

In fact this looks like the way for it.

[Garry Yao]

@Saare, You're awesome, I neglected that!

[Sa'ar Zac Elias]

• Seems like FF also adds the D,E bullets, are we able to fix it there?
• Seems like ​this file does not work in FF.
• Attaching another document that fails parsing.

[Garry Yao]

Replying to Saare:

• Seems like FF also adds the D,E bullets, are we able to fix it there?

I figured it out, yes it affects all browsers actually, that the empty list bullets issue only persist if you check "Continue from previous List" but not "Start new list" in the list numbering dialog;

• Seems like ​this file does not work in FF.

It's fixed now.

• Attaching another document that fails parsing.

This's another story, where we have two lists that are too close (without any break to denote they're two ;/ ), I've added another routine to deal with it.

[Garry Yao]

Caught by Wiktor:

1. List bullet pattern like (2) are not well handled;
2. Fixing redundant list item numbering.

[Wiktor Walc]

Something might be still wrong here:

 'cke:listsymbol' is null or not an object

when pasting documents from #7209

[Wiktor Walc]

IE8 now shows an internal error when using the following example: ​http://dev.ckeditor.com/attachment/ticket/6570/ordered_list.docx (it did not happen in 3.5.2, the list properties were not recognized properly in 3.5.2, but the error didn't occur)

The JavaScript error is:

 '0' is null or not an object, default.js line 220

[Wiktor Walc]

With the attached patch IE8 now throws an alert message with the following document: ​list-test.doc from #1457

  'undefined' is null or not an object  default.js, line 643 character 8

[Wiktor Walc]

(Just a note that I could not find any other issues while checking this patch)

[Sa'ar Zac Elias]

New patch fixes the error. FF 3.6 will still produce incorrect result:

<ol>
	<li>
		one</li>
	<li>
		two
		<ol style="list-style-type: lower-alpha;">
			<li>
				AAA</li>
			<li>
				BBB</li>
		</ol>
	</li>
</ol>
<p style="margin-left: 108pt;">
	&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; i.&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; III</p>
<p style="margin-left: 108pt;">
	&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; ii.&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; IIII</p>
<ol style="list-style-type: lower-alpha;">
	<li value="3">
		CCC</li>
	<li>
		three</li>
</ol>

But this is because we have no clear indication of list items there:

<p class="MsoNormal" style="margin-left: 108pt; text-indent: -108pt;"><span style=""><span style=""><span style="font: 7pt &quot;Times New Roman&quot;;">&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;
</span>i.<span style="font: 7pt &quot;Times New Roman&quot;;">&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;
</span></span></span><span dir="LTR"></span>III</p>

<p class="MsoNormal" style="margin-left: 108pt; text-indent: -108pt;"><span style=""><span style=""><span style="font: 7pt &quot;Times New Roman&quot;;">&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;
</span>ii.<span style="font: 7pt &quot;Times New Roman&quot;;">&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;
</span></span></span><span dir="LTR"></span>IIII</p>

FF4 works, and at least we got no error. R+ for me as for other cases, please give the latest patch your review.
@Garry, this is a wonderful enhancement, congratulations.

[Garry Yao]

Fixed with [6616], thanks for the throughly review.