#7316 closed Bug (fixed)
[FF] Click on paste button create wrong linebreak
| Reported by: | Garry Yao | Owned by: | Garry Yao |
|---|---|---|---|
| Priority: | Must have (possibly next milestone) | Milestone: | CKEditor 3.5.3 |
| Component: | Core : Pasting | Version: | 3.5.2 |
| Keywords: | Firefox IBM | Cc: | satya_minnekanti@… |
Description
- Place cursor among text;
- Click on 'Paste' or 'Paste from Word' button;
- Actual Result: Line break inserted at the position.
Attachments (2)
Change History (17)
Changed 14 years ago by
| Attachment: | 7316.patch added |
|---|
comment:1 Changed 14 years ago by
| Owner: | set to Garry Yao |
|---|---|
| Status: | new → review |
comment:2 Changed 14 years ago by
| Cc: | satya_minnekanti@… added |
|---|
comment:4 Changed 14 years ago by
| Keywords: | IBM added |
|---|---|
| Milestone: | → CKEditor 3.5.3 |
comment:5 Changed 14 years ago by
| Status: | review → review_failed |
|---|
- The new "beforeSelectionChange" event is not needed. It's enough to listen to "selectionChange" with higher priority, canceling the event.
- The removeListener() call is missing the listener function to be removed.
Changed 14 years ago by
| Attachment: | 7316_2.patch added |
|---|
comment:6 Changed 14 years ago by
| Status: | review_failed → review |
|---|
comment:7 Changed 14 years ago by
| Status: | review → review_passed |
|---|
comment:8 Changed 14 years ago by
| Resolution: | → fixed |
|---|---|
| Status: | review_passed → closed |
Fixed with [6556].
comment:9 Changed 14 years ago by
This is still reproducible on the latest nightly build on FF 3.6.15 and should be reopened.
comment:10 Changed 14 years ago by
This issue was not fixed as I can reproduce it on FF 3.6.6, 3.6.8 and 3.6.15. I would like this ticket to be reopened and this defect to be fixed. Thanks.
comment:11 Changed 14 years ago by
I have just tried to reproduce it in the trunk and on the nightly demo page and it works for me. Could you please check it again? Please make sure you have cleared browser's cache.
Note that I did manage to reproduce it on Rev 6555 samples but in recent revisions like Rev 6593 samples it works fine.
comment:12 Changed 14 years ago by
Sorry I failed to mention earlier that you must click ok on the Paste dialog to reproduce the defect outlined in the test case.
comment:13 Changed 14 years ago by
Please use FF 3.6.15 and open the following sample: Rev 6593 samples
- Select "some" (third word), press Ctrl+C
- Click between "You" and "are": "You |are"
- Press the "Paste" button
- In the "Paste" dialog press "Ctrl + V" (the cursor is blinking straight after "some", in the same line)
- Press "Ok" button
- The result is correct on my side:
This is some <strong>sample text</strong>. You someare using (...)
Is it the same way how you reproduce it?
comment:14 Changed 14 years ago by
No I am reproducing it a different way.
- Open Rev 6593 samples in FF 3.6.15
- Click between "You" and "are": "You |are"
- Open the Paste dialog.
- Leave the paste dialog empty & click ok.
Result: Line break inserted between "You" and "are".
Regression of [6373], where pastebin was affected by bogus br.