Opened 7 years ago

Closed 6 years ago

#7356 closed Bug (fixed)

Style::removeObjectStyle something might be wrong

Reported by: Alfonso Martínez de Lizarrondo Owned by:
Priority: Normal Milestone:
Component: Core : Styles Version: 3.4.1
Keywords: Discussion Cc:

Description

At the very least, in that function the

	var styles = CKEDITOR.style.getStyleText( def );

isn't used, but the final part to remove the style has remained that way since it was created in [5847] that changed also the applyObjectStyle but was reverted in [5978]

So a little clean up is needed there, deciding if it must use getStyleText or def.Styles (but using a local variable), and correcting the comments.

Change History (2)

comment:1 Changed 6 years ago by Jakub Ś

Keywords: Discussion added
Status: newconfirmed

All I can say that this still occurs in CKEditor 3.6 and that I'm putting it on discussion.

comment:2 Changed 6 years ago by Garry Yao

Resolution: fixed
Status: confirmedclosed

Fixed with [7082].

Note: See TracTickets for help on using tickets.
© 2003 – 2017 CKSource – Frederico Knabben. All rights reserved. | Terms of use | Privacy policy