Opened 6 years ago

Closed 4 years ago

#8003 closed Bug (wontfix)

CKPackager: issue with leaking variables

Reported by: Wiktor Walc Owned by:
Priority: Normal Milestone:
Component: Project : CKPackager Version:
Keywords: Cc:

Description

Just to not lose it, #8000 revealed a problem with CKPackager. I'm leaving a ticket to investigate it.

Attachments (1)

8003_TC.patch (630 bytes) - added by Garry Yao 6 years ago.

Download all attachments as: .zip

Change History (7)

comment:1 Changed 6 years ago by Jakub Ś

Status: newconfirmed

comment:2 Changed 6 years ago by Frederico Caldeira Knabben

Status: confirmedpending

Please add a simple TC here.

comment:3 Changed 6 years ago by Garry Yao

Milestone: CKEditor 3.6.2
Status: pendingconfirmed

Changed 6 years ago by Garry Yao

Attachment: 8003_TC.patch added

comment:4 Changed 6 years ago by Garry Yao

After a quick check the fixes of this issue requires huge change to the current packager, which currently does a single pass on both parsing and outputting, while detecting duplicate identifiers requires a pre-process of building symbol tree.

Right now we can workaround this issue by avoid using short variable names, while obviously it's not bulletproof.

comment:5 Changed 6 years ago by Frederico Caldeira Knabben

Milestone: CKEditor 3.6.2

comment:6 Changed 4 years ago by Piotrek Koszuliński

Resolution: wontfix
Status: confirmedclosed

Since we use Google Closure Compiler it's no longer an issue that we need to fix.

Note: See TracTickets for help on using tickets.
© 2003 – 2017 CKSource – Frederico Knabben. All rights reserved. | Terms of use | Privacy policy