Opened 5 years ago

Closed 5 years ago

Last modified 5 years ago

#8995 closed Bug (fixed)

Link gets destroyed in bbcode when you modify it

Reported by: Jakub Ś Owned by: Garry Yao
Priority: Normal Milestone: CKEditor 3.6.5
Component: General Version: 3.6
Keywords: Cc:

Description

To reproduce:

  1. Open bbcode sample and clear all contents
  2. Insert link http://google.com?test=1&abc=xt using link dialog
  3. Now realize that parameter abc should have value txt not xt :). Try to correct it.
  4. Switch to source

Result: [url=http://google.com?test=1&abc=xt]http://google.com?test=1&abc=txt[/url]

Ampersand is escaped and URL got doubled.
Each time you switch to source and back new amp; is added:

[url=http://google.com?test=1&abc=xt]http://google.com?test=1&abc=txt[/url]

Reproducible in all browsers from CKEditor 3.6.

Attachments (1)

8995.patch (489 bytes) - added by Garry Yao 5 years ago.

Download all attachments as: .zip

Change History (8)

comment:1 Changed 5 years ago by Jakub Ś

Status: newconfirmed

comment:2 Changed 5 years ago by Jakub Ś

Here is a screencast showing that the same thing happens when you modify initial content: http://screenr.com/5tX8

It was reported in #8751 but I'm leaving this one open as it is addressing the problem more accurately.

Last edited 5 years ago by Jakub Ś (previous) (diff)

Changed 5 years ago by Garry Yao

Attachment: 8995.patch added

comment:3 Changed 5 years ago by Garry Yao

Milestone: CKEditor 3.6.5
Owner: set to Garry Yao
Status: confirmedreview

comment:4 Changed 5 years ago by Garry Yao

While the patch doest not prevent from escaping HTML (which is wrong) on output, it avoid HTML-escaping BBCode from source, which will break a second load for the above case.

comment:5 Changed 5 years ago by Frederico Caldeira Knabben

Status: reviewreview_passed

comment:6 Changed 5 years ago by Garry Yao

Resolution: fixed
Status: review_passedclosed

Fixed with [7598].

comment:7 Changed 5 years ago by Garry Yao

[7598] caused a regression identified by test:

http://ckeditor.t/dt/plugins/bbcode/plugin.html

Re-fixing with [7628].

Note: See TracTickets for help on using tickets.
© 2003 – 2017 CKSource – Frederico Knabben. All rights reserved. | Terms of use | Privacy policy