Opened 5 years ago

Closed 5 years ago

#8888 closed Bug (fixed)

CK Editor dialogs do not show completely in small window

Reported by: Satya Minnekanti Owned by: Olek Nowodziński
Priority: Normal Milestone: CKEditor 4.0.1
Component: UI : Dialogs Version: 3.0
Keywords: IBM Cc: Damian, Teresa Monahan

Description

To reproduce the defect:

  1. Open any CK Editor sample.
  1. Re-size browser window to minimum.
  1. Click on Table icon.

Issue: Table Properties dialog comes up but we can't see some of the fields, even when we use the browser scroll bar we can't see the fields that are out of view.

I have attached a screenshot of the issue.

It happens for all the big diloags (Image, Flash,IFrame, Paste dialogs)

Attachments (2)

Table dialog when browser minimised.jpg (19.2 KB) - added by Satya Minnekanti 5 years ago.
8888.patch (4.5 KB) - added by Garry Yao 5 years ago.

Download all attachments as: .zip

Change History (14)

Changed 5 years ago by Satya Minnekanti

comment:1 Changed 5 years ago by Jakub Ś

Keywords: IBM added; ibm removed
Status: newconfirmed
Version: 3.0

Confirmed in all browsers from CKEditor 3.0

Just wondering what could we do here? Perhaps this could be one of:

  1. Scrolling dialog when browser scrolls but only when browser viewport is smaller than dialog width/height - not sure if this is possible
  2. Resizing the dialog when it is bigger than the viewport and adding scrollbar inside it

Changed 5 years ago by Garry Yao

Attachment: 8888.patch added

comment:2 Changed 5 years ago by Garry Yao

Component: GeneralUI : Dialogs
Milestone: CKEditor 3.6.5
Owner: set to Garry Yao
Status: confirmedreview

Fixed position is not anymore suitable for small viewport, thus the patch propose a check on dialog show, potentially switch to absolute position in such case, and to re-layout the dialog on window resize.

comment:3 Changed 5 years ago by Frederico Caldeira Knabben

Status: reviewreview_passed

comment:4 Changed 5 years ago by Garry Yao

Resolution: fixed
Status: review_passedclosed

Fixed with [7612].

comment:5 in reply to:  4 Changed 5 years ago by Satya Minnekanti

Replying to garry.yao:

Fixed with [7612].

This is still an issue in IE7, IE8 Compatability view & IE9 Compatability view. Can you please re-open the ticket

comment:6 Changed 5 years ago by Jakub Ś

Resolution: fixed
Status: closedreopened

IE7-IE8 - I can confirm this problem in CKE 3.x. If you open dialog and scroll, dialog will not move but if you open dialog, move it up (grab and move up) and then scroll, the dialog will also scroll.
It is also possible to lose dialog in that way - if you grab it and try to move it dialog may dissapear.

IE9-IE10 - I can confirm this problem in CKE 3.x. If you open dialog and scroll or open, drag dialog and scroll, dialog will not move.

comment:7 Changed 5 years ago by Jakub Ś

Milestone: CKEditor 3.6.5
Status: reopenedconfirmed

comment:8 Changed 5 years ago by Piotrek Koszuliński

Milestone: CKEditor 4.0.1

comment:9 Changed 5 years ago by Olek Nowodziński

Owner: changed from Garry Yao to Olek Nowodziński
Status: confirmedassigned

comment:10 Changed 5 years ago by Olek Nowodziński

Status: assignedreview

Created a 1 LOC fix for this issue. Unfortunately this is a rendering bug in IE like #6068 or http://murphy.cz/ie7-hover-ghosts-bug/ and most likely it has nothing to do with dialog code.

comment:11 Changed 5 years ago by Piotrek Koszuliński

Status: reviewreview_passed

R+.

Extracted another issue: #9850.

comment:12 Changed 5 years ago by Piotrek Koszuliński

Resolution: fixed
Status: review_passedclosed

Masterised git:3059c62.

Note: See TracTickets for help on using tickets.
© 2003 – 2017 CKSource – Frederico Knabben. All rights reserved. | Terms of use | Privacy policy