Custom Query

This is the continuation of #4688

WebSpellChecker team has been reported CheckDirty functionality doesn't work correctly after replacing misspellings with correct word. While preparing solution we discovered additional problem in IE. Here are steps to reproduce:

1. Open ​http://ckeditor.com/demo in any IE
2. Enable SCAYT and wait for all misspellings would be underlined
3. Change editor's mode to <Source> then to <WYSIWYG>
4. Run in console CKEDITOR.instances.editor1.checkDirty()

NOTE: For the above steps you can use api sample

Expected result: checkDirty=false
Actual result: checkDirty=true

Problem has been reproducible in all versions of IE from CKEditor 3.0

When I have a paragraph with margin-left:3in (for example) and click on increase indent button, ckeditor change margin-left to 43px.

Indent plugin get only the integer part ignoring unit.

To correct I've changed _source\plugins\indent\plugin.js adding CKEDITOR.tools.convertToPx to getStyle calls inside parseInt.

The regular expression used for attribute matching is overly aggressive (it matches outside of HTML tags). This was resulting in some of the protection characters making their way to our final output (such as: "{C}" or "{cke_protected_1}").

The event is fired in OnPreRender(). This is not the proper place to fire this event.

It should be fired in IPostBackDataHandler.RaisePostDataChangedEvent().

In attachment you can find a pach

It is still possible to click on a dialog button after having disabling it with the disableButton method in CKEDITOR.dialog (​http://docs.cksource.com/ckeditor_api/symbols/CKEDITOR.dialog.html#disableButton).

When "disableButton" is called, the property "disabled" is correctly set to true and a css class is added to the button. But if you click on the button, there's no check to see if it's disabled and the event is still fired.

I think this could be fixed by modifying the code in _source/plugin/dialogui/plugin.js and adding a check for disabled before the onClick is applied.

Like this :

(line 949)

onClick : function( dialog, func )
{
    this.on( 'click', function()
    {
        if(!this._.disabled)
        {
            // Some browsers (Chrome, IE8, IE7 compat mode) don't move
            // focus to clicked button. Force this.
            this.getElement().focus();
            func.apply( this, arguments );
        }
    });
}

By the way, the css class (cke_disabled) added to the button when it's disabled does nothing and the button doesn't look disabled.

• Configure your computer so that a Japanese keyboard is available. (See attached document for further information on how to do this).
• Open the attached HTML sample in Firefox with the Japanese keyboard enabled and type in the editor.

Problem:　The text is entered into the editor in English and it is not possible to switch the input mode to Japanese.

This is reproducible in 3.6.4 and 3.6.5 but works correctly in 3.6.3 and 4.0. It only seems to occur when startupFocus: true is included in the editor config. We have reproduced this on both FF10 ESR and FF16.

This is a patch on ckeditor 3.6.2. (this is a new feature and not actually a bugfix, I call it a patch because it involves editing an existing pluging file)

This patch allows inserting html source into the wysiwyg iframe area, which you can NOT edit in the editor itself, is NOT saved in the real source, but WILL allow you to modify the appearance of the wysiwyg editor. It does this by inserting (both prepending and appending) html in the body tag of the wysiwyg editor. (Note: it only works for the NON-FULLPAGE version. luckily, you won't need it for the fullpage config.)

for example, you can add <div id="x" class="y">...</div> wrappers so included css files will work.

I use it to insert html blocks quite deep into a fairly complex website and it still works like a charm.

USAGE EXAMPLE:

site.css:

body#mybodyid.mybodyclass div#myIdcontainer  div.myclasscontainer1{float:right;}
body#mybodyid.mybodyclass div#myIdcontainer  div.myclasscontainer1 div.myclasscontainer2{color:#f00;font-weight:bold;}

html/js:

<script>
	var myckconfig = {
		contentsCss : 'site.css?1234',	
		bodyId      : 'mybodyid',
		bodyClass   : 'mybodyclass',
		bodyPrepend : '<div id="myIdcontainer"><div class="myclasscontainer1"><div class="myclasscontainer2">',
		bodyAppend  : '</div><br style="clear:both;" /></div></div>',
	};
	$('textarea.ckeditor1').ckeditor(myckconfig);
</script>
<textarea class="ckeditor1">this should show up bold and red!</textarea>

When using CKEditor inside an iframe, the getParent() method in CKEDITOR.dom.node fails with a security exception when trying to find the parent of the topmost element (the IFRAME).

Steps to reproduce:

1. Create an instance of CKEditor in an iframe document
2. Press enter while editing

steps:

1. open editor and switch to source mode, input the following code:

<textarea><img src='xx.png' /></textarea>

2. switch to wysiwyg mode and then switch to source mode again

expected:

editor code is

<p><textarea>&lt;img src=&#39;xx.png&#39; /&gt;</textarea></p>

actual:

editor code is

<p><textarea>&lt;img data-cke-saved-src=&#39;xx.png&#39; src=&#39;xx.png&#39; /&gt;</textarea></p>

PS:

I know it is better to write escaped html inside textarea, but it is easier for user to write raw html inside textarea and browser does not complain either.

PS2:

In htmldataprocessor it is better to add textarea into protectElementsRegex and put protectElements on the top of the toHtml function, but then ckeditor's htmlparser will fail to parse <textarea><img /></textare>, so i think it needs a change to the htmlparser of ckeditor: allow any content inside tag textarea except </textarea>

see article in forum: Breaking block quotes in Email replies relaated topic: Ticket #7354

Short Description: Quoted parts of messages are not allways splited, if enter is pressed, e.g. "quotes with a <div>-Tag" are not splitted.

Thunderbird or any other Email client splits the quoted part of the message, if enter is pressed.

In FCK Editor 2.latest, in the file

editor/filemanager/connectors/cfm/image.cfc

There is a private function "throw()" which became an official function in Coldfusion 9. I'm providing a patch to change this function's name to "fckThrow"

Verified in 2.6.9

The function never fires,if config.fillEmptyBlocks is a function,although there are empty elements and a &nbsp; is placed instead just as if config.fillEmptyBlocks was true [<div class="block">&nbsp;</div>] If config.fillEmptyBlocks=false it works as expected [<div class="block"></div>]

config.fillEmptyBlocks = function( element )
	{
		alert('fillEmptyBlocks!');
		if ( element.attributes[ 'class' ].indexOf ( 'clear-both' ) != -1 )
			return false;
	}

Summary: CKEditor's val() returns the value of the last element, while jQuery's returns the value of the first element.

Reproduce: On a page with 2 input text, do the following: jQuery('input[type=text]').first().val('value1') jQuery('input[type=text]').last().val('value2') jQuery('input[type=text]').val()

This last line will return 'value1' if on a page without CKEditor, and 'value2' on a page with CKEditor (and jqueryOverrideVal set to true).

This will happen in any browser and os. (Tested with chrome on Ubuntu)

More in depth: The val() function of jQuery, when used to get a value, will get the value of the first element it contains only.

The val() function of CKEditor that overrides jQuery's will walk over every element contained in the jQuery object (using each) and call getData or oldValMethod on each element. Then, it will return the value of the last element.

I do not have a test case file as this can be reproduced on just about any page, as long as the jqueryOverrideVal is set to true.

On an iPad using a Safari or Chrome browser, selection does not work when a jQuery $("body").on("touchstart") event listener is used.

To reproduce the issue CKEditor must use iframe for wysiwygarea and CKEditor container must have some offset (​​https://bugs.webkit.org/show_bug.cgi?id=128924) from the document node.

Any touch listener on any ckeditor iframe parent will cause this issue on iOS also floating panels become not clickable, because focus leaves iframes before click handling happens (blur happens before click and panel hides)

The definition of the function returned from dialog.validate.functions suffers from two bugs.

1. When obtaining the "value" from the arguments, the inner function should be referencing its own arguments, not those of the outer function.
2. When calling functions, it should be using "call" and passing "this" so that other validation functions passed as arguments will have the item as "this" as they expect.

When resizing a column to the maximum available width (by shrinking a column next to it), the width of the second column is set to 0, which is an invalid number.

When 0px is used, the column behaves like it did have width style set at all, while the fact is that user decided to resize it to the minimum. Setting 1px will preserve a narrow size of the column.

1) The moment of resizing a column

2) The second column has width set to 0px

		<tr>
			<td style="width: 238px;">&nbsp;</td>
			<td style="width: 0px;">&nbsp;</td>
			<td>&nbsp;</td>
			<td>&nbsp;</td>
		</tr>

3) The second column has width set to 1px

		<tr>
			<td style="width: 237px;">&nbsp;</td>
			<td style="width: 1px;">&nbsp;</td>
			<td>&nbsp;</td>
			<td>&nbsp;</td>
		</tr>

The text in the toolbar can be selected (and it might lead to those little errors when the focus gets lots and user is frustrated). I've tested and it doesn't recognize any CSS attribute with regards to user-select, but acts as IE with the property unselectable:

<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Transitional//EN" "http://www.w3.org/TR/xhtml1/DTD/xhtml1-transitional.dtd">
<html xmlns="http://www.w3.org/1999/xhtml" >
<head>
    <title>Untitled Page</title>
</head>
<body>
	<div style="user-select:none">
		This text shouldn't be selectable. user-select:none
	</div>
	<div style="-moz-user-select:none">
		This text shouldn't be selectable. -moz-user-select:none
	</div>
	<div style="-o-user-select:none">
		This text shouldn't be selectable. -o-user-select:none
	</div>
	<div unselectable = 'on'>
		This text shouldn't be selectable. unselectable = 'on'
	</div>
</body>
</html>

So I've tested and copying the IE code seems to work. I'm attaching a patch.

I think that it should be reported to Opera so we can have a cleaner code, but for the moment we can use this workaround.

If you set a height when inserting a table, a height attribute is added to the table. Height is not a valid attribute for table (it works, but not valid), style should be used instead. I'm attaching the changes that I've done in fck_table.html.

FCKeditor extension for MediaWiki doesn't seem to be following MediaWiki's coding conventions as described in ​http://www.mediawiki.org/wiki/Manual:Coding_conventions.

For example, FCKeditorEditPage.body.php had this in two separate lines:

class FCKeditorEditPage extends EditPage
{

when it should've been just one line as per MW's coding conventions:

class FCKeditorEditPage extends EditPage {

The extension credits ($wgExtensionCredits) in FCKeditor.php seem to be out-of-date and using "double quoting" (i.e. "name" => "FCKeditor", and so on) when 'single quoting' would be OK. I've created a patch against the current SVN version to fix these minor issues, let's see if I can attach it here... ;-)

Plugins system is very cool,
but actually you cannot write one which is available with a right click.

And in fact, it's possible with a 50 line patch ( inspired by the FCKCommands style ). See the file joined

And now you can customize the FCKConfig.ContextMenu with whatever you want written in a plugin.

For example, a plugin with predifine value for a textfield can be create and accessible via toolbar and context menu.

FCKCommands.RegisterCommand( 'DynTextField', new FCKDialogCommand( 'DynTextField', FCKLang.DynTextFieldDlgTitle, FCKPlugins.Items['DynTextField'].Path + 'fck_DynTextField.cfm', 350, 300 ) ) ;

var oDynTextFieldItem = new FCKToolbarButton( 'DynTextField', FCKLang.DynTextFieldBtn ) ;
oDynTextFieldItem.IconPath = FCKPlugins.Items['DynTextField'].Path + 'DynTextField2.gif' ;
FCKToolbarItems.RegisterItem( 'DynTextField', oDynTextFieldItem ) ;

FCK.ContextMenu.RegisterCommand('DynTextField', {
            AddItems : function( menu, tag, tagName )
            {
                if ( tagName == 'INPUT' && ( tag.type == 'text' || tag.type == 'password' ) )
                {
                    menu.AddSeparator() ;
                    menu.AddItem( 'DynTextField', FCKLang.TextFieldProp, 51 ) ;
                }
            }}) ; 

I am developing a project using FCKEditor. The project was on ​http://newweb.[mysite].com since it is not ready to be on www.[mysite].com The quick uload image was working while testing on localhost, but when on the onine test site, had a problem. Although it was uploading the image, it would stop on the Upload Tab showing the progress bar dots.

After a lot of tests I realized that something was not working well at the document.domain automatic fix script in SendFileUploadResponse function on FileWorkerBase.cs

I added some alerts at the catch(e) events to understand what was going on, but with no success

finally I tried to remove this thinh and it worked!

This is what I did:

protected void SendFileUploadResponse( int errorNumber, bool isQuickUpload, string fileUrl, string fileName, string customMsg ) {

Response.Clear();

Response.Write( "<script type=\"text/javascript\">" );

Minified version of the document.domain automatic fix script. The original script can be found at _dev/domain_fix_template.js Response.Write( @"(function(){var d=document.domain;while (true){try{var A=window.top.opener.document.domain;break;}catch(e) {};d=d.replace(/.*?(?:\.|$)/,);if (d.length==0) break;try{document.domain=d;}catch (e){break;}}})();" );

if ( isQuickUpload )

Response.Write( "window.parent.OnUploadCompleted(" + errorNumber + ",'" + fileUrl.Replace( "'", "
'" ) + "','" + fileName.Replace( "'", "
'" ) + "','" + customMsg.Replace( "'", "
'" ) + "') ;" );

Response.Write("try {window.parent.OnUploadCompleted(" + errorNumber.ToString() + ",'" + ResolveUrl(fileUrl.Replace("'", "
'")) + "','" + fileName.Replace("'", "
'") + "','" + customMsg.Replace("'", "
'") + "') ;}catch(e) {alert('problem3:' + e.name + ', ' + e.message);}");

else

Response.Write( "window.parent.framesfrmUpload?.OnUploadCompleted(" + errorNumber + ",'" + fileName.Replace( "'", "
'" ) + "') ;" );

Response.Write( "</script>" );

Response.End();

}