Opened 11 years ago
Closed 11 years ago
#11131 closed Bug (fixed)
Divarea + widget breaks when switching to source mode while having nested editable focused
| Reported by: | DrColossos | Owned by: | Piotrek Koszuliński |
|---|---|---|---|
| Priority: | Normal | Milestone: | CKEditor 4.3.2 |
| Component: | UI : Widgets | Version: | 4.3 Beta |
| Keywords: | Cc: |
Description (last modified by )
- Open image2 sample.
- Focus nested editable (caption).
- Click "source" button.
Following error will be thrown:
Uncaught TypeError: Cannot call method 'getStartElement' of null editor.js:785 CKEDITOR.tools.extend.elementPath
Attachments (2)
Change History (13)
Changed 11 years ago by
| Attachment: | cke-divarea.png added |
|---|
comment:1 Changed 11 years ago by
| Component: | UI : Source View → UI : Widgets |
|---|---|
| Description: | modified (diff) |
| Keywords: | widget divarea source removed |
| Milestone: | → CKEditor 4.3.1 |
| Status: | new → confirmed |
| Summary: | Divarea + Widget breaks source switch → Divarea + widget breaks when switching to source mode while having nested editable focused |
comment:2 Changed 11 years ago by
| Milestone: | CKEditor 4.3.1 → CKEditor 4.3.2 |
|---|
Rearranged tickets due to new ones which have high priority.
comment:3 Changed 11 years ago by
| Owner: | set to Marek Lewandowski |
|---|---|
| Status: | confirmed → assigned |
comment:5 Changed 11 years ago by
Fix for this issue is already prepared, however we still need to prepare TCs for that issue ( ensuring that contentDomUnload event fires in each wysiwyg mode ) - for that i'll wait for PJ tests modifications in #5217, which will run given test in each wysiwyg mode.
comment:6 Changed 11 years ago by
| Description: | modified (diff) |
|---|
comment:7 Changed 11 years ago by
#5217 will take some time, so to unblock this ticket I pushed to master tools created in t/5217b.
comment:8 Changed 11 years ago by
| Status: | assigned → review |
|---|
Additionally i found that inline editor does not fire contentDomUnload event. My understanding is that it should fire it, however i didn't want to implement it without additional confirmation.
Initially i've created tt using function mentioned in comment:7 ( which will be attached to this ticket ), but later on i wanted to include it to ckeditor-tests-v4/dt/core/editable/events.html, so in order to fit it there I had to adjust code to its state.
As a result i've suggested changes in ticket #11363
Changes commited to t/11131 at dev and t/11131 at tests.
comment:9 Changed 11 years ago by
| Owner: | changed from Marek Lewandowski to Piotrek Koszuliński |
|---|
Pushed t/11131b (dev, tests) with contentDomUnload fired for every type of editable upon detaching.
comment:10 Changed 11 years ago by
| Status: | review → review_passed |
|---|
comment:11 Changed 11 years ago by
| Resolution: | → fixed |
|---|---|
| Status: | review_passed → closed |
Fixed on master with git:2699ee7 on dev and 149cefd on tests.
I simplify the ticket description.