[Umbrella] Rich content drag-and-drop and files pasting and dropping support

[Piotr Jasiun]

Umbrella ticket for drag-and-drop and direct pasting of files for CKEditor.

Parts:

• #11526 (research)
• #11460 (handling dropped content)
• #12168 (setData, getData, method)
• #12169 (events)
• #12173 (paste integration)
• #12341 (fixes after #12173)
• #12172 (inline widgets integration)
• #11219 (block widgets integration)
• #12264 (Files in dataTransfer)
• #11580 (notifications plugin)
• #11461 (handling pasted and dropped images, upload manager)
• #11636 (improve selection.getSelectedHTML, range.cloneContents and range.deleteContents).
• #12262 (test and improve selection.getSelectedText).
• #11975 (tables).
• #11977 (images).
• #12090 (reusing global data transfer in block widgets dnd).
• #12095 (dnd inline widget loses styles (e.g. bold))
• #12612 (CORS)
• #12613 (dragover)
• #12614 (gray out uploading images)
• #12617 (replaceWith should use insertHtmlIntoRange)
• #12619 (Chrome: Drop image to the empty document)
• #12805 (Manual tests for upload)
• #12871 (Manual tests for drag&drop)
• #12806 (Integrate new get and delete selected HTML methods)

Postponed:

• #12618 (Block alignment buttons during upload)
• #11976 (lists drag and drop).
• #11978 (multiselection).
• #11979 (ctrl key).
• #12541 (File upload plugin)
• #12616 (smart drop plugin)
• #12872 ([Firefox] Improve copy/cut and paste binding)
• #12873 ([IE] Improve copy/cup and paste binding)
• #12091 (editor#dragenter).

Note: each of these parts should be handled in its ticket, not in this umbrella ticket.

Related: #7422.

Edit: Small test case to check #11657. It seems that in inline and divarea editors there is something wrong with selection and D&D.

[Piotr Jasiun]

I talked with Fred and we will focused on images for now.

[Wim Leers]

Impressive work!

[Piotrek Koszuliński]

As you can see in #11526 and #11460 the feature turned out to be a very demanding challenge, the design phase took nearly all the time we had for implementation phase. We don't want to postpone CKEditor 4.4 for which we have enough new features, so we're rescheduling drag and drop instead.

[Frederico Caldeira Knabben]

While playing with the manual testing page in t/11460, I had this issue:

1. In the classic editor, start a selection before "11" in the title up to the end of "spaceflight" in the first paragraph.
2. Drag the selection after "landed" in the first paragraph.

The dragged content will be lost and no insertion happens. A js error is thrown.

[Piotr Jasiun]

During the previous weeks custom D&D was deeply testes and about 30 issues were found:

​https://docs.google.com/document/d/1hG4H0r21MXNkRd3amDEOBPygJe3ehBAXFWAal2DptGQ/edit?usp=sharing

After considering this results the future plan is to:

• fix most important part of bugs as a part of #11460,
• improve getSelectedHTML, cloneContents and deleteContents (#11636), because this is the reason of some bugs (ex. Bug 4, Bug 7),
• fix D&D for tables (Bug 3, Bug 17, Bug 20, Bug 24, Bug 30), images, lists (Bug 12, Bug 19, Bug 21) and eventually Firefox multiselection (Bug 14, Bug 16) after fixing #11636,
• leave part of the issues as separate tickets or close as "won't fix" (ex. Bug 6).

[Jakub Ś]

#12027 was marked as duplicate.

I assume this will be supported but just to remind - change event should react to drag&drop.

[Piotrek Koszuliński]

Yes, you're right that drop will fire change. That's already implemented.

[Piotr Jasiun]

Ladies and gentlemen: we are done here.

[Piotrek Koszuliński]

Congrats :)!

BTW. 4.5.0 has some nice stats:

 298 files changed, 22444 insertions(+), 3959 deletions(-)

And there's still few tickets to be closed :).

[Wim Leers]

Wow! Congratulations to all! :)