Opened 8 years ago

Last modified 7 years ago

#14838 confirmed Bug

The color FF00FF (or F0F) is not named as Fuchsia (or Magenta) recognized by HTML/CSS and X11.

Reported by: cactus20100 Owned by:
Priority: Normal Milestone:
Component: UI : Toolbar Version: 3.0
Keywords: Cc:

Description

Steps to reproduce

  1. add plugin "color button" to CKEditor with Office 2013 theme
  2. Create a form like this :
<form style="margin-left: 80px;">
        <textarea name="editor1" id="editor1" rows="10" cols="80">
        </textarea>
        <script>
            var config = {
                language : 'en',
                height : '500',
                width : '600',
                colorButton_colors : 'FF8C00,FFFF00,00FF00,FF00FF',
            }
            CKEDITOR.replace('editor1', config);
        </script>
</form>
  1. Pass you mouse on every color of the color selector

Expected result

The colors are named in ordre : Dark Orange, Yellow, Lime, Fuchsia (or Magenta ?)

Actual result

The colors are named in ordre : Dark Orange, Yellow, Lime, FF00FF

Other details (browser, OS, CKEditor version, installed plugins)

tested on IE11 (11.0.9600) and Firefox 47 plugin color button : office 2013 theme tested on version 4.5.6 too.

Change History (4)

comment:1 Changed 8 years ago by Jakub Ś

Color name is taken from language file: https://github.com/ckeditor/ckeditor-dev/blob/master/plugins/colorbutton/plugin.js#L273

CKEditor either takes name from language file or uses code if it can't find that name. We would need to add all or almost named color to our language files.

Last edited 7 years ago by Jakub Ś (previous) (diff)

comment:2 Changed 8 years ago by Jakub Ś

Keywords: styling removed
Status: newconfirmed
Version: 4.5.113.0

comment:3 Changed 8 years ago by Jakub Ś

We should also take care translating both shortened hex and full hex like - FF0000,F00. In some cases only shortened codes are translated thus no name is assigned to full hex colors.

WE either have to translate them or make sure that plugin will pass only shortened color to language file.

This part was taken from #14839 which was marked as duplicate.

comment:4 Changed 8 years ago by Jakub Ś

Other tickets that fall under Select "Color Dialog Problems / Enchancements":
#8706, #8698, #8519, #8679, #8523, #8218, #8701, #4994, #5960, #5597, #11679, #14839.

Version 1, edited 8 years ago by Jakub Ś (previous) (next) (diff)
Note: See TracTickets for help on using tickets.
© 2003 – 2022, CKSource sp. z o.o. sp.k. All rights reserved. | Terms of use | Privacy policy