#7932 closed Bug (fixed)
Focus jump to top when reentering the iframe (in IE8)
Reported by: | Ulrich | Owned by: | Garry Yao |
---|---|---|---|
Priority: | Normal | Milestone: | CKEditor 3.6.3 |
Component: | Core : Selection | Version: | 3.1 |
Keywords: | IE | Cc: | gogobu@…, ruud@…, mattleff@… |
Description (last modified by )
Steps to reproduce :
- Open demo in IE8
- Delete some text, so that the body is smaller than the iframe
- Place Focus in the text somewhere
- Click outside of the editor
- Click in the white space in the iframe below the body
Focus jumps to position 1, but should be at the end
Browser name and OS : IE8 on Windows XP
Attachments (8)
Change History (39)
comment:1 Changed 14 years ago by
Status: | new → confirmed |
---|---|
Version: | 3.6.1 (SVN - trunk) → 3.0 |
comment:2 Changed 14 years ago by
Resolution: | → wontfix |
---|---|
Status: | confirmed → closed |
comment:3 Changed 14 years ago by
Resolution: | wontfix |
---|---|
Status: | closed → reopened |
If we can't do anything about it please close the issue.
@Ulrich I'm not sure if you have closed the issue because of above comment or because you have deducted that this is a won't fix.
If because of my comment, than I must say sorry for confusing you. I have written that to our senior developers:)
comment:4 Changed 14 years ago by
Status: | reopened → confirmed |
---|
Changed 14 years ago by
Attachment: | 7932.patch added |
---|
comment:5 Changed 14 years ago by
Keywords: | IE added |
---|---|
Owner: | set to Garry Yao |
Status: | confirmed → review |
Version: | 3.0 → 3.1 |
comment:6 Changed 14 years ago by
Description: | modified (diff) |
---|
comment:7 Changed 14 years ago by
Summary: | Focus does not jump to end when reentering the iframe (in IE8) → Focus jump to top when reentering the iframe (in IE8) |
---|
Changed 14 years ago by
Attachment: | 7932_2.patch added |
---|
Changed 14 years ago by
Attachment: | 7932_3.2.patch added |
---|
comment:10 Changed 14 years ago by
Status: | review_failed → review |
---|
New patch takes care of IE6/7, even not having the dragging selection feature in IE8/9/Quirks , it eliminates the selection lost issue.
Due to an Trac error I can't obsolete the patches, 7932_3.2 is the latest.
comment:11 follow-up: 12 Changed 13 years ago by
Garry,
the patches from 7932_2.patch to 7932_3.2.patch cannot be downloaded for an internal error in Trac; can you publish it somewhere else?
Thanks
Changed 13 years ago by
Attachment: | 7932_4.patch added |
---|
Changed 13 years ago by
Attachment: | review.patch added |
---|
Changed 13 years ago by
comment:12 Changed 13 years ago by
Replying to lfassio:
Garry,
the patches from 7932_2.patch to 7932_3.2.patch cannot be downloaded for an internal error in Trac; can you publish it somewhere else?
Thanks
It shows me that it's the diff that triggers the Trac error with the patch, 7932_3 is the latest one.
comment:13 Changed 13 years ago by
Status: | review → review_failed |
---|
I'm not able to apply this patch (malformed). Please try creating it again.
Changed 13 years ago by
Attachment: | 7932_3.patch added |
---|
comment:14 Changed 13 years ago by
Status: | review_failed → review |
---|
comment:15 Changed 13 years ago by
comment:16 Changed 13 years ago by
Keywords: | NeedsTest added |
---|
comment:17 Changed 13 years ago by
Just a note that it might be worth to check #5538 according to comment added by Garry.
comment:19 Changed 13 years ago by
comment:20 Changed 13 years ago by
Cc: | gogobu@… added |
---|
comment:22 Changed 13 years ago by
Status: | review → review_failed |
---|
I've created tests for several related tickets and everything is passing, which indicates that we're almost there.
The test for this ticket is not passing on IE9+Compat, IE8+Compat and IE6 (and probably on IE7 and IE+Quirks). It passes on IE9, IE8 and other browsers.
comment:23 follow-up: 24 Changed 13 years ago by
Cc: | ruud@… added |
---|
(sorry for the comment. I just want to add myself to cc, but if i leave the comment field blank the content is 'potential spam'. Maybe I do something wrong?)
comment:24 Changed 13 years ago by
Replying to ruud_bmg:
(sorry for the comment. I just want to add myself to cc, but if i leave the comment field blank the content is 'potential spam'. Maybe I do something wrong?)
(That should be ok, sorry... we'll be investigating.)
Changed 13 years ago by
Attachment: | 7932_5.patch added |
---|
comment:26 Changed 13 years ago by
Status: | review_failed → review |
---|
I didn't mean to address the ticket in IE6/7...while, I agree... we can be a bit better here, so new patch should be enough to align this behavior with IE9.
comment:27 Changed 13 years ago by
Component: | General → Core : Selection |
---|---|
Milestone: | → CKEditor 3.6.3 |
Status: | review → review_passed |
comment:28 Changed 13 years ago by
Resolution: | → fixed |
---|---|
Status: | review_passed → closed |
Fixed with [7374].
comment:29 Changed 13 years ago by
~@ruud_bmg - Akismet was rejecting your request to add you to the CC field because it looks like you have set at that time more than one email address in your account settings (the one that is assigned now to the user "gogobu").~
@ruud_bmg - thanks for reporting the problem. Indeed "Akismet says content is spam" when cc-ing as a second person, without posting anything.
comment:30 Changed 13 years ago by
@wwalc: ok, is there anything i can do to fix/prevent that? I don't know the user gogobu, so I don't know how the e-mail address got in my account settings.
comment:31 Changed 13 years ago by
@ruud_bmg - sorry for the confusion, I just noticed in logs that you have tried to set the CC field to two email adresses, but in fact it was because gogobu cc-ed himself two weeks earlier. It's a system error, I've marked your earlier changes that failed as "ham", let' s see if it will help.
This is rather browser dependable. If we can't do anything about it please close the issue.
Opera remembers the position.
IE places cursor at the beginning.
FF and chrome place cursor at the end.