Custom Query

Steps to reproduce

1. Open editor with iframe plugin (e.g. ​http://sdk.ckeditor.com/samples/fullpreset.html ) and clear its content.
2. Click "Iframe" button.
3. Set URL to http://wikipedia.org, "Width" to 100%, "Height" to 800px, "Align" to "Middle".
4. Check "Enable scrollbars" and "Show frame border".
5. Click OK.
6. Go into source mode and copy generated code into ​https://validator.w3.org/nu/#textarea
7. Validate HTML

Expected result

• Editor should not allow to set "Width" to "100%" (only digits should be allowed).
• Editor should not allow to set "Height" to "800px" (only digits should be allowed).
• No validation errors found.

Actual result

5 validation errors are found:

• Bad value 800px for attribute height on element iframe: Expected a digit but saw p instead.
• Bad value 100% for attribute width on element iframe: Expected a digit but saw % instead.
• The align attribute on the iframe element is obsolete.
• The frameborder attribute on the iframe element is obsolete.
• The scrolling attribute on the iframe element is obsolete.

Steps to reproduce

1. Counfigure your CKEditor so that it allows Drag and Drop
2. Dropp file with ' in its name. You can use the attached one.

Expected result

<p><img alt="" height="630" src="/CKFinder/userfiles/images/can't%20send%20fax.JPG" width="450" /></p>

Actual result

<p><img alt="" height="630" src="/CKFinder/userfiles/images/can\'t%20send%20fax.JPG" width="450" /></p>

The ' in word can't is escaped.

Other details (browser, OS, CKEditor version, installed plugins)

Problem can be reproduced in every browser

Steps to reproduce

1. Open ​http://sdk.ckeditor.com/samples/standardpreset.html
2. Select image and copy it to the clipboard.
3. Click "Paste as plain text" button and follow instructions

Expected result

Image is replaced with its alternative text.

Actual result

Nothing is pasted.

Steps to reproduce

1. Go to ​http://codepen.io/f1ames/pen/QprrBa.
2. Insert simple box widget (button between Image and Table).
3. Inside widget type (and then select):

[item1
item2]

4. Create unordered list from selection.

Expected result

The list is created inside widget.

Actual result

The creation of list creates new widget for every list item nested inside the former widget which creates invalid widget structure. Also when getData is called only first item list is present (due to invalid structure). See attached gif - ​https://dev.ckeditor.com/attachment/ticket/16917/Mar-23-2017%2010-20-29.gif.

Other details (browser, OS, CKEditor version, installed plugins)

Tested on Chrome (56.0.2924.87 (64-bit)) with newest CKEditor (4.6.2).

Steps to reproduce

1. Set ckeditor 4.6.2 with french language
2. Click in the flash plugin
3. Alignment of HSpace and VSpace

Actual result

See image

Other details (browser, OS, CKEditor version, installed plugins)

ckeditor 4.6.2 in French language + flash plugin

Steps to reproduce

1. Set editor enterMode to ENTER_BR
2. In editor, enter text - 'Send to 123 Main St'
3. Place cursor immediately after 'to', before space
4. hit Enter key
5. on new line, hit Delete or Arrow Right

Expected result

Space should be visible and key press should either move cursor or delete the space.

Actual result

Notice that first key press does nothing and space before '123' is not visible.

Other details (browser, OS, CKEditor version, installed plugins)

Problem can't be reproduced in native contenteditable element.

Steps to reproduce

1. Open nightly build and insert a Table
2. Keep cursor inside Table Cell & open Context meny by pressing Ctrl + Shift + F10 or Application key
3. with JAWS on Navigate through context menu options using keyboard(UP/Down arrow keys)

Issue: JAWS reading each menu item as separate list ex: JAWS reads Paste 1 of 1, Cell Submenu 1 of 1, Row Submenu 1 of 1, Column Submenu 1 of 1 but for Delete Table & Table Properties it combined them as one list and says 1 of 2, 2 of 2 respectively which is incorrect all of them are part of same menu

Steps to reproduce

1. Set editor enterMode to ENTER_BR
2. In editor, enter text - 'Send to 123 Main St'
3. Place cursor immediately after 'to', before space
4. hit Enter key

Expected result

Space in front of '123' is visible and cursor is blinking before it.

Actual result

There is no space in front of '123' and cursor is still blinking at the end of first line.

Other details (browser, OS, CKEditor version, installed plugins)

Steps to reproduce

1. Allow dl/dd/dt elements to content filtering
2. Set editors source content:

<p>Para</p><ol><li>li A</li><li>li B</li></ol><p>Para</p><dl><dt>dt A</dt><dd>dd A</dd><dt>dt B</dt><dd>dd B</dd></dl>

3. Put cursor at the beginning of first "Para"
4. Press delete until text is deleted plus once more to delete paragraph
5. Repeat 3 and 4 to next paragraph and compare results

Expected result

Cursor is blinking ath the start of first list element

Actual result

First list element gets changed into paragraph

Other details (browser, OS, CKEditor version, installed plugins)

This works fine in Firefox. Chrome has been broken since CKEditor 4.4.1 and hasn't worked in IE at all.

You will get the same result in native contenteditable element in Webkit and IE with below code:

<div style="border:1px solid black; width:500px;" contenteditable="true">
<p>Para</p><ol><li>li A</li><li>li B</li></ol><p>Para</p><dl><dt>dt A</dt><dd>dd A</dd><dt>dt B</dt><dd>dd B</dd></dl>
</div>

The reason I have reported this bug is because it has been working in Chrome till version 4.4.0 so maybe there is something we can do to improve default behaviour.

Steps to reproduce

1. Go to "placeholder" sample page

   http://sdk.ckeditor.com/samples/placeholder.html
   

2. paste the following source code:

   Dear [[Customer Name]],
   

3. Select the whole text and apply "Underline" or "Strikethrough"

Expected result

The whole text should be underlined.

Actual result

Only the text that is not in placeholder gets underlined.

Other details (browser, OS, CKEditor version, installed plugins)

Windows 7 Browser: Firefox 52.0.2 CKEditor: 4.6.2

Steps to reproduce

1. Open ​https://jsfiddle.net/ssjjtrcd/
2. Look at the editor's UI.

Expected result

UI should be red.

Actual result

UI has default color.

Steps to reproduce

1. CKeditor in standard preset
2. open source mode
3. paste attached html
4. leave source mode
5. Set cursor some where in the content
6. Safari stops working

Expected result

Except to able to edit the content of the table

Actual result

Safari hangs.

Other details (browser, OS, CKEditor version, installed plugins)

Safari 10.1 (12603.1.30.0.34) MacOS Sierra 10.12.4 ckeditor 4.6.2

Steps to reproduce

1. Copy some link.
2. Open ​http://sdk.ckeditor.com/samples/classic.html
3. Click inside the editor.
4. Press Ctrl + L.
5. Immediately after the previous step, press and hold Ctrl + V for a while

Expected result

Link is pasted several times into the focused field of newly opened dialog

Actual result

Link is pasted several times inside the editor. It's even possible to type into the editor while dialog is open.

Note also that this scenario is possible only when the dialog is opened for the first time. On the subsequent dialog openings the link is pasted once/twice into the editor before the focus is moved into the appropriate field inside the dialog.

Font plugin now recognizes styling attributes (size, align, face) on font element and transforms it into span, but if the element has the style attribute resulting in the same styling (font-size, text-align, font-family) it is not properly recognized and transformed. It is removed instead.

The plugin should be also able to recognize such styling and transform font into span with a proper style attribute.

Steps to reproduce

Upload a file using the uploadfile plugin, drag & drop from your favourite file manager.

Expected result

A link, with no target specified.

Actual result

A link, always with target="_blank" specified.

Feature request

Add a configuration option for uploadfile target specification.

Alternately (or; even better:) add / document a way to make default target depend on file / mime type.

Originally reported on Disqus, did not try to reproduce it. ​http://ckeditor.com/addon/maximize#comment-3256559859

I was having everything in my page turned contenteditable when using maximize. Finaly I solved the issue. If you have a classic ckeditor and one or more inline editors in the same page, the maximize "refreshCursor" function only checks that the editor being maximized is not an inline one, but it does not check on the rest of CKEDITOR.instances, which are also refreshed..

The function's loop should be modified to:

for ( var i in all ) {
var one = all[ i ]; 
if ( !one.editable().isInline() && one.mode == 'wysiwyg' && !one.readOnly ) {
.........
}
}
]}}

Steps to reproduce

1. Insert below code into CKEditor

   <table border="1" cellpadding="1" cellspacing="1" dir="ltr" style="width:500px">
   	<thead>
   		<tr>
   			<td>
   			<p>00000</p>
   			<p>11111</p>
   			</td>
   			<td>
   			<p>22222</p>
   			<p>333333</p>
   			</td>
   			<td>
   			<p>444444</p>
   			<p>555555</p>
   			</td>
   		</tr>
   		<tr>
   			<th scope="col">
   			<p>00000</p>
   			<p>11111</p>
   			</th>
   			<th scope="col">
   			<p>22222</p>
   			<p>333333</p>
   			</th>
   			<th scope="col">
   			<p>444444</p>
   			<p>555555</p>
   			</th>
   		</tr>
   	</thead>
   	<tbody>
   		<tr>
   			<td>
   			<p>bbbbbbbb</p>
   			<p>ccccccccc</p>
   			</td>
   			<td>
   			<p>ddddddddd</p>
   			<p>eeeeeee</p>
   			</td>
   			<td>
   			<p>ffffffffffff</p>
   			<p>gggggggggg</p>
   			</td>
   		</tr>
   	</tbody>
   </table>
   <p dir="ltr">&nbsp;</p>
   

2. Right click table.
3. Select Table Properties.

Expected result

Headers option shows "None".

Actual result

Headers option shows "First".

Other details (browser, OS, CKEditor version, installed plugins)

Problem can be reproduced in every browser starting from CKEditor 3.0.

Thank you for all of your hard work. I am the current volunteer developer of a hybrid content management system, email list server, and free website provider called FreeToastHost that is made for and used by over 11,000 non-profit Toastmasters public speaking clubs worldwide. The system creates websites from a custom template that we merge each club's custom content into. The system depends extensively on CKEditor for content editing and I always make sure that I give credit for the editor where credit is due. (e.g., not my creation)

Because all the recent updates to our system are the result of me contributing a lot of my spare time, some things have lagged behind other systems a bit. Case In Point: Implementation of full HTTPS support. We are making headway on that, but we are bumping up against mixed content issues for the content that our users create via CKEditor.

While I certainly do post-processing where I can to address insecure URLs entered for photos, iframes, etc., it has occurred to me that it would be very helpful if CKEditor could also help with this. This is becoming more and more important and browsers are now starting to flag insecure pages and content more aggressively.

What I am thinking is maybe some additional settings to prevent explicit ​http:// URLs from being specified in the relevant dialogs. It would be good if there were individual settings for photos, iframe, links, etc. E.g. something like PreventInsecurePhotos, PreventInsecureIframes, PreventInsecureLinks, etc.

Additionally, it would be helpful if the Advanced Content Filtering could be used to filter out insecure content. This would address insecure content that already exists.

If I am missing some way that already exists to do this, then I certainly am sorry for imposing on your time, and I thank you for your consideration.

Steps to reproduce

1. Open Microsoft word and type the following: "[tab]Test" ([tab] is an actual tab, not the phrase "[tab]").
2. Select All and Copy the contents from MS Word.
3. When pasting into the CKEditor you get different results when pasting normally (Ctrl-V) compared to when using the Paste from Word dialog.

Expected result

Both methods of pasting the contents should yield the same result. I would also expect a marked up tab to trigger the adding of the text-indent CSS property to the paragraph.

Actual result

When pasting normally, I get:

<p>&nbsp;&nbsp;&nbsp; Test</p>

in Linux and

<p>&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; Test</p>

in Windows.

When pasting using the Paste from Word dialog, I get:

<p>Test</p>

Other details (browser, OS, CKEditor version, installed plugins)

Linux: Firefox ESR 45.8.0, CentOS 6.8, CKE 4.6.2, Paste from Word

Windows: Firefox 53.0, Windows 10, CKE 4.6.2, Paste from Word

The inconsistency was duplicated here: ​http://ckeditor.com/features

Steps to reproduce

1. Open ​sample.
2. Copy content of the textarea under the editor.
3. Switch editor into the source mode.
4. Paste copied code into the editor.
5. Switch back to WYSIWYG mode.

Expected result

Empty iframe is visible inside the editor.

Actual result

Iframe with "If it's shown, the test is failed" text inside.

Steps to reproduce

1. Open an instance of ckEditor on IE11 with enabled Keyboard Navigation (Shortcut F7 or via Menu: File > Keyboard navigation)
2. Open a Color Select Dialog > More colors dialog
3. Try to close the dialog window

Expected result

The window should close.

Actual result

The window stays open and an error is logged to the console: The property "removeClass" of an undefined object can not be accessed. colordialog.js, Row: 11, Column: 485

As we started to use modified clone of colordialog color picker in uicolor plugin, it will be good to extract common parts to a separate plugin so both colordialog and uicolor plugins can utilize it.

Failing ​tests updating filler references on undo flow has shown that if you make a full selection the startFiller/endFiller will not be checked on whether they've been replaced.

It's an edge case but worth fixing.

The tests fails on Chrome only - since Chrome team changed selection internals recently.

Steps to reproduce

1. Go to ​http://tests.ckeditor.dev:1030/tests/plugins/widgetselection/manual/basic.
2. Select all (using keyboard) inside first editor instance.
3. Change Paragraph format to e.g. Header 1.
4. Start typing.

Expected result

Newly typed characters appears in the editor and are visible.

Actual result

Newly typed characters are not visible.

Other details (browser, OS, CKEditor version, installed plugins)

Chrome 58.0.3029.110 (64-bit) on OS X. Same happens on Safari.

This happens because the filler is not properly removed so new typed content is inserted inside this filler (which is invisible).

Steps to reproduce

1. Go to ​​http://tests.ckeditor.dev:1030/tests/plugins/widgetselection/manual/basic.
2. Select all using keyboard inside last editor instance (Only non-editable).
3. Start typing.

Expected result

Unable to type anything (works this way when selection is made using mouse).

Actual result

The content gets replaced.

Other details (browser, OS, CKEditor version, installed plugins)

Chrome/Safari on OS X.

Color names in preset are not localized.

Steps to reproduce

1. Go to ​http://tests.ckeditor.dev:10470/tests/plugins/tableselection/manual/blur.
2. Follow the scenario for classic editor.

Expected result

It is possible to blur editor with Tab/Shift+Tab when row is selected.

Actual result

Tab/Shift+Tab does not work.

Other details (browser, OS, CKEditor version, installed plugins)

Safari (Version 10.1.1 (11603.2.5)) on OS X El Capitan 10.11.6.

I have also noticed that if editor is focused from another instance (using Shift+Tab), blurring it with Tab works.

Steps to reproduce

1. Go to ​http://tests.ckeditor.dev:10470/tests/plugins/tableselection/manual/editortypes.
2. Select the first row in a table.
3. Copy.
4. Paste after Some text (and before existing table).
5. Select whole row in a first (pasted) table.
6. Without releasing the mouse button, hover over the second table.

Expected result

No error and probably selection should expand somehow on the second table.

Actual result

Error is thrown Uncaught TypeError: Cannot read property 'length' of undefined.

Other details (browser, OS, CKEditor version, installed plugins)

Tested on Chrome and Safari.

Steps to reproduce

1. Open ​http://tests.ckeditor.dev:1030/tests/core/selection/manual/iecontenteditablefalse.
2. Insert non-editable widget.
3. Select part of the text inside it.
4. Press any letter on keyboard

Expected result

Widget becomes selected.

Actual result

Selection jumps out of widget and it allows to type before/after the widget.

Steps to reproduce

1. Open page with CKEditor.
2. Copy some rich content and try to paste it as plain text using button in the toolbar.
3. Use keystroke shown in notification (Cmd+Shift+V).

Expected result

Content is pasted as plain text.

Actual result

Nothing happens.

It seems that Opera on macOS uses Cmd+Shift+Alt+V to paste as plain text.

Other details (browser, OS, CKEditor version, installed plugins)

Opera 45, macOS

Steps to reproduce

1. Go to ​http://tests.ckeditor.dev:1030/tests/plugins/tableselection/manual/integrations/selectall/table.
2. Follow the scenario (with Cmd + A).
3. When releasing Cmd + A, release A and after some time release Cmd.

Expected result

The table is faked selected.

Actual result

Native selection is visible.

Other details (browser, OS, CKEditor version, installed plugins)

OS X, tested on Safari, Chrome. Works fine on Firefox.

Additionally on Safari, error is thrown: TypeError: null is not an object (evaluating 'e.getChild(f-1).type'). If Cmd + A is release at once it works fine. Seems to be working fine on Windows where select all is fired after releasing A. On OS X it is fired after releasing Cmd.

Steps to reproduce

1. Open ​http://tests.ckeditor.dev:1030/tests/plugins/tableresize/manual/empty
2. Click on the table when move cursor is shown. Resize handlers should appear.
3. Click into the empty space inside the editor.

Expected result

Nothing happens

Actual result

Error is thrown: Object required

Other details (browser, OS, CKEditor version, installed plugins)

I've observed strange behaviour when switching between subscript/superscript (concerns situations when both are switched on). Added this to fcknamedcommand (start of execute function):

if (((this.Name=='Subscript') &&
(!FCK.EditorDocument.queryCommandState('Subscript')))
|| ((this.Name=='Superscript') &&
(!FCK.EditorDocument.queryCommandState('Superscript')))) {
FCK.ExecuteNamedCommand('RemoveFormat');
}

and voila - subscript/superscript works fine ...

Moved from SF:
​http://sourceforge.net/tracker/index.php?func=detail&aid=1428321&group_id=75348&atid=543656

There should be a configuration entry to make it possible to override language file entries with custom texts. In this way it would be possible to set language entries from the server side (see #1014).

At this moment it seems not very intuitive hot to assign SkinPath in PHP. To achieve path pointing to:

"/sub1/# CMS/sub2/"

ones have to assign:

"/sub1/%2523 CMS/sub2/"

...there must be an easier way to do it.

When enlarging a block element with element unit, the enlargement will climb up to any ancestor block, which is wrong.

I guess that everybody has this in mind, but no one has written it so far.

In the future it would be very nice to have an automated performance testing system, so that we can keep track of any unexpected degradation of the performance. And also to avoid that little + little + little changed do end up summing a serious problem.

For a reference, this post about Chrome explains the same basic idea: ​http://blog.chromium.org/2008/11/putting-it-to-test.html and points that some of the tools are based on HTML and JS, so maybe we can reuse something from there.

We could encapsulate APIs for functional testing, consider the following basic ones:

1. Toolbar button clicking;
2. Dialog controlling;
3. Document selection and keystrokes;

In some cases, CKEditor uses an alert to display messages, i.e. invalid . but, in some cases, the developer would like to use his own UI to display these messages. so, i think it can be replaced by an internal function that the developer can overwrite, or make an optional config entry with a callback that will overwrite the original alert.

Browsers parse the contents of the style attribute and do strange things with its contents, so we should protect like we do for href and src so it's modified only when the user request it, and not by the browser.

CKLangtool works only with single quotes, it is causing problems like this one: #6038.

The width of the toolbar comboboxes (style, format, fontsize, etc.) should be configurable. Most of the time the name of the selected item is abbreviated and cannot be read.

There is no need for adjusting the width to the combobox content. Being able to set the width manually is fine.

Michael

​http://ckeditor.com/demo

if content selected contains a table ,then apply list format ,the table will change to be first in content.

1. Insert line of text
2. Insert a table
3. Insert some text below the table.
4. Select all
5. Press "bullet list" button

1. Load default sample page;
2. Click on 'CKEditor' link to open dialog;
3. Switch to "Advanced" tab;
4. Switch back to "Link" tab;

• Actual Result: URL field is reset to blank

Happens also to "table" dialog.

Using the following with an editor configured as enterMode=BR:

<blockquote>
	abababab^</blockquote>

Hit ENTER, then click on the blockquote button.
Expected: blockquote is removed in the current caret position.
Actual:

<blockquote>
	abababab^</blockquote>
<blockquote>
	&nbsp;</blockquote>

The CKEditor event 'mode' documentation

• ​http://docs.cksource.com/ckeditor_api/symbols/CKEDITOR.editor.html#event:mode

This is the link provided in the release v3.6.2 notes.

A new event parameter was added by ticket #7931 (New event afterSetMode) The documentation currently says: {String} e.previousMode

The previous mode of the editor.

This is incorrect, it should be {String} e.data.previousMode

The previous mode of the editor.

I couldn't find a way to request documentation changes and there doesn't seem to be a TRACS component, so I've tagged this under General.

During work, I've encountered a situation in which I need to remove the div options from the context menu in a specfic condition (while leaving it intact in any other situation). This is currently impossible - one can remove an option for the entire instance, and not just that one time.
My suggestion is to allow it with null assignment:

return { editdiv : null };

For example:

<div>

^
<bookmark/>
<span id='x'/>
<bookmark/>
^

getEnclosedNode should return span whose id is "x".

for detail see patch in attachement.

When toggling toolbar button by clicking on it twice, when fast enough it will display the native context menu that disturbs user.

​http://docs.cksource.com/CKEditor_3.x/Users_Guide/Keyboard_Shortcuts

1. Open inlineall sample.
2. Focus one of editors.
3. Apply marker style from stylescombo.
4. Style is applied, but it's not visible in the inline editor contents.

It works on themed editor, because marker style is defined in contents.css.

Other TC:

1. Open inlineall sample.
2. Open format combo.
3. Apply header 1 style.
4. Open combo again and compare how header 1 looks in combo and in contents of the editor. They have different font styles.

CKEditor needs a dedicated alert for samples that would explain the users why the content they see is limited if they downloaded the Basic or Standard editor packages.

The alert should use the editor#dataFiltered event.

<ol>
	<li>item1</li>
	<li>&nbsp;
	<ol>
		<li>item2</li>
	</ol>
	</li>
</ol>

Place caret at the beginning of second list item (nbsp) and press enter.

Result:

<ol>
	<li>^item1</li>
	<li>&nbsp;</li>
	<li>&nbsp;
	<ol>
		<li>item2</li>
	</ol>
	</li>
</ol>

Note that the caret was moved up to the item 1.

I was able to reproduce this on Chrome, but not on FF.

• Open source code view
• Insert the attached html code snippet
• Switch back to wysiwyg view
• Select all content
• Press 'Del' key

IE10 crashes, IE9 is fine. This is also reproducible with the current demo.

When I load CKEditor in a StageWebView class in Adobe AIR, the print function does not work. It does nothing at all. Same version of CKEditor in other browsers - printing works.

Also, hinting, when hovering over a button does not work.

Guide: ​http://docs.ckeditor.com/#!/guide/dev_toolbar

Option: ​http://docs.ckeditor.com/#!/api/CKEDITOR.config-cfg-removeButtons

Currently we're observing selection changes to be able to mark widgets as selected (selected != focused). This code is tricky and unnecessary.

Firefox 24 or Chrome 30.0 on Win8:

In code editor:

<p><a href="&lt;?=$foo;?&gt;">Bar</a></p>

Toggle source to wysywyg and toggle back to code

<p><a href="&lt;?=$foo;?&gt;">Bar</a></p>

The result is the same.

IE10 (and other IE) Win8:

In code editor

<p><a href="&lt;?=$foo;?&gt;">Bar</a></p>

Switch to wysywyg and back to code

<p><a href="">Bar</a></p>

Result: href is empty

When I test this without a php start tag (loosing the ?) in IE10:

In code editor

<p><a href="&lt;=$foo;?&gt;">Bar</a></p>

Switch to wysywyg and back to code

<p><a href="&lt;=$foo;?&gt;">Bar</a></p>

The result is correct.

You can reproduce this on the CKEditor demo page.

In our environment it is the same but if I add the following to the config, it works:

config.protectedSource.push( /<\?[\s\S]*?\?>/g );
config.protectedSource.push( /&lt;\?[\s\S]*?\?&gt;/g );

But protectedSource is not something what we want to use.

Is this a bug? Thanks in advance

1. Open MathJax sample.
2. Select some text containing widget (or just widget).
3. Create link.
4. Right click widget.
5. There are no link and unlink options in context menu.

There is bad TC called test avoid having inline event handlers executed in dt\core\htmldataprocessor.html
The reason is that it attempts to execute editorBot#setData multiple times (using doTest function. setData does call wait and resume inside itself so any code after first wait() call will not be executed.

Consider the usual workflow — typing along, and now you want to make a link. Until you have been re-trained by CKEditor, you are likely to press the link button, and now you have your URL— but no custom anchor text, and no way to create it, except by deleting the link, typing some text, selecting it, and now making pressing the link button (if you even know this is an option).

This could be alleviated simply by having a text box for the anchor text. If left blank we put in the URL as the anchor, as is done now. But if something is put in there (or what was there is edited) then that is used as the anchor text. So the proposed fix is to allow adding or editing anchor text when creating or editing a link, but the user's pain is mostly for new links i'm sure.

If this has a chance of going in i think i'd be able to make a patch. My end-users thank you for your consideration!

This is the continuation of #10146 issue.

Problems can be reproduced in all browsers and don't occur in CKEditor 3.x

Examples:

Two brs are handled the same way as one br

Both code snippets

<br>
<br>
<p>This is a paragraph of text.</p>

and

<br>
<p>This is a paragraph of text.</p>

will result into:

 
<p>This is a paragraph of text.</p>

This

    <br /> 
    <br /> 
    <p>This is a paragraph of text.</p> 
    <br /> 
    <br /> 
    <p>Second paragraph of text.</p>

results in

 
<p>This is a paragraph of text.</p>
&nbsp;

<p>Second paragraph of text.</p>

One br is chnaged into  

This

<table>
	<tbody>
		<tr>
			<td>Table cell contents</td>
		</tr>
	</tbody>
</table>
<br>
<p>P contents</p>

will result in

<table>
	<tbody>
		<tr>
			<td>Table cell contents</td>
		</tr>
	</tbody>
</table>
&nbsp;
<p>P contents</p>

I understand that fix for #10146 has introduced fix which changes last BR into &nbsp and most likely example two is a "won't fix". Another reason for this may be that nbsp; in second example creates in fact new line.
The only problem with example two I see is that code is in fact different to what user has entered and this doesn't occur in CKE 3.x.

Example one is rather a bug and there should be some difference between how one and two BRs are handled.

EDIT: This ticket is the follow up to #10146. Most scenarios from #10146 were fixed. Examples mentioned in this ticket are still live. When fixing this issue, please have older test cases from #10146 in mind so that they didn't get broken again.

There is a workaround mentioned in ​http://dev.ckeditor.com/ticket/10146#comment:34. It actually handles all the cases but one. When there is no other way to fix it perhaps some smarter way of using that hack could be implemented?

Extracted from ​http://dev.ckeditor.com/ticket/11439#comment:16

One of the CKEditor users asked about the lack of "dotted" borders for tables. After a few minutes of debugging I just realized that showborders is not a part of the Standard preset.

The plugin s relatively small (145 SLOC), but is quite crucial when working with border-less tables, thus let's include it by default to provide a better OOTB experience.

Tested on CKEditor 4.3.4, Chrome 33 on Android 4.4.2.

Android change font size in the contenteditable area what is on the one hand useful, because it is easier to read and edit content. But on the other hand, because of this, non-editable elements, like placeholder widget, has smaller font size. Also what user see is not what he would get.

We should search for a flag to disable such feature and consider if we should use it.

Currently it is not possible with CKEditor iframe plugin to allow HTML5 video embeds (YouTube, Vimeo etc.) to go fullscreen.

Required attributes to allow fullscreen are:

• fullscreen="true"
• allowfullscreen="true"
• mozallowfullscreen="true"
• webkitallowfullscreen="true"

Definition for fullscreen, note change label to editor.lang.iframe.allowFullscreen or similar.

{
	id : 'allowFullScreen',
	type : 'checkbox',
	label : 'Allow Fullscreen',
	'default' : '',
	setup : function( element )
	{
		var value = element.hasAttribute( 'fullscreen' );

		this.setValue( value || '' );
	},
	commit : function( element )
	{
		if ( this.getValue() )
		{
			element.setAttribute( 'fullscreen', 'true' );
			element.setAttribute( 'allowfullscreen', 'true' );
			element.setAttribute( 'mozallowfullscreen', 'true' );
			element.setAttribute( 'webkitallowfullscreen', 'true' );
			
		}else
		{
			element.removeAttribute( 'fullscreen' );
			element.removeAttribute( 'allowfullscreen' );
			element.removeAttribute( 'mozallowfullscreen' );
			element.removeAttribute( 'webkitallowfullscreen' );
		}
	}
}

CKEDITOR.dom.node#getNextSourceNode
CKEDITOR.dom.node#getPreviousSourceNode

Seems that these methods are missing docs, and they are pretty useful and important. Additionally we should provide some test for them.

When typing in language that requires character composition (e.g. Japanese, Korean or Chinese) undo manager does not record snapshots. Reproducible only on IEs.

To reproduce:

1. Enable e.g. Japanese language (see instructions in #8854). Tip: it's useful if you enable the language floating toolbar in Windows.
2. Set input mode to Hiragana.
3. Start typing random letters in editor. Some will be composed into Japanese characters, but that's not important. What's important is that you can see that inputted text is underlined what means that you're in composition mode. Press enter to finally input text.
4. See that undo button never gets enabled.

Reproducible from CKEditor 4.2.0.

After #12162 there's one red in ​http://tests.ckeditor.dev:1030/tests/plugins/magicline/widgets on most browsers (all except Chrome).

I found the both last odd and perhaps incorrect, but I need a.nowodzinski's opinion.

For now I commented out both cases in ​git:fb3b497.

Hi,

I'm struggling with a strange bug with the image2 (​http://ckeditor.com/addon/image2, version 4.4.4) plugin. If I insert two widgets with a caption and align the first one left and leave the align of the last one none, the first widgets becomes unselectable.

The problem was reproducible on the demo side ​http://ckeditor.com/demo#widgets

This code should reproduce the problem:

<figure class="image" style="float:left"><img alt="Apollo-CSM-LM" src="http://c.cksource.com/a/1/img/demo/apollo-csm-lm.png" width="200" />
<figcaption>Apollo CMS-LM spacecraft</figcaption>
</figure>

<figure class="image"><img alt="Apollo-CSM-LM" src="http://c.cksource.com/a/1/img/demo/apollo-csm-lm.png" width="200" />
<figcaption>Apollo CMS-LM spacecraft</figcaption>
</figure>

If you inspect the selection wrapper of the widget with none align, it covers the first widget (​http://imgur.com/veQbbwE). Could be a problem with the css float?

I tested it in Chrome (latest) and Firefox (latest) on a Mac (Version 10.8.5)

Thank you for your help!

The CKEditor 4 repos should adopt the ​CKEditor Boilerplate project.

1. Open ​http://tests.ckeditor.dev:1030/tests/plugins/uploadwidget/manual/image
2. Open an image in Preview.
3. Select part of it and copy.
4. Paste it into the editor.

Pasted image wasn't uploaded. In the data we can find <img src="webkit-fake-url://e303f4ea-3e1d-4c51-a83d-52707aeeb397/image.tiff" />

So toolbar is closer to the toolbar editor.

.catch() in ES6 Promises causes an CKBuilder error:

Jun 25, 2015 8:39:12 PM com.google.javascript.jscomp.LoggerErrorManager println
SEVERE: plugin.js:87: ERROR - Parse error. missing name after . operator
                                }).catch(function() {
                                         ^

Reproduced with the online builder only. The CLI one works fine.

1. Load EnterKey sample
2. Click inside editor Set Korean language and Hangul keyboard (Korean character (not Latin))
3. Reload the page and change enter mode to BR
4. Click at the end of line and press Enter
5. Start typing

Result: Cursor will be moved up

Problem can be reproduced in IE11 only at least from CKEditor 4.0.

Issues which may be related: #10414, #12910

Edit: This is IE11 bug, it was reported here ​https://connect.microsoft.com/IE/feedback/details/1629173/ie11-broken-composition-in-contenteditable-when-using-korean-hangul

Steps to reproduce

1. Open Placeholder demo
2. Select all text, delete it
3. Type 'Testing '
4. click placeholder button
5. hit right arrow, as placeholder is selected (boo)
6. hit Enter
7. type a letter
8. press left arrow key
9. press backspace

Expected result

Paragraphs are merged together, as they are when no widget is present

Actual result

Widget is selected, paragraphs don't change.

Other details (browser, OS, CKEditor version, installed plugins)

4.5.x, Chrome

Investigation

The issue happens inside of selection.js#getOnKeyDownListener, where it checks for getPreviousEditableNode. It finds the widget, but assumes that the backspace key would have deleted the widget. Instead, it should check if the text and widget are adjacent, maybe with next.getParent().contains(range.startContainer)?

Steps to reproduce

1. On a Mac machine using Chrome go to the demo page
2. Select some text
3. Hold down the control key and left click (single finger on a trackpad) with the mouse

Expected result

The context menu appears and I can cut/copy/paste the selected text

Actual result

The context menu appears but the selection is lost and I can't do the cut/copy/paste operations on the text I wanted

Other details (browser, OS, CKEditor version, installed plugins)

This repros for me both in our app and on the demo page using Chrome version 44. Firefox (version 40) does not reproduce the bug and has the expected behavior. Using a right click or a trackpad two-finger click works fine, but if a ctrl+click is going to show the context menu, it should preserve the selection. You can preserve the selection by ctrl+clicking and holding down the mouse button while you move the mouse over the context menu before releasing, so it seems like the problem is happening on the mouseup event when that event occurs in the editor's editable.

Steps to reproduce

1. Add some styles to add a class to a table

CKEDITOR.config.allowedContent = true;

CKEDITOR.stylesSet.add( 'my_styles', [
    // Block-level styles
    { name: 'Nice table', element: 'table', attributes: { 'class': 'MyTable' } }
] );

CKEDITOR.config.stylesSet = 'my_styles';

2. add a little CSS to check that it works

.MyTable {
    border-collapse:collapse;
    border:1px solid blue;
    background-color: #00DD00;
}

.MyTable td, .MyTable th{
    border:1px solid blue;
        padding: 5px 1em;
}

3. Put some tables in your content with that class and border = 0 or border = 1

4. Now try to use the Styles dropdown

Expected result

In both tables the Style should be shown as "Nice table"

Actual result

Only works correctly in the second one. The first one has the "cke_show_border" class that CKEditor adds automatically and the Styles system doesn't ignore it. Once you click then it's applied and then it works correctly until you reload the content.

Other details (browser, OS, CKEditor version, installed plugins)

This has been failing for eons, all browsers demo at ​http://jsfiddle.net/8jcyf9aa/

Steps to reproduce

1. you can use the demo - type in 5 lines of text. Break the lines with shift+return

2. Select that text and some more and make all that text bold

3. Select 3 of those lines and click on the list control

Expected result

You will see that extra return characters have been added to the list items

Actual result

The list should be clean with no extra CR's.

Other details (browser, OS, CKEditor version, installed plugins)

This test was run on 4.5.4 This bug was NOT present in version 3.6.6

Related Issues

• #14256

We should create CONTRIBUTING.md file in github repo BUT we need to remember to keep it simple and write only the essential stuff.

• Issue tracker URL
• CLA (once it's up and running)
• Explicit link to ​Code Contributing
• Transifex catch (people often fall prey to that trap) - actually we copy'n'paste ​Changes That Cannot Be Accepted as a Pull Request here.
• Link to Transifex project

And after that we might put links for a further reference.

Steps to reproduce

1. Open samples/index.html (also ​http://ckeditor.com/demo)
2. Set the following data

   <p>asd</p>
   <p>zxc</p>
   <p>qwe</p>
   <p>asd</p>
   

3. From the SCAYT dropdown select "Enable SCAYT".
4. From the SCAYT dropdown select "Check Spelling".
5. Click "Change to".
6. Click "Change to".
7. Click "Finish Checking".

Expected result

Dialog closes. Back to editing content.

Actual result

Error in the console

getWordsInfockscayt.js:36:10529 TypeError: g.ltr is not an Object. (evaluating 'c in g.ltr')

Dialog does not close, just keeps displaying a spinner.

Other details (browser, OS, CKEditor version, installed plugins)

WSC Version: 3.0.7670

Tested in Chrome Version 46.0.2490.86 (64-bit), Safari Version 9.0.1 (11601.2.7.2)

Since we'd just added release version of CKEditor to npm we could do the same for dev version.

The problem now is that ​our package name has been taken some time ago and it's not active anymore.

Steps to reproduce

1. Open Media Embed sample [​​http://sdk.ckeditor.com/samples/mediaembed.html]
2. Delete existing content, add few paragraphs of text
3. Embed a video in between paragraphs by using Media Embed dialog.
4. Switch to source, change widget alignment to center by adding

   class="embed-narrow embed-align-center"
   

5. Switch back to Richtext, select the widget
6. Click Undo
7. Click Redo

Issue: Widget selection lost and first paragraph in editor body gets selected

2 unit tests are failing in this test suite:

tests/plugins/embedbase/undo test undo and redo after creation
Error
Error: IndexSizeError: DOM Exception 1
tests/plugins/embedbase/undo test undo and redo after edition
Unexpected error: IndexSizeError: DOM Exception 1
Expected: undefined (undefined)
Actual:   undefined (undefined)
Error
Error: IndexSizeError: DOM Exception 1
tests/plugins/embedbase/undo test undo and redo after creation and edition
Unexpected error: IndexSizeError: DOM Exception 1
Expected: undefined (undefined)
Actual:   undefined (undefined)

It started to appear after #14539. However I've followed the steps that TC is doing manually and the issue does not appear to be there, so it's likely due to a way that the test is written.

This ticket gathers all the issues concerning Paste from Word support in Microsoft Edge.

• ticket:16682
• ticket:16745

Features that are broken in Edge(mostly because content is not recognized as pasted from Word):

• Background Color: All styles except the background color are removed.
• Lists(all kinds except flat ordered list): Always remain paragraphs, regardless of the pasting method.
• Image: src points to a url starting with file://.

Steps to reproduce

1. Open Full editor demo from: ​http://nightly.ckeditor.com/
2. Open the attached file in Word, copy and paste it into the editor.

Expected result

List structure is the same as in the Word file.

Actual result

Lists are malformed - they are shifted one level up.

Other details (browser, OS, CKEditor version, installed plugins)

IE11 Only.

And it could be possible.

What Chrome gives, when I paste a file is DataTransfer (a.k.a. ClipboardData) object with an empty "files" property, but with 2 "items": first with a filename and the second with a file. It means it is possible to get a file from the second "item", on paste.

Unfortunately, when the upload plugin was implemented there was only one item on Chrome and only the first item is handled (see ​https://github.com/ckeditor/ckeditor-dev/blob/685fc7474fab779afe76edcf36011d2fb6bafab8/plugins/clipboard/plugin.js#L2545). If this line will be replaced with a loop it should be possible to get the file.

Note that on Windows pasted file is not available at all.

Also, note that now you do not need try-catch block there since items have a "kind" property which let you check if it is a file or a string.

New Edge 15 ​implemented Clipboard API, so it will be nice to switch from our pastebin to real API in this browser.

Note however that users report some errors (see comments in the linked thread).