Custom Query

Hello,

It seems it is not possible to disable the auto inline functionality when CKEditor is being loaded via Ajax. This is because DOM is ready on the moment CKEditor executes the following code:

CKEDITOR.domReady( function() {
    !CKEDITOR.disableAutoInline && CKEDITOR.inlineAll();
} );

I cannot set CKEDITOR.disableAutoInline before that, because CKEDITOR does not exist in window yet.

Is there a way to resolve this nasty issue?

If the 'Browse server' button in the image or link dialog is clicked, resulting in the popup window opening, and that popup is then closed, the original dialog no longer has keyboard focus. Accordingly, the escape key does not work.

Reproduce case, using 4.4.3 (revision fd4f17c):

1) Go to ​http://ckeditor.com/demo 2) Click 'Image' button. The image dialog opens. 3) Click 'Browse Server' button. The browse server popup opens. 4) Either choose an image or cancel. The browser server popup closes. 5) There is no keyboard focus any more, and the escape key on the keyboard does not work.

Comparison case:

1) Go to ​http://ckeditor.com/demo 2) Click 'Image' button. The image dialog opens. 3) Press escape, and the image dialog closes.

Hello,

For various reasons I need to use the CKEditor inside an iFrame that is populated with content via JavaScript. This seems to cause a bug in the isInline() function within Core.Editable, where the document of the editor is compared with the CKEDITOR.document to conclude if the editor is inline or not. Because the editor is located inside the iFrame, and the iFrame document does not match the CKEDITOR.document, the result is always false. This causes an issue with the magicline plugin that relies on this to calculate the position of the line. Its very likely that other plugins are also affected that use the isInline() function.

I made a JSFiddle to demonstrate the issue: ​http://jsfiddle.net/wschwarz/ktw9utcm/

The solution I applied is also included there as a comment, which checks if the 'cke_editable_inline' class is applied onthe editor to decide if it is inline or not. Un-comment it to see how the isInline() function returns the correct value and the magicline is positioned correctly. This might not be the ideal solution but it worked for me. If a better fix is available please let me know.

Steps to reproduce:

1.Insert a table inside the Ckeditor text area. 2.Click on the corner of the table. 3.Resizable border of the table will appear. 4.Drag the border out of the editor.

Issue 1:The dotted resizable corners of the table is displayed out of the CK editor. Issue 2:Now when we try to use the scroll of editor, the editor becomes unresponsive.

This occurs only in IE8 and IE9 and not in Firefox. I have attached a video to this, having the recording of the issue for your reference.

Unable to create link when certain fields are removed from the dialog. In other words, some default values are missing.

Before I was usign the following code to remove the linktype and protocol fields in the link dialog I don't need...

if ( dialogName == 'link' ) {
        var infoTab = dialogDefinition.getContents( 'info' );
        infoTab.remove( 'linkType' );
        infoTab.remove( 'protocol' );
    }

This will still remove the items, but when trying to hit enter or ok the dialog just fails.

From here:http://ckeditor.com/forums/Plugins/Problems-removing-dialog-fields-of-link-plugin-in-4.4.3

The stylesheetparser is a great feature. Why it is not available in dialog windows? There is a text input for class names of css, but selecting a class would be easier :-)

Open full featured demo ​http://ckeditor.com/demo#full Paste the dummy "Lorem Ipsum..." text several times in order to have scrollbar in the editor. Open "Find" window and try to search "Lorem" word. The scrolling to the word is not correct in all matches. Sometimes the whole page is scrolled.

Generally, in CKEditor, highlighting a selection with an image and executing a removeFormat command will remove any styling on the image, which is usually OK. However, any integration of large images with custom cropping and high-resolution images will, upon doing this, result in very large images being placed into the document.

I'd love for there to be a configuration option to say, for example, when executing removeFormat, do not touch the "img" tag.

I'm using inline mode, enterMode : CKEDITOR.ENTER_DIV

1) Slap a heap of divs into the editor 2) Hit enter anywhere, a new div is created (is this by design?) 3) Ctrl-A, Del 4) Use source button to verify editor is indeed "empty" 5) Use blocks plugin to verify editor is not actually empty, but has a dummy div holder 6) Hit Enter, divs are still created 7) Use source to set <p></p> for content 8) Hit Enter, <p>s are created now

Problems: 1) Is the enter-in-div=div by design? 2) There should be a way to go back to <p> mode between divs 3) The dummy container created for an empty editor should fall back to <p> if editor is indeed empty

1. Find dialog: Enter key when focus is in "Find what" field should find the text.

2. Replace dialog: (tabindex) Tab key when cursor is in "Find what" field should move focus to "Replace with" field.

Any HTML markup inserted before a doctype or <html> tag is clearly invalid, but the way that CKEditor handles it isn't helpful. Given a doc that starts like this (adapted from your ​full-page demo page):

<p>hello</p>
<html>
<head>
	<title>CKEditor Full Page Example</title>
</head>
<body>
<h1><img alt="Saturn V carrying Apollo 11" class="right" src="http://c.cksource.com/a/1/img/sample.jpg" /> Apollo 11</h1>
...

It is transformed into this:

<html>
<head>
</head>
<body>
<p>hello</p>
</body>
</html>
<title>CKEditor Full Page Example</title>
<h1><img alt="Saturn V carrying Apollo 11" class="right" src="http://c.cksource.com/a/1/img/sample.jpg" /> Apollo 11</h1>

If you pass this into any HTML sanitisation system (such as htmlpurifier), it will probably strip everything after the closing </html> (trashing nearly all of the document, including all of the original head tag), and renderers may ignore anything after the </html>, though I note that CKEditor does not. I understand the reasoning behind this approach, but it is unlikely that is what the user intended, and it would be better to try something a little more sane first, for example, if there is a <body> tag, move the early markup after that, so the output would become:

<html>
<head>
	<title>CKEditor Full Page Example</title>
</head>
<body>
<p>hello</p>
<h1><img alt="Saturn V carrying Apollo 11" class="right" src="http://c.cksource.com/a/1/img/sample.jpg" /> Apollo 11</h1>
...

If that fails, then fall back to wrapping it in an HTML element. As it stands, moving all the content to after the </html> tag is far more destructive than having content before the <html> tag in the first place!

Editor blur event is triggered when opening dialog with file element. If you don't put file element inside a dialog blur event is not triggered!

I think this is a Widget issue, but I'm not 100% sure.

I have a CKEditor that is using the magicline, image2, and footnote plugins. The document has an image or footnote box at the bottom.

It seems that when I have one of those selected (an image or footnote box), and I try to move my mouse down to the magic line at the bottom of the document, the magic line disappears on mouseout of the widget.

If I click a piece of text to put my cursor in a text area, then the magic line works correctly.

If I have an image at the top of the page, I don't have this problem with the top magicline, so it's only the magic line at the bottom.

Attached is a 17 second video showing this problem

Hi guys, may I suggest changing the loading order of custom config files (using the customConfig parameter) to what would make more sense and follow the concept of inheritance from generic to more specific.

At present the config defined in any config js file is overridden by config defined in any config js file imported using the customConfig parameter. All of this is then overridden with in-page config.

It would be much more logical and practical to slightly modify the config loading order so that config defined in any config js file referenced from the current config is loaded first and then overridden by the config in the current context.

This would allow chaining config files with more specific config overriding more generic config defined in imported files.

For example consider the following scenario: In-Page Config customConfig: 'product_description_editor_config.js' ...

product_description_editor_config.js customConfig: 'generic_description_editor_config.js' ...

generic_description_editor_config.js customConfig: 'common_editor_config.js' ...

product_summary_editor_config.js customConfig: 'generic_summary_editor_config.js' ...

generic_summary_editor_config.js customConfig: 'common_editor_config.js' ...

common_editor_config.js customConfig: ...

As it stands the configuration defined in common_editor_config.js would override any config defined in generic_description_editor_config.js which would in turn override config defined in product_description_editor_config.js.

All of this would then be overridden with what's defined in in-page config.

This limits a developers ability to chain and override configuration in much the same way as they would in CSS or object inheritance. This basically means you can only define configuration in common_editor_config.js that's not going to override any other config in the the config js files that reference it, which significantly limits the use of being able to chain config files.

May I suggest that the loading order is reversed so that config defined in files referenced using customConfig parameter is loaded first and then overridden by config in the file that has the customConfig parameter.

I understand that this may be a breaking change for some people who upgrade, but given the current limited use of overriding, I think the impact will be minimal.

When I enter the source mode, and exit, all the buttons of the editor are disabled, for some contents.

See comment:5 for steps to reproduce.

Copying plain text, say from notepad, and pasting into editor in Chrome is causing the text format to be messed up.

Steps to reproduce:

1. use the attached sample html file
2. copy some text from notepad.
3. paste into editor

Browser and OS:

1. Google Chrome
2. Windows 8

Edit:

1. Use Blink or Webkit browser
2. Load any sample and switch to source mode
3. Paste below code and switch to wysiwyg

   <table >
   	<tbody>
   	<tr>
   		<td>
   			<span style="font-size:23pt">explorer deliver</span>		
   		</td>
   	</tr>
   	</tbody>
   </table>
   

4. Type "some text" in notepad and copy this text with ctrl+C
5. Paste this text in explorer del^iver

Result: Span is removed.

This problem can be reproduced in Blink and Webkit brwosers from CKEditor 4.0. I was able to reproduce this in Windows and Linux but not Mac.

To reproduce the defect:

1. Open any CK Sample, open Templates dialog and select Text and Table Template.

2. Right click inside table cell, open Table Properties dialog by clicking on Table Properties option in context menu.

3. Try to change Table Caption

Issue: Caption field is disabled, we should allow the user to change Table Caption

Edit:

As mentioned in comment:5, the fix for #6663 which is "enabled field for text only caption" might not have been correct because as @satya has mentioned it this is AVT violation because keyboard user cannot modify Table Caption.

Field should be enabled but it is not yet clear how HTML in dialog should be presented.

In Lotus Notes, there's a featured called the Permanent Pen. You can set the style of the pen and when it's selected, you can write with that style anywhere in any document regardless of the document's formatting, where it came from, etc.

​http://www-12.lotus.com/ldd/doc/domino_notes/rnext/help6_client.nsf/b3266a3c17f9bb7085256b870069c0a9/0878ce791468b5b185256c1c0037f06d?OpenDocument

One of our customers find creating a table difficult in CKEditor, and finds the look and feel for the table and the dialog a little bit dated.

We would like a way to make the table look more modern in the editor if possible, and have an alternative to creating table For example, having a new plugin allowing to graphically select how many rows and columns is needed.

I built the Editor without the iframe plugin (guessing that the fallback would be just an inline-div) and did realise that I then require the divarea plugin.

When using the inline editing mode, the editor would work fine. But replace mode would result in the editor being disabled, without so much as a warning. In the code I tried to backtrack the problem but had no such luck. When I noticed that even the sample for textarea replacement did not work, I guessed that I misconfigured the builder somehow...but still did not know that I had to use the divarea plugin instead.

I stumbled upon the solution by accident when googling the issue.

A nice way to solve this would be an error/warning when neither the iframe nor the divarea plugin is used.

I am developing an iOS app which integrates ckeditor 4.4.4. I just started testing on iOS 8, seems like ckeditor does not work at all. Whenever i have more than 500 words in a document,the following issues occur:

1. Focus keeps on switching between caret current position and top of page. Sometimes caret is also moved to the top of page while i am typing.
2. Touch event does not work when document is long, so i cannot start typing.
3. Cannot scroll my content -- happens randomly.

I have tested on nightly build 4.4.5 also. Issues can be reproduced in that build also. Seems like these are due to toolbar validation because if open my document in read only mode, none of the issues. occur. Any ideas on the fix? In the mean time any way i can disable the toolbar and still work in wysiwyg mode?

When pasting this source code into CKEditor (tested with 4.4.4) in Internet Explorer (tested with IE11):

<div style="background-image: url('data:image/png;base64,iVBORw0KGgoAAAANSUhEUgAAAAUAAAAFCAYAAACNbyblAAAAHElEQVQI12P4//8/w38GIAXDIBKE0DHxgljNBAAO9TXL0Y4OHwAAAABJRU5ErkJggg==')">Foo</div>

It is changed into the following code when switching back to the WYSIWYG view:

<div style="background-image: url(&quot;data:image/png;base64,ivborw0kggoaaaansuheugaaaauaaaafcayaaacnbyblaaaaheleqvqi12p4//8/w38giaxdibke0dhxgljnbaao9txl0y4ohwaaaabjru5erkjggg==&quot;);">Foo</div>

Because data URIs are case-sensitive, the image becomes invalid.

The cause is the semicolon before base64. This part of htmldataprocessor.js contains the bug:

if ( CKEDITOR.env.ie ) {
	// IE outputs style attribute in capital letters. We should convert
	// them back to lower case, while not hurting the values (#5930)
	defaultHtmlFilterRulesForAll.attributes.style = function( value, element ) {
		return value.replace( /(^|;)([^\:]+)/g, function( match ) {
			alert(match);
			return match.toLowerCase();
		} );
	};
}

When i use Replace all feature and close the replace all dialog after that, an exception occurs in IE11.

Environment: OS:Windows 7 x64 Browser: Internet Explorer 11.0.9600.17280 (Update 11.0.12)

Reproducible on demo page: ​http://ckeditor.com/demo#full

Steps:

1. Remove all sample text and images from the CKEditor on the demo page.
2. Type the following text: test text number 1
3. Press Replace button on the toolbar
4. In the Find what field type the following text: number
5. In the Replace with field type the following text: N
6. Press Replace All button
7. Press OK button on the notification Message Box
8. Press close button on the Find and Replace dialog
9. Look in the browser console for the error.

Screen shot is attached.

System hangs when using Image upload on IOS 8 (iPhone, iPad):

Image Uoload Chose File "selected file" Send it to the Server

SYSTEM HANGS !!!!!!

This wad detected in version CKEditor 3.6.2 (revision 7275) used by my application, and HAS BEEN REPRODUCED ON YOUR DEMO KEditor 4.4.4 (Standard) (revision 1ba5105)

If you put from the source mode a link that has no text the editor automatically removes it. This is bad because I am using css to define images to be put instead of the text and the link is something like <a href="..." class="myclass"></a> and in the myclass is defined the actual image to be clicked on.

Steps to reproduce:

1. go to demo page
2. go in source mode
3. replace existing source with <a href="www.google.com"></a>
4. exit the source mode
5. enter again the source mode and you will see that the tag is no there anymore

The best solution I think would be that a config parameter to change this behavior would exist

Hi,

I'm struggling with a strange bug with the image2 (​http://ckeditor.com/addon/image2, version 4.4.4) plugin. If I insert two widgets with a caption and align the first one left and leave the align of the last one none, the first widgets becomes unselectable.

The problem was reproducible on the demo side ​http://ckeditor.com/demo#widgets

This code should reproduce the problem:

<figure class="image" style="float:left"><img alt="Apollo-CSM-LM" src="http://c.cksource.com/a/1/img/demo/apollo-csm-lm.png" width="200" />
<figcaption>Apollo CMS-LM spacecraft</figcaption>
</figure>

<figure class="image"><img alt="Apollo-CSM-LM" src="http://c.cksource.com/a/1/img/demo/apollo-csm-lm.png" width="200" />
<figcaption>Apollo CMS-LM spacecraft</figcaption>
</figure>

If you inspect the selection wrapper of the widget with none align, it covers the first widget (​http://imgur.com/veQbbwE). Could be a problem with the css float?

I tested it in Chrome (latest) and Firefox (latest) on a Mac (Version 10.8.5)

Thank you for your help!

Browsers: Chrome, FF and IE9+

1. Open editor with following content and selection:

   <ol>
   	<li>hello</li>
   	<li>moto</li>
   	<li><strong>[:D]</strong></li>
   </ol>
   

2. Click "Remove format" button.
3. Press "Ordered List" or "Unordered List" button.

Actual result:

There is an error in console: TypeError: node is null range.js:1724

this.setStart( node.getParent(), node.getIndex() );

The bug happen with CKEDITOR.ENTER_BR when you enter some words and then add MathJax waiting for the math created and then go to the start of Math press Enter and then press backspace the math is not return back.

1. Open document properties sample
2. Insert below meta tag into page (under title :)). You can also insert doctype but this has no effect on result.

   <meta charset="utf-8" />
   

3. Open document properties dialog and notice that charset it not set in dialog.
4. When you set charset to UTF-8 in dialog, below meta tag is inserted:

   <meta http-equiv="Content-Type" content="text/html; charset=utf-8" />
   

This problem can be reproduced from CKEditor 4.0 beta.

In current version the problem gets worse.

1. Let's say that you have removed HTML5 charset and decided to use HTML4 charset.
2. In current version (latest master) this charset is also not recognized. What is more every time you set utf-8 charset in dialog, new tag gets inserted so you can end up with multiple meta tags inserted into page.

Shouldn't charset meta tag be somehow dependent on doctype or this is something developer/user should know when creating page?

To reproduce the defect:

1. Open any CK Editor sample, switch to High Contrast mode.

2. Enter some text inside editor.

3. Click on Show Blocks button in toolbar

Expected Result: Dotted lines shows around each block level elements like(p, div etc) and corresponding html tag(p, div) displays inside them.

Actual Result: Dotted lines shows around each block level elements like(p, div etc) but corresponding html tag(p, div) is missing in HC mode.

Steps to replicate:
copy below snippet in 'source' mode

<p>Heading:</p> 
 <ol> 
    <li> 
	<ul>
	<li>List 1 Item 1</li>
	<li>List 1 Item 2</li>
	</ul> 
	<div>&nbsp;Sub heading</div>
	<ul>
	<li>List 2 Item 1</li>
	<li>List 2 Item 2</li>
	</ul> 
    </li> 
</ol> 

Repeat the steps below with Firefox, Chrome and IE8:

1. 1st scenario: Select the complete "List 1 Item 1" bullet line and then delete it.
   It works fine with Firefox and Chrome browser, the order of the list get mess up(re-ordered) with IE8 browser.

2. 2nd scenario: Now place the cursor at the very beginning of the "List 1 Item 1" bullet line and then backspace delete
   All Firefox/Chrome/IE8 browsers has this issue where the order of the list get mess up(re-ordered).

Over at ​https://www.drupal.org/node/1993928, we're working on shipping the Language plugin with Drupal 8 core. It will not be enabled by default, but it will be 'available' by default, hence making it simple to meet WCAG2, which is required by many governments.

It's working well in general, except… that the way it handles <span>s is extremely frustrating.

If you write

<p><span dir="ltr" lang="nl">Hallo, wereld!</span></p>

and you have your cursor at the end of that line and press enter (to start a new paragraph) and type something, you'll get:

<p><span dir="ltr" lang="nl">Hallo, wereld!</span></p>
<p><span dir="ltr" lang="nl">foo</span></p>

Where you'd really expect the language span to not be applied to this new paragraph.

The language button is working on inline level, but currently not on a block level. You will notice that with RTL languages in LTR texts as the text stays left aligned. We could add the following behavior:

• if text included in a block element is selected, the block element should get a lang and dir attribute.
• if the user is adding a next blocklevel element, the language should be applied as well
• if the user has a blocklevel selected with a language, the language button should be active.
• If the user deactivate the button, the blocklevel element should remove the language and dir attributes.

Click on "Font" drop-down. Click on "Size" drop-down (all further clicks on "Font", "Size", "Format", "Background Color" and "Text color" drop-downs will result showing and immediate hiding of drop-down). Browser name and OS : Checked on IE8、IE9、IE10、IE11 on Windows 7.

We should describe solution for this issue in documentation just like for ticket #12768.

You can see this directly at ​http://ckeditor.com/demo#widgets

When dragging a widget, I would expect the editor to scroll up or down if I'm attempting to drag past the edges of the container. However, dragging is limited to the current height of the container, unless I also manually scroll with the scrollwheel.

After moving a widget (e.g. an image with a caption) to a different position and right-clicking on a text input, an error is thrown in the console and the right click menu doesn't show up. Issue occurs on Chrome 37.0.2062.120 (64-bit) running at Ubuntu 14.04.

Reproduction steps:

1. Open "New image plugin" sample: ​http://ckeditor.com/latest/samples/plugins/image2/image2.html
2. Move one of the images to the top of the text area.
3. Right-click on the image caption (don't select the text, just click it).

Result: No right click menu is visible and an error in the console is thrown: "Uncaught TypeError: Cannot read property 'checkReadOnly' of undefined"

Expected result: Right click menu should be opened.

1. Insert a table with default values.
2. Enter some content to each cell.
3. select one row.
4. right click -> merge cells.
5. while content in the merged cell is still selected click 'Select table' button.

Result: table is not selected

This happens only when merged cell content is selected, if you click inside the merged cell to deselect the content before clicking 'Select table' button then table will be selected.

This seems to be a IE9/10/11 specific issue.

When trying to write some text inside a word with added style (ie bold) the text doesn't have applied styles and new text can be placed on wrong place (like on the end of word).

Steps to reproduce:

1. Open demo and place cursor inside some word (ie: space|flight)
2. Toggle 'Bold' button to start writing bold text
3. Start writing some text

Expected result: spacesometextfligth (new text should be bold)

Actual result: spaceflightsometext

The result is the same on every tested browser.

The same result is when using voice input:

1. Open demo and place cursor inside some word (ie: space|flight)
2. Toggle 'Bold' button to start writing bold text
3. Start voice input some text

Actual result: text from voice input is not bold

From my observation it looks like Android or Cyanogenmod keyboard is replacing text from auto-suggest.

The only way to write bold text is to put:

1. cursor between two spaces
2. Toggle bold button
3. write new text

Tested on:

• Android 4.4.4 - Cyanogenmod 11-201410008-SNPAPSHOT-M11-i9300
• Browsers:
  • Firefox: 32.0.3
  • Chrome: 37.0.2062.117
  • Browser (preinstalled Chrome): 33.0.0.0 (from user agent string)

The issue was originally reported @ ​http://stackoverflow.com/questions/26257663/ckeditor-android-formatters-work-incorrectly

Inside the same fieldset, two ckeditors will overflow the container on resize in Chrome/Safari.

Code that reproduces the bug:

<!DOCTYPE html>
<html>
	<head>
		<title>CKEditor</title>
		<meta http-equiv="Content-Type" content="text/html; charset=UTF-8">
		<style>
			html {
				background-color: lightgray;
			}
			textarea {
				width: 100%;
			}
		</style>
	</head>
	<body>
		<div id="content">
			<fieldset>
				<textarea name="editor1" id="editor1">&lt;p&gt;Foo foo!&lt;/p&gt;</textarea>	
				<textarea name="editor2" id="editor2">&lt;p&gt;Foo foo!&lt;/p&gt;</textarea>
			</fieldset>
		</div>
		<script type="text/javascript" src="http://ckeditor.com/apps/ckeditor/4.4.5/ckeditor.js"></script>
		<script>
			CKEDITOR.replace('editor1');
			CKEDITOR.replace('editor2');
		</script>
	</body>
</html>

• enable autogrow plugin
  
• remove all content
  
• insert table with margin: 1%

The height of the editor will be greatly increased. The table will appear at the bottom of the editor.

When working in full page mode, if you open the editor for a given page, then use the docprops dialog to change a document setting, for example the background color, but you do not make any other changes, then CKEDITOR.editor.checkDirty() will still return false, so the changes will not be saved if saving is done only if checkDirty() returns true.

This is because checkDirty() and resetDirty() use only getSnapshot(), which returns the document body, but all changes in the docprops dialog are outside of the body.

Suggested change:

In checkDirty():

if (this.config.fullPage)
    return this.status == 'ready' && this._.previousValue !== this.getData();
else
    return this.status == 'ready' && this._.previousValue !== this.getSnapshot();

and in resetDirty():

if (this.config.fullPage)
    this._.previousValue = this.getData();
else
    this._.previousValue = this.getSnapshot();

To reproduce:

• Open editor, open image edit popup
• External .destroy()

Result: dialog is cleaned up, but the background overlay is left behind.

Reproducible in the current CKEditor demo Steps:

• Remove all editor content
• Insert table

-> Magicline is available before and behind the table

• Open table properties and set horizontal alignment

-> Magicline is not available

Using an iPhone/iPod touch:

1. Open image dialog (also occurs in link dialog)
2. try to select an image

Results: The dialog is sized in such a way that the ok and cancel buttons are off the right of the screen and the user cannot scroll to the right to click it.

This is the same as #8771 which was closed as "expired - can't reproduce" a while back. This bug is still present in 4.4.5 and is actually very easy to reproduce even with the demo at ​http://ckeditor.com/demo#full-page:

Click the document properties button to open the docprops dialog.

Go to "Design" page.

Click on "Choose" button of "Text color" field.

Do *not* pick a color in the colorpicker but close the colorpicker with "Cancel".

Click on "Choose" button of Background color".

Now *do* pick a color in the colorpicker and close it with "OK":

The selected color is set into the "Background color" field (as expected) but is incorrectly *also* set into the "text color" field.

As already described in #8771, the problem is in ckeditor/plguins/docprops/dialogs/docprops.js, in the "getDialogValue" function:

Buggy code:

var onOk = function() {
	releaseHandlers( this );
	callback( this, this._.parentDialog );
};
var releaseHandlers = function( dialog ) {
	dialog.removeListener( 'ok', onOk );
	dialog.removeListener( 'cancel', releaseHandlers );
};
var bindToDialog = function( dialog ) {
	dialog.on( 'ok', onOk );
	dialog.on( 'cancel', releaseHandlers );
};

The problem with the above is that "releaseHandlers" is set directly as the "cancel" listener.

Suggested change:

var onOk = function() {
	releaseHandlers( this );
	callback( this, this._.parentDialog );
};
var onCancel = function() {
	releaseHandlers( this );
};
var releaseHandlers = function( dialog ) {
	dialog.removeListener( 'ok', onOk );
	dialog.removeListener( 'cancel', onCancel );
};
var bindToDialog = function( dialog ) {
	dialog.on( 'ok', onOk );
	dialog.on( 'cancel', onCancel );
};

Reproduction steps {using Chrome Version 37.0.2062.124 m (64-bit)}

1. Go to CK Editor demo page
2. Select Inline editing
3. Select all the text in one of the editor boxes and delete it (ctrl+A and then DEL).
4. Switch to Right to Left editing (ctrl + right shift)
5. Insert Bulleted list
6. Insert Numbered list

Result: browser is stuck!

The inline mode of CKEditor does not honor the ​baseHref option.

I guess it is because it relies on the base HTML tag and the inline editor does not use an iframe.

Could this feature be implemented inside the dataProcessor instead, to work in inline mode seamlessly? Otherwise, please add a note to the documentation of the option, so it is clear it will not work with inline editing.

The tutorials for adding custom widgets do not mention using them with custom tool bars

eg if you add a widget with

editor.widgets.add('foo', {
 allowedContent:'span[foo]'
,button:'Add foo'
});

config = {
  extraPlugins='foo'
 ,toolbar_Test=[['Source','foo']]
 .toolbar='Test'
}

Then the 'Foo' plugin will NOT appear on the toolbar also any 'foo' attributes will be stripped from spans

I have discovered, after a great deal of lost time that the command is auto generated from the widget name by uppercasing the first letter and lowercasing the rest

eg changing the toolbar definition to

[['Source','Foo']]

Reproduce with the help of the simplebox widget:

Click the toolbar button to insert a simplebox.

In the second of the two editable boxes of the widget, set the cursor somewhere in the middle of the word "Content...".

Use SHIFT+Cursorkeys to move the cursor up into the first of the editable boxes, somewhere in the middle of the word "Title", so that you have a selected text area that selects the end of the word "Title" and the beginning of the word "Content...".

Press DELETE to delete the selected text.

The result is as expected: The remaining text is now in the first box (the title box), but the content box, which is now empty, is still there, i.e. you can again insert new text into the content box.

Now make the following slight modification to the simplebox plugin:

Change the template so that the title box (the one with class="simplebox-title") is a div instead of a h2, like so:

template:
    '<div class="simplebox">' +
        '<div class="simplebox-title">Title</div>' +
        '<div class="simplebox-content"><p>Content...</p></div>' +
    '</div>',

(Also for completeness sake, change the "allowedContent" so that it says "div(!simplebox-title)" instead of "h2(!simplebox-title)".)

Reload the editor and repeat the above experiment.

You will see that when you press DELETE to delete the highlighted text, that the text is deleted as expected, but the second editable box (the div with class="simplebox-content") is also deleted, i.e. a protected part of the widget is damaged. You can no longer add new text into the "content" field of the widget since it no longer exists.

1. Create Table with formattings (e.g. width=50%, bg-color=blue, headers=first row)
2. Select (all cells) of the table
3. Copy (STRG + C)
4. Paste (STRG + V)
5. Open table properties of the pasted table

Result: Table looses formattings (width, bg-color, headers)

Expected: All table formattings are copied properly

The textarea used to input the Tex code should have spell checking disabled by specifying spellcheck="false" since spell checking makes absolutely no sense there.

This is especially annoying in Internet Explorer 11 which seems to fix words automatically, for example changing "\binom" to "\Binom", thus breaking the code.

I have been hassling with ckeditor on iOS for quite a while due to Ticket #12457. Turned out that inline editor does not suffer from all those issues of selection in iOS 7,8. So i moved my code to adapt with inline editor. Now i have observed new issue in selection with inline editor. Here are the steps to reproduce in 'inlinetextarea' sample from ckeditor in iOS 7:

1. select any word.
2. Now click on 'Link' button on the toolbar.
3. Type some URL in the text field and press OK.

Observe link is inserted at some random position (sometimes at last selection point).

Similarly my app has no of modal windows. Each time i open a window, selection is lost in the inline ckeditor, so cannot perform operation on the intended selection. Please suggest a solution to this.

In Firefox on Android, if you press enter at the end of a paragraph, the cursor skips down to a new line briefly, but then jumps back up. It is not possible to cursor down. You can tap a touchscreen where the next paragraph would be entered to move there. Problem occurs on your demo site, and in our local copy of 4.4.5.

Test platform: Android 28 or 33 on Nexus 10, Android 4.3.

This seems similar to ticket #12423.

Current behaviour: Insert a table and open cell properties layer. Type 70 for width click OK and the cell will become 70 px. Then open the layer again and change the measure unit to % and click OK -> nothing happens (bug) . Open the layer again and px are prefilled in the dropdown instead of % . Edit the input to 71 for example and the new cell width is fired.

Expected: when changing the the measure unit without editing the value, and clicking OK then the new unit to be applied.

Following on from the update to ​`getAscendant` should hasAscendant have the same parameter pattern?

1. Open sample page
2. Start typing, e.g. abc
3. Observe elements path bar

Actual result: span element gets created on each key press as checkElementMatch return FALSE

Expected result: span element gets created only once on the first key press

This works as expected in FF & Chrome

If user drop a big image it should not break paragraph.

There is something wrong with meta-tags protection. When I open the docprops window, then keywords-, description-, autor- and copyright-fields are empty. If I remove /<meta[\s\S]*?\/?>/gi from function protectSource in file htmldataprocessor.js, it shows the content of the meta-tags.

When you copy and paste a relative url in a contentEditable field, it becomes an absolute path (in some browsers?). CKEditor does some processing to fix this. When you enable the BBCode plugin, nothing changes and the url stays absolute.

Steps to reproduce:

1. Make a relative link (Link protocol: <other>, URL: 'test.html'
2. Copy and Paste that link inside the editor
3. Check the source

The same works perfect without BBCode enabled.

Tried in Chrome 38 and FF 33.

In CK demo paste this source code in the source area of the CK editor:

<div style="background:#eee;border:1px solid #ccc;padding:5px 10px;">AAAA</div>

<div style="background:#AAA;border:3px solid #ccc;padding:5px 10px;">BBBB</div>

as the first row is the style "Special container" and the second is the same style with modified color and border. Go to the end of the "AAAA" string and click "Del". Then "BBBB" is merged into the same paragraph, but the paragraph gets the style of "BBBB" instead of "AAAA".

If there is more than one paragraph style in the style combo with surrounding <div></div> the bug is present, but as the the demo such second style lacks, typing it in the source area gives us the same effect.

Only FF. Chrome and IE seem to work correctly - they take the style from the "AAAA" text.

Let's have the following HTML:

<div>111<br></div>
<div>222 <br></div>

This we receive as we use divs for paragraphs and using magicline after 111. After 222 we have whitespace, it is not &nbsp; for FF. We select 222 (only 2s without the interval behind) and copy (CTRL+C) and then in the clipboard we have '222 '.

Steps to reproduce on the demo:

1. Place the following HTML on empty CK area with firebug. Using source button in the demo clears the divs, so use firebug.
2. Select the 222 text without the interval and make CTRL+C.
3. Place the cursor among 111 and CTRL+V. The result is 1222 11.

The bug reproduces for the most of the cases, rarely it will work correct, even though on the demo we did not faced correct behaviour.

Once Paste from Word button is used, after that, even if we use Ctrl+V with a content in clipboard that is copied somewhere in the editor, then the specific Paste from Word filtering/processing is executed.

I see in the paste from word plugin code that there is flag "forceFromWord", that actually is never set to 0. There is event handler function resetFromWord that set the flag to 0, but it is not attached to any event. I can see that in ver.3.6.5 this handler has been attached to 'afterPaste' event and this misbehaviour is not reproduced.

When copying multi-line text where each line starts with double byte white space(s) from Firefox and pasting into a ckeditor text field, the double byte white spaces are all dropped.

Steps to reproduce:

1. create a html file with the following content:

   <html><title></title><body>
   &#12288;1<br>
   &#12288;&#12288;2<br>
   &#12288;&#12288;&#12288;3
   </body></html>
   

2. Open the file in firefox and copy all 3 lines.
3. Paste into a ckeditor text field (I'm currently using ​http://ckeditor.com/demo#inline for testing)

Actual behavior:
All double byte white spaces are dropped.

Expected behavior:
They should be retained.

Additional information:
If the same html file is opened in Chrome and copying happens from a Chrome browser, pasting into ckeditor text field succeeds as expected.

Copying a single whitespace and the pasting it several times again has not effect.

• Steps to reproduce:

1. Open a ckeditor text field and put

   x x
   

into it.

2. Copy the whitespace (without the 'x')
3. Paste the whitespace 5 times

• Actual output:

1 whitespaces

• Expected output:

1 whitespaces

• Additional information:

Copying single whitespace in Chrome and Internet Explorer works fine. In firefox it also works if one copies 2 or more whitespaces.

Reproducing this but work also while using double byte whitespace instead of single byte whitespace.

We are using a MindTouch implementation of CKEditor.

Follow these steps to reproduce the issue:

1. Open the latest version of Google Chrome
2. Create a new page
3. Type three words into the header
4. Highlight the words and set them as H1
5. Type five words below your new header, making sure they are plain text
6. Triple click the middle word in the header to highlight the whole line
7. Press backspace
8. Notice the plaintext below has now inherited the H1 styling

This does not happen in IE9.

JAWS user may want to access the toolbar controls using button list (INSERT F5) and select a button (e.g. bold button) from the list and then use space to trigger the action. However, I could not trigger any button action in this way. The workaround is to use “B” key to iterate through the button list and then enter the space key to trigger the action. The issue can be reproduce in the last night build sample CKEditor page. ​http://nightly.ckeditor.com/14-11-17-07-09/standard/samples/replacebycode.html

Reproduced on demo and nightly build on IE11 on Windows 8.1

Steps to reproduce:

1. Apply some font styling (font family, size, colour).
2. Type a line and create a new line by pressing enter
3. Click the beginning of the new line to position the cursor there. (Optionally, reposition the cursor elsewhere first).
4. Begin typing again

Behaviour:

Expected: The text styling on the new line should be the same as that on the previous line

Actual: The style has reset to the editor's default

Edit:
Image2 resize feature could have limiter which limits resizing image to:

1. specified width (perhaps also height) in pixels.
2. body (for classic editor) or editable element (for inline editor) width (perhaps height as well). I'm not sure whether size has to be specified or will be taken from computed styles (but what if body size changes in the meantime?)

image2 let you enlarge the picture beyond the editor limits so there is a horizontal-scroll if the image is too big

This is how HTML/CSS works. You can set overflow:hidden; for body element if you don't want to see scrolls. This is not a bug so I have reedited you original report.

I'd like there to be another enter key mode which matches people's expectation on how paragraphs and new lines are created, based on how most people use a textarea.

The rule would be:

• Two new lines = P element
• One new line = BR element

My mistake, here is the correct way to reproduce:

1- Use Chrome 39.0.2171.71 m (although the bug also occurs in Firefox, the present procedure only works in Chrome, I don't know why).

2- Go to the official Shared Space demo: ​http://ckeditor.com/ckeditor_4.3_beta/samples/plugins/sharedspace/sharedspace.html

3- In Chrome's console, type: for (var i in CKEDITOR.instances) CKEDITOR.instances[i].setReadOnly(true); ==> All buttons are now disabled.

4- Click anywhere on the shared toolbar. ==> Three buttons are now enabled: "Paste", "Paste as plain text" and "Paste from Word".

If you remove editor container from DOM and then call editor.destroy(), you got exception, because CKEditor assumes frameElement of editable is available. But element.frameElement is null.

Demo: ​http://jsfiddle.net/danya_postfactum/wfy9fgdd/2/

Currently, "menu" plugin skips menu items, associated with commands, having disabled state. This behavior is good for context menus. But "menu" plugin is "abstract", it's also used for toolbar menus, where this behavior is not desired.

See demo: ​http://jsfiddle.net/danya_postfactum/gwragLhw/ See table tools button. It should have "Delete table" and "Table properties". But these items are displayed when cursor in table context only.

It's easy to fix, because this feature is not used, except "table" and "clipboard" plugins. Other plugins just do not add items to context menu for inappropriate contexts.

I'll send patch now.

Steps to reproduce:

1. Insert numbered list and insert a table in it

2.Place a cursor after the table, and hit ENTER

Expected: new numbered list item should be added Actual: the previous list item with the table is deleted.

Issue happens in all browsers

Let the user enter a list of checkboxes/ radio buttons, that are actionable.

Numbered bulleted list - no choices for types of lists and no differentiation (e.g. uses 1,2,3 for every level) at different levels. They're exposed for the edit case, but not in the creation case.

Very often user needs to change attributes of some html element. For example, set class for current span element. At now there are no way to do this without switching to html code, searching manually this element in long html code and editing.

TinyMCE 3.x have this feature, you can check this here: ​http://www.tinymce.com/tryit/3_x/full.php Here is screenshots: ​http://i.imgur.com/DAllHOy.png ​http://i.imgur.com/wfElESi.png ​http://i.imgur.com/yb2hETk.png

Via this feature we can set for element custom id css class, edit css styles, onclick events, and many other features.

Will be good to implement this feature in CKEditor too, maybe not in core, but via separate plugin.

I have a report where I wait for user input before creating a textarea object in jquery and turning it into a CKEditor instance. This works beautifully on IE 10/11, Firefox, Chrome, and Safari on Desktops but when we test on an iPad iOS 8 users have an issue typing into the editor.

When a user starts to type, the entire view scrolls back to the top of the page away from editor. The text still gets entered and after scrolling the page back down the user can see editor with their new text.

Plugins Using: autogrow clipboard colordialog dialog find link pastefromword

I'm hoping since I can't find another post/ticket on this topic it is a configuration or css setting conflicting with CKEditor. Any help would be beneficial.

PS: Some browsers on the iPad only scroll back to top when pressing the space button.

The dialog resize feature would be much more useful on the image properties dialog if the image preview would resize as well as the URL and Alt input fields, see attached image for example.

Steps to Reproduce

1. Open the editor full featured demo page
2. Paste in this test text:

   test` test~ test! test@ test# test$ test% test^ test& test* test( test) test- test_ test= test+ test[ test{ test] test} test\ test| test; test: test' test" test, test< test. test> test/ test?
   

3. Open the find dialog
4. Enter test as the search term
5. Check the Match whole word checkbox
6. Click find repeatedly

Expected Behavior

I don't think there is any consensus to exactly which characters should or should not delimit words but the main characters we are concerned with are parentheses (), square brackets [], and the slash / which are used often to enclose or connect words but without making them compound words with the other content around the symbol.

Word 2013 finds every instance of the word in this test with Find whole words only checked, Internet Explorer finds all but the one next to a single quote '

Actual Behavior

Only the instances of test that are adjacent to quotes and common sentence separator characters are found.

When using jQuery UI, there are sometimes issues when CKEditor is instantiated inside a jQuery UI modal dialog. Typically, the CKEditor dialogs become read-only.

This is explained here: ​http://bugs.jqueryui.com/ticket/9087

It would be very helpful if jQuery UI was detected in the jQuery Adaptor (typeof jQuery.ui != 'undefined') and the fix for CKEditor instances in modal dialogs (from the above ticket reference) was executed in that case. I do not expect the JQuery UI developers to implement something specific for CKEditor, so I am hoping that you may be open to adding some variation of this in the jQuery adaptor.

Hi, i have a problem in IE 11 with object stylied with sizes:

<div style="width: 903px; height: 210px;">test div</div>

Select borders are over editor sizes. How can i hide this or use css maybe?

This is an extension of ticket #12132 ​https://dev.ckeditor.com/ticket/12132
The image dialog still has some ACF issues.

Expected behaviour:

If you disallow image styles, but still allow their related element attributes, the image dialog should force the usage of the attributes.

Eg: this code

<img style="width:30px; height:40px; float:left;">

should become

<img width="30" height="40" align="left">

What actually happens:

The image dialog ignores ACF and keeps the styles at first. The ACF rules are only applied after you switch to source code view.

How to reproduce:

1. set this configuration

// Allow all elements/attributes/styles/classes by default
config.allowedContent = {
    $1: {
        elements: CKEDITOR.dtd,
        attributes: true,
        styles: true,
        classes: true
    }
};
// Then disallow some styles
config.disallowedContent = 'img{width,height,float}';
// Or all of them
//config.disallowedContent = 'img{*}';

2. insert an image with width/height/align set.

3. inspect the image element - it contains the style attribute.

4. switch to source code view - the style attribute is gone.

Use the following code:

<p>test</p>

<ul>
	<li>test
	<ul>
		<li>test</li>
	</ul>
	</li>
</ul>

Put the cursor at the start of the first list item and hit backspace. The item won't be removed, cursor will be moved at the end of the previous paragraph.

Javascript error in IE9-11:

• Create new table on CKEditor area;
• Enter some table caption using "Table Properties" dialog;
• Press "Ok" button on table properties dialog;
• Set mouse pointer on entered caption's text value;
• Click right mouse button (at the entered caption) and select "Table Properties" from context menu;
• Edit table caption value and click "Ok";

As a result you will receive javascript error: SCRIPT5022: IndexSizeError ckeditor.js, line 407 character 528

On a desktop browser, if you enter a very long string of characters without spaces, they will break onto the next line, however on iOS they do not and instead the editor "overflows" horizontally. Since it is not possible to horizontally scroll it then becomes impossible to see this overflowed content.

This behaviour is easily seen when pasting URLs, for example, which can be quite long.

I have not tested on other mobile browsers.

See attached screenshots for example.

The toolbar based interface gets out of hand quickly as new plug-ins are added. I tend to think all the icons can get very "busy" very quickly and contribute to information overload on the part of end users.

I think that some sort of overhaul of the toolbar based interface will be warranted in the future.

Some possible ideas...

(1) Implement/support icon/button pods, groups of configurable, related hidden buttons in an overlay that are displayed when a displayed toolbar button is clicked. The overlay could have a title that describes the grouping.

(2) Support some sort of configurable drop down menus as a configurable alternative to icons for the toolbar. Again, the purpose is to enable end developers to move some icons off screen while still having them accessible. I get that drop downs are supported for plug-ins, but why can't I just configure CKE to put a group of toolbar icons in a drop-down menu to take up less toolbar space?

(3) Support some sort of tabbed toolbar groupings as a configurable alternative. Thus, the top level groupings could correspond to tabs that provide high-level groupings of icons.

With all of the above approaches, the general idea is to make sure that the most used toolbar icons are readily available, while configuring less frequently used icons as somehow temporarily hidden, yet still having them be accessible.

Granted, I can fiddle around with changing toolbars, but that is kind of a show it ("it" being an icon/button) and access it, or don't show it and don't access it approach. What I am suggesting, is more of a configurable middle approach--don't show an icon/button, but still have it be available via an overlay, drop-down, or tab selection.

Hi.

It could be useful to allow users to copy one selected cell into all the selected cells. In this scenario all the selected cells should contain the same content as the source cell after the paste command.

I have modified the editable.js file to support this feature.

I hope you will find this feature useful.

When i came across documentation for ACF-Custom mode, I clicked a link for live demonstration of ACF-Custom mode. But, result is Not Found (404).

I've pasted the code below so you can see what I'm doing to strip HTML comments from the HTML code. The HTML comments get effectively stripped out but empty script tags (<script src="..."></script>) get stripped out too:

CKEDITOR.on('instanceReady', function(ev) {
  // Filter rules to apply on output
  // Node properties & methods: http://docs.ckeditor.com/#!/api/CKEDITOR.htmlParser.element-property-attributes
  ev.editor.dataProcessor.htmlFilter.addRules({
    comment: function() {
      // Remove HTML comments
      return false;
    },
    elements: {
      script: function(node) {
        // Remove language and script attributes from script tags
        'language' in node.attributes && delete node.attributes.language;
        'type' in node.attributes && delete node.attributes.type;
      }
    }
  });
});

I fixed it just by commenting out the "comment" rule in the htmlFilter. A bit weird :S

Page crashed when typing multi-byte characters( Japanese/Chinese in my test ) after hitting enter key before image. Happened on iOS 8 safari.

Step to reproduce:

1.Make caret right before an image, then hit enter key.

2.Try to input multi-byte characters.

Expected Results:

Multi-byte characters are normally input.

Actual Results:

Page crashed and reloaded with message said: "A problem occurred with this webpage so it was reloaded"

Toggling bulleted list inserts unwanted line breaks when enterMode is configured as CKEDITOR.ENTER_BR

Please see attachment.

Type is required attribute of <style> tag according to ​http://www.w3.org/TR/html401/present/styles.html#style-group

But CKEDITOR generates following

<style>.cke{visibility:hidden;}</style>

There shall be simple fix - add attribute " type='text/css' " to generated <style> tag. We tried to fix downloaded source code by adding one line into document.js:

  var style = new CKEDITOR.dom.element( 'style', this );
  style.setAttribute('type','text/css'); //added by us
  style.append( new CKEDITOR.dom.text( cssStyleText, this ) );

But it seems it does not work in Internet Explorer 11.

It is causing problems with formal validation of HTML code in IBM internal application.

Usking kama skin, if a button is disabled in a dialog via the following:

CKEDITOR.dialog.add('dialog', function () {

return {

... onShow: function () {

this.disableButton('ok');

} ...

}

});

The button disables properly but no related styling for being disabled are applied and it appears identical to an enabled button.

I was able to fix this with a few CSS overrides:

a.cke_dialog_ui_button_ok.cke_disabled:hover, a.cke_dialog_ui_button_ok.cke_disabled:focus, a.cke_dialog_ui_button_ok.cke_disabled:active {

background-position: 0px -1144px;

}

a.cke_dialog_ui_button_cancel.cke_disabled:hover, a.cke_dialog_ui_button_cancel.cke_disabled:focus a.cke_dialog_ui_button_cancel.cke_disabled:active {

background-position: 0px -1105px;

} a.cke_dialog_ui_button.cke_disabled:hover, a.cke_dialog_ui_button.cke_disabled:focus, a.cke_dialog_ui_button.cke_disabled:active {

background-position: 0px -1069px;

}

a.cke_disabled {

opacity: 0.3;

}

I've been unable to recreate this on the demo site -- the only input[file] elements in core plugins are on image and link plugins -- both of which appear on the third tab. This problem appears only when the input is on the first tab.

When using the inline editor with Chrome -- if a plugin has a file input on the first tab, when the dialog is shown, the file input element will gain focus -- this has the effect of making ckeditor lose focus and the toolbar will be hidden.

After closing the dialog, the cursor selection is still somewhere in the editor, but the toolbar is still hidden. One must click off the editor and back on to get the toolbar to show up again.

I tried this in FireFox 35, IE11 and Chrome 40 -- Chrome was the only one to exhibit the problem. Also, it seems like timing issue -- if I have dev tools open with a breakpoint in the plugin's onShow function and resume, the problem goes away.

Edit:

1. Add attached plugin to editor and use attached sample file.
2. Load sample, click on editor and click on button with no icon.

Result: Dialog with file element loads and toolbar disappears. It is not brought back after closing dialog.

checkDirty() function does not work properly with CodeSnippet and Mathematical plugins in Inline mode.

If there is a codesnippet or a formula in the ckeditor element, CheckDirty() always returns "true" after page has been loaded.

Steps to reproduce:

1. Select any editable element on the page and add codeSnippet or a Formula
2. Save the element and reload the page
3. Execute in JS console:

CKEDITOR.instances.editor_instance.checkDirty()

where editor_instance is id of the element. It will return "True" but it should be "False"

This issue emerges only in Inline mode, not in classic mode.

Software versions:

Ckeditor: 4.4.7 (custom build)

OS: Ubuntu 12.04 x86_64

Browsers: Chrome 40 and Firefox 35 (latest versions at this time)

Edit: Please also see comment:8 because this issue also occurs when you just load the editor (checked in CKEditor 4.5.6 at the time of writing).

In the plugin.js for the "Forms" plugin, the code explicitly defines different allowed contents for different form elements:

allowedContent = {
	checkbox: 'input[type,name,checked]',
	radio: 'input[type,name,checked]',
	textfield: 'input[type,name,value,size,maxlength]',
	textarea: 'textarea[cols,rows,name]',
	select: 'select[name,size,multiple]; option[value,selected]',
	button: 'input[type,name,value]',
	form: 'form[action,name,id,enctype,target,method]',
	hiddenfield: 'input[type,name,value]',
	imagebutton: 'input[type,alt,src]{width,height,border,border-width,border-style,margin,float}'
},

but since "checkbox", "radio", "textfield", "button", "hiddenfield" and "imagebutton" all define their allowed content for the same tag (with the name <input>), what we end up with is actually that the combination of all the allowed contents for all these form elements is allowed for all of them.

For example, even though "checkbox" explicitly lists that the allowed content is only "input[type,name,checked]", it is still possible to add for example the "src" attribute by hand to an <input> tag with type="checkbox" (in source code mode) and it will not be removed, even though it was initially not listed as allowed content.

I guess it is not removed because the "imagebutton" defines "src" as a valid attribute for the <input> tag, and thus *all* <input> tags now allow the "src" attribute, even tags with type="checkbox" where the "src" attribute does not make any sense.

Proposed fix: For the allowed content, instead of the string notation, use the object notation with a match function, like this:

allowedContent = {
	checkbox: {
		input: {
			match: function (element)  { return element.attributes.type == "checkbox"; },
			attributes: "type,name,checked"
		}
	},
	radio: {
		input: {
			match: function (element)  { return element.attributes.type == "radio"; },
			attributes: "type,name,checked"
		}
	},
	textfield: {
		input: {
			match: function (element)  { return element.attributes.type == "text" || element.attributes.type == "email" || element.attributes.type == "password" || element.attributes.type == "search" || element.attributes.type == "tel" || element.attributes.type == "url"; },
			attributes: "type,name,value,size,maxlength"
		}
	},
	textarea: 'textarea[cols,rows,name]',
	select: 'select[name,size,multiple]; option[value,selected]',
	button: {
		input: {
			match: function (element)  { return element.attributes.type == "button" || element.attributes.type == "submit" || element.attributes.type == "reset"; }, // TODO
			attributes: "type,name,value"
		}
	},
	form: 'form[action,name,id,enctype,target,method]',
	hiddenfield: {
		input: {
			match: function (element)  { return element.attributes.type == "hidden"; },
			attributes: "type,name,value"
		}
	},
	imagebutton: {
		input: {
			match: function (element)  { return element.attributes.type == "image"; },
			attributes: "type,alt,src",
			styles: "width,height,border,border-width,border-style,margin,float"
		}
	}
}

The proposal above should be equivalent to the original code, only the added "match" functions should make sure that for each type-variant of the <input> tag, only the actually defined allowed content is applied.

Of course you then may want to revise these individual allowed content definitions, for example for the imagebutton, you may want to allow "name" and "value" too?

We have CKEditor set to use em units for font sizes in our CMS. This is so content is portable.

If you select 1em for the font size then I think that should be equivalent of unsetting any existing font size style, and removing any empty wrapper span.

Currently it just gives an explicit 1em font size.

Edit:
While it is possible to select e.g. font-size 72px and then reset it by unselecting 72px option from same dropdown or it is possible to reset style with Remove Format Button, we may be missing something here:

• Remove Format Button removes all inline styles it finds or all inline styles it has defined. Users may want to remove just the font-size.
• Resetting e.g. font-size with dropdown is only possible for matching styles. If user pastes span with font-size in em then default dropdown won't match anything.
• The default option could first of all target only font-size (if used in font-size dropdown) and remove font-size whether it matches anything in dropdown or not (it could be highlighted when tag contains font-size style).

As you know, one of the worst (notorious) problems about WYSIWYG editors is the style mess made when pasting, or when styling using a pure visual approach. You make a number of efforts to mitigate this: the advanced content filter, paste from word, I think other internal filters, and sensible decisions regarding how to merge and remove HTML nodes. This is all good, but it does not solve the problem well enough in my opinion, especially for the case where users are pasting into an unfiltered editor (unfiltered due to necessary support for arbitrary markup).

I suggest you extend the "Remove Format" plugin to have a context menu. When you right-click at any point in the document it has an item on the context menu to remove any of the inline styles defined above that point.

For example, you paste something in and it has got a line-height there (because the browser extracted it from some CSS class when you did the original 'copy' op). The user can right click, see it there, and remove it. This stops them needing to remove it manually from the HTML view, which frankly is scary when a lot of inline styles are defined. It would be good also to be able to choose to remove a style globally (i.e. remove all line-height defined for any node).

Please consider this. I think it would be a really big improvement to CKEditor.

PART 1, wording of dialog intro text

The issue with browser pasting is a thorny one. I think it would help a bit to tweak the dialogue text to be more concise/accurate.

Before: "Because of your browser security settings, the editor is not able to access your clipboard data directly. You are required to paste it again in this window. Please paste inside the following box using the keyboard (Ctrl/Cmd+V) and hit OK"

After (Windows/Linux): "Because of browser security, the editor is not able to access your clipboard data directly. Paste in the box below using the keyboard (Ctrl+V) and hit OK"

After (Mac): "Because of browser security, the editor is not able to access your clipboard data directly. Paste in the box below using the keyboard (Cmd+V) and hit OK"

I've done 3 things here: 1) Removed reference to 'security settings' as only Firefox ever had such a setting, and it is since removed. It really confuses users, who then look for the settings. 2) Shortened the sentences as much as possible for conciseness, made it fit on fewer lines. 3) Tailored for Windows/Mac. We don't want to get techie giving multiple keypresses to try, and confusing Windows users (what's Cmd?) when this is such a core dialog.

PART 2, make function of paste from Word clearer

Can we make the dialog title for Paste from Word as "Paste from Word (automated cleanup)". Just so that it makes it clear why this is a separate button, as it will confuse users.

It would be much better to just have two paste buttons (plain text, regular). Detect if it is coming from Word via some simple heuristic, and then clean up if the CKEditor config says to do so.