Custom Query

We need to identify issues first, so this ticket requires tests.

Identified issues:

• #11131

1. Download the standard package
2. Modify the replacebycode sample to include just a set of plugins:

   CKEDITOR.replace( 'editor1', {
   	plugins: 'enterkey,entities,toolbar,wysiwygarea,image',
   	filebrowserBrowseUrl : '/ckfinder/ckfinder.html'
   } );
   

3. Open the sample, press the Image button. See that the ""Browse Server" button is available, although the filebrowser plugin isn't really enabled.

The reason why is it happening is the way how the plugin interacts with the editor:

CKEDITOR.on( 'dialogDefinition' is executed always when this plugin is merged into ckeditor.js (in release process). However, the init method of a plugin is not executed, because it is not enabled.

One of possible solutions for this issue could be to check by the plugin itself inside CKEDITOR.on( 'dialogDefinition' if I'm really enabled.

TC1

Use the API sample and add the image2 plugin, now insert an image with the textarea to test the API and that image can't be edited because it isn't a widget.

TC2

Go to placeholder sample and execute:

CKEDITOR.instances.editor1.insertText( '[[foo]]' )

Text will be upcasted to widget, but widget won't be initialized on it.

Workaround

After inserting HTML/text call:

editor1.widgets.fire( 'checkWidgets' )

1. Performance: #11001.
2. Repositioning: #11161.
3. Initial position: #11176.

Can be reproduced on demo page.

To Reproduce:

• Insert table with 3 rows and 2 columns (exact number not important, as long as there are enough rows to select multiple by dragging)
• Highlight multiple rows and cells by clicking in one cell and dragging the mouse
• Click the Insert Horizontal Line button

Notice that the browser is now frozen. The browser did NOT freeze up in version 3.6.5

All button names start with a upper-case letter. Image2 and language don't follow that naming convention.

I've upgraded my CK-Editor to 4.3.

Since I can do no more newline. After saving everything is in one line. In the demo here on ckeditor.com that does not work.

Test it: ​http://ckeditor.com/demo#bbcode

Reproduce:

• Write a text with multiple line breaks
• Click on Source code
• You can see, that all text is in one line

The editor is thus completely useless! Please fix it quickly!

THANKS!

Part of: #11437.

Includes: #12090.

Solution description

1. Editor#paste event has to be modified so it inserts content into passed (as a data property) range or current selection. This is required, so it will be possible to drop between blocks (required by block widgets dnd).

2. Widgets has to fire editor#drop and finalize their entire dnd process only by using this event. Currently we just move DOM element when dnding block widget, but we need to change this, so inline and block widgets dnd will work the same way.

Original ticket description

Using Firefox (other browsers untested), open ​http://ckeditor.com/demo#widgets and set in the console a listener for paste:

CKEDITOR.instances.editor2.on('paste', function() { alert("pasted")})

Test that it works with Ctrl+C, Ctrl+V, Ok so far.

Now drag the image widget. The magic line appears and everything works fine.

Then edit the image and disable the "Captioned image" in the dialog.

Now when the image is dragged, the magic line doesn't appear and a paste event is fired upon drop, the HTML seems to include the whole widget.

Using the normal editor everything works fine, no paste is fired for dragging an image around.

Following #11201:

• Image and image2 got to share command, button, dialog and other names.
• The "old image" plugin should detect whether image2 is loaded: if so it will stay disabled.

Obstacles:

• The way the image plugin is disabled.
• The dependency between image plugin and "image button" (forms).
• Testing stuff. I.e. it's already been noticed that if a build contains image, image2 and forms, "image button" works fine even though image plugin is not initialized.
• The less people will have troubles because of that change, the better.

When pasting a bullet list from Microsoft Word then text gets replaced with "<>".

Steps to reproduce:

1. Copy a bullet list from Word using CTRL+C
2. Go to CKEditor and paste the content using CTRL+V
3. You will see that only one item is left and the text has been replaced with "<>".

Browser: IE 11.0.9600 OS: Windows 7 Word: Microsoft Office Professional 2010

Followup for #12006. And part of #11437 (#11219).

After #12006 we store dragged widget in some private property. As a part of #11437 we'll introduce global data transfer object which general dnd will use. Let's populate it and reuse also in block widget dnd, so integration is simple.

Part of: #11437

1. open placeholder plugin
2. select a placeholder
3. apply "bold" style to selected placeholder (or another style change)
4. drag the placeholder to another position

Result: moved placeholder lose applied style

This is happening mainly in Mac but some variation can be observed in Windows.

1. Open replacebycode sample
2. Put cursor at the end of first paragraph July 21 at 02:56 UTC.^ and press enter.
3. Press Command+I or Ctrl+I
4. Press Command+I or Ctrl+I again and type few letters.

Results: On Mac it is impossible to remove simple style. On Windows button is still highlighted, elements path shows 'em' but when you start typing you get normal text.

Problem can be reproduced in Blink and Webkit browsers from CKEditor 4.4.5.

This issue causes #12631.

1. Open replacebycode sample.
2. Press the new page page.
3. Elements path shows only the body tag.
4. Press bold button.
5. Elements path shows body>strong

1. Open any sample.
2. Delete all contents (make sure that paragraph is created - see #12630).
3. Press the bold button multiple times.
4. See the elements path. Multiple strong tags were created.

This issue is caused by #12621 (inability to remove a style).

• ​http://www.winbeta.org/news/microsoft-unveils-developer-channel-internet-explorer-12-ie12
• ​http://devchannel.modern.ie/#welcome-page

NOTE

If you downloaded Windows 10 before April, then in order to test IE12 vel Spartan you need to go to about:flags and click "enable" in the "Enable Experimental Web Platform Features" section. Now IE12 is discovered as Chrome (you can verify this in dev tools - there should be "edge", not "11" in the right top corner of the dev tools panel.

You may also need to disable Compatibility View, because by default in the intranet IE starts in this mode.

NOTE2

As for now, Spartan isn't really usable so it will not be possible to bring a full compatibility with it. Dev tools are often unstable (what makes development a nightmare), ​weird stuff happens and new Windows updates bring rather drastic changes. Therefore, we'll focus now on the biggest changes that we are rather sure that we need to make on our side to have at least some basic level of compatibility. Further changes will be made in separate tickets, most likely after CKEditor 4.5.0.

Should be: getTaskCount, getDoneTaskCount.

MathJax is under Apache licence which we can not use in our project so we should not use MathJax CDN directly. We can make it configurable and let user choose does he want and can use Apache licence.

Merged to major with ​git:4d77c1b.

1. Open ​http://ckeditor.dev/plugins/uploadwidget/dev/upload.html
2. Drag anchor and drop it somewhere else in the editor.

Result: Anchor is uploaded.

After #12806:

1. Open replacebycode sample.
2. Drag anchor.
3. Now you have 2 anchors.

Try dropping image on image in editor and page will relaod

To reproduce the defect:

1. Open ​http://nightly.ckeditor.com/15-03-10-07-08/full/samples/replacebyclass.html.

2. Open any dialog that has multiple tabs ( ex: Table Properties)

3. Navigate dialog using keyboard.

Actual Result

1. when a dialog opens focus going in to first field in tab panel that's opened.

2. User has to press Alt + F10 to access tab list from a tab panel.

3. User has to press Enter key to go in to a tab panel from a tab in tablist.

This fails Accessibility Compliance since tabs & tab panels are not coded as per CI guidelines or ARIA Authoring Practices

Expected Result:

1. When dialog opens focus should go to selected tab & when user press tab key focus should go to tab panel.(User should not have to press enter to move focus from selected tab to tabpanel content. That should always be done with tab key.)

2. User should be able to move focus to tablist with tab key. For tabs in a dialog, tablist must be in the dialog's tab ring. Only selected tab should be in the tab ring. User changes which tab is selected with the arrow key once focus is in the tablist.

Please see ​http://www.w3.org/TR/2013/WD-wai-aria-practices-20130307/#tabpanel on keyboard interaction in a tab panel

Tab - only active tab is in the tab order. User reaches the tabbed panel component by pressing the tab key until the active tab title receives focus.

Left Arrow - with focus on a tab, pressing the left arrow will move focus to the previous tab in the tab list and activate that tab. Pressing the left arrow when the focus is on the first tab in the tab list will move focus and activate the last tab in the list.

Right Arrow - with focus on a tab, pressing the right arrow will move focus to the next tab in the tab list and activate that tab. Pressing the right arrow when the focus is on the last tab in the tab list will move focus to and activate the first tab in the list.

Up arrow - behaves the same as left arrow in order to support vertical tabs

Down arrow - behaves the same as right arrow in order to support vertical tabs

Currently they have their own styling. We need to use ​https://github.com/cksource/samples-framework

Trello board: ​https://trello.com/b/q0sTrRwa/13037-make-basic-sample-and-toolbar-configurators-using-the-new-samples-framework

There were many new strings added to the lang files in such plugins as embed, uploadwidget, filetools, etc. They must be reviewed.

On Webkit and Blink paste filter is set to semantic-content by default.

It means that every external paste will be stripped from classes and styles. And this means that PFW's options like PFWKeepStyles stop working.

We could require adjusting paste filter's options with code like:

editor.on( 'instanceReady', function( evt ) {
    if ( editor.pasteFilter )
        editor.pasteFilter.allow( '*(*)[*]' );
} );

But this basically disables the paste filter which we need on Webkit and Blink for external pasting due to the awful mess that these browsers do in HTML.

So the only solution I can think of now is to disable the paste filter if PFW was executed for that paste.

After changes introduced in #13042 id attributes are removed on drag and drop and copy and paste block widgets. They seems to be generally removed during these operations and they should not, so anchors may work fine.

This is most probably because getHtmlFromRange and extractHtmlFromRange do this.

1. Open ​http://tests.ckeditor.dev:1030/tests/plugins/clipboard/manual/draganddrop
2. Start dragging the image widget.
3. Drop it right below itself.

An error is thrown: Uncaught TypeError: Cannot read property 'getParent' of nullrange.js:1905 CKEDITOR.dom.range.setStartBeforerange.js:923 CKEDITOR.dom.range.moveToBookmarkplugin.js:1405 (anonymous function)

Trello board - ​https://trello.com/b/YfDwLj7q/13172-4-5-docs-updates

It throws a "Object doesn't support this action" error in line with delete window.CKEDITOR;. WAT?! Simple change to CKEDITOR = undefined; should fix this.

1. Open ​http://tests.ckeditor.dev:1030/tests/plugins/clipboard/manual/draganddrop
2. Select some blockquote or header.
3. Drop it into the image caption.

Result: ACF is not applied, headers/blockquote are not stripped.

I checked that it is because of changes introduce in #13042: paste event contains range parameter when it is fired as a result of drag and drop. Without that parameter ACF works fine.

1. ​http://tests.ckeditor.dev:1030/tests/plugins/clipboard/manual/draganddrop
2. Copy something inside the editor using the context balloon.
3. Try to paste it somewhere else.

Result: paste option is not available.

Note that if you copy external content you will be able to paste it inside the editor, what most probably means that editors copy is broken there.

Was fine on 4.4.7.

Source:

<p>
	<a href="http://en.wikipedia.org/wiki/File:Comet_67P_on_19_September_2014_NavCam_mosaic.jpg"><img src="img/comet-67p.jpg" alt="Comet 67P" width="1131" height="900" class="image30 align-right" /></a>
</p>

Settings:

	image2_alignClasses: [ 'align-left', 'align-center', 'align-right' ],
	image2_disableResizer: true,

	stylesSet: [
		{ name: 'Image 30%', type: 'widget', widget: 'image', attributes: { 'class': 'image30' } }
	]

Classes are neither read nor printed to the source.

The embed plugin should be reviewed as well.

It's not clear for user what happens after pressing the OK button in a dialog.

1. ​http://tests.ckeditor.dev:1030/tests/plugins/clipboard/manual/draganddrop
2. DnD inline image in the inline editor (sometimes works also in the classic one).
3. Undo.

Error is thrown:

'null' is null or not an object

inside range.setStartBefore().

Hi everyone,

I have an "issue" I would like to report. While it is not really a bug it is one in terms of cleanliness of code. We have strict policies at our company concerning the usages of "eval()" and similar methods/prototypes.

We would very much like to use your product/library in our products however we cannot do so as in your code there are usages of things like "new Function()". Is there anything on your roadmap to remove such constructs?

1. Open samples/old/inlineall.html
2. Select all contents of one editor.
3. CTRL+C.
4. Focus another editor.
5. CTRL+V.

Expected: Contents pasted, undo enabled.

Actual: Contents pasted, undo disabled.

Then:

• Repeat 5. as many times as you wish. Undo still disabled.
• Type a letter. Undo disabled.
• Type another letter, undo is enabled but snapshots make no sense.

Check this code: ​http://jsfiddle.net/oqzy8dog/3/

It does not work on IE, because the only way to store data transfer ID is to use text data type. Since we do not want to change this text we simple do not use generated ID and the ID is the content on the Text data or an empty string (this is just a backup solution, because if dataTransfer is reset on dragend we can simple use the same dataTransfer object until it is reset, without comparing ID):

this.id = this.getData( clipboardIdDataType );

// If there is no ID we need to create it. Different browsers needs different ID.
if ( !this.id )
	if ( clipboardIdDataType == 'Text' ) // IE
		this.id = '';

In this case this.id is an empty string, because it was not set when the dataTransfer constructor was called. Then we set the text and when we set up the dataTransfer object for the second time (on drop) the id became this data.

So then we compare IDs in initDragDataTransfer:

if ( this.dragData && dataTransfer.id == this.dragData.id )

they do not match and new object is created, so custom data we set on dragstart will not be available on drop.

There are two solutions.

Solution A: do not use ID

We could consider not using ID at all on IE so the change would be:

if( clipboardIdDataType != 'Text' ) {
	this.id = this.getData( clipboardIdDataType );	
}

but then all external drops will have the same DataTransfer object if user forget to reset it manually on dragend.

Solution B: update ID

Alternatively we could update ID every time user set the text data. This seems to be a little weird, but can work a little better.

Reproducible on ​http://tests.ckeditor.dev:1030/tests/plugins/clipboard/manual/draganddrop when dropping from outside of the editors. First DnD works, but second no - content is inserted in the wrong place (previous selection position).

When using Spartan in Windows build 10116 the Source is not working... It issues a page refresh.

When I paste the content from Word to Firefox I loose the formatting.

Everything is fine when I use paste from Word button. Also on version 4.4.8 it works fine. It also works on Chrome.

It is most probably because of using new Clipboard API on Firefox, and trusting Firefox that the content is correct.

Steps to reproduce

1. Set pasteFromWordRemoveFontStyles to false.
2. Paste content from Word with font size, color etc.
3. Set pasteFromWordRemoveFontStyles to true.

Expected result

Styles are removed when the setting is true.

Actual result

Styles are removed when the setting is false.

Other details (browser, OS, CKEditor version, installed plugins)

In all browser except Firefox there's a poor selection handling for tables inside of contenteditable element. To enhance user experience when it comes to working with tables we need to provide a custom selection handling.

Selection highlighting

We need to provide a nice highlighting for selected table parts across all the browsers. That would be accomplished by changing background of every currently selected cell, so that user has clear understanding what cells are selected.

Of course the selection has to be customizable with CSS.

More flexible selection

We want to allow for more flexible table selection. Currently (except Firefox) it's only possible to make a continuous selection, containing all subsequent cells.

We'd like to improve it in a way that the user is able to make rectangular selection in a table. This also means that it would be possible to select just a single column or row of a table.

We also need to provide integration with existing features for this kind of a selection.

For now the copyformatting plugin has one language configured: English.

Translations are available in transifex though, so the plugin needs to be updated accordingly.

Steps to reproduce

1. Visit ​http://nightly.ckeditor.com/17-01-19-07-07/standard/samples/
2. Open browser dev tools.
3. Switch Ckeditor instance on the page to Source mode.
4. Click anywhere on the page outside of the editor instance.

Expected result

No js errors throw.

Actual result

Uncaught TypeError: Cannot read property '$' of undefined

at window.CKEDITOR.window.CKEDITOR.dom.CKEDITOR.focusManager.f (ckeditor.js:224) at window.CKEDITOR.window.CKEDITOR.dom.CKEDITOR.focusManager.<anonymous> (ckeditor.js:225) at ckeditor.js:26

Other details (browser, OS, CKEditor version, installed plugins)

MacOS Sierra, Chrome 55.0.2883.95. This is throwing in CKeditor 4.6.2, in addition to Nightly build.

Please also see comment:5 and comment:7 for other test cases.

Steps to reproduce

1. Open ​http://sdk.ckeditor.com/samples/standardpreset.html
2. Select and copy image.
3. Click "Paste from Word" and follow instructions

Expected result

Image is pasted

Actual result

Error is thrown: Uncaught TypeError: Cannot read property 'style' of undefined

Steps to reproduce

1. Open attached file in MS Word.
2. Select all, copy to clipboard.
3. Open a CKEditor sample that includes flash plugin (so that the issue is more visible).
4. Paste into the editor using CTRL/CMD + V.

Expected result

No object elements are created.

Actual result

An object elements is created.

Other details (browser, OS, CKEditor version, installed plugins)

Firefox, Chrome.

It's due to object element in datatransfer.

Steps to reproduce

1. Create a 5x5 table (editor should become scrollable).
2. In the first cell make 2x2 nested table with width set to 15.
3. Fill every cell with letter "s".
4. Start selection from nested table, then move it out of the table and drag it to scroll down the editor.

Expected result

Selection should stay in a nested table without returning any errors in console.

Actual result

There is an error in a console. ​https://gist.github.com/Mgsy/b5c95910313a7cb70e87beae921ac74f

Other details (browser, OS, CKEditor version, installed plugins)

Windows 10, tested on Chrome, Edge, IE11, Firefox.

This issue is reproducible on our Document Editor demo. I wasn't able to repro it on a regular sample.

Maybe the fact that the editor is placed into a DOM dynamically has something to do?

1. Go to ​Document Editor demo.
2. Make a partial selectiom on the table, say 2x3 cell
3. Copy to clipboard.
4. Move selection into another paragraph.
5. Paste.
6. Try to make table seleciton on a pasted table.

Expected

Our custom selection is being made.

Actual

Exception is thrown:

ckeditor.js?oqkjc5:66 Uncaught TypeError: Cannot read property 'ownerDocument' of undefined
    at window.CKEDITOR.window.CKEDITOR.dom.CKEDITOR.dom.element.getDocument (ckeditor.js?oqkjc5:66)
    at window.CKEDITOR.window.CKEDITOR.dom.CKEDITOR.dom.element.getDocumentPosition (ckeditor.js?oqkjc5:108)
    at b (ckeditor.js?oqkjc5:1220)
    at window.CKEDITOR.window.CKEDITOR.dom.CKEDITOR.dom.document.<anonymous> (ckeditor.js?oqkjc5:1227)
    at window.CKEDITOR.window.CKEDITOR.dom.CKEDITOR.dom.document.c (ckeditor.js?oqkjc5:11)
    at window.CKEDITOR.window.CKEDITOR.dom.CKEDITOR.dom.document.window.CKEDITOR.window.CKEDITOR.dom.CKEDITOR.event.CKEDITOR.event.fire (ckeditor.js?oqkjc5:13)
    at HTMLDocument.<anonymous> (ckeditor.js?oqkjc5:58)

Additional Information

I was able to reproduce it on Chrome, and Edge. Most likely it's reproducible on other browsers too.

Calling setReadOnly(true) in IE 8 and 9 then clicking in the entry area of the editor causes the Javascript Error listed below.

I have tried it on the latest version of Chrome, Firefox and Safari and none exhibit the problem. I have NOT tried it in other versions of IE.

Message: Unable to get value of the property 'ownerDocument': object is null or undefined Line: 303 Char: 472 Code: 0 URI: ​http://wolf/Pathway/ckeditor/ckeditor.js?0111891205

Message: Unable to get value of the property 'ownerDocument': object is null or undefined Line: 303 Char: 472 Code: 0 URI: ​http://wolf/Pathway/ckeditor/ckeditor.js?0111891205

Simplified TC:

1. Set editor to readOnly:true
2. Load editor with empty content area
3. Click inside editor

JS error:
Message: SCRIPT5007: Unable to get value of the property 'ownerDocument': object is null or undefined.
Line: 370
URI: /ckeditor/core/selection.js

Problem can be reproduced from CKEditor 3.6.3 rev. [7374] in IE8-10.

Unable to resize header/footer table columns.

1. Open editor with following content

   Hello <a href="http://en.wikipedia.org/wiki/Neil_Armstrong">Neil Arm</a> .
   

2. Select link Neil Arm.
3. Change selection background color.
4. Double click Arm word to open link dialog.

Actual result: Dialog won't open.

Please note: Double click on word Neil open dialog properly.

When the cursor is positioned before or after the text, the unlink button is active but if you click it nothing happens.

Once I added a link, I can't unlink it. "Unlink" button is not working.

Found in Google Chrome.

1. Open ​http://ckeditor.com/demo#full
2. Start with two div elements with selection that contains a part of first and the second div:

<div  class="para">
     Some [content
</div>
<div class="note">
     This is] a note
</div>

3. Press Div button and attempt to insert a div.

Result:

Uncaught TypeError: Cannot read property 'equals' of null
createDiv @ div.js:147

Steps to reproduce

1. Created a table with 4 columns and 3 rows
2. make a vertical split in the cell 2,2
3. Do a column insert before in 4th column

Expected result

a new column is inserted between 3rd and 4th column

Actual result

A column will be created between 2nd and 3rd column

Other details

please visit this link for better understanding ​https://github.com/ckeditor/ckeditor-sdk/issues/164

Steps to reproduce

1. Update find_highlight config option to

config.find_highlight = { element : 'span', styles : { 'background-color' : '#004', 'color' : '#fff', 'border' : '1px solid #004' } };

2. Open any CKEditor sample and type some text, e.g. test.
3. Open Find & Replace dialog.
4. Click 'Find' button to search for a word, e.g. test.
5. Click 'Cancel' button.
6. Switch to 'Source' view.

Actual result

A SPAN <span style="border-image: none;"> gets added around the 'test' word.

Other details (browser, OS, CKEditor version, installed plugins)

IE11 and MS Edge

Steps to reproduce

1. Open nightly build ​http://nightly.ckeditor.com/16-09-12-06-07/full/samples/

2. Clear all content

3. Select Font Name ( Georgia) Font Size (24) & type some content.

4. Select a new Font Name (ex: Tahoma)& type content

Expected result: Newly typed text should have Font Name (Tahoma) & Font Size 24

Actual result: Newly typed text has Font Name (Tahoma) but Font Size going back to default

Steps to reproduce

1. Open nightly sample (​http://nightly.ckeditor.com/16-11-30-07-06/standard/samples/)
2. Use Printsceen or Paint to paste image (Ctrl + V) into the editor

Expected result

base64 image pastes into the editor

Actual result

Other details (browser, OS, CKEditor version, installed plugins)

Firefox 50.0.x only

Use attached .docx file.

1. Open CKEditor samples/index.html.
2. Open the attached docx file (I did it with Word 365).
3. Select all the content in Word and copy it to the clipboard.
4. Go back to CKEditor, focus it and paste.

Expected result

List items are not lost.

Actual result

List items are stripped.

Other details (browser, OS, CKEditor version, installed plugins)

Word 365

Steps to reproduce

1. Start CKEditor with the following config

   		CKEDITOR.replace( 'editor1', {
   			forceSimpleAmpersand: true
   		} );
   

2. Type & in wysiwyg mode
3. Switch to source mode

Expected result

&

Actual result

&

Other details (browser, OS, CKEditor version, installed plugins)

Reproduced on Chrome. Reproducible since 4.3.2 at least, did not try earlier versions.

Azerbaijani is 100% complete at Transifex, but so far it hasn't been added to CKEditor configuration.

Expected result

Azerbaijani should be added to CKEditor configuration to make it available to users.

​https://www.transifex.com/ckeditor/ckeditor/language/az/

Steps to reproduce

1. Open ​http://sdk.ckeditor.com/samples/draganddrop.html with Edge
2. Try to move contacts from the list on the right to editor

Expected result

When elements are being dragged over editor, cursor should not have red markings that disallow drop. And when dropped - the dragged element should be inserted to editor text.

Actual result

On Edge when dragging elements, cursor has red marker saying it cannot drop the element within editor. Dropping element anyway does nothing - the dragged element is not inserted to editor text.

Other details (browser, OS, CKEditor version, installed plugins)

Edge browser on Windows 10 64bit from official MS images (here for VirtualBox). VirtualBox run on Linux. No plugins installed, system is completely clean and run for the first time.

Steps to reproduce

1. Open nightly build ​http://nightly.ckeditor.com/17-01-18-07-08/full/samples/

2. Insert a Table. Keep cursor inside the table & press CTRL + SHIFT + F10 or Application key to open Context menu

Expected result

Context Menu opens & focus is on first menu item ( pls see Aria Authoring practices for menu here :[ ​https://www.w3.org/TR/wai-aria-practices/#menu])

Actual result : Context Menu opens but focus is not on menu item & user has to press Down arrow key to get focus on the menu. This is violation of Accessibility Checkpoint 4.1.2 Name, Role, Value)

Steps to reproduce

1. Open attached Table_alignment.docx document in Word.
2. Copy it's content.
3. Paste into a full featured editor.

Expected result

Tables are aligned as in the docx document.

Actual result

Alignments are stripped.

More details

It looks in Word pretty much like this:

The problem is that Word generates following markup:

<div align=right>

<table class=MsoTableGrid border=1 cellspacing=0 cellpadding=0 style='(...)'>
 <tr style='(...)'>
 	(...)
 </tr>
</table>

</div>

Which displays it correctly, but uses deprecated align attribute.

We have a ​style transformation in core which transforms any align into float CSS prop, which is fine for elements like table, img, iframe, but it's wrong for div and p. Becasue for div and p it defines the alignment of content elements within this element.

It's also worth to remember that align is a little more aggresive than text-align CSS prop, as it affects anything, whereas for text-align you need to apply margin: x auto for block-alike elements, otherwise they won't be aligned.

When encountering an element that has multiple styles the PFW plugin creates a stack of span elements each having one of these styles.

This way this:

<span style="font-size: 50px; color: red; font-weight: bold">Test</span>

Becomes this:

<span style="font-size: 50px">
  <span style="color: red">
    <span style="font-weight: bold">Test</span>
  </span>
</span>

Some styles should not be stacked though - one of them is the height style.

Problem is - this happens.

Steps to reproduce

1. Open "Document Editor" sample on ckeditor.com.
2. Copy something, e.g. a part of a header.
3. Press Ctrl + Shift + V to paste clipboard as plain text.

Expected result

Text is pasted.

Actual result

Text is not pasted.

Other details (browser, OS, CKEditor version, installed plugins)

We'd like implement this in a way that CTRL+SHIFT+V will paste formatting only if it has been activated with CTRL+SHIFT+C - so that the Copy Formatting icon is active, and the toolbar button shows "pressed" state.

If copy formatting is not active, then this hotkey will paste as plain text.

This will improve interoperability with apps like MS Word, which use exact same hotkey, while keeping the original paste as plain text hotkey for people that doesn't use copy formatting.

Issue caused by copy formatting using keyboard shortcut which is usually used to paste plain text browsers.

Currently pasting rich text into dialog could strip all additional information (e.g. styling) and pass only plain text into the editor. It's especially visible when pasting from Word:

1. Open attached Word document.
2. Select part of the sentence (e.g. first two words).
3. Click "Paste" button to open paste dialog.
4. Paste into dialog.

The text pasted into dialog is converted into plain text and in this form is then pasted into the editor.

There should be a way to get the original, raw pasted data from dialog, preferably from native dataTransfer. However, due to limitations of clipboard API, it can be fetched only synchronously. Probably the best way to get it from editor's dialog is to create new event, which will be fired after pasting into dialog.

The way to obtain raw data should be universal, as in the future editor may need to get some other data type, not only text/html. In this case creating a snapshot of native dataTransfer and passing it to the event should be a sufficient solution.

This is a mirror of a ticket in Drupal: ​https://www.drupal.org/node/2785483

The problem here is that features added through addCommand assume that the content they allow will remain that way, but it's possible to override that using the config.

Steps to reproduce

1. Open nightly build
2. Navigate to Font Name, Font Size, Text or Background Colour dropdowns
3. Press Enter to open the list box
4. Press Esc

Expected Result: Corresponding list box closes and focus goes back to button menu in tootlbar

Actual Result: When we press ESC key first time, JAWS going to Virtual PC Cursor, User has to press ESC 2nd time to close it. This should be fixed.

We have ​an ugly loop in each PFW test suite.

We need to extract this into a reusable code (simply a hleper will do), so that tests are more clean.

Steps to reproduce

1. Open ​http://nightly.ckeditor.com/17-04-11-06-09/standard/samples/
2. Press "Paste" button.
3. Check if screen reader is announcing notification correctly.

Expected result

Screen reader reads the notification.

Actual result

• Firefox + VoiceOver: screen reader announces "Firefox has new window", but reads notification only after clicking it.
• Firefox + JAWS: screen reader becomes muted when notification appears.
• Chrome + VoiceOver: notification is read, however ⌘+V is read as plus v.

Currently if td's background background property contains something more than just a color, it won't be recognized. We could improve it.

1. Open CKEditor with tabletools plugin.
2. Set the editor content using "Source" button to the following:

   <table border="1" cellpadding="1" cellspacing="1" style="width:500px">
   	<tbody>
   		<tr>
   			<td style="background:#00cc99 no-repeat center">&nbsp;</td>
   			<td>&nbsp;</td>
   		</tr>
   	</tbody>
   </table>
   

3. Go back to wysiwyg mode.

Expected

First cell has a backgournd applied.

Actual

Color is stripped out by ACF.

Additional Notes

Recently we have added a more advanced function for parsing CSS background - CKEDITOR.tools.style.parse.background. We could use it to more reliably tell if property contains a color.

Rationale: It was needed during ​PR#337, where Firefox would put much more values into CSS prop ta

Steps to reproduce

1. Open ​http://nightly.ckeditor.com/17-04-19-06-08/full/samples/old/enterkey/enterkey.html
2. Sent enter mode to BR
3. Paste contents from attached document
4. Switch to Source Mode

Expected result

<b><i>Paste from word</i></b><br />

Actual result

<p><b><i>Paste from word</i></b></p>

Other details (browser, OS, CKEditor version, installed plugins)

Now that we improved handling for paste as plain text, it would make sense to add a proper information in Accessibility Instructions dialog (alt+0).

So we want to put hotkey for paste as plain text:

• ctrl+shift+v on Windows
  • For Edge it's ctrl+shift+v followed by ctrl+v
• cmd+alt+shift+v on Safari, Mac

Steps to reproduce

1. Open inlineall.html or sharedspace.html sample
2. Click in one of editors
3. Start pressing tab

Expected result

No errors get thrown.

Actual result

Cannot read property 'contains' of null is thrown once you leave last inline editor in sharedspace or after focusing third editor in inline all.

Message: Cannot read property 'contains' of null
URL: ckeditor-dev/plugins/indent/plugin.js
Line: 366

Other details (browser, OS, CKEditor version, installed plugins)

Problem can be reproduced from CKEditor 4.6.2 only in Chrome.

Steps to reproduce

1. Put attached sample into ckeditor/samples folder and open it
2. Apply same styles and selections as in attached video:
   • This is some [sample text.] - apply yellow marker
   • This is [some sample text.] - apply underline
   • [This is some sample text.] - press Print Extract Contents button

Expected result

This is <u>some <span class="marker"><strong>sample text</strong>.</span></u>

Actual result

This is <u><span class="marker">.<strong>sample text</strong></span>some </u>

The text content in Document Fragment is "This is .sample textsome "

Other details (browser, OS, CKEditor version, installed plugins)

Problem can only be reproduced in all browsers starting from CKEditor 4.5.0.

The undo system present on browsers through execCommand is quite limited, as it doesn't take care of DOM modification (done by many features in the editor).

For IE, we have implemented a custom undo system which takes snapshots of the document area innerHTML.

The porting to Firefox is just a matter of testing and doing the necessary adjustments.

In the past, we have used a different loading system that separated the code in three files. We have understood that it doesn't gave us so much in the loading performance, and the method has been changed. Now we have just one file with all the code.

To better organize the code, we must now merge the fck_1.js and fck_2.js files (and their respective browser specific implementations) to the fck.js file.

A new license must be created to fix some issues with the current LGPL/CDL system:

• LGPL is incompatible with some Open Source licenses. Probably a triple OS license support would fix this issue (GPL/LGPL/MPL).

• Incorporate all licenses in a single license term, including the CDL.

• We must continue under a copyleft license, leaving the CDL as the unique non-copyleft license.

• Limit the CDL validity to avoid it being used on systems that could offer a way to bypass us, like Component Bundles or development runtime platforms.

• There are people out there abusing of our code (including commercial software). Find a way to enforce our rights, leaving abuses in a dangerous situation.

I'm trying to test if we can have a set of meta bugs (one for each browser) that can tell us the state of support for each browser.

I don't see the ability to have a Ticket depend on another one, maybe we can use then Keywords on each Ticket to know bugs affecting each browser?

Other ideas about how to track each browser and know for example what's missing in Opera or Safari to say that it's officially supported?

Depends on: #1, #2
Blocks: #3

Based on ​https://sourceforge.net/tracker/index.php?func=detail&aid=1456343&group_id=75348&atid=543655 (the file provided doesn't work with the current version, and instead of a testcase I think that a sample describes much better its use)

I've cleaned up, removed bad code and so this sample provides a simple example about how to properly use the API instead of having in a tracker a bad example of directly accessing the iframe contents.

It might also be the a partial answer to some questions about how to load initially the editor in source mode (but that could be another file using just the proper events)

Switch to Source throws error in the Error Console.

Loading the editor in Opera gives an error (well, lots of errors, this is just one that focused my attention) pointing to the fck_showtableborders_gecko.css it seems that it doesn't handle the CSS3 "not" selector

table:not([border]) 
{
	border:1px dotted #d3d3d3 ;
}

I'm attaching a testcase, maybe we can have a little set of files in order to test browser capabilities (just to be run when a new browser is released so it's possible to see what might work or not).

As I looked at the problem with Opera and the panels I fixed some HTML errors in the test page as well as a broken FCKDebug.OutputObject and two other minor changes. I've committed those changes to SVN as they were quite easy and couldn't break anything.

I've committed two fixes to the SVN to avoid an error in Firefox 3 and some warnings based on the public bugs and patches available. (I hope that everything is alright)

​https://sourceforge.net/tracker/index.php?func=detail&aid=1604576&group_id=75348&atid=543655
​https://sourceforge.net/tracker/index.php?func=detail&aid=1577247&group_id=75348&atid=543653

and the new sample file
​https://sourceforge.net/tracker/index.php?func=detail&aid=1456343&group_id=75348&atid=543655

The question is: when should the public bugs be marked as fixed? now in order to avoid that we forget about them or latter when the public SVN is updated?

There are also two other bugs that it seems that should be fixed in SVN but they aren't closed:
buttons in modal dialog IE (SVN)
​https://sourceforge.net/tracker/index.php?func=detail&aid=1199014&group_id=75348&atid=543653
​https://sourceforge.net/tracker/index.php?func=detail&aid=1208960&group_id=75348&atid=543653

is this fixed also?
​https://sourceforge.net/tracker/index.php?func=detail&aid=1490615&group_id=75348&atid=543653

Steps to reproduce: Go to the end of the sample text (sample 12, default values), press enter to start a new paragraph an create a list (OL or UL), now put the first item and press enter, the second item appears two lines below, looking at the source in that moment shows this:

<body spellcheck="false">
	<p>
	This is some <b>sample text</b>. You are using <a _fcksavedurl="http://www.fckeditor.net/" href="http://www.fckeditor.net/">FCKeditor</a>.
	</p>
	<ol _moz_dirty="">
		<li _moz_dirty="">
			a
			<br _moz_editor_bogus_node="TRUE" _moz_dirty=""/>
			<br _moz_dirty="" type="_moz"/>
		</li>
		<li _moz_dirty="">
			b
			<br _moz_editor_bogus_node="TRUE"/>
		</li>
		<li _moz_dirty="">
			c
			<br _moz_editor_bogus_node="TRUE"/>
		</li>
	</ol>
</body>

Blocks: #1

Testing the enter key in IE:

• Go to end of text, press enter a new paragraph starts;
• Type some letters or words and press shift+enter, a new line starts;
• Type a little more and press enter to start a new paragraph, now the current paragraph simply disappears.

Blocks #1

The keyboard is quite broken in Opera right now. Enter creates a new paragraph but leaves the cursor at its current position Ctrl+C and Ctrl+V doesn't work at all.

Blocks: #1

Press the Select All button, the content gets selected, but now any keypress goes to somewhere else (main document?) instead of clearing the contents.

I plan to incorporate the patch as described here (upgrading everything to latest version, and reviewing that everything is fine) ​https://sourceforge.net/tracker/index.php?func=detail&aid=1496115&group_id=75348&atid=543655

this fixes several bugs and feature requests about this problem. First I'll do the changes locally and then upload a patch here so it can be reviewed before it's applied to SVN.

This is just a note to check if the fix proposed in the following report comments is valid, and therefore apply it to the code:

​https://sourceforge.net/tracker/?func=detail&atid=543653&aid=1515377&group_id=75348

If the content has a br then this line (177, fckhtml.js) gives an error in IE 6

if ( sNodeName == 'br' && htmlNode.hasAttribute('type') && htmlNode.getAttribute( 'type', 2 ) == '_moz' )

The distribution package structure must be reviewed to check if it is under the common standards used in the Java world:

• Check the directories structure and file names
• Confirm that basic files is available (the license was missing, for example)
• Every distributed file must contain the standard headers of the project, including the copyright notices, and license references.

Well... anything else that may come in our minds.

I would like to make the File Browser Connector and Quick Uploader configurable with a Java interface. The current implementation is hardcoded to use the server file system. This is something which severly limits the use of the Java libary in more mature products or frameworks, because it's likley that these do have their own way of managing the server side resources - not necessarily on the server file system.

When I signed in in assembla I didn't know that the login Id was going to be repeated over an over again in any change that I do, and I find distracting to have the email repeated, so I've tried to find out if it's possible to change that behavior but it seems that the current system doesn't allow that.

So: I plan to try to delete this account and then sign again as alfonsoml

Opinions against?

I plan to study this set of patches: ​https://sourceforge.net/tracker/index.php?func=detail&aid=1605345&group_id=75348&atid=543655
​https://sourceforge.net/tracker/index.php?func=detail&aid=1504513&group_id=75348&atid=543655
​https://sourceforge.net/tracker/index.php?func=detail&aid=1026583&group_id=75348&atid=543655
​https://sourceforge.net/tracker/index.php?func=detail&aid=1026582&group_id=75348&atid=543655

so it's possible and documented how to define a custom toolbar without using a customconfig.js file but instead just specifying its contents at the moment the editor is created. This should allow also other kind of customizations in the future.

I'll work in a new branch were I'll apply other patches, I'll try to open tickets for each one .

This might be a fix to this bug: ​https://sourceforge.net/tracker/index.php?func=detail&aid=1613963&group_id=75348&atid=543653

the current code generated for popup links doesn't work if the final user has javascript disabled. This patch fixes this problem: ​https://sourceforge.net/tracker/index.php?func=detail&aid=1577202&group_id=75348&atid=543655

this can be easily done using the current events, but what's missing in that case is that the dropdowns combos doesn't have the same style applied. This patch takes care of it: ​https://sourceforge.net/tracker/index.php?func=detail&aid=1500040&group_id=75348&atid=543655

Check the changes proposed in ​https://sourceforge.net/tracker/index.php?func=detail&aid=1443472&group_id=75348&atid=543655
and ​http://wiki.fckeditor.net/ImprovingPasteFromWord
then try to define a clean up code that we can agree on and also provide an easy way for the developer to add their own clean up code if he doesn't like the function.

In a way similar to this patch: ​https://sourceforge.net/tracker/index.php?func=detail&aid=1434698&group_id=75348&atid=543655
it will unify some redundant code and avoid bugs like this one: ​https://sourceforge.net/tracker/index.php?func=detail&aid=1573191&group_id=75348&atid=543653