Custom Query

To reproduce:

1. Open replacebyclass.html in IE.
2. Open the find dialog.
3. Click on the "Match case" label.
4. The checkbox isn't checked.

Current implementation of documentFragment has been ported from V2 for IE 5.5 support, which have dropped for V3. We could now replace those IE hacks with standard support of native documentFragment.

Reference

​Sitepoint

The Format combo is to be developed for V3.

Procedures

1. Open the replace by code example page in IE6;
2. Clean up the document by the following ways:
   • Switch to source mode, delete all contents;
   • Switch back to wysiwyg mode.
3. Click on Table to open dialog and insert a default table, check the document now.

• Actual Result : Empty newline existed above the inserted table.

Reproducing procedure:

1. Open Replace by code sample in Webkit.
2. Click the Template button to open dialog.

• Actual result: Content TABLE doesn't fit to parent DIV width.

To reproduce the bug:

1. Open replacebyclass.html of trunk in Firefox 3.
2. Enable show blocks.
3. Switch to source mode and back.
4. Now show blocks is disabled.

Reproducing procedure:

1. Open Replace by code sample in IE;
2. Check flash button to open dialog;
3. Fill in url as below, then swith to Advanced page and field in Id field with 'id1';

   http://f.friendster-tweakers.com/rsc/swf/clock/fsdbp.swf
   

4. Check the document now:

• Actual Result: id attribute not applied.

  <p><object classid="clsid:d27cdb6e-ae6d-11cf-96b8-444553540000" codebase="http://download.macromedia.com/pub/shockwave/cabs/flash/swflash.cab#version=6,0,40,0"><param name="quality" value="high"></param><param name="movie" value="http://f.friendster-tweakers.com/rsc/swf/clock/fsdbp.swf"></param><embed pluginspage="http://www.macromedia.com/go/getflashplayer" quality="high" src="http://f.friendster-tweakers.com/rsc/swf/clock/fsdbp.swf" type="application/x-shockwave-flash"></embed></object></p>
  

The toolbar is quite chaotic right now. It should be reorganized to resemble the V2 buttons order.

It has not support for '/' also.

'this' in the dialog element onLoad function was fixed and now we need to improve image dialog.

Now 'dialog=this.getDialog()' instead of only 'dialog=this'.

Fuctional Testcase

test-editor-insertHtml.patch

When resizing the browser window, the toolbars wrap incorrectly in IE.

The timestamp querystring is not being appended to the editor.css file request when opening toolbar combos.

This can be easily verified by opening the [nightly build demo ​http://nightly.ckeditor.com/latest/ckeditor/_samples/replacebyclass.html], looking at the "Net" tab of Firebug.

Currently, we are introducing specific output manipulation directly into the domParser code. This makes that code quite hard to maintain, and less flexible, as it is not able to customize the manipulation with easy.

There should be instead a way to attach a "filter" to the parser, including all necessary rules for it.

In this the data processor can have a public filter property, which can be easily modified by a plugin or external code.

The generated link url is not right when setting protocol with <other>.

Functional Testcase

Tested with test-link-protocol-other.patch.

Functional Testcase

Tested with test-form-all.patch.

There are still lots of features in the V2 Style System that are missing in V3, like the usage of variables in the definition and proper support for attributes and styles checks.

I'll be attaching a path with several enhancements and some code organization.

Implement the Font and Size combos.

Specifically, attributes name,style and check box based options didn't get committed.

Functional Testcase

Provide a test case for checkbox, others field types could also be reproduced in same way.

Implement the Styles combo in V3.

Currently it's unable to update dialog from existed element attributes.

To reproduce:

1. Delete the <!DOCTYPE> line in sample.html.
2. Open replacebyclass.html in IE6.
3. The toolbar is messed up.

Implement the "Text Color" and "Background Color" buttons in the toolbar.

CKEDITOR.config.startupFocus set to 'true' doesn't work for both modes.

Image button and hidden field labels read "undefined" in JAWS right now. Proper labels should be added for the two buttons.

Now UI-level functional is a little bit hard since we have no tool to locate elements. YUI CSS3 Selectors, which could help to locate those elements like buttons. So we'll merge into testselector.jsfile for this functionality.

The bgColor and textColor button should have no states after applying the styles. Currently we can still found sometimes these two buttons toggled on after panel is closed.

Certain toolbar items are not correctly with title and tabIndex.

Both list commands appending extra <br> at end of the target block elements.

CKEditor is extremely unfriendly towards screen readers at the moment:

1. To navigate into the editing area, the user would have to tab through all or almost all toolbar buttons in Firefox and IE.
2. Pressing e to focus on the editing area like a textbox often does not work in IE, and never works in Firefox.
3. There's no announcement to the user that he's put his focus into an editable area.

Tested on Safari 4 Windows and Webkit nightly build Mac. Issue occurs when pasting text or typing text.

To reproduce:

1. Open FCKEditor Demo page ​http://www.fckeditor.net/demo/toolbar?toolbar=Basic

2. Type or paste text into editor. Text will be 1 line too short to fill proper box size.

3. Resize Safari window. Editor area will suddenly expand to fill entire box.

Note 1: If it does not happen, try shift-reload first. It only happens on the first non-cached load of the page.

Note 2: Some editor layouts have no issues, some editor layouts have significant sizing issues, some over with the editor area 1 inch screen height too small.

See attached file for an extreme case.

Using IE8 in the current CKEditor nightly:

doubleclick in the bolded "sample" word, now click the bold command to unbold that word: the whole "sample text" is selected and becomes unbolded.

Put the cursor in the middle of "sample text" in IE8 in the current nightly of CKEditor, in the status bar click in the "strong" tag to select the whole tag.

It gives an error in the selection plugin, line 585, Invalid argument.

Implement the context menu.

1. Open a sample in IE
2. Click outside the editor, just to be sure it has no focus.
3. Click the "Smileys" dialog, for example.
4. Select any of the smileys.

An error is thrown. It happens with all dialog.

Now it is impossible to disable PanelButton in toolbar. It should be possible to disable it in source mode.

Due to previous fixes, LockRatio and Reset Button has wrong position in FF and Webkit.

In The panel system (contextMenu and floatPanel)should auto hide on any click which doesn't fall into the panel region, now it's not working appropriately. It could be identified by the context menu

Procedures

1. Open the replace by code example page;
2. Left click on the document to open Context Menu;
3. Click on the bold command;
   

• Expected Result : The menu will hide before the command execution.

4. Right click on the document region outside the menu;

• Actual Result : The menu has always been there.

The Edit Form function doesn't works, which make certain related feature like Form Properties on Context Menu failed too.

Introduce the HTML entities support in V3.

In the early beginning we were able to access the plugin path only by a parameter sent to the init function. Now, this parameter is not sent anymore, but the arguments are still there. Some cleanup is need to remove it from the code (it may cause confusion).

It's now impossible to use Tab navigating through all the toolbar items caused by a stop at the the first combo button.

After introducing the HTML Parser Filter system, method like protectHtml should be removed, which in this case cause JavaScript error.

CKEDITOR.tools.createClass logic's not right in the following sense:

• Generally class creation need to fix contructor property, which is wrong after prototype copying;
• Private fields should be available in constructor;

Implement the ENTER key customization in V3.

The spellchecker dialog shows a small piece of broken HTML at the text panel. It shouldn't display HTML, and shouldn't even display broken one. See attached screenshot.

How to reproduce:

1. Go to ​http://www.fckeditor.net/demo
2. Click on the FCKeditor text area to place the cursor at the end of the default demo text.
3. Press Enter, and type "ñ". This is the same as &ntilde;, which is a common character in Spanish language (although I don't speak Spanish).

Notice: I've typed this char by typing ~ followed by n. In my keyboard layout (which is us_intl, or US International), ~ key is a deadkey.

4. Click on spellchecker button.

Tested with Firefox 2.0.0.19 on Linux.

Menu( Context Menu currently) should has some same navigation mechanism with drop-down control like RichCombo.

Current CKEDITOR.tools.clone function doesn't work for Array cloning.

When mouse wheel on combo dropdown, the whole document is also scrolling.

It's unable to switch off ShowBlock on IE.

Procedures

1. Open the replace by code example page;
2. Initial the document with the following content and selection:

   ^<ol><li>item</li></ol>^
   

3. Click on stylesCombo to open drop-down.

• Actual Result: No options are listed in the drop-down.

CKEDITOR.editor::insertElement is about introducing changes to the document, which need to make sure the schema are satisfied. The functional test reproduce a typical case of this when inserting a table failed within list items.

Related tickets

#3097

Currently CKEDITOR.editor.insertHtml and CKEDITOR.editor.insertElement are having different results when the inserted element happened to be malformed or schema-violated.
This is because insertHtml is depending some native methods like pasteHtml to perform revision, from which the result may vary from browser to browser. While insertElement is all about our own logic, which perform no revision at all( The revision logic is proposing at #3100 though).

When initial a document with focus but no content, the CKEDITOR.editor::getSelection returns 'null', which disable and subsequent range requests, this bug is due to a IE bug which reporting selection which not belonged to parent document.

It should be possible for plugin developers to define icons for their context menu items easily, instead of having to include a separate .css for the purpose.

Some of the dialogs panels like 'Add New Image' do not get the input focus, while others like 'Add Anchor' move the focus to the panel. It is especially noticeable in IE, as unlike FF it does not hide the focus marker when a panel is opened.

If the V3 editor is hosted on third party domain clicking "Spell Check" throws the following error "Permission denied to set property Window.fakeOpener" (FF) or "A Runtime Error has occurfed. Do you wish to debug? Line: 30 Error:Permission Denied" (IE).

The documentFragment file has been mistakenly named with camel case, just like the class name. It must instead be renamed to full lowercase.

The reference in loader.js is also to be renamed, as well as the test file for it.

To reproduce:

1. Set config.tabSpaces=4 in config.js.
2. Open replacebyclass.html in IE or Firefox.
3. Put focus into editing area.
4. Press tab.
5. Nothing happens.

In Senthil's demonstration this evening, what happened was the editor put 4 spaces while blurring itself and put focus into the next field - but that's also wrong.

To reproduce:

1. Delete the doctype line in sample.html to make it a quirks mode document.
2. Open replacebyclass.html in IE.
3. Resize the IE window smaller such that some toolbar buttons cannot be fitted on the same row.
4. The alignment of toolbar icons becomes messy.

Currently the Spellcheck dialog loading is very slow and come without any waiting message,and sometimes failed in browser other than FF.

IE6 witness.

To reproduce:

1. Open replacebyclass.html sample in any supported browser.
2. Change the paragraph into a numbered list.
3. Press numbered list button again.
4. The list is not removed.

Specifically the overrides of both <b> and <i> are not working.

ASC char '|' is been translated into HTML Numeric Entity, which is wrong.

Most browsers hang or crash when accessing the smiley feature on a subsequent instance of the editor.

Steps to reproduce:

1. Open Ajax example
   
2. Use smiley plugin to add smiley to the document.
   
3. Destroy the editor
   
4. Create new editor
   
5. Attempt to add a smiley
   

Result: Most browser will hang or crash at this point. Possibly related to a recursion issue.

Reproducing Procedures

1. Open the ajax.html example page;
2. Click Create Editor button to have a new instance;
3. Insert some content and click Remove Editor to destroy the instance;
4. Click Create Editor button again to have another new instance;

• Actual Result : The content is lost within the new instance and the document become not editable.

Reproducing Procedures

1. Open the replace by code example page;
2. Make document content and selection as following:

   <ol>
   	<li>
   		level1^
   		<ol>
   			<li>
   				level2</li>
   		</ol>
   	</li>
   </ol>
   

3. Press Enter key

• Actual Result :

  <ol>
  	<li>
  	</li>
  	<li>
  		level1
  		<ol>
  			<li>
  				level2</li>
  		</ol>
  	</li>
  </ol>
  

• Expected Result :

  <ol>
  	<li>
  		level1
  		<ol>
  			<li>
  				level2</li>
  		</ol>
  	</li>
  	<li>
  	</li>
  </ol>
  

EnterKey logic within document should be disabled for source mode.It's now cause JavaScript error generated when hit the key.

Reproducing Procedures

1. Open the replace by code example page;
2. Make document content and selection as following:

   <pre>
   	text^</pre>
   

3. Hit Enter key then click Select All command;
4. Click Indent command;

• Actual Result : Javascript Error occured.
• Expected Result :

  <pre style="margin-left: 40px">
  	text </pre>
  

It's necessary to disable the Source button when perform switching.

Reproducing Procedures

1. Open the replace by code example page;
2. Delete all the content within document;
3. Triple click on Source button;

• Actual Result : The origianl content now re-appears.

The fake object is unable to get width style which should be updated from the fake control element.

The following currently doesn't work in all cases:

var editor = editor.replace( 'editor1' );
editor.on( 'someEvent', function() { ... } );

... because the event may be fired during the "replace" call, so the event registration comes too late.

There are ways to do so, but it's a little cumbersome:

CKEDITOR.on( 'instanceCreated', function( ev )
    {
        ev.editor.on( 'someEvent', function() { ... } );
    });

editor.replace( 'editor1' );

There should be instead a way to do that on instance creation, just like this:

editor.replace( 'editor1',
    {
        // ... some editor settings

        on :
        {
            someEvent : function() { ... },
            otherEvent : function() { ... }
        }
    });

Screen shot attached

The name of this button is confusing. It would be good to change it to something like page break for printing.

Like #3089, the same kind of patch is needed for FCKeditor and IE8

Load the replacebyclass example in IE8, click on any of the dropdowns: they are empty.

Also, clicking then in the document doesn't close the panel

As reported in ​http://www.fckeditor.net/forums/viewtopic.php?f=6&t=13378

the line 54 in fckpanel.js gives a permission error (Access denied), if the editor is placed in a page using domain relaxation.

This is the first part that fails:

		this.Document = this._Popup.document ;

While having the focus inside the editor, if you scroll the containing page, the caret will stay blinking inside the editor. But, at that point, the DEL key has not action anymore. Other keystrokes will continue work correctly.

In V2, we have special support for <pre> blocks, making it possible to switch them forth and back to <p>, for example. We need it in V3.

In V2, we implemented some checks to ensure that there is always a way to escape from special blocks, like <table> and <pre>.

For that we guarantee that there is always an element where to move at the very end of the document. We need it in V3.

When moving the caret inside the editor (on selectionChange), the editor could automatically fix paragraphs with no blocks, resulting in a more accurate WYSIWYG experience, as after all the paragraphs will be fixed on output.

Move the keyboard focus to an element in IE won't have an immediate result, which may cause subsequent dependent operation fails, as described by the test case.

At the time when context menu was displayed, the editor chrome width become noticeable larger, it restored back to normal width later on Menu hide randomly.

Reproducing Procedures

1. Open the replace by class example page;
2. Make a selection which contains some content;
3. Open Smiley dialog to insert a random icon;
   • Actual Result: JavaScript Error occurred.

If you type a question mark then submit, every "?" is transformed to "shy". In source mode, if you type &#063; same problem again.

Tested in FF3.0.6 and Opera9.63

If you paste some text that contains some HTML entities (like hardbreaks &nbsp;), switch to source code view and then switch back again, you can see all the hardbreaks being replaced with nbsp text.

Reproducing Procedures

1. Open the replace by class example page;
2. Click on 'Image' dialog button to open dialog;
3. Click on 'Cancel' button to close the dialog;
   • Actual Result: An JavaScript Error thrown;

After opening the ajax example in IE6 and creating the editor instance for the first time, it is not possible to focus in the editing area.

Some of the commands doesn't work under certain conditions. Example:

-WSC in Opera

-Print in Opera

-Save if there is no FORM element

Those buttons should be disabled.

The releaser is adding the xml:space="preserve" attribute at one of the tags in the sample pages.

I have made a Swedish translation of the extension. Version 0.1 :)

Steps to reproduce:

-Click the Style combo (it opens)

-Click the Format combo (it opens)

-Click the Style combo (it should be opened but it doesn't)

-Click the Format combo (it should be opened but it doesn't)

The same problem with Float Buttons.

Currently, if you want to set the UI to a specific language, you need to set, in the configurations, both autoLanguage to "false" and defaultLanguage to the desired language code. This is cumbersome, and counterintuitive.

It should be possible to set the UI language with a single configuration option.

Reproducing Procedures

1. Open the replace by code example page;
2. Open flash dialog and fill in url with : ​http://f.friendster-tweakers.com/rsc/swf/clock/fsdbp.swf, specify width with '100', height with '100', click Ok to insert the flash.
3. Open flash dialog again to add another new flash;

• Actual Result : The previous flash content is still in the preview area.

Made some mistakes on my original Hebrew translation files (sorry). These correct them.

After #3213 editor doesn't work in non English browsers due to lack of "editorTitle" translation.

When inline style is applied, it should always create at the possible outmost, with selection enlarged.

Reproducing Procedures

1. Open the replace by class example page;
2. Make the content along with selection as below by double click 'text':

   <b><i>^text^</i></b>
   

3. Click on 'Font' to open combo and select 'Arial' option;
   • Expected Result:

     <p>
     	<span style="font-family: Arial,Helvetica,sans-serif;"><b><i>text</i></b></span></p>
     

   • Actual Result: An JavaScript Error thrown;

     <p>
     	<b><i><span style="font-family: Arial,Helvetica,sans-serif;">text</span></i></b></p>
     

Undo/Redo support for RichCombo and PanelButton is to be implemented.

Undo/Redo support for EnterKeyis to be implemented.

Reproducing Procedures

1. Open the replace by class example page;
2. Open 'Format' combo and select 'Heading 1' style;
3. Click on 'Numbered List' to apply list format;
   • Actual Result:

     <ol>
     	<li>
     		This is some <strong>sample text</strong>. You are using <a href="http://www.fckeditor.net/">FCKeditor</a>.</li>
     </ol>
     

   • Expected Result:

     <ol>
     	<li>
     		<h1>
     				This is some <strong>sample text</strong>. You are using <a href="http://www.fckeditor.net/">FCKeditor</a>.</h1></li>
     </ol>