Custom Query

Undo control is not working when the changes are made by the Find/Replace.

In Safari 3.x release, Tab and Shift Tab is not able to reach the editor area at all. Thus user can't reach the editor area using tab or shift tab.

If CKEditor is loaded in a hidden element, getRanges() in the selection plugin throws a JavaScript exception, since getNative returns null, and the return value isn't checked. Adding

if (sel === null)
   return [];

on line 447 of selection/plugin.js fixes the problem for me.

This problem can be duplicated in replace-by-class by adding "display: none" to the containing <p> element's style.

To reproduce

-set in toolbar/plugin.js

CKEDITOR.config.toolbarLocation = 'bottom';

-open replacebyclass example

-put cursor in "sample text"

-put cursor in FCKeditor

Result: toolbar icons jump in toolbar.

Looking at file requests in nightly build (skins) sample, it's possible to note that the skin.js file and the main CSS files don't have the timestamp ("t") parameter in the URL. We must ensure this parameter is properly sent to the server.

I've detected the 'previous source node' is incorrect with the attache d TC.

In IE, if setting the "smiley_path" configuration to a relative URL, the final <img> tags contain the full resolved URL instead.

IT works as expected with Firefox.

Reproducing Procedures

1. Open the replace by class example page;
2. Open 'Flash' dialog to Insert a random flash;
3. Switch to 'Source' mode.
   • Actual Result: Flash object doesn't show in source.

To reproduce open the Special Character dialog and click on any character.

The javascript error occurred in the wysiwyg plugin.

Firefox doesn't show missing images. This is very annoying. There is a way to show something instead.

Solution based on #2933 in attachment.

The collapse toolbar button is missing in CKEditor trunk.

To reproduce:

1. Open replacebyclass.html in IE.
2. Open the Paste from Word dialog.
3. Copy some random text from MS Word.
4. Paste into the Paste from Word dialog with Ctrl-V.
5. Nothing happens.

Second level context menus for table properties (such as Row, Cell, and Column sub-menus) do not show up in FCKEditor 2.6.4 when viewed with IE8 on Vista (both x64 and x86).

This is discussed here: ​http://www.fckeditor.net/forums/viewtopic.php?f=6&t=13532

Currently VoiceOver announces the editor as, for example, "frame1". It should be instead announced using the correct accessibility string.

To reproduce:

1. Modify sample.html and replacebyclass.html such that the editor is surrounded by a few textboxex with tabindex, and the editor's textbox should have a tabindex as well.
2. Open replacebyclass.html in IE6.
3. Put focus in the first textbox, tab until the focus is in the editor.
4. Now press tab or shift-tab.
5. JavaScript error.

In paste text dialog one can change size of the textarea - it should be disabled.

Steps to reproduce:

• Insert 2 or more CKEditors on one page.
• Open one of Styles combos - it works
• Click to open any other - it is empty.

The CKEDITOR.dom.walker class has been introduced to replace the CKEDITOR.dom.domWalker class. Now, any part of the code using the domWalker must be changed to use walker instead, and domWalker is to be delete.

​ko.js and FCKeditor.i18n.ko.php

When hitting ENTER in in the last <li> of a list, if empty, the <li> must be removed, and the a new paragraph with the selection must be placed after the list.

With #2876, the new dom walker is introduced, this ticket is about establishing the missing TCs and bug fixing on it.

To reproduce just open Replace dialog in IE7.

Focus caused error because 'Replace' tab was not selected.

Agile ticket for updating TCs for CKEDITOR.dom.range regard recent changes.

Agile ticket for updating TCs for CKEDITOR.dom.document regard recent changes.

Agile ticket for updating TCs for CKEDITOR.dom.documentFragment regard recent changes.

Currently only the parent node id attribute is striped with CKEDITOR.dom.node::clone( true, true ) , so it doesn't work with the 'includeChildren' param.

Agile ticket for updating TCs for CKEDITOR.dom.element regard recent changes.

Sometimes Undo command cancels too much.

Example:

• Copy to clipboard:

  http://dollzmania.us/images/holiday03/11-6-02%20prop%20Image113.gif
  

• Open replacebyclass example

• Remove all the content.

• Insert this image using image dialog

• CTRL+V in the editor

• Click undo

Result: editor is empty.

Expected result: Image in the editor.

Tested Firefox 3.1 and IE8, open any dialog and move the mouse over an <input type="text">

The cursor remains as an arrow, it isn't clear that the user can type there.

The cursor should have changed to the "beam" indicating that it's an active text input.

The problem is due to the reset.css file.

IE is returning the namespace definition as the following along with the 'outerHtml' when creating an element with tag name 'cke:custom', which is unexpected.

<?xml:namespace prefix="cke" />

Infected by [3353], apply inline style throw JavaScript Error when reaching the end of document.

Reproducing Procedures

1. Open the replace by class example page in Firefox.
2. Clear all content and insert text 'bold';
3. Click 'SelectAll' then apply 'Bold' style;
4. Double click the bold text 'bold', and Click on 'Italic' command.
   • Actual Result: JavaScript error occurred.

Reproducing Procedures

1. Open the replace by class example page;
2. Make the following content with selection by double click on the anchor;

   ^<a name="name"></a>^
   

1. Click on 'Link' to open dialog, switch to 'Advanced' tab;
   • Expected Result: 'Name' filed is updated with the value 'name';
   • Actual Result: Anchor properties is not updated.

Screen shot is attached

Implement the About dialog on V3.

The panel list inside combo is not correctly marking those selected items.

Reproducing Procedures

1. Open the replace by class example page;
2. Make the following content along with selection:

   <ol>
   	<li>
   		^text</li>
   </ol>
   

3. Click on 'Bullet List' command to change list type;
   • Expected Result: Elements path is shown as : body -> p -> strong

     <ul>
     	<li>
     		^text</li>
     </ul>
     

   • Actual Result: Javascript error thrown.

Reproducing Procedures

1. Open the replace by class example page;
2. Make the following content along with selection:

   <ol>
   	<li>
   		^text</li>
   </ol>
   

3. Click on 'Bullet List' command to change list type;
   • Expected Result:

     <ul>
     	<li>
     		^text</li>
     </ul>
     

   • Actual Result: Javascript error thrown.

Reproducing Procedures

1. Open the replace by class example page;
2. Make the following content along with selection:

           ^<div>
               text
               <p>
                   paragraph
               </p>
           </div>^
   

3. Click on 'Increase Indent' command;
   • Expected Result:

             <div style="margin-left: 40px;">
                 <p>
                     text
                 </p>
                 <p>
                     paragraph
                 </p>
             </div>
     

   • Actual Result: Javascript error thrown.

             <div>
                 <p>
                     text
                 </p>
                 <p>
                     paragraph
                 </p>
             </div>
     

These are three of the more common dialog commands that could use hotkey combos.

Dialog layout is wrong in Firefox 2.

Replication steps:

1. Select a paragraph of text from the editor area.
   
2. Use the Size control to make the text larger (select 16 in the control). Notice that size 16 indicated in the control.
   
3. Use the Size control and select size 16 again. The text size becomes smaller again. Notice that no size is indicated in the control.
   

Same thing is happening with Font control also.

The dropdown title displayed when dropping down the font name droplist says "Font Style". It would seem that it should be called "Font Name".

This issue exists in the nightly samples.

The paste area in the Paste from Word dialog isn't editable in Firefox 2.

There're many cases when we need to traverse the range from the start boundary node to the end boundary node, it's archiveable by the following codes:

var boundaryNodes = range.getBoundaryNodes();
		var firstNode = boundaryNodes.startNode;
		var lastNode = boundaryNodes.endNode.getNextSourceNode( true );
var node = firstNode.getNextSourceNode();
while( node )
{
	if ( node.getName() == 'span'  && currentNode.getAttribute( '_fck_bookmark' ) )
	{
		node = node.getNextSourceNode();
		continue;
	}
	// Processing logic...
	node = node.getNextSourceNode();
}

It's cumbersome due to at least two reasons:

1. The collapsed range problem reported at #3292;
2. It make code DUP at every plugin for the same logic;

It's necessary to introduce an API for this feature with dom iterator, which already holds a method for iterating over paragraphs. So after the API, other plugins should walking through the range as easy as using the iterator.

Right now we have many times:

var isCustomDomain = CKEDITOR.env.ie && document.domain != window.location.hostname;

It should be replaced with just

var isCustomDomain = CKEDITOR.env.isCustomDomain();

Steps to reproduce:

1. Type in a line of text
2. Press Enter
3. Type another line of text.
4. Select the second line of text.
5. Press the "backspace" key and delete all of the highlighted text, or just simply press backspace to delete all of the text.
6. Press Ctrl-Z or the Undo toolbar button

Observation: Only some of the deleted text is restored after pressing undo, and in some cases the entire second line of text is deleted. The behavior is sporadic, but reproducible. I've also noticed that if you have a lot of content in the editor, after calling the undo command the very last line of text will vanish.

Expected: The highlighted / deleted text should be restored as it was prior to deletion and the remainder of the content remains unchanged.

Notes: Redo performs in the same odd fashion. First noticed this behavior in the 2.6.3 version, but it's also reproducible in the nightly build:

​http://www.fckeditor.net/nightly/fckeditor/_samples/default.html

If the clipboard plugin is disabled, there are usually no menu items to display in the context menu (there are still items for tables, etc).

In this case, it would be nice to simply display the browser's default context menu, rather than showing an (ugly) empty menu.

Attached is a patch that implements this.

• Open the replace by class example.

• Make the following content by using the Source button:

  <ul>
  	<li>
  		Item 1
  		<ul>
  			<li>
  				Item 2</li>
  			<li>
  				Item 3</li>
  		</ul>
  	</li>
  	<li>
  		Item 4<br />
  	</li>
  </ul>
  

• Place the cursor after the 3 in "Item 3".

• Choose increase indent. Expected result:

  <ul>
  	<li>
  		Item 1
  		<ul>
  			<li>
  				Item 2
  				<ul>
  					<li>
  						Item 3</li>
  				</ul>
  			</li>
  		</ul>
  	</li>
  	<li>
  		Item 4<br />
  	</li>
  </ul>
  

• Actual result:

  <ul>
  	<li>
  		Item 1
  		<ul>
  			<li>
  				Item 2</li>
  			<li>
  				Item 3</li>
  		</ul>
  	</li>
  </ul>
  

This can be reproduced with any of the nightly samples.

Reproducing Procedures

1. Open the replace by class example page;
2. Make the following content along with selection:

   text
   <a href="#">context^ menu</a>
   

3. Right click to open context menu, now click on the 'text' before the link;
   • Expected Result: The element path bar is refreshed.
   • Actual Result: The element path bar still indicate the old position.

Reproducing Procedures

1. Open the replace by class example page;
2. Switch to 'Source' mode;

• Actual Result: there's no visual line-break after <p>.

'Select all'/Ctrl-A command is not consistence between FF and IE.

Reproducing Procedures

1. Open the replace by class example page;
2. Click on 'Select All' command, then press 'Del' key.
   • Actual Result: There's still a paragraph inside document.

The keyboard shortcuts ALT+F10 and ALT+F11 do not work in FF2

Navigation key on sub menu items is not working within IE.

Reproducing Procedures

1. Open the replace by class example page;
2. Insert a table, right click to open context menu which has sub-menu;
3. Navigate to the menu item which would trigger sub-menu, press 'arrow-right' key.
   • Expected Result: Sub menu show up.
   • Actual Result: Javascript error thrown.

The table dialog is the only one that goes out of our design standards, having all labels at the left of the fields instead of above them. We need uniformity here.

The initial textarea height is incorrect after the DOM structure adjustment at #3387.

Start with a completely blank editor in wysiwyg mode. Type a few characters, then press the indent button. A JavaScript error will result.

Attached is a patch which fixes the problem.

To reproduce:

1. Open replacebyclass.html in IE6.
2. Switch to Source mode.
3. The source text area is collapsed in height.

We have base tag config but it works in preview only.

To reproduce:

1. Remove the doctype line in sample.html to make samples open in quirks mode.
2. Open replacebyclass.html in IE6.
3. Open the smiley dialog.
4. Many smiley icons are missing.
5. Open the special charater dialog.
6. There're scroll bars along the edges of the dialog.

There's some cases where it's necessary to check whether a attributed is intrinsic OR assigned dynamically on an element.

Reproducing Procedures

1. Replace the content of 'replacebyclass' with attached html file.
2. Open the replace by class example page;
   • Actual Result: The sample page is not loaded.

It's not able to undo changes made by 'Font Size' change.

Load this in source mode:

<script>alert(0)</script>

when you switch to design view the alert will show, so any script will be executed instead of being protected.

load this in source mode:

<a href="#" onclick="alert(1)">click me</a>

IE and Safari will show the alert when you click the link, meaning that any event handler is being executed while in design view.

To reproduce:

1. Open replacebyclass.html in IE6.
2. Open any dialog that has a tab bar (e.g. the image dialog).
3. The tab bar is seen at a position about 10px lower than the intended location.

The bug occurs in both standards mode and quirks mode. But it doesn't affect IE7.

JAWS is does not read Format, Font & Size Drop down as Combo Boxes.

For example, in the Paragraph Format combo box, JAWS should read the first option in the combo box followed by "to select the options use arrow keys".

This applies to other combo boxes.

To reproduce:

1. Remove the doctype line from sample.html.
2. Open replacebyclass.html in IE6.
3. Open any combo box - e.g. the style combo.
4. The position of the combo menu is a few pixels off from where it should be.

Other browsers are not affected.

When a paste dialog is opened, e.g. Paste from Word, the cursor will initially be focused inside the text area. After tabbing out of the text area, it is not possible to tab back into it.

After using ALT+F10 to switch focus to the toolbar, JAWS does not read out the first item that is selected.

Hi,

After calling the SetData function, the paste buttons are not enabled (my clipboard has data) in internet explorer (tested in IE7). Other browser does not have this problem. How can I solve this problem?

Here is the code of my test:

<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Transitional//EN" "http://www.w3.org/TR/xhtml1/DTD/xhtml1-transitional.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">

<head runat="server">
    <title></title>
    <script type="text/javascript" src="/fckeditorLatestBuild/fckeditor.js"></script>
    <script type="text/javascript">
        window.onload = function() {
            var oFCKeditor1 = new FCKeditor('MyTextarea1');
            oFCKeditor1.BasePath = "/fckeditorLatestBuild/";
            oFCKeditor1.ReplaceTextarea();
            setTimeout("myClick()",5000);
        }
        
        function myClick() {
		var oEditor = FCKeditorAPI.GetInstance('MyTextarea1');
		oEditor.SetData("<p>hello world</p>");
		oEditor.Focus();
    	}
    </script>
</head>

<body>
    <form id="form1"">
    <div>
          <textarea id="MyTextarea1" name="MyTextarea"></textarea>
    </div>
    </form>
</body>
</html>

Thanks in advance!

When iterating over the following document content, the original BR nodes on boundary of the newly established paragraphs should be removed, but during the process, padding block element like: <br _moz_dirty="" /> will be removed also, which result in a collapsed block.
So the correct behavior should respect these special blocking padding elements.

If the editor configuration is set to use an indent unit other than px (e.g. 'pt'), outdenting does not work. This is because the indent detection logic uses getComputedStyle, which returns the indent in pixels.

One solution is to mimic V2 behavior and use getStyle instead of getComputedStyle. Attached is a patch which implements this.

To reproduce:

1. Remove the doctype line from sample.html.
2. Open replacebyclass.html in IE.
3. Open any of the three above mentioned dialogs.

To reproduce:

1. Remove the doctype line from sample.html.
2. Open replacebyclass.html in IE6.
3. Open one of the color selection boxes.
4. You see a scrollbar in the color selection box opened.

If the editor area DocType is set to XHTML then it is not possible to drag the scrollbar in the editor area. When the scroll bar is clicked a javascript error occurs; this error prevents the scrollbar from working.

The DocType is specified in our custom configurations file using the following statement: FCKConfig.DocType = '<!DOCTYPE html PUBLIC "-W3CDTD XHTML 1.0 StrictEN" "​http://www.w3.org/TR/xhtml1/DTD/xhtml1-strict.dtd">' ;

The error details are as follows:

Message: 'nodeName' is null or not an object Line: 457 Char: 2 Code: 0 URI: ​https://brue/editor/264/v1/fckeditor/editor/_source/internals/fck_ie.js

This line of javascript is:

if ( e.nodeName.IEquals( 'input' ) && e.type.IEquals( ['radio', 'checkbox'] ) && !e.disabled )

I've worked around this problem by adding an extra guard.

if ( e.nodeName && e.nodeName.IEquals( 'input' ) && e.type.IEquals( ['radio', 'checkbox'] ) && !e.disabled )

This works for me as we never use FCK to edit web forms. However, a proper solution needs to test the DOM model for an attribute present in IE8 under both HTML and XHTML.

Currently, it's a bit cumbersome to add and remove plugins in the editor setting. To do that, we need to manipulate the plugins setting string in the custom configuration file. For example:

// Add a new plugin.
config.plugins += ',myplugin';

// Remove the elementspath plugin.
config.plugins = config.plugins.replace( /(?:^|,)elementspath(?=,|$)/, '' );

This situation, other than being counterintuitive, makes it impossible to set these configurations at editor creation time. We should instead have ways to make it with easy, as this is a common task.

To reproduce:

1. Open replacebyclass.html.
2. Press the maximized button to maximize the editor.
3. Press Source to go to Source mode.
4. Press maximized button again to restore to normal size.
5. The editor fails to restore back to normal size.

It works in IE8 compatibility view (i.e. IE7 Standards mode) and in quirks mode.

The config.autoLanguage parameter is now obsolete - it's not checked anywhere by the editor's code. Instead, what we're doing right now is this:

1. Check if there's a config.language - if it is defined, use that.
2. Check if we have a translation matching the browser's default language - if we have, use that.
3. If all fails, use config.defaultLanguage.

Right now the explanation in config.js, as well as some of the documentations in _source/core/lang.js, are not reflecting what's actually happening.

To reproduce:

1. Open replacebyclass.html in IE8.
2. Click on any of the font/font size/format/etc. combo boxes. Color boxes can also be used.
3. The resulting floating panels are opened (1px, 1px) off from the correct position.

To reproduce:

1. Open replacebyclass.html in IE.
2. Double click "You" in the editing area.
3. Click the Bold button.
4. "You are using " is bolded.

The bug can be reproduced across IE6, 7 and 8.

To reproduce:

1. Open replacebyclass.html.
2. Press "Show Blocks" button.
3. Switch to Source mode.
4. Switch back to WYSIWYG mode.
5. The blocks are still shown, but the state of the show blocks button is wrong.

This bug can be reproduced on all browsers.

To reproduce:

1. Add config.language = 'ar'; in config.js to get an RTL UI.
2. Open replacebyclass.html in Firefox, Safarai, Opera or IE.
3. Open any floating panel - e.g. the font combo box.
4. The floating panel is opened 1px off to the left from its intended position.

If setting ProcessHTMLEntities to false, empty paragraphs are filled with the &#160; entity, instead of &nbsp;. Because of this, IgnoreEmptyParagraphValue is having no effect, and an empty editor outputs:

<p>&#160;</p>

Paste in source mode

<p>
	<script>alert('sample text. You are using <a href="http://www.fckeditor.net/">FCKeditor</a>');</script></p>

switch to WYSIWYG and back to Source. Result:

<p>
	<script>alert(&#39;sample text. You are using </script><a href="http://www.fckeditor.net/"><script>FCKeditor</script></a><script>&#39;);</script></p>

expected result: nothing changed

This new code in fck_tablecell.html is missing a </td>, and the Safari working in HTML 4.0 mode objects to the <option...../> - starts at line 222:

<tr>
     <td nowrap="nowrap">
       <span fcklang="DlgCellType">Cell Type</span>:</td>
      <td colspan="2">
        &nbsp; <select id="selCellType">
        <option fcklang="DlgCellTypeData" value="td" />Data
        <option fcklang="DlgCellTypeHeader" value="th" />Header
         </select>
</tr>

Better written as <option....>Data</option> etc ??

By default Safari only shows the beam or text cursor for all the content. We should add in the internal css a rule to fix that:

img {
	cursor:default;
}

Other elements might need also this kind of rule in Safari (form elements for example)

There's some specific code in V2 to handle this in fck_gecko.js (can't find right now the original ticket)

		this.EditorDocument.addEventListener( 'mousedown',
			function( ev )
			{
				var element = ev.srcElement ;

				if ( element.nodeName.IEquals( 'IMG', 'HR', 'INPUT', 'TEXTAREA', 'SELECT' ) )
				{
					FCKSelection.SelectNode( element ) ;
				}
			}, true ) ;

		this.EditorDocument.addEventListener( 'mouseup',
			function( ev )
			{
				if ( ev.srcElement.nodeName.IEquals( 'INPUT', 'TEXTAREA', 'SELECT' ) )
					ev.preventDefault()
			}, true ) ;

		this.EditorDocument.addEventListener( 'click',
			function( ev )
			{
				if ( ev.srcElement.nodeName.IEquals( 'INPUT', 'TEXTAREA', 'SELECT' ) )
					ev.preventDefault()
			}, true ) ;

Also the last functions take care of disabling the default behavior of those elements.

Previous highlight marking style is not removed when search more than twice.

Reproducing Procedures

1. Open the replace by class example page;
2. Open 'Find' dialog, search for 'some';
3. Keep the dialog open, another search for 'are'

• Actual Result: Search results from both matching are marked.

The fixed color selector palettes displayed for font color and background color should provide names for those colors. This is to allow JAWS to read meaningful names instead of numbers.

The bug described in #2856 exists also in V3.

In samples we still have "FCKeditor". I found it also in JS files and testcases

The About button must remain enable in source mode. It's currently disabled.

Currently the padding block bogus br logic is not right, it's appending the br for every newly established block, which sometimes cause too much line breaks:

Reproducing Procedures

1. Open the replace by class example page with enterMode: P;
2. Click on 'New Page' button to clear all content;
3. Enter one line text and press enter key;
4. Now press backspace key to delete the new line;
   • Expected Result: One key strike will bring you back to the first line;
   • Actual Result: Three key strike is necessary to back to the first line;

Steps to reproduce:

1. Open nightly Replace text area by class name sample
   
2. Place cursor on the bold sample text text
   
3. Attempt to create a list or indent the paragraph
   

Actual result
The feature fails, leaving behind an _fck_bookmark span as below:

<p>
  This is some <strong>samp<span _fck_bookmark="1" id="cke_bm_81S" style="display: none;">&nbsp;</span>le text</strong>. 
You are using <a href="http://www.fckeditor.net/">CKEditor</a>.</p>

This can also be reproduced by selecting the entire line of text using the mouse (not CTRL+A).
Reproduced on FF2, FF3 and IE7

1. use chrome(version:1.0.154.36) 2.create a table
2. paste something into table
3. the format of the table is error

For empty nodes, getText() will return undefined instead of empty string. According to jsdoc, this method returns string.

Sample testcase

1. Using "Replace Textarea by code" example, fill editor with content:

   <h1></h1>
   

2. Evaluate this code:

   var e = CKEDITOR.instances.editor1;
   var text = e.document.getBody().getChild( 0 ).getText();
   console.log(typeof text);
   CKEDITOR.tools.trim(text);
   

3. Results in "TypeError: str is undefined" from CKEDITOR.tools.trim

Please correct me if my point of view is incorrect.

Steps to reproduce:

1. Open ajax sample
   
2. Create table with default values
   
3. Right click in a cell to invoke context menu.
   
4. Attempt access the cell sub-menu.
   

Actual result:
Cell sub-menu doesn't display.

Reproduced on latest nightly Ajax sample. Please refer to attached image.

Pasting from Word doesn't work in IE. Tested on IE7. Please refer to attached image.