Custom Query

All copyright notices in the files must be updated to 2008.

In order to be accessibility compliant on a web site one should always use an alt text tag for an image. Is there any way that FCKEditor can require the tag be entered when an image is inserted?

Found another bug. I use Mediawiki 1.11. with the FCK-Editor from this page (​http://www.mediawiki.org/wiki/Extension:FCKeditor_%28by_FCKeditor_and_Wikia%29) While using the Firefox all works fine. The Problem came with the Internet Explorer 7. If I want to adapt the text color or using other text formatting the IE7 can't handle with the following code: <span style="color: rgb(63, 255, 10);">colored Text</span> I have found out that <font color="#3FFF0A">colored Text</font> is working in IE7 and in Firefox. Can you reproduce this problem?

Step to reproduce:

1. Enter into FCKEditor text: "212221"
   
2. Call dialog "Find/Replace"
   
3. Enter search string: "21"
   
4. Click button "Find" - we get selection 212221 - right
   
5. Click button "Find" - we get selection 212221 - wrong
   

Thanks.

Pressing TAB inside the table doesn't insert a new row.

Steps to reproduce:

1. Create a table
2. Go into the last cell (bottom cell)
3. Press the TAB key

The table gets highlighted instead of inserting a new row.

In Internet Explorer (version 7 at least), when inserting the HTML below, a placeholder shows up as expected, but after switching to source view and back to WYSIWYG view, the placeholder dissapears.

<span class="embedded-object-18-408"><embed width="300" height="225" allowfullscreen="true" type="application/x-shockwave-flash" flashvars="&amp;image=/picserver/s/orig/public/video/water_balloon_11.mpeg.flv0000.jpg&amp;file=/picserver/s/video/public/water_balloon_11.mpeg.flv" src="../../videoplayer/mediaplayer.swf?0.4076338401231444"></embed></span>

In Firefox 2, when inserting the HTML below, a placeholder does not appear, After switching to the source view and back to the WYSIWYG view, though, a placeholder does appear.

<span class="embedded-object-18-408"><embed width="300" height="225" allowfullscreen="true" type="application/x-shockwave-flash" flashvars="&amp;image=/picserver/s/orig/public/video/water_balloon_11.mpeg.flv0000.jpg&amp;file=/picserver/s/video/public/water_balloon_11.mpeg.flv" src="../../videoplayer/mediaplayer.swf?0.4076338401231444"></embed></span>

In Windows Safari 3, when inserting the HTML below, instead of a placeholder, the actualy SWF shows up. After switching to source view and back, the video is replaced by a placeholder.

<span class="embedded-object-18-408"><embed width="300" height="225"
allowfullscreen="true" type="application/x-shockwave-flash"
flashvars="&amp;image=/picserver/s/orig/public/video/water_balloon_11.mpeg.flv0000.jpg&amp;file=/picserver/s/video/public/water_balloon_11.mpeg.flv"
src="../../videoplayer/mediaplayer.swf?0.4076338401231444"></embed></span>

Inserting HTML using InsertHtml results in the src URL attribute being replaced by a site root relative path.

The following HTML:

<embed type="application/x-shockwave-flash" pluginspage="http://www.macromedia.com/go/getflashplayer" src="http://delfi.laborint.com/r/videoplayer/mediaplayer.swf?0.07093275174449953" play="true" loop="true" menu="true" flashvars="&image=/picserver/s/orig/public/video/water_balloon_copy_24.mpeg.flv0000.jpg&file=/picserver/s/video/public/water_balloon_copy_24.mpeg.flv" width="300" height="225" allowfullscreen="true"></embed>

gets transformed to:

<embed width="300" height="225" allowfullscreen="true" flashvars="&amp;image=/picserver/s/orig/public/video/water_balloon_copy_24.mpeg.flv0000.jpg&amp;file=/picserver/s/video/public/water_balloon_copy_24.mpeg.flv" menu="true" loop="true" play="true" src="../../videoplayer/mediaplayer.swf?0.07093275174449953" pluginspage="http://www.macromedia.com/go/getflashplayer" type="application/x-shockwave-flash"></embed>

Tested with both Windows and OS X Firefox 2. Windows Safari 3 does not seem to have this problem.

Tested with Firefox:

1. Load the nightly demo at ​http://www.fckeditor.net/nightly/fckeditor/_samples/default.html
2. Insert a table
3. Right click in a cell, choose Table Properties
4. Repeat #3 up to ten times (usually happens on fourth try?)

Observation: the right click menu doesn't go away after selecting Table Properties

The paste dialog is broken by some previous code changes, it is giving out JavaScript errors when "OK" is pressed.

As briefly described in this topic: ​http://www.fckeditor.net/forums/viewtopic.php?f=6&t=8397#p22183 Filenames with special characters in it cause the XML used in the iBrowser to be invalid which breaks IE browsers.

In mozilla, if you drag an image around, the src changes from url to ../../url; problem if you use absolute urls for images (/path/to/image) it changes to (../../path/to/images) or a base url for the editor and the image disappears. Going to source view and back again, the good src is restored, presumably from _fcksavedurl.

When collapsing the toolbar everything works fine, however if you want to expand it back it is displayed in a wrong place. The bottom border of the editing disappears.

Steps to reproduce:

1. Press toolbar collapse button

2. Press tollbar expand button

3. Notice that the toolbar has moved down. An empty field is also present above and below the toolbar. It is hard to see it when the page background is set to white, so try to change the background of the page to see all issues of the bug.

Browser: Opera 9.50 beta Build:9762

It is impossible to move objects inside the editing area e.g. tables, flash objects, images, buttons etc. This also applies for the text itself.

Context menus don't work at all. They don't work with all the objects and also inside the editing area.

With

FCKConfig.EnterMode = 'br' ;
FCKConfig.ShiftEnterMode = 'p' ; (or same on 'div')

Shift + Enter make <br>

If I click on the button, FCkeditor produce

<td style="margin-left: 20px">text...</td>

So you can't see the indentation.

The layout of floating dialogs are broken when opened in Firefox 3.0 beta 2. Specifically, the bottom button row is broken in FF3.

If you have HTML content that contains a BODY tag with a BODY tag, only the content inside the inner tag is visible. For example:

<html> <BODY> <p>outer</p> <BR> <BODY> inner<BR> </BODY></BODY></HTML>

Only the "inner" text appears in the FCKeditor. This is needed because e-mail messages often have nested BODY tags.

Using Safari 3.0.4 (523.12.2) and creating FCKeditor instances using the Javascript API or replacing existing empty textareas, a single whitespace character is being added to the editor area. While this isn't a critical bug, it's somewhat annoying as the first line you enter in a blank FCKeditor instance has a single leading whitespace character.

The following creates an empty FCKEditor instance without an explicit default value, which gets populated with a single whitespace character:

<script>
var oFCKeditor = new FCKeditor( 'FCKeditor1' ) ;
oFCKeditor.BasePath	= sBasePath ;
oFCKeditor.Height	= 300 ;
oFCKeditor.Create() ;
</script>

Similarly replacing an existing empty textarea causes a single whitespace character to get inserted

<textarea name="test" id="test"></textarea>

I've just updated from version 2.4.3 to version 2.5.1.

I noticed that in a table with a thead en th-cells the contextmenu doesn't work when right-clicking in de last (bottom) row.

Example:

<table title="Tabel" cellspacing="0" cellpadding="0" summary="Tabel">
    <thead>
        <tr>
            <th scope="col">nummer</th>
            <th scope="col">Onderwerp</th>
        </tr>
    </thead>
    <tbody>
        <tr>
            <td>1</td>
            <td>abc</td>
        </tr>
        <tr>
            <td>2</td>
            <td>def</td>
        </tr>
    </tbody>
</table>

Without the thead there seems to be no problem.

regards, Koen Willems

In Apache, mod_security is usually installed (​http://www.modsecurity.org/) - it is commonly used to detect and prevent against possible attacks. Quick example from official mod_security site (​http://www.modsecurity.org/documentation/quick-examples.html):

    # Prevent path traversal (..) attacks
    SecFilter "\.\./"

Similar rule is available in a "Apache 2.x rules" at ​http://www.gotroot.com/:

##generic recursion signatures
SecRule REQUEST_URI "!(alt_mod_frameset\.php)" "chain,id:300004,rev:2,severity:2,msg:'Generic Path Recursion denied'"
SecRule REQUEST_URI "\.\./\.\./"
#generic path recurision si

The problem is that ../.. is used by FCKeditor:

http://www.fckeditor.net/fckeditor/editor/filemanager/browser/default/browser.html?Type=Image&Connector=../../connectors/php/connector.php

so it may be blocked in rare cases.

We should avoid passing ".." in urls.

For more info please take a look at: #950

For more info please take a look at: #950

For more info please take a look at: #950

Reproduction procedure:

1. Go to sample01.html
2. Open the Find dialog
3. Type "some sample" in the "Find what" field
4. Press "Find" twice, you should see the no match found message
5. Press "Find" once more, you'll see a JavaScript error

When switching between source and WYSIWYG view, preserve the selection.

Related tickets:
View source code of selection: #611
Maintaining Cursor positioning in text area while switching views: #1845 = #385

For MediaWiki, you can define certain kinds of interwiki links that won't show up in the page content. They instead get put on the "other languages" menu (by default). This is for links to translations of the article on another related wiki.

The code for an interlanguage link is identical to an interwiki link. The only way to tell one from the other is that a) the interlanguage link has "iw_local = 1" on its interwiki table row, and b) the prefix of the interlanguage link is a key in the language names array (see languages/Names.php). A common example might be, on the page "Dog", "[[fr:chien]]" to make an interlanguage link to the French version of the page.

As a first step, it would be nice to at least preserve this markup so it doesn't get lost when someone edits the page. (I'll file a separate ticket for allowing users to add, edit and delete interlanguage links.)

The editor must run inside the Adobe AIR platform.

For example:

<img src="a.gif" alt="b />

becomes

<img alt="b src="a.gif" />

when switching two times between normal view and normal view.

This is undesirable behavior, because e.g. user defined regular expressions become unreliable.

The bug is caused by the function FCKXHtml._AppendAttributes in fckxhtml_gecko.js, where it says

for ( var n = 0 ; n < aAttributes.length ; n++ )

which should become:

for ( var n = aAttributes.length-1 ; n >= 0; n-- )

See also ​http://www.fckeditor.net/forums/viewtopic.php?f=5&t=4987

I'm using fckeditor for specially privileged administrative purposes, so I want thing that would not be a good idea to grant to public at large.

I need to be able to change the upload directory according to an incoming GET parameter. This should be straightforward, but it is not.

Also, in order to use fck for editing existing html on the server, I had to hack the distributed code. This works, but it isn't necessary.

My apologies for cross-posting this from the FCKeditor support site; this site appears to be the more appropriate location for this, however.

We first discovered this issue locally in IE7 (FF seems unaffected), but this issue was confirmed in IE7 in the MediaWiki+FCKEditor sandbox. ​http://mediawiki.fckeditor.net/index.php/Sandbox

The problem is FCKeditor is mis-behaving when dealing with extra white spaces in list items. For example, if you take the following wikitext list

* a bullet list
* anchors
* links

and put three blank spaces immediately before and after the word "bullet" in the first list item then click 'Show preview' or view the Wikitext and go back to the WYSIWYG display. The list gets mangled to look like the following (again in wikitext).

*
* a   
* bullet    list
* anchors
* links

Sometimes I also get a Javascript error:

Line: 88
Error: 'null' is null or not an object

From the following file -- (I had to fat-finger this in, so it may not be completely accurate) extensions/FCKeditor/fckeditor/editor/js/fckeditorcode_ie.js

This is the offending line of code (line 88):

var FCKEvents=function(A){this.Owner=A;this._RegisteredEvents={};};FCKEvents.prototype.AttachEvent=function(A,B){var C;if (!(C=this._RegisteredEvents[A])) this._RegisteredEvents[A]=[B];else C.push(B);};FCKEvents.prototype.FireEvent=function(A,B){var C=true;var D=this._RegisteredEvents[A];if (D){for (var i=0;i<D.length;i++){try{C=(D[i](this.Owner,B)&&C);}catch(e){if (e.number!=-2146823277) throw e;}}};return C;};

version 2.5.1 Build 17566

We have styles set to our div styles in a CSS. DIV is also the default normal. When trying to add a selected style to a div where the code is <div> some text here </div> the div will not apply. When it is <div class=> some text here </div> the style applies great.

If you need to see a reprodcution of this or server config files please let me know. I have attached some config files.

my email is my username.

The PHP connector DetectHTML function does no error checking to make sure that the file was opened or read correctly. This causes a cascade of errors on systems with the PHP open_basedir set to disallow opening of files in the temporary file-upload directory. See the forums post ​http://www.fckeditor.net/forums/viewtopic.php?f=6&t=8619.

In the file 'editor/filemanager/connectors/php/util.php' starting on line 87 is the DetectHTML function.

Original:

function DetectHtml( $filePath )
{
	$fp = fopen( $filePath, 'rb' ) ;
	$chunk = fread( $fp, 1024 ) ;
	fclose( $fp ) ;

With improved error checking, it should be something like this...

function DetectHtml( $filePath )
{
	$fp = fopen( $filePath, 'rb' ) ;
        if ( $fp !== false )
        {
         	$chunk = fread( $fp, 1024 ) ;
             if ( $chunk === false )
             {
                     $chunk = '';
             }
	       fclose( $fp ) ;
        }
        else
        {
             $chunk = '';
        }

I'm not sure whether it would be better to return TRUE or FALSE in the case of being unable to open and/or read the file. I leave it to the security experts to debate that.

The inline CSS caching is not compatible with the current AIR implementation (see #1914). As we are using it for our internal CSSs, those styles have no effect in the editor.

two cell mergedown ok! three cell mergedown table broken.

Reproduction procedure:

1. Open _sample01.html in domain relaxation mode under IE6 or IE7.
2. Open the image dialog.
3. Click "Browser Server".
4. Select an image from the file browser. Upload one first if there's no image.
5. Permission denied error.

Reproduction procedure:

1. Open sample01.html in IE6 or 7 under HTTPS and domain relaxation mode.
2. Open the image dialog, or the flash dialog, or the image button dialog.
3. Warning message about unsafe contents.

The close button is mispositioned in the dialogs when in RTL mode.

Confirmed with IE6 and IE7.

When using Smarty protection source in FCKEditor 2.6beta :

FCKConfig.ProtectedSource.Add( /<\{[\s\S]*?\}>/g );
FCKConfig.ProcessHTMLEntities	= false ; //true

The following code is broken when swithing between wysiwyg/source edition :

<p><a href="{if $a=1}url1.htm{else}url2.htm{/if}">TEST</a></p>
<p>{if $a=1}url1.htm{else}url2.htm{/if}</p>

become :

<p><a href="%7Bif%20$a=1%7Durl1.htm%7Belse%7Durl2.htm%7B/if%7D">TEST</a></p>
<p>{if $a=1}url1.htm{else}url2.htm{/if}</p>

conclusion: Smarty code is protected only in tag and not in attribute.

Is it a bug ? how to avoid this behavior ?

When I now want to open the filemanager in a specific directory not depending on a session, but on variables available in the environment system that opens the editor, then I need to modify the source of several files. An array or JSON object that can be populated with variables and that is passed to the filemanager already out of the box would be a nice addition.

FCKConfig.LinkUploadVariables = {'path':'sub/', 'somethingElse':'value'}

Trying with beta 2.6 plugin Placeholder to update my plugin based on this one :

On IE 6.0, when you click on the yellow Number, you should get the same number in windows but here the custom number does not come back.

Think that the problem is here : fck_placeholder.html L 46

var eSelected = oEditor.FCKSelection.GetSelectedElement() ;

is something like not initialised because in th function (LoadSelected()) it goes straight to the end. (eSelected does not exist)

Confirmed with IE7. Ok with FF.

Steps to Reproduce

1. Insert an image (like a smiley).
2. Remove the selection from the image and select it again.
3. Open the "Insert Special Character" dialog.
4. Insert any char.

A JavaScript error is thrown in Selection.EnsureSelection. There is no way to close the dialog after it. The page is now blocked.

Note that the desired action was correctly completed though.

Steps to reproduce

1. Start typing text.

2. Try to change the font or the background color using the color menu.

3. See that nothing is changing

Expected behavior

Font or background color should change when a color is picked instantly as in other browsers.

Testing platform

Windows Vista. Safari 3.0.4 (523.15).

FCKeditor versions: 2.5.1, 2.6beta and SVN

Fire PHP Connector with:

http://www.fckeditor.net/fckeditor/editor/filemanager/connectors/php/connector.php?Command=GetFolders&Type=Image&CurrentFolder=\

Response should be an error because the CurrentFolder does not start with a /

The actual response is:

<Connector command="GetFolders" resourceType="Image">
<CurrentFolder path="/\/" url="/_userfiles/image/\/"/>
<Folders/>
</Connector>

Hello

I want to use Font size, Text color, BGColor... on Mediawiki+FCKeditor

so, I have modified fckeditor_config.js like below

FCKConfig.ToolbarSetsWiki? = [ .... FontFormat?, ....

];

->

FCKConfig.ToolbarSetsWiki? = [ ....

['FontFormat','FontName','FontSize'], ['TextColor','BGColor'], ....

];

It is working well on the Mozila FireFox but not working on the Internet Explorer

Because The Mediawiki FCKeditor replace <span style="color: rgb(255, 153, 0);">Red</span> with <span style="">Red</span> on the Internet Explorer

Please let me know how can i fix this problem.

Thank you

best regards

This bug was originally reported by dCyphr in our forum, at ​http://www.fckeditor.net/forums/viewtopic.php?f=8&t=8711#p22790

We need to provide a set of default values for important CSS attributes for dialog elements exposed to the main window, to avoid native CSS styles from interfering.

The test used in FCKTools.FixCssUrls to check if a path is full/absolute is buggy. It is calling test() with no parameters.

All browsers seem to ignore it, but this is breaking Opera.

When I run spell check using SpellerPages IE crashes (always). Basically, I run a spellcheck and once I get the popup that the spellcheck is complete, I click on the OK button and that's when the crash occurs. I'm using Windows XP SP2 and my IE version is 7.0.5730.11.

I have only had a quick look at the 2.6 beta... but on IE7 whenever a floating popup box appears on the screen... it just contains one word... "undefined" .

I will do more tests later...

Please include the ability to set a default for image borders. When linking images, and there is NO border set, the image gets an ugly border around it. It would be extremely helpful if we could have a configuration switch that would automatically default the border to zero (0).

Ok I have searched and did not find an entry for this. I have tested this on Windows XP with IE7 and Firefox and it fails in IE7 but works in Firefox. I was not able to test this in the Nightly version and images browsing is disabled.

How to repeat:

1. Load your Demo Tool

2. Delete all text

3. Insert the Eagle Image

4. Add the text "This is an Eagle" under the image (this is just so the image is no longer selected)

5. Exit the Image Dialog

6. Click ONCE on the image (producing the image handles)

7. Click the Insert Link

8. Add any URL (www.fckeditor.net)

9. Click OK.

This adds the link to the code, but the Link Dialog does not close; locking the surfer from being able to do anything else. The only way out here is to hit F5 to refresh the page, causing you to loose all your changes.

At this point there is no way to close the Dialog Box!

People around there doesn't understand the real meaning of <strong> and <em> and are using them indiscriminately for formatting, enforcing loudly that in this way they are XHTML aware.

They are also accusing us to use the good and old <b> and <i> "formatting" tags for "formatting", instead of the new and fashionable <strong> and <em> "semantic" tags (even if those are available in the Styles combo anyway).

So, to shut up the general mass opinion, it seems that it would be better for us to configure the editor to produce <strong> and <em> by default, removing those entries from the Styles combo.

At this point, we should also think about the following tags, which are produced by default with the "formatting" buttons:

• <u> : change to <span style="text-decoration: underline;">
• <strike> : change to <span style="text-decoration: line-through;"> (or <del>?)

We can use the powerful features of FCKeditor to easily configure it to produce the above tags. But... does all that makes sense? Would anyone get angry with us because of it?

Hi,

Using 2.6B on Safari 3.0.4 (Mac and Windows versions)

If you set .EnterMode = 'br', I am noticing that you get opening and closing <br> tags for example just type some text then switch to source view:

sample<br>
</br>text

PS - the SVN from 3/6/08 exhibits the same behavior

PSS - v2.5.1 doesn't exhibit this behavior, it works as expected.

Steps to reproduce:

1. Go to our demo page ​http://www.fckeditor.net/demo

2. Insert a table.

3. Right-click inside a cell to activate the context menu

4. Go to a sub-menu e.g. Cell, Row or Column

Notice that the submenu appears not besides the context menu but practically on it.

Expected behavior would be displaying a submenu besides the original context menu.

Tested using 2.6 beta and SVN version on IE7. It works fine in IE6 and FF2.

In Firefox when you right click a checkbox or a radio button, no context menu appears. But if you right-click to the right of the checkbox or radio button, the context menu does appear.

I've tested this in both version 2.6b and the nightly build. Checked in 2.5.1 and it appears there as well.

"FCK.InsertHtml()" function ignores selection/position when executed from a floating dialog instanciated with "FCKDialogCommand", and the web browser is IE7. The inserted text always gets inserted at the beginning. This does NOT happen when using Firefox 2.0.0.12. Furthermore, it does not happen if executed from an IE popup using window.showModalDialog().

Attached is a very simple plugin called 'insertbug' that adds the command 'InsertText' for demonstrating the problem. Firefox has no problem with selected text getting replaced or inserted at the insertion carot position. With IE, "Inserted Text" is always inserted at the beginning.

Tested 2.6.beta and nightly build 18335 (03/09/2008).

Place cursor in non-bold text

Press ctrl-b. Bold button on toolbar goes to "depressed" state (expected)

Press ctrl-b again. Bold button goes back to normal

Type. You get bold text - not expected.

Second ctrl-b press isn't correctly cancelled by the editor, so Opera picks it up and sets its internal state to "output bold text" even though FCKEditor removes the B tag from the DOM. The editor should make sure the keypress or keydown is cancelled also after the "remove empty B tag" operation.

Mediawiki auto-converts hyperlinks in [ ] to be numbered links such as [1] and [2] if a link-name is not provided. Whereas any URL not encased within [ ] will be simply hyperlinking with the URL as the link name.

FCK editor converts a ​http://URL into a numbered link by default. Can the default be set to using the URL as the link name instead? This is much more intuitive than using numbered links.

Like the title suggests.

To reproduce, open the editor, click the button to add a table, fill for example the text 'hello' in the title field. click on OK, now you can see the table in the editor with on top the title in bold 'ello'

IE7 introduced native support for XMLHttpRequest, so we must use it whenever possible.

This problem was discovered while I was working on #1647 today.

To reproduce:

1. Open sample01.html in Firefox.
2. Tap Shift-Enter twice at the end of the paragraph.
3. Switch to Source mode and back.
4. Repeat step 3 again.
5. The two <BR> nodes were truncated one-at-a-time at step 3 and step 4.

If I have a file with a pound sign # in it, it is not escaped when I upload it. Ticket #182 fixed most escaping issues, but using encodeURI() doesn't escape everything (e.g #). That's actually good since currently it's applied to the whole URI, and for characters like : and / we don't want those escaped in "​http://" for example. See ​http://xkr.us/articles/javascript/encode-compare/ which shows the different encode functions.

My suggestion would be to NOT encode anything in javascript. Rather, update all connectors to encode the file name (and/or url). In php, this would use the rawurlencode() function. Then that fully-encoded file name would be appended to the unencoded domain+directory.

If I use the Insert Special Character dialog and choose a character that uses an entity number, e.g. &#8219; or &#9658; (right pointing triangle, in this case), intead of an entity name, e.g. &trade; or &bull;, the actual character goes into the editor window rather than the entity number/name (which can be viewed in source). On saving, the character is replaced with a question mark. I notice that if I paste an entity number into view source, then click out and back to source again, the number is converted to the name, except for numbers &#8219; and &#9658;. These are converted to the characters, which one save are replaced with question marks.

Steps to reproduce:

1. Open sample01.html in Firefox 2 or Firefox 3 beta.
2. Type or paste something really long into the editing area so that the scroll bar appears.
3. Press the maximize button.
4. The editing area is not maximized vertically - the scrollbar is still at the previous height.

Error Message: Line: 103 Error: Can't move focus to the control because it is invisible, not enabled, or of a type that does not accept the focus.

Cause: Invoking the links dialog for properties of either an existing anchor or 'mailto:' when using IE7.

This dialog can open three different ways based on link type for which it'll be a properties dialog; namely 'url', 'anchor', or 'email'. The error is true for both 'anchor' and 'email' since the element on which focus gets placed is specific for 'url', and so is invisible for the other two cases. Replacing line 162 of 'dialog/fck_link/fck_link.js' that reads like:

	SelectField( 'txtUrl' ) ;

with valid (and sensible) places to put focus based on the three conditions:

	switch( document.getElementById( 'cmbLinkType' ).value )
	{
		case 'url'	: SelectField( 'txtURL' ) ; break ;
		case 'email'	: SelectField( 'txtEMailSubject' ) ; break ;
		case 'anchor'	: document.getElementById( 'cmbAnchorName' ).focus() ;
	}

fixes it for me. (SelectField isn't totally valid for anchor)

FF seems not to care, but IE does. (SVN build 18395)

Put it in the docs and present it as a public thing so people can easily access every FCKeditor instance on the page.

E.g. (currenlty)

if (FCKeditorAPI)
{
	for (fckeditorName in FCKeditorAPI.__Instances)
	{
		if (FCKeditorAPI.GetInstance(fckeditorName).IsDirty())
		{
			changesMade = true;
			break;
		}
	}
}

The fix for #183 broken the FCKeditorAPI "Instances" object cleanup. The "_test/manual/fckeditorapi/test1.html" test page shows the problem.

In the 2.6 Beta, when adding a hidden form field to a form, the field is added below the dialog window, but the dialog cannot be closed by ok, cancel, or x. This is reproducable in the demo.

Reproduction procedure:

1. Open sample06.html in IE.
2. Click on the editing area such that the caret appears in the editing area.
3. Click on the placeholder plugin button.
4. Type something.
5. Even though with the placeholder dialog in the foreground, you find that you can still type things into the background editing area.

Fatal error: Call to undefined method Parser::parser() in H:\TaxCon\BaseSite\extensions\FCKeditor\FCKeditorParser.body.php on line 29

This error came in when I installed this editor on MW 1.12rc1

I've found a couple of bugs regarding context menus, but couldn't find similar issue.

Latest Ubuntu 7.10 + Firefox 2.0.0.12 (no additional plugins).

Tested on: latest nightly build of FCKeditor, 2.4.3, CFKinder 1.2.

Open FCKeditor, right-click with your mouse (anywhere). Firefox context menu appears, FCKeditor menu is hidden below (I barely see it). I have to left-click once again to switch off Firefox context menu and access FCKeditor menu.

To reproduce the bug:

1. Open sample12.html in IE or FF, change EnterMode to 'br'.
2. Try to insert a page break anywhere by pressing the Page Break button.
3. You get a JavaScript error.

This bug is related to #1853 as the problem is caused by FCKDomRange::SplitBlock().

FCKeditor is by default set to work with XHTML 1.0 Transitional.

Today we have sample14.html, which is a nice demonstration on how to configure FCKeditor for XHTML 1.1. We should create other two samples that match some important usage cases: Flash and Old HTML.

Flash accepts a limited number of tags. A reference for it can be found here: ​http://kb.adobe.com/selfservice/viewContent.do?externalId=tn_14808

The old HTML sample should be called "Legacy Tags". It should be configured to work with <b>, <i> and <font> tags.

Steps to Reproduce

1. Load sample01.html.
2. In the Find dialog search for "e".
3. Continuously click in the Find button to find all occurrences of "e".

It will successfully find the first two occurrences, in "some" and "sample". After that, it blocks on the last found position and don't continue through the remaining occurrences inside "text", "are" and "FCKeditor".

Load sample01, in IE or Firefox, double click the sample and click the italics button.

The html generated is

This is some <i><strong>sample </strong></i><strong>text</strong>.

But it seems that it would be more logical to generate

This is some <strong><i>sample </i>text</strong>.

Load sample01 in Firefox2 and click the link button.

An error appears in the js console "element has no properties" called from

 SelectField("txtURL");
 onload();

but opening again the dialog works fine.

load sample09, put the focus in the first editor and press the Ctrl+Alt+Enter combo to execute the FitWindow command, an error is generated (it doesn't matter the browser):

this._UIButton has no properties
File: editor/_source/classes/fcktoolbarbutton.js
Line: 55

We don't need anything from FCKDebug when normally using the editor. We should be able so to avoid including its code inside the compressed files to save some bytes from it. The solution would be loading fckdebug.js by request, only if debugging is enabled.

Our code may have some debugging calls laying around, so the compressed files should still contain the debugging functions, but those should be empty. We could use @Packager.Remove.Start and @Packager.Remove.End to easily achieve that.

When I switch to the Wikitext version, I lose the titles on my tables.

I use a nightly build (2008/03/05).

I realized a small patch for the /plugins/mediawiki/fckplugin.js file. You must change the line 317 "stringBuilder.push( '|' ) ;" with the text bellow (in the "table" switch/case of the _AppendNode function).

if (htmlNode.rows[r].cells[c].tagName.toLowerCase()=="th") {

stringBuilder.push( '!' ) ;

} else {

stringBuilder.push( '|' ) ;

}

Best regards.

For details please check the original ticket reported by mosipov: #1944.

For details please check the original ticket reported by martinkou: #1919.

FCKEditor2.5 IE6.0 MergeDownCells twice Error! if ( tableMap[j-1] && tableMap[j-1][i] == cell )

{

alert("old:"+cell.rowSpan);

cell.rowSpan++ ;

alert("new:"+cell.rowSpan)

} result is old:1 new:1

so I changed it:

Disconnect all the cells in tableMap from their parents, set all colSpan and rowSpan attributes to 1. for ( var i = 0 ; i < tableMap.length ; i++ ) {

for ( var j = 0 ; j < tableMap[i].length ; j++ ) {

var cell = tableMap[i][j] ; if ( cell.parentNode )

cell.parentNode.removeChild( cell ) ;

cell.colSpan = cell.rowSpan = 1 ;

add to count cell.rowSpan:wangxiuling

cell.rowsCount=1;

}

}

Scan by columns and set rowSpan.

for ( var i = 0 ; i <= maxCol ; i++ ) {

for ( var j = 0 ; j < tableMap.length ; j++ ) {

if ( ! tableMap[j] )

continue ;

var cell = tableMap[j][i] ;

if ( ! cell

cell._rowScanned === true )

continue ;

if ( tableMap[j-1] && tableMap[j-1][i] == cell )

{

cell.rowSpan++ ;

add by wangxiuling

cell.rowsCount++;

} if ( ! tableMap[j+1]

tableMap[j+1][i] != cell )

cell._rowScanned = true ;

}

}

Insert physical rows and columns to the table.

for ( var i = 0 ; i < tableMap.length ; i++ ) {

var rowObj = table.ownerDocument.createElement( 'tr' ) ; for ( var j = 0 ; j < tableMap[i].length ; ) {

var cell = tableMap[i][j] ; if ( tableMap[i-1] && tableMap[i-1][j] == cell ) {

j += cell.colSpan ; continue ;

}

add by wangxiuling

cell.rowSpan=cell.rowsCount

rowObj.appendChild( cell ) ; j += cell.colSpan ; if ( cell.colSpan == 1 )

cell.removeAttribute( 'colspan' ) ;

if ( cell.rowSpan == 1 )

cell.removeAttribute( 'rowspan' ) ;

} table.appendChild( rowObj ) ;

}

The fckdialog.html file has an XHTML doctype but doesn't validate:

​http://validator.w3.org/check?uri=http%3A%2F%2Fwww.fckeditor.net%2Ffckeditor%2Feditor%2Ffckdialog.html&charset=%28detect+automatically%29&doctype=Inline&group=0

This is mainly because there are a lot of & < and > in the inline javascript code. The easiest would be to move the javascript code to a javascript file i guess.

This is a real problem when integrating with zope where the .html files might be parsed before delivery. The parsing breaks because of the invalid html.

It seems like the InsertHtml() function from a floating dialog is getting executed about 10 to 15 times. It is not noticeable using the 'insertbug' plugin as it is attached to #1990. However, if you replace the 'Insert Text' string that gets inserted with content that is taller than the editor window, you can then see the up/down rapid flickering from what appears like multiple re-insertions. Ultimately, it does end up working correctly, but the behavior is strange.

This doesn't happen with FF. However, the ultimate result isn't consistent between FF and IE. With FF, what gets inserted is not selected, but with IE it does end up selected.

SVN build 18515

The fckeditor.py module has a type: ToolBar instead of Toolbar. The attached patch fixes this.

I've encountered a bug while reproducing bug #2055 and checking the FF behaviour.

It seems it's impossible to merge cells down and right.

Steps to reproduce:

1. Open demo page www.fckeditor.net/demo using FF

2. Insert a table 2x3

3. Go into the the top left cell

4. Try to choose merge.

Not only options : Merge Down and Merge Right aren't present but the Merge Cells option is disabled as well.

This bug doesn't occur in IE6 and IE7.

Browser: Firefox 2.0.0.12

OS: Windows XP

FCKeditor versions affected: 2.6beta and the current SVN

I try to upload a file, but I have this error : ADODB.Stream erreur '800a0bbc' Impossible d'écrire dans le fichier

In English, it means "Impossible to write in the file". Here, the file path generated by fck :
NAS-PROD\wwwsites-data$\demo-modules.cyim.com\upload\file/test.doc

The problem is due to a concatenation of IIS server path and file path. IIS path is like that
cylab\sites\ File path is like that : /file/myfile.doc

I have updated the file "class_upload.asp" to correct my problem : Function SaveAs, I add this line : sFileName = replace(sFileName, "/", "\")

I think i'm not the first guy to use IIS and FCK. So, why i have this problem ?

To reproduce the bug:

1. Open _samples/html/sample01.html included in the latest SVN trunk in IE or Firefox.
2. Open any floating dialog window, e.g the Smiley dialog.
3. Press Tab on the keyboard until the focus shifts to the editing area.
4. Once the focus goes to the editing area, you find that you can edit the "inactive" document again.

This bug is pretty obvious to users who are used to switching UI widget focus via the Tab key so it should block the final 2.6 release.

Install CategoryTree extension: ​http://www.mediawiki.org/wiki/Extension:CategoryTree

Use the <categorytree> tag. Error: style is being stripped.

<categorytree style="border: 1px solid gray; padding: 0.7ex; float: right; clear: right; margin-left: 1ex; background-color: white;" mode="pages">Manual</categorytree>

switch to wikitext, wysiwyg mode and back to wikitext:

<categorytree mode="pages" style="clear: right; border-right: gray 1px solid; padding-right: 0.7ex; border-top: gray 1px solid; padding-left: 0.7ex; float: right; padding-bottom: 0.7ex; margin-left: 1ex; border-left: gray 1px solid; padding-top: 0.7ex; border-bottom: gray 1px solid; background-color: white" mode="pages">Manual</categorytree>

style attribute has changed.

If i use a link in a page like:

[http://www.google.com/ http://www.google.com/]

And the click on wikitext to edit the page directly the link will be truncated to:

[http://www.google.com/]

So mediawiki will represent it as a [1] instead of the url title.

In FCK (ver 2.6) I don’t seem to be able to resize the window of the floating dialog system. Is there any way to enable this feature ?

When adding a category to a page using wikitext such as [[Category:Foo]], if you switch back to wysiwyg mode, the link is reformatted as [[Category:Stuff|Category:Foo]]. With the category formatted in this way, it causes the category list page to improperly group that page in the alphabetic list. In this instance the page in question would be listed under section C regardless of the name of the page.

Example on the Sandbox: On the page ​http://mediawiki.fckeditor.net/index.php/Sandbox I have added [[Category:Foo|Category:Foo]] as formatted by FKCeditor to end of the Sandbox page. When navigating to the Foo category page ​http://mediawiki.fckeditor.net/index.php?title=Category:Foo it would be expected that the Sandbox page is grouped with other pages beginning with the letter "S". It is however grouped with pages starting with the letter "C".

Using wikitext to reformat the link to be [[Category:Foo | Category:Foo]] or [[Category:Foo]] allows MediaWiki to properly place the Sandbox page under the grouping for "S".

Using MediaWiki FKCeditor 2.5.1 build 17566 with Mediawiki 1.12.0

When hitting enter (and creating a new paragraph), the entire page will scroll back up in the Firefox 3 beta. Apparently, the behaviour of scrollIntoView has changed to match IE, so that scrollIntoView(true) should be used (rather than scrollIntoView(false), which is used now).

I found this related ticket:

​http://dev.fckeditor.net/changeset/1126

The relevant bug in bugzilla:

​https://bugzilla.mozilla.org/show_bug.cgi?id=426698

To reproduce:

• start wth empty page
• hit "bold" buton
• switch to Wikitext

Problem: <b></b> is changed into '''''', which is later changed into single quote '. To solve this issue it should be enough to check whether there is anything inside of the <b> tag. If it is empty, just skip it.

Hello,

it would be great if there would be an option to define which VIEW-mode is used as default view-mode.

It might be great for most users to have the WYSIWYG Editor as default and just toggle to Code-View. but i dont think that counts for all users.

We do run several wikis at work but i was forced to uninstall the FCKEditor extension for almost all mediawiki-installations based on the fact that it was just not possible to configure the defasult-view-mode for each wiki.

Being able to define that for each user would be even better but i stop here, as that would be another ticket.

In /editor/filemanager/connectors/asp/basexml.asp the charset ist set in line 33:

Response.CharSet = "UTF-8"

but additionaly the codepage has to be set correctly with:

Response.CodePage = 65001

At the moment an IIS defaulting to another encoding doesn't submit XML-data in UTF-8 and browsing a directory containing files with special chars like umlaute results in an error on IE. Firefox doesn't show an error, but filenames with special chars aren't displayed corectly.

Right clicking in the last row of a table that contains a thead produces a JS error (on Firefox 2.0.0.13 OSX 10.5.2)

A[B] has no properties fckeditorcode_gec... (line 64)

The HTML table below will reproduce this JS error on the current 2.6 online demo

<table width="200" cellspacing="1" cellpadding="1" border="1">
    <thead>
        <tr>
            <td>&nbsp;</td>
            <td>&nbsp;</td>
        </tr>
    </thead>
    <tbody>
        <tr>
            <td>&nbsp;</td>
            <td>&nbsp;</td>
        </tr>
        <tr>
            <td>&nbsp;</td>
            <td>&nbsp;</td>
        </tr>
    </tbody>
</table>

Further more, If there are 2 rows in the thead then the last 2 rows of the table will show the same error..

It would be great to have the possibilty to protect tags from modifying.

The best example is the placeholder plugin. Changes should only be possible by double-clicking on the tag itself to open the placeholder dialog window. This would help to avoid accidentally overwriting or modifying placeholders.