Custom Query

Filters
 
Or
 
  
 
Columns

Show under each result:

Results (601 - 700 of 1835)

← 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 →
Ticket Summary Keywords Owner Type Status Priority
#2113 Safari: <span class="Apple-style-span"> created when inserting special characters Confirmed Safari Review+ Martin Kou Bug closed Normal
Description

Reproduction procedure:

  1. Open sample01.html in Safari.
  2. Apply "Red Title" style to the paragraph.
  3. Insert a few special characters via the special character dialog in the paragraph.
  4. The inserted characters aren't red and come with a strange <span class="Apple-style-span"> tag.

This seems to be a WebKit bug as the problem also appears when adding special characters via document.execCommand('inserthtml', false, $HTML) directly in Safari. But a short term workaround may be possible as well.

#2117 File browser does not work under domain relaxation mode Confirmed Review- Martin Kou Bug closed Normal
Description

I've created separate ticket, because it's probably a different issue than #1919.

  1. Open _sample01.html in domain relaxation mode under Firefox 2.0.0.13.
  2. Open the image dialog.
  3. Click "Browser Server".

Even if there are images in the folder, they are not displayed. In frmresourceslist.html there is an empty body 

<body class="FileArea"/>

although GetFoldersAndFiles has been called succesfully.

#2124 Path problem under Windows Confirmed HasPatch Bug closed Normal
Description

Hello!

I noticed that FCKeditor's PHP Connector doesn't work under Windows. Linux is work as expected.

The problem is in io.php file on line 156: $sRealPath = realpath( './' ) ;

Under windows $sRealPath will be "c:\....\editor\filemanager\connectors\php\".

That last backslash is the problem, it doesn't appear on linux systems. Thats why line 168

if ( $position === false
$position <> strlen( $sRealPath ) - strlen( $sSelfPath ) ) is true.

I suggest to change this:

$sRealPath = realpath( './' ) ;

to

$sRealPath = realpath( '.' ) ;

On linux systems these calls are equivalent, but under windows second one would work as expected.

#2125 InsertHtml() ignores current selection in IE. Again. Confirmed IE Review+ Martin Kou Bug closed Normal
Description

I hate to be a pest about the same thing over and over again, but the bug as reported in #1990 is back as originally stated for both 2.6 and the SVN.

For whatever reason, the condition put in place to fix #2057, which was the fix for the flashing problem of the fix for #1990, that detects whether the selection has already been restored is always true when running the simple plugin attached to #1990. Therefore, the selection never does get restored hence why the original #1990 problem.

Perhaps the logic implemented by #2057 will only work if the EditorDocument doesn't have focus. This is my guess because if I rearrange lines 152 thru 155 in the InsertHtml function of 'fck_ie.js' such that FCKUndo.SaveUndoStep() happens before setting focus: 

	FCKUndo.SaveUndoStep() ;

//	FCK.Focus() ;
	FCK.EditorWindow.focus() ;

that seems to fix it. Perhaps logic of #2057 should be reviewed if needed for other broken circumstances. Putting that save undo call before the InsertHtml() call in the plugin also works around it. (What fun could you have without IE?)

FYI... The FCKSelection.Restore() function gets called a lot, even when there is no active dialog. Not much can be done with the editor per 100 times this gets called. However, the call rate gets drastically reduced after a positive response (e.g. OK button) to a dialog.

#2126 [IE] Dialogs break toolbar button states Confirmed IE Review+ Martin Kou Bug closed Normal
Description

State of the cut/copy buttons doesn't work properly after a positive response (OK button) to a dialog. It can be corrected by invoking a dialog and then pressing 'Cancel'. State can also be temporarily corrected by right clicking along with the proper states of the context menu, but still won't continue to work properly until canceling a dialog.

This was not a problem with 2.6 beta (build 18219).

Problem noted with IE7. Not a problem with FF 2.0.0.13.

#2127 Disable scrollbar of editor parent while dialog is active Confirmed Review+ Martin Kou New Feature closed Normal
Description

It would be nice to have again what effectively was a feature before 2.6. In other words, it would be nicer if somehow the vertical scroll bar of the main browser window could be disabled while a dialog is active. This is because the mouse wheel can now scroll away the whole dialog (and editor window) after a scroll bar within a dialog reaches its limit and the parent page containing the editor instance is taller than the browser window. (a little bit annoying) This of course couldn't happen from a popup.

The following:

window.document.body.style.overflow='hidden';

could work for IE, but unfortunately not FF. FF scrolls to the top before disabling the scroll bar. I'm hoping you can think of a more elegant solution.

#2129 character"&" will be "&amp;" when turn on "wikitext" Confirmed Bug closed Normal
Description

"version 2.5.1 Build 17566"

I think it will be "&" when turn on "wikitext".

Can be reproduced in sandbox of mediawiki.fckeditor.net.

thanks!

#2133 Dialog Heights not set correctly Confirmed Martin Kou Bug closed Normal
Description

Just upgraded to 2.6, using IE7 on WinXP. When viewing Source, Anchor, Find/Replace dialogs (and others) the height is not being set correctly.

e.g. The Source area is showing only a small area at the top for viewing the source. See attached gif image.

#2135 Null is saved when submiting the form in IE6 Confirmed IE Review+ Martin Kou Bug closed Normal
Description

Set the EditorAreaCSS property: 

oFCKeditor.Config['EditorAreaCSS'] = 'some/file.css';

in some/file.css is standard css file. Everything ok, no problems... But if I write into this file standard css function: 

@import url('some/other/file.css');

Everything seems to work fine but that is not true. File was imported succesfuly, styles changed according to 'some/other/file.css', but try to do this: 1) Click into FCKeditor area and change some text 2) Click on Source button (the source code will appear) 3) Click on Source button again (you will get back into WYSIWYG area) - still everything seems fine, style is ok but follow the last step 4) Click on submit button The submited text is now 'null' and everything what was really in the FCKeditor area disappeared forever!!!! Even if everythink looked fine...

For reproducing the bug don't do anythink else than what is described in four steps above. When you write something in FCKeditor area after step 3 the submited text will be ok.

When I removed the @import function and copied the content of the 'some/other/file.css' file into 'some/file.css' everything was ok...

#2136 Error when looking at bulleted list properties in 2.6 Confirmed IE Review+ Martin Kou Bug closed Normal
Description

Create a bulleted list in v2.6 (no problem in v2.5)

Right-click and select Bulleted List Properties

The following error will be displayed:

Line: 103 Error: Can't move focus to the control because it is invisible, not enabled, or of a type that does not accept the focus.

Dialog window will display after you close error window.

Tested on ​http://www.fckeditor.net/nightly/fckeditor/_samples/default.html

Error does not occur with ordered (numbered) list.

#2142 HTML samples should use php extension in action paramter inside a form Confirmed Review+ Wojciech Olchawa New Feature closed Normal
Description

My suggestion is to replace sampleposteddata.asp with sampleposteddata.php in action parameter inside the form. I think that the usage of asp extension is less useful for the users. I don't know what is the most common used server side however I think that PHP is more popular than ASP (more of the users use Appache rather than IIS for example). Of course a user could always use the php examples however I don't see why php extension couldn't be used in html samples as well.

#2146 Styles for TABLE, TD, TR Confirmed New Feature closed Normal
Description

Sorry for my bad english.

What is needed to do:

Now the "Style Combo Box" shows only available styles for element in current cursor position ("current element"). One needs to gather also available styles for "Parent element" (parent of "current element"). And also for Parent of "Parent Element" and so on till root element.

For example in this situation... 

<table>
<tr>
  <td><p>some text _CURSOR_HERE_ some text</p></td>
</tr>
</table>

...the Style Combobox must gather available styles for this elements: p, td, tr, table.

And now...

When user selects the style from "Style Combobox", we need to:

  1. determine correct element to apply the style: current element or some ancestor of current element.
  2. apply selected style to this element.

For example if selected style is designed for TR element (see an example below), then we apply the selected style to TR (not to current element but to some ancestor of current element).

Example fckstyle.xml 

<Style name="Odd row" element="tr">
	<Attribute name="class" value="odd" />
</Style>

Some details:

In this situation... 

<table id="table1">
<tr id="tr1">
	<td id="td1">
	<p id="p1">
		<table id="table2">
		<tr id="tr2">
			<td id="td2"><p id="p2">some text _CURSOR_HERE_ some text</p></td>
		</tr>
		</table>
	</p>
	</td>
</tr>
</table>

...the Style Combobox must gather available styles only for this elements: p2, td2, tr2, table2. Not for: p1, td1, tr1, table1. For first ancestors only. For first TD, for first TR, for first TABLE and so on.

Resume:

In that way we get the feature: styles for tr, th, td elements (and some more).

Sorry for my bad english.

#2147 Template information on tables dropped when switching from Wikitext to WYSIWYG Confirmed Bug closed Normal
Description

Summary: FCKeditor is behaving incorrectly when working with templates, it'll drop the template information put on tables.

Tested against latest version, and with ​http://mediawiki.fckeditor.net/nightly/svn/mediawiki_fckeditor_ext_N.tar.gz

Similar to Ticket #2069, still not working when used as described below:

Steps:

Go edit any page, go to wiki text, type:

{|{{Prettytable}}| {{Hl2}} | Cell 1 | {{Hl2}} | Cell 2 |}

Click on Wikitext button again, no blue colors right? get back to Wikitext, BAM, templates lost.

Contents of prettytable template:

border="2" width="100%" cellspacing="4" cellpadding="3" rules="all" style="margin:1em 1em 1em 0; border:solid 1px #AAAAAA; border-collapse:collapse;empty-cells:show;"

hl2 template:

bgcolor="#A7C1F2"

Software information:

MediaWiki 1.12.0 PHP 5.2.5 Linux Box, Firefox Browser 2.0.0.11

Also tried with the installation on mediawiki.fckeditor.net, same thing

Screenshots:

Write wikitext with template information: ​http://img90.imageshack.us/img90/9539/wegottemplatessf8.png

By looking at the code for the template, it is abvious that the table should have some color: ​http://img90.imageshack.us/img90/7632/shouldhavecoloryp7.png

Go back to the wikitext, where are our template calls? ​http://img90.imageshack.us/img90/9396/templateinfogonekp7.png

What if we put the template contents directly? ​http://img90.imageshack.us/img90/350/whatifwepf0.png

Works correctly: ​http://img91.imageshack.us/img91/8629/workedthistimecp0.png

Sample Data:

None

Text case file:

None

#2149 Stylesheets with custom css urls are not attached to the editorarea Confirmed Review+ Frederico Caldeira Knabben Bug closed Normal
Description

We need to generate the css rules for each user which are using the fckeditor. To achieve this our css files are parsed as php files. To get correct css rules we send in the id as a GET parameter to the css files.

In this way we get urls like: /styles.css?id=15

This does not work with the new css cache feature in fckeditor. The problem is the regex used at least two places in fcktools.js (FCKTools.AppendStyleSheet and FCKTools.GetStyleHTML) which look like "/[
\/\.]\w*$/"

I have temporary changed the regex to /[
\/\.].*$/ in our solution, but you guys will surely come up with a better solution.

And why your at it, why don't you move this regex rule to your fckregexlib? At least it will be easier to customize.

#2150 Find dialog hangs when searching for word not found in a larger text Confirmed Review+ Martin Kou Bug closed Normal
Description

Scenario:

  1. Paste a larger text into the editor (i.e. the gpl license ​http://www.gnu.org/licenses/gpl-3.0.txt)
  2. Open the find dialog and search for word not found in the text.
  3. The scripts hangs and after a while the browser ask to stop the script.

Tested in nightly build with firefox on linux and ie7 on windows.

#2152 [FF] When deleting table resize handles don't disappear Confirmed Firefox CantFix Bug closed Normal
Description

When deleting a table in Firefox, the resize handles stay on the screen even though the table borders disappear. Only after double clicking somewhere or typing do the handles disappear.

#2154 Empty editor submits "<p>&#160;</p>" when ProcessHTMLEntities is false Confirmed Bug closed Normal
Description

How to reproduce:

  1. Set FCKConfig.ProcessHTMLEntities to false and let the editor be empty at start up
  2. Load the editor
  3. Switch to source view and observe that the source is "<p>&#160;</p>" or submit and you'll get the same result.


Is this intentionally? We can't let the FCKConfig.ProcessHTMLEntities be true because our Norwegian characters will be processed and unsearchable (unless we do some post processing).

Reproduced in Firefox 2.0.0.14 on Ubuntu and IE 7 on MS Vista.

Expected result: Empty post as when FCKConfig.ProcessHTMLEntities is true.

#2156 [IE] Can't remove styles after calling GetData() Confirmed IE Review+ Alfonso Martínez de Lizarrondo Bug closed Normal
Description

In IE7, open the first sample. (​http://www.fckeditor.net/demo)

Call GetXML() by pasting this code into the address bar. 

javascript:alert(FCKeditorAPI.GetInstance('FCKeditor1').GetData());

You should get an alert with the source currently in FCKEditor. Dismiss the alert.

Now try making the text that's bold not bold. It doesn't work. (I've tried selecting the bolded text and clicking the "B" button. I've also tried placing the cursor inside the bolded text an clicking the "B" button. These both work fine prior to calling GetData().)

#2159 Undoing replaced text restores fake selection HTML Confirmed Martin Kou Bug closed Normal
Description

This bug was discovered while working on #2150. It will be fixed with the patch of #2150 since the find/replace logic of the dialog is being rewritten right now.

To reproduce:

  1. Open sample01.html.
  2. Open the Replace dialog.
  3. Look for "some" and fill in "same" for the replacement text.
  4. Press "Replace" twice so that the "some" in the document is replaced.
  5. Close the dialog.
  6. Press undo once.
  7. The "some" in the editing document is highlighted... but it's a fake highlight done by CSS effects and it shouldn't be saved by the undo system at all.
#2160 Match whole word option in Find/Replace dialog should capture words next to punctuation marks. Confirmed Martin Kou Bug closed Normal
Description

This minor bug was discovered whiled working on #2150.

To reproduce:

  1. Open sample01.html.
  2. Type in "Hello, World!" at the end of the paragraph.
  3. Open the Find dialog.
  4. Try to find "hello" with the match whole word option ticked.
  5. The "hello" word is not found, because it is next to a comma.

This issue will be fixed in the final patch to #2150.

#2162 Working with Firebug might include reference to chrome: file Confirmed Firefox Review+ Alfonso Martínez de Lizarrondo Bug closed Normal
Description

I don't know the exact steps to reproduce, but I've seen a page that it wasn't possible to edit anymore giving an error in both IE and Firefox. The page was edited with full page and it had this included (after the last successful edit): 

		<link charset="utf-8" rel="stylesheet" type="text/css" href="chrome://firebug/content/highlighter.css" />

So it might be a good idea to check that the <link>s doesn't point to restricted urls

#2166 [IE] Link isn't displayed when image is placed inside <fieldset> Confirmed IE Bug closed Normal
Description

Hi there

I was playing around with your editor and found a bug. If I use the following code: <fieldset>

<a href="/File/Meg_TechRun1.jpg">

<img src="/Image/001_Meg_TechRun_Thumb.jpg" />

</a>

</fieldset>

and right click on the image and edit the link, it moves the cursor to the first position in the source and the link in the popup is empty. This is happening in my IE7 browser, but not in my Firefox.

If you need more information, feel free to email me at friendly_781114@…

Thanks.

M

#2167 [IE] Foucs isn't placed on floating dialogs. Confirmed IE Review+ Artur Formella Bug closed Normal
Description

When you open a link dialog or a image dialog, the focus isn't placed on the dialog but remains in the editing area.

Steps to reproduce

  1. Open the Insert Link Dialog
  1. Start to type (without placing the cursor in the proper place.
  1. If you type you will see that the text appears in the editing area and the cursor is blinking on the dialog area as well.

In this situation you can't insert a link when you have highlighted a text which should be made a link because it will overwrite your selection.

Testing area

Tested using IE6 and IE7 on MediaWiki 1.12 using the latest FCKeditor SVN version. This bug doesn't occur on FF2.

#2170 Text coping by Ctrl+Ins doesn't work Confirmed Review+ Martin Kou Bug closed Normal
Description

Text coping by Ctrl+Ins doesn't work anymore. Reproduced at ​http://www.fckeditor.net/demo

Additional info: I have old integration with FCKeditor 2.2 there copying by Ctrl+Ins work fine. If I add [ CTRL + 45 /*INS*/, 'Copy' ] to FCKConfig.Keystrokes problems solves for IE. But under Firefox (version 2.0.0.14) I start getting warnings that copying is disabled by my browser for security reasons. This is incorrect cause using the same version of Firefox and FCKeditor 2.2 I can copy text by Ctrl+Ins without any problem.

#2180 Display simple textarea if javascript is disabled Confirmed New Feature closed Normal
Description

If javascript is disabled in FCKeditor compatible browser, most of the time nothing appears to the end user (neither FCKeditor nor simple textarea).

The only example that works with javascript disabled is sample02.html.

I belive that many people use server side integration and are unaware of this problem. Below is a simple work-around for this issue: 

public function CreateHtml()
{
	$HtmlValue = htmlspecialchars( $this->Value ) ;

	$Html = '' ;

	if ( strpos( $this->Width, '%' ) === false )
	$WidthCSS = $this->Width . 'px' ;
	else
	$WidthCSS = $this->Width ;

	if ( strpos( $this->Height, '%' ) === false )
	$HeightCSS = $this->Height . 'px' ;
	else
	$HeightCSS = $this->Height ;

	if ( $this->IsCompatible() )
	{
		if ( isset( $_GET['fcksource'] ) && $_GET['fcksource'] == "true" )
		$File = 'fckeditor.original.html' ;
		else
		$File = 'fckeditor.html' ;

		$Link = "{$this->BasePath}editor/{$File}?InstanceName={$this->InstanceName}" ;

		if ( $this->ToolbarSet != '' )
		$Link .= "&amp;Toolbar={$this->ToolbarSet}" ;

		// Render the linked hidden field.
		$Html .= "<input type=\"hidden\" id=\"{$this->InstanceName}\" name=\"{$this->InstanceName}\" value=\"{$HtmlValue}\" style=\"display:none\" />" ;

		// Render the configurations hidden field.
		$Html .= "<input type=\"hidden\" id=\"{$this->InstanceName}___Config\" value=\"" . $this->GetConfigFieldString() . "\" style=\"display:none\" />" ;

		// Render the editor IFRAME.
		$Html .= "<iframe style=\"display:none\" id=\"{$this->InstanceName}___Frame\" src=\"{$Link}\" width=\"{$this->Width}\" height=\"{$this->Height}\" frameborder=\"0\" scrolling=\"no\"></iframe>" ;

		// If JavaScript is enabled, make iframe above visible
		$Html .= "<script type=\"text/javascript\">" ;
		$Html .= "<!--\n";
		$Html .= "document.getElementById('{$this->InstanceName}___Frame').style.display='';";
		$Html .= "\n//-->";
		$Html .= "</script>" ;

		//If JavaScript is disabled, display simple textarea and leave iframe invisible
		$Html .= "<noscript>";
		$Html .= "<textarea name=\"{$this->InstanceName}\" rows=\"4\" cols=\"40\" style=\"width: {$WidthCSS}; height: {$HeightCSS}\">{$HtmlValue}</textarea>" ;
		$Html .= "</noscript>" ;
	}
	else
	{
		$Html .= "<textarea name=\"{$this->InstanceName}\" rows=\"4\" cols=\"40\" style=\"width: {$WidthCSS}; height: {$HeightCSS}\">{$HtmlValue}</textarea>" ;
	}

	return $Html ;
}

I know it's ugly but it seems to work. The problem is that the same value ($HtmlValue) is posted twice for textarea and hidden field. I'm not sure whether there is a way to copy this value from textarea in <noscript> tag to a hidden field.

Do you have any other proposals?

#2185 FCKPackager incorrectly adds semicolons after functions passed as an argument to another function. Confirmed Bug closed Normal
Description

Write the following JavaScript code and let FCKPackager compress it: 

void(
function(b)
{}
);

FCKPackager would give you something like this: 

void(function(b){};);

Notice the semicolon after the anonymous function, it is incorrect.

This bug is causing the current FCKeditor code in the SVN unusable after running build_release.bat, because of the following code in fckdocumentprocessor.js: 

if ( FCKBrowserInfo.IsSafari )
{
        FCKDocumentProcessor.AppendNew().ProcessDocument = function( doc )
        {
                var spans = doc.getElementsByClassName ?
                        doc.getElementsByClassName( 'Apple-style-span' ) :
                        Array.prototype.filter.call(
                                        doc.getElementsByTagName( 'span' ),
                                        function( item ){ return item.className == 'Apple-style-span' ; }
                                        ) ;
                for ( var i = spans.length - 1 ; i >= 0 ; i-- )
                        FCKDomTools.RemoveNode( spans[i], true ) ;
        }
}
#2189 Gujarati language file Confirmed Review+ Wojciech Olchawa New Feature closed Normal
Description

Gujarati Language file (gu.js)

#2191 A button to activate/deactivate Confirmed Review+ New Feature closed Normal
Description

It would be very useful to be able activate or deactivate this editor with the click of a button like with ​wikEd for example.

#2201 fck & updatepanel: ie6/7 crash after postback if an image or a table is selected Confirmed IE Review+ Alfonso Martínez de Lizarrondo Bug closed Normal
Description

I have create an application with fckeditor inside an updatepanel. If inside the editor I insert an image and then select it by clicking on it, doing a postback ie6 and ie7 crashes. The same is also for a table; you can reproduce the problem using the attached project.

#2208 Update for Italian Language File Confirmed Review+ Wojciech Olchawa Bug closed Normal
Description

This update was originally posted by zed1973.

Here are the missing translations for Italian language: 

> AnchorDelete          : "Rimuovi Ancora",     //MISSING
> ShowBlocks            : "Visualizza Blocchi", //MISSING
> InsertRowAfter                : "Inserisci Riga Dopo",        //MISSING
> InsertRowBefore               : "Inserisci Riga Prima",       //MISSING
> InsertColumnAfter     : "Inserisci Colonna Dopo",     //MISSING
> InsertColumnBefore    : "Inserisci Colonna Prima",    //MISSING
> InsertCellAfter               : "Inserisci Cella Dopo",       //MISSING
> InsertCellBefore      : "Inserisci Cella Prima",      //MISSING
> MergeCells                    : "Unisci celle",
> MergeRight                    : "Unisci a Destra",    //MISSING
> MergeDown                     : "Unisci in Basso",    //MISSING
> HorizontalSplitCell   : "Dividi Cella Orizzontalmente",       //MISSING
> VerticalSplitCell     : "Dividi Cella Verticalmente", //MISSING
> DlgFindAndReplaceTitle        : "Cerca e Sostituisci",        //MISSING
> DlgPasteSec           : "A causa delle impostazioni di sicurezza del
browser,
> l'editor non è in grado di accedere direttamente agli appunti. E' pertanto
> necessario incollarli di nuovo in questa finestra.",  //MISSING
#2210 [FF] font-weight: bold and font-style:italic instead of strong and em Confirmed Firefox CantFix Bug closed Normal
Description

Hello,

There is a bug with Firefox when doing some manipulations on bold and italic.

Let's try this with the demo FCK on the website :)

1/ Type "Hello world"
2/ Make the characters "rld" in bold

In Source view, we'll have something like <p>hello wo<strong>rld</strong></p>

3/ Now we delete the substring "orld" and then retype orld

In source view : <p>hello w<span style="font-weight: bold;">orld</span></p>

We have the same kind of bug with the italic button Tested on FF 2.0.0.14 and FF 3RC1 with FCK 2.6

#2215 Copy textarea.tabIndex on ReplaceTextarea Confirmed Review+ Frederico Caldeira Knabben New Feature closed Normal
Description

The ReplaceTextarea method could copy the tabindex value from the textarea when replacing it. In this way we automate this feature.

#2218 Improve browser detection Confirmed Review+ Martin Kou New Feature closed Normal
Description

It seems that Epiphany browser is getting more and more popular recently. This browser is based on Gecko engine and is compatible with FCKeditor. However, as reported by yell0w at #fckeditor IRC channel: ​http://irc.fckeditor.net/index.php?date=2008-05-23 current implementation of browser detection doesn't detect it properly.

Epiphany introduces itself as 

Mozilla/5.0 (X11; U; Linux i686; en; rv:1.9b5) Gecko Epiphany/2.22

so searching for "Gecko/" fails.

Similar issue for FCKeditor.Java have been reported in #1744. There is another example of "user agent" that fails current browser detection: 

Mozilla/5.0 (X11; U; Linux i686 (x86_64); en-US; rv:1.8.0.2) Gecko/Debian-1.5.dfsg+1.5.0.2-3 Firefox/1.5.0.2
#2220 Encode email "mailto:" links Confirmed HasPatch Review+ New Feature closed Normal
Description

So far the email address typed in the link dialog gets packed as a href-attribute unencoded into the html source. This is easy for spambots to be scanned and so it is necessary to at least obscure the mail address. This proposal provides a possibility to encode the email address using the simple String.fromCharCode() technique.

We modify the file "editor/dialog/fck_link/fck_link.js" such that the method oParser.CreateEMailUri returns the email href-attribute not in plain text but encoded.

Replace the return statement of the oParser.CreateEMailUri method 

  return sBaseUri + sParams ;

by 

  var uri = sBaseUri + sParams ;
  var urj = '' ;
  for ( var i = 0; i < uri.length; i ++ ) {
    if ( i > 0 ) { urj += ','; }
    urj += uri.charCodeAt(i) ;
  }
  return 'javascript:location.href=String.fromCharCode(' + urj + ')' ;

As the "protocol" of the link is no more "mailto", we should implement also a decoder that from the encoded href-attribute gets back the email address as well as the subject and the body. This is important if the CKEditor user wants to edit again an encoded email link. This is not yet implemented.

#2221 Constant "database is locked" error on the dev site Confirmed DevSite Bug closed Normal
Description

The dev site (Trac) is throwing "database is locked" errors constantly, no matter the site load.

When this error happens, the page has to be refreshed several times until it works.

#2222 EditTools do not work with FCK Confirmed Bug closed Normal
Description

Any content within the EditTools, which uses JavaScript (via the ​CharInsert extension) to add data to the editing box, cannot be added to the edit box when the FCK editor is in use. When the extension is disabled, it works fine, however.

#2224 page not found error for specific string Confirmed Bug closed Normal
Description

Entering the following string in FCKEditor and submitting the form results in a page not found error:

insert locks from [anything]

where [anything] can be any string

#2234 DIV container tool Confirmed Review+ Martin Kou New Feature closed Normal
Description

Currently there is no way to create a <div> which embraces a series of block elements. For example, producing the following output: 

<div class="MyDiv">
    <p>Para 1</p>
    <p>Para 2</p>
</div>

The current style system always see <div> as a block element, and therefore, when applying <div> based styles, it converts current blocks to <div>.

The idea would be creating a dedicated button for it. It would behave much like the Blockquote button, but it should have a dialog containing the following fields, basically:

  • General Tab:
    • Style: a selection box listing all styles defined for <div> elements in the style system. We should create a reusable component that can be used on other dialogs, for tables, cells, links, etc.
    • Class: the "class" attribute.
  • Advanced Tab:
    • Id: the "id" attribute.
    • Inline Style: the "style" attribute.
    • Title: the "title" attribute.
    • Language: the "lang" attribute.
    • Text Direction: a selection for the "dir" attribute.

The only thing still pending to understand is how to edit a previously created <div> and how to delete it. Maybe it is the case to leave the edit and delete operations in the context menu only, while the toolbar button will always create a new <div>, making it possible to nest them.

#2238 Object placeholder is blank in compressed version Confirmed Review+ Frederico Caldeira Knabben Bug closed Normal
Description

Steps to Reproduce

  1. Open the ​nightly build.
  1. Paste any YouTube video in the source, like the following: 
<object width="425" height="355"><param name="movie" value="http://www.youtube.com/v/1suHskbL1pE&hl=en"></param><param name="wmode" value="transparent"></param><embed src="http://www.youtube.com/v/1suHskbL1pE&hl=en" type="application/x-shockwave-flash" wmode="transparent" width="425" height="355"></embed></object>
  1. Switch to WYSIWYG.

Note that the <object> placeholder is totally blank, instead of having the puzzle icon and the border. It is still selectable though, so it seems to be something related to the compressed CSS.

The "unpacked" SVN verstion (trunk) don't have this problem.

#2239 Remove <?= from php scripts Confirmed Bug closed Normal
Description

Reported on #fckeditor IRC channel by OZZlE.

When short_open_tag setting is disabled, <?= doesn't work. 

<?php echo...

should be used instead.

#2240 Editor doesn't support XHTML spec for inclusion of <div> <p> etc within a <li> list item Confirmed Bug closed Normal
Description

See Word example for the kind of formatting Travelers (our customer and a customer of your with current Support) are attempting to create. Ignore the blank paras between list items - clearly these should be removed and included as margin between the list items. It is the para following number 1. that is the particular problem.

HTML examples as follows:

Nested list without unnumbered para (from Word):

<ol type="1"> <li style="margin: 0pt; color: black"><span style="font-size: 10pt">The following Exclusions are added to this Network Security Section </span> <ol style="margin-top: 0pt" type="a"> <li style="margin: 10pt 0pt 0pt; color: black"><span style="font-size: 10pt">Damage directly or indirectly caused by or resulting from any Computer or Telecommunication System used for the purpose of operating or controlling machinery or equipment and inter alia this exclusion shall exclude Damage directly or indirectly resulting from computer controlled building management systems security lighting security cameras and other security devices and fire protection devices </span></li> </ol> </li> </ol>

Nested list with unumbered para inbetween (from Word):

<ol type="1"> <li style="margin: 0pt; color: black"><span style="font-size: 10pt">The following Exclusions are added to this Network Security Section </span></li> </ol> <div style="margin: 0pt 0pt 0pt 36pt"><span style="font-size: 10pt; color: black">The insurance provided under this Network Security Section does not cover</span></div> <ol type="1"> <ol type="a"> <li style="margin: 0pt; color: black"><span style="font-size: 10pt">Damage directly or indirectly caused by or resulting from any Computer or Telecommunication System used for the purpose of operating or controlling machinery or equipment and inter alia this exclusion shall exclude Damage directly or indirectly resulting from computer controlled building management systems security lighting security cameras and other security devices and fire protection devices </span></li> </ol> </ol>

Nested list with unumbered para inbetween (manually edited to achieve valid XHTML):

<ol type="1"> <li style="margin: 0pt; color: black"><span style="font-size: 10pt">The following Exclusions are added to this Network Security Section </span><div style="margin: 0pt 0pt 0pt 36pt"><span style="font-size: 10pt; color: black">The insurance provided under this Network Security Section does not cover</span></div> <ol type="a"> <li style="margin: 0pt; color: black"><span style="font-size: 10pt">Damage directly or indirectly caused by or resulting from any Computer or Telecommunication System used for the purpose of operating or controlling machinery or equipment and inter alia this exclusion shall exclude Damage directly or indirectly resulting from computer controlled building management systems security lighting security cameras and other security devices and fire protection devices </span></li> </ol></li> </ol>

Example created in the Editor: nested list:

<ol type="1"> <li><span>The following Exclusions are added to this Network Security Section</span> <ol type="a"> <li><span><span style="font-size: 10pt; color: black; font-family: Arial; mso-fareast-font-family: 'Times New Roman'; mso-ansi-language: EN-GB; mso-fareast-language: EN-GB; mso-bidi-language: AR-SA">Damage directly or indirectly caused by or resulting from any Computer or Telecommunication System used for the purpose of operating or controlling machinery or equipment and inter alia this exclusion shall exclude Damage directly or indirectly resulting from computer controlled building management systems security lighting security cameras and other security devices and fire protection devices </span></span></li> </ol> </li> </ol>

Example created in the Editor: nested list with unnumbered para inbetween:

<ol type="1"> <li><span>The following Exclusions are added to this Network Security Section</span></li> </ol> <p style="margin-left: 40px">Unnumbered para inbetween.&nbsp;</p> <ol type="a"> <li><span><span style="font-size: 10pt; color: black; font-family: Arial; mso-fareast-font-family: 'Times New Roman'; mso-ansi-language: EN-GB; mso-fareast-language: EN-GB; mso-bidi-language: AR-SA">Damage directly or indirectly caused by or resulting from any Computer or Telecommunication System used for the purpose of operating or controlling machinery or equipment and inter alia this exclusion shall exclude Damage directly or indirectly resulting from computer controlled building management systems security lighting security cameras and other security devices and fire protection devices </span></span></li> </ol>

It generally seems to be very hard to workaround this problem, even in the Editor. Travelers are wanting a solution that allows users to create freetext clauses in XHTML without needing to understand and code in XHTML. However, their developers can't workaround this issue, hence the ticket.

#2243 File endings are incorrect in released packages Confirmed Wiktor Walc Bug closed Normal
Description

Reported by bitsfritz in #1667:

The *.pl and *.cgi files in FCKeditor 2.6 and nightly build still have dos style linefeeds (CRLF), so something went wrong.

#2247 SHIFT+SPACE to insert &nbsp; Confirmed Review+ Frederico Caldeira Knabben New Feature closed Normal
Description

Hitting SHIFT+SPACE should insert a &nbsp; in the editor.

#2248 FF: FCK.InsertHtml( '&nbsp;') inserts a plain space Confirmed Firefox Review+ Frederico Caldeira Knabben Bug closed Normal
Description

The FCK.InsertHtml( '&nbsp;') call inserts a plain space in the selection, instead of the proper &nbsp; char.

#2252 Setting to disable our custom menu Confirmed Review+ Martin Kou New Feature closed Normal
Description

There should be a configurable way to not use our custom context menu at all, leaving the default browser context menu to work.

The solution is already proposed at #311. I think the "BrowserContextMenu" setting name is better because it follows the already present "BrowserContextMenuOnCtrl" name.

#2253 Empty anchor tags being removed. Confirmed HasPatch Bug closed Normal
Description

If you make the code <a href="bob"></a> FCKeditor will eat it at it's first opportunity. Since this is perfectly valid code I'm pretty sure this was an introduced bug while trying to fix SF-BUG 1556878. They tried to fix the outcome not the cause and then removed perfectly valid xhtml in the process.

The easiest way to reproduce this is as follows:

  1. Start an FCKEditor.
  2. Go to source mode (in FCKEditor)
  3. Type in <a href="bob"></a> (note nothing in the contents area of the anchor)
  4. Go to WYSIWYG mode.
  5. Go back to source mode.

You'll find that your typing has vanished.

Here's the fix. The source file is editor/_source/internals/fckxhtml.js in function FCKXHtml.TagProcessors .

If you remove the following lines the "expected" behavior returns. 

                // Firefox may create empty tags when deleting the selection in some special cases (SF-BUG 1556878).
                if ( htmlNode.innerHTML.Trim().length == 0 && !htmlNode.name )
                        return false ;

The real code that gets run is editor/js/fckeditorcode_gecko.js and editor/js/fckeditorcode_ie.js .

It's a little tricky to edit this because the lines are huge. Remove the following text from both files and you'll be golden: 

if (B.innerHTML.Trim().length==0&&!B.name) return false;

I suggest this code somehow makes it into the codebase as a fix.

--

Jeffrey Hundstad

#2254 Malfunction in FCKSelection object Confirmed Review+ Martin Kou Bug closed Normal
Description

FCKSelection have 2 methods called: HasAncestorNode and MoveToAncestorNode. Both of theme have input parameter called nodeTagName of type string and as written in comments of this function the passed string should be written in upper case.

But in the code when check is done actual tag name never converted to upper case. 

if ( oContainer.tagName == nodeTagName ) return true ;

So if your edited HTML has tags written in lower case (like custom tags) this functions won't find the ancestor tag.

Hope you'll fix this small thing in next revision.

tank's

#2257 nested dialogs don't work correctly Confirmed Bug closed Normal
Description

Assume that in a dialog you want to show a mini-editor (ex: in the google maps plugin, being able to insert an image or link in the marker text).

So the process is: base editor, launches a dialog (let's name it base-dialog) that contains a minieditor (just another instance with a simplified toolbar).

If a dialog is launched from the minieditor, then there are several problems.

  • First time, the cover frame is show in the main editor, not covering the base-dialog. The insertion point in the minieditor is lost.
  • The second time it seems to work fine.
  • Close base-dialog, and launch it again. Now when you try to launch another dialog from the minieditor, it is shown behind the current base-dialog, and the game is over, you won't be able to get back to the main editor.

I think that at least the last part is important to fix. No matter what happens, no matter if there is any error, the user should be able always to close the dialogs and return back to its content (I mean: there might be other unknown circumstances where there's an error, but that shouldn't mean a reload of the page for the user).

#2261 [IE] @import in EditorAreaCss causes a javascript error in source view Confirmed IE Martin Kou Bug closed Normal
Description

I am having a similar problem as described here: ​http://www.fckeditor.net/forums/viewtopic.php?f=6&t=9345&p=24267&hilit=editorareacss+import#p24267

But my problem is a little bit different.
In my fckconfig.js I set the 

FCKConfig.EditorAreaCSS = 'mystyles.css' ;

then in mystyles.css I have the lines: 

@import "/includes/css/main.css"; 
@import "/includes/css/foo.css"; 
@import "/includes/css/bar.css"; 

html, body {
	text-align: left;
	background-color: white;
	font-size: 12px;
}

I do this because I have 3 css files I want my editor area to show up like. Once I do this, when I bring up my page that has the fckeditor textarea on it, I will do this:

  1. click in the textarea - the menu does not pop down - like it should.
  2. manually put the menu down
  3. click source button.
  4. don't make any changes and just click ok on the source popup window (yes i have my source set to pop up)
  5. you get a javascript error that says:

Permission denied fckeditor.html?InstanceName=[mytextarea name]&ToolBar=Basic

If I remove the @imports out of my mystyles.css file, it will work fine.

I also downloaded the nightly build for fckeditor on 6/8/2008 and tried reproducing this bug on that nightly build version too, and the bug is still there.

Please notify me once this is fixed so I can upgrade. For now, I'm sticking to 2.4.2 until this is resolved.

Thanks so much!!! -NS

#2263 Editor - anchor - java script error Confirmed IE Review+ Martin Kou Bug closed Normal
Description

Click the anchor button and give the name as test.then click source button.then return back from source(reclicking that source button).then click only one time undo button.then click source button.that time java script error is occoured.This problem only in ie. Firefox is having no problem

#2272 FF3: Paste from word leaves lots of garbage tags Confirmed Firefox3 Review+ Martin Kou Bug closed Normal
Description

In Firefox 3 RC3, the "paste from word" feature leaves lots of garbage tags behind. Specifically:

  • It does not remove comments.
  • It does not remove <style> elements.
  • It does not remove <meta> elements.
  • It does not remove <link> elements.

The comments issue can be fixed by changing this line in fck_paste.html's CleanWord function: 

html = html.replace(/<\!--.*?-->/g, '' ) ;

...to this: 

html = html.replace(/<\!--[\s\S]*?-->/g, '' ) ;

(Because . does not match new lines, multi-line comments are not removed; [\s\S] does the trick instead.)

To be safe, I recommend making similar changes to all of the fck_paste.html instances where .* is used. Specifically, these lines: 

html = html.replace(/<o:p>.*?<\/o:p>/g, '&nbsp;') ;

html = html.replace( /<SPAN\s*>(.*?)<\/SPAN>/gi, '$1' ) ;

html = html.replace( /<FONT\s*>(.*?)<\/FONT>/gi, '$1' ) ;

html = html.replace( /<(\w+)[^>]*\sstyle="[^"]*DISPLAY\s?:\s?none(.*?)<\/\1>/ig, '' ) ;

html = html.replace( /<(H\d)><FONT[^>]*>(.*?)<\/FONT><\/\1>/gi, '<$1>$2<\/$1>' );
html = html.replace( /<(H\d)><EM>(.*?)<\/EM><\/\1>/gi, '<$1>$2<\/$1>' );

var re = new RegExp( '(<P)([^>]*>.*?)(<\/P>)', 'gi' ) ;	// Different because of a IE 5.0 error

...should be changed respectively to: 

html = html.replace(/<o:p>[\s\S]*?<\/o:p>/g, '&nbsp;') ;

html = html.replace( /<SPAN\s*>([\s\S]*?)<\/SPAN>/gi, '$1' ) ;

html = html.replace( /<FONT\s*>([\s\S]*?)<\/FONT>/gi, '$1' ) ;

html = html.replace( /<(\w+)[^>]*\sstyle="[^"]*DISPLAY\s?:\s?none([\s\S]*?)<\/\1>/ig, '' ) ;

html = html.replace( /<(H\d)><FONT[^>]*>([\s\S]*?)<\/FONT><\/\1>/gi, '<$1>$2<\/$1>' );
html = html.replace( /<(H\d)><EM>([\s\S]*?)<\/EM><\/\1>/gi, '<$1>$2<\/$1>' );

var re = new RegExp( '(<P)([^>]*>[\s\S]*?)(<\/P>)', 'gi' ) ;	// Different because of a IE 5.0 error

Also, to get rid of the <meta>, <link> and <style> elements, I suggest adding these additional replacements: 

// Remove meta/link tags
html = html.replace(/<(META|LINK)[^>]*>\s*/gi, '' ) ;

// Remove style tags
html = html.replace( /<STYLE[^>]*>([\s\S]*?)<\/STYLE[^>]*>/gi, '' ) ;
#2273 dragresizetable plugin is broken in FF3 Confirmed Firefox3 Review+ Martin Kou Bug closed Normal
Description

This bug was discovered while testing for #1614:

  1. Enable the dragresizetable plugin.
  2. Go to sample01.html in Firefox 3.
  3. Create a table.
  4. Try to resize its columns by draggable.
  5. It doesn't work, FF3 thinks you're wanting to drag the indicator .gif out of the document.
#2284 [FF] Table selection rectangle doesn't update Confirmed FireFox CantFix Bug closed Normal
Description

When you change the width of a selected table via the table-properties dialog, the selection rectangle doesn't get updated to the new width of the table.

#2287 Bad Spacing between two tables (FF2 Only) Confirmed Firefox Review+ Frederico Caldeira Knabben Bug closed Normal
Description

When you insert a table, click to the right side of it, and then add in a second table, it will display something like: 

<table>...</table>

<table>...</table>

within the editor, but when you preview (or after saving) it shows up like: 

<table>...</table>


<table>...</table>

The reason is that between the two tables, in the editor, there is a <p/> tag, which FF does not render. But when you preview/save, it is transformed into <p></p>.

You can see this in action at: ​http://www.screencast.com/users/DShafik/folders/Jing/media/d4769677-866b-4a5b-8d21-1aa0a31cd14c

This issue affects 2.5.1 (at least) through to, and including trunk

#2291 [FF3] simple copy & paste from Word document - extra code not stripped Confirmed Bug closed Normal
Description

You can check this bug by yourself trying to copy and paste (CTRL+C/V) some text from a Microsoft Word document using first FF2 and after FF3 in Demo FCKeditor pages.

In FF3, viewing the source code of the copied text, you can see some extra information that in FF2 is stripped (meta tags, xml and style definitions): 

<meta content="text/html; charset=utf-8" http-equiv="Content-Type" />
<meta content="Word.Document" name="ProgId" />
<meta content="Microsoft Word 11" name="Generator" />
<meta content="Microsoft Word 11" name="Originator" />
<link href="file:///[...]" rel="File-List" /><!--[if gte mso 9]><xml>
<w:WordDocument>
<w:View>Normal</w:View>
[...]
</xml><![endif]--><style type="text/css">
<!--
 /* Style Definitions */
[...]
</style>
<![endif]-->
#2296 Permission denied error when clicking on files in file browser under domain relaxation Confirmed Firefox Review+ Martin Kou Bug closed Normal
Description

Reproduction procedure:

  1. Open sample01.html under domain relaxation mode.
  2. Open the image dialog.
  3. Click "Browse Server".
  4. Click on one of the uploaded image files.
  5. Permission denied error.

This bug affects both Firefox 2 and Firefox 3.

#2297 The TAB key should move out of the editor if TabSpaces=0 Confirmed Review+ Frederico Caldeira Knabben Bug closed Normal
Description

We'll be working on the future on a complete reviewed support for the TAB key (see #979). Meanwhile, we should provide some basic features, and the ability to move out of the editor using TAB seems to be one of them.

#2302 transforming image to image button fails Confirmed Bug closed Normal
Description

If you have an image buttons, for example <input type="image" src="​http://www.fckeditor.net/images/logos.gif" />, then click 'Insert/edit image' and try to click ok in the dialog, you'll get a javascript error saying "e is null; editor/dialog/fck_image/fck_image.js; Line 274". (Tested in IE7 and Firefox 3.)

Also about the messages "Do you want to transform the selected image on a image button?" and "Do you want to transform the selected image button on a simple image?". Shouldn't they read "Do you want to transform the selected image into an image button?" and "Do you want to transform the selected image button into a simple image?" and be localizable?

#2307 RTL: Click on Link dialog tabs enlarge the dialog width Confirmed Firefox CantFix Martin Kou Bug closed Normal
Description

With FF3, when in RTL, like when loading the Arabic localization, if you click on a dialog tab the Link dialog enlarges on its width. Each click enlarges it s few pixels.

No problem with IE.

#2308 RTL: The scrollbar is at the right side for the toolbar combos Confirmed Firefox3 Safari CantFix Bug closed Normal
Description

All toolbar combos has the scrollbar at the right side with Firefox 3. FF2 show them at the left, as expected.

#2309 Small arrow for select items on toolbar combos are not RTL Confirmed Bug closed Normal
Description

In RTL mode, the small arrow indicating the selection of an item in the toolbar combos should be on the right. It is currently in the left, just like the LTR version.

#2311 IE: Dialogs are broken with server side samples Confirmed IE Review+ Martin Kou Bug closed Normal
Description

This is quite a strange bug. The dialogs are broken with server side samples, like ASP or PHP, since [2094]. The HTML samples are ok though.

#2314 Traditional and Simplified Chinese translations for Blockquote are mixed up Confirmed Review+ Martin Kou Bug closed Normal
Description

In Simplified Chinese translation file editor/lang/zh-cn.js, the Blockquote entry reads: 

 Blockquote			: "引用文字",

But that is actually Traditional Chinese.

Similarly, the Traditional Chinese translation file has the Simplified Chinese translation of Blockquote.

This is not a too serious defect however because most Chinese users can understand both versions, it just feels strange.

The bug was discovered when I was working on #2234.

#2316 Sample posted data page should have the table width at 100% Confirmed Review+ Frederico Caldeira Knabben Bug closed Normal
Description

If small data is posted by the editor, the posted data table shrinks to fit it. It should be instead always at 100% width.

#2320 FF3: Find/Replace scrolls the entire page Confirmed Firefox3 IE Review+ Martin Kou Bug closed Normal
Description

Because the Find/Replace code uses the "scrollIntoView" function, the entire page gets scrolled when highlighting the found elements. This is the same problem we had with #2279 and #2319, so maybe the same solution used there can be used here too.

#2321 FF3: FCK.InsertElement scrolls the entire page Confirmed Firefox3 Review+ Frederico Caldeira Knabben Bug closed Normal
Description

Because the InsertElement code uses the "scrollIntoView" function, the entire page gets scrolled when inserting new block elements. This is the same problem we had with #2279 and #2319, so maybe the same solution used there can be used here too.

#2322 Fit window command resets caret position Confirmed IE Firefox Safari Review+ Martin Kou Bug closed Normal
Description

To reproduce the bug:

  1. Open sample01.html in IE, Safari or Firefox.
  2. In either source mode or WYSIWYG mode, replicate the given paragraph a few hundred times so that the whole document is long enough to be scrollable in full window mode or in the original size.
  3. Scroll to the middle of the document, and select one of the "sample text" in one of the middle paragraphs.
  4. Press "Fit window".
  5. In IE, the selection is scrolled just below the visible area.
  6. In Firefox or Safari, the selection is totally lost, and the caret is placed at the beginning of the document.

Interestingly, the bug does not occur in Opera.

#2323 Show blocks command scrolls selection out of visible area. Confirmed Review+ Martin Kou Bug closed Normal
Description

To reproduce the bug:

  1. Open sample01.html in any supported browser.
  2. In source mode or WYSIWYG mode, copy the given paragraph a few hundred times so that the whole document is scrollable.
  3. Scroll to the middle of the document, select one of the "sample text" in one of those middle paragraphs.
  4. Press "Show Blocks".
  5. The selected text is scrolled out of the visible view pane.
#2327 fckpaste.html - escaping HTML inside Javascript (like #2056) Confirmed Review+ Bug closed Normal
Description

I am not allowed to reopen ticket #2056, so here is my report.

The problem is still present in "editor/dialog/fck_paste.html" line 67 :

</iframe> has to be replaced with <\/iframe>

#2334 [IE] XHTML namespace support broken Confirmed IE Bug closed Normal
Description

I have the following content:

<p xmlns="​http://www.w3.org/1999/xhtml">this is interesting</p>

On Firefox 3 this shows in the source as:

<p>this is interesting</p>

So FCKeditor has stripped out the xmlns declaration. OK. But then I create an editor on IE7 with the same comment. The source shows:

<p xmlns="​http://www.w3.org/1999/xhtml">this is interesting</p>

I then add the <em> tag around "is". This results in:

<p xmlns="​http://www.w3.org/1999/xhtml">this <em xmlns="">is</em> interesting</p>

This breaks my content. It won't even show up in the browser, as FCKeditor has taken <em> out of the XHTML namespace.

#2339 Pre-defined default values Confirmed New Feature closed Normal
Description

Add a feature that enables the installer of FCKeditor to add pre-defined properties to Toolbar elements.

For example: Step 1. The installer could add something like 

Toolbar.table.width = 400;

to 

fckconfig.js

Step 2. The user would edit a page with FCKeditor and insert a table and the width attribute would already be set to 400.

(I will use the table toolbar element from here on but ultimately it would be good to be able to set pre-defined properties for any toolbar element that has properties.)

Normally one would use CSS but what if we don't want all tables in the page to behave this way, only the tables inserted by users in FCKeditor?

For more information (notably my last post!): ​http://www.fckeditor.net/forums/viewtopic.php?f=5&t=5739

thanks, r

#2347 IE: The "id" attribute of <hr> elements get lost Confirmed IE Bug closed Normal
Description

Pasting the following code in the source: 

<hr id="test" />

Switching to WYSIWYG and back to source gives us: 

<hr />

Confirmed with IE. Ok with Firefox.

#2349 [IE] Dialog system is broken with rtl Confirmed IE Review+ Martin Kou Bug closed Normal
Description

When using RTL language on IE6, the new dialog system is broken (there are two scroll bars, and some of the dialog is missing).

The image attached is using the nightly build, with IE6 and 'he' in the accept_language.
Can be done also with: 

FCKConfig.AutoDetectLanguage	= false ;
FCKConfig.DefaultLanguage	= 'he' ;

in the fckconfig.js file.

#2356 IE7 Access Denied - Local Filesystem Confirmed IE7 Review+ Martin Kou Bug closed Normal
Description

Problem: Opening any of the html sample pages of FCKEditor from the filesystem in IE7 gives an "Access Denied" error coming from file fckeditor\editor\js\fckeditorcode_ie.js on line 62 with the code: "B.open("GET",A,false);".

This has been resolved by me in the post: ​http://www.fckeditor.net/forums/viewtopic.php?f=6&t=10424

Basically the native IE7 XmlHttpRequest Object appears to not allow requests on the filesystem. Here is the offending code causing the issues: (file fckeditor\editor\_source\internals\fcktools_ie.js)

FCKTools.CreateXmlObject = function( object ) {

var aObjs ;

switch ( object ) {

case 'XmlHttp' :

Try the native XMLHttpRequest introduced with IE7. try { return new XMLHttpRequest() ; } catch (e) {} bad for use on local filesystem

aObjs = [ 'MSXML2.XmlHttp', 'Microsoft.XmlHttp' ] ; use this instead for local filesystem break ;

case 'DOMDocument' :

aObjs = [ 'MSXML2.DOMDocument', 'Microsoft.XmlDom' ] ; break ;

}

for ( var i = 0 ; i < 2 ; i++ ) {

try { return new ActiveXObject( aObjs[i] ) ; } catch (e) {}

}

if ( FCKLang.NoActiveX ) {

alert( FCKLang.NoActiveX ) ; FCKLang.NoActiveX = null ;

} return null ;

}

#2357 PropertiesLoader Exception when undeploying a webapp using FCKeditor.Java Integration Confirmed Michael Osipov Bug closed Normal
Description

Hello
I think PropertiesLoader must be changed to something like this:

package net.fckeditor.handlers;
import java.io.BufferedInputStream;
import java.io.IOException;
import java.io.InputStream;
import java.util.Properties;
import org.slf4j.Logger;
import org.slf4j.LoggerFactory;

public class PropertiesLoader {
	private static final Logger logger = LoggerFactory.getLogger(PropertiesLoader.class);
	private static Properties properties = new Properties();
	static {
		try {
			InputStream in =PropertiesLoader.class.getResourceAsStream("default.properties");
			if(null == in) {
				logger.warn("Can't find default properties!");
			} else {
				properties.load(new BufferedInputStream(in));
				logger.info("Default's properties loaded successfully!");
				in.close();
			}
		} catch (IOException e) {
			logger.error("Error while loading default properties!", e);
			throw new RuntimeException("Can't load default properties!", e);
		} catch (NullPointerException e) {
			logger.error("Error while loading default properties!", e);
			throw new RuntimeException("Can't load default properties!", e);
		}
		try {
			InputStream in = PropertiesLoader.class.getResourceAsStream("/fckeditor.properties");
			if (null == in) {
				logger.warn("Can't find user properties!");
			} else {
				properties.load(new BufferedInputStream(in));
				logger.info("User's properties loaded successfully!");
				in.close();
			}
		} catch (IOException e) {
			logger.error("Error while loading user properties!", e);
			throw new RuntimeException("Can't load user properties!", e);
		} catch (NullPointerException e) {
			logger.error("Error while loading user properties!"+ e);
			throw new RuntimeException("Can't load user properties!", e);
		}
	}
	public static String getProperty(final String key) {
		return properties.getProperty(key);
	}
	
	public static void setProperty(final String key, final String value) {
		properties.setProperty(key, value);
	}
}



I just added in.close() because PropertiesLoader.class.getResourceAsStream throws an exception when i undeploy my webapps on glassfish ;)

#2362 Remove/Deselect style Confirmed Bug closed Normal
Description

This only happens on some styles. Once a style is selected, it can not be removed by re-selecting the style.

This can be shown by selecting the Red Title in the demo. I know that changing the format to normal will fix this particular example, however re-enabling the format field in my case is not an option.

#2368 IE: Protected source for comments is broken Confirmed IE Review+ Martin Kou Bug closed Normal
Description

The fix for #2263 is breaking source protection in IE SVN nightly.

To replicate:

  1. Click source.
  2. Add <!-- test --> to the source.
  3. Press Source again to revert to design mode.
  4. Press Source again, and you have a "null" cannot be null.
#2369 Updated Faroese language file 2008-07-15 Confirmed Review+ Frederico Caldeira Knabben Task closed Normal
Description

File fo.js is attached

#2376 FCKeditor should remember the last selection position when it loses focus in IE. Confirmed IE Review+ Martin Kou Bug closed Normal
Description

IE has a long standing bug in which it allows only a single selection position to exist within a window, no matter how many iframes and different pages are opened inside. This causes an annoying problem with FCK.InsertHtml():

  1. Open sample01.html in IE.
  2. Put the caret or selection in the middle of the text.
  3. Click on somewhere outside of the FCKeditor widget.
  4. Type in the address bar: 
    javascript: alert(frames[0].FCK.InsertHtml('abcd'));
  5. The "abcd" is inserted at the beginning of the document, which isn't right.

It should be possible to use the onbeforedeactivate event to save the selection position before FCKeditor is defocused.

#2378 Search for better options than EncodeConfig Confirmed Wiktor Walc Bug assigned Normal
Description

At this moment it seems not very intuitive hot to assign SkinPath in PHP. To achieve path pointing to: 

"/sub1/# CMS/sub2/"

ones have to assign: 

"/sub1/%2523 CMS/sub2/"

...there must be an easier way to do it.

#2381 Double Iframes for FCKeditor Confirmed Review+ Artur Formella Bug closed Normal
Description

Possibly asked and answered.

Sorry I don't have time to download and verify bugs, and I'm not sure what component this even belongs to.

We're using Drupal 5.6 with the 5.x-2.2-beta2 module of FCKeditor.

What I suspect is that the error is only visible with this combination.

What I know is the error is completely avoidable.

in fckeditor.js

in function FCKeditor.ReplaceTextarea()

Add the following code at the very beginning:

var oIFrame = document.getElementById(this.InstanceName + '_Frame');

if (!oIFrame) {

Then add the following code at the very end:

}

This protective if-block will prevent any duplicates from be formed, since the code inside that if-block creates the iframe with then name: this.InstanceName + '_Frame'.

Yes, it's probably the fault of some other library further up. Shouldn't matter. Code should do the right thing, and duplicate editors is bad. This won't appreciably affect speed of the component, and is a good thing.

If I'm reporting this the wrong way, sorry, if I'm reporting to to the wrong place, double my-bad. But there you go.

Jeff

#2385 Updates to the Swedish language file Confirmed Task closed Normal
Description

Update all missing translation in the swedish lang-file except two where I was unsure about the right translation

#2387 FF: Bulleted list error with CTRL+A Confirmed Firefox Review+ Martin Kou Bug closed Normal
Description

Tested with Firefox/2.0.0.16, in the online demo.

With the following source: 

<div>aaa</div>
<div>bbb</div>
<div>ccc</div>

In editing mode:

  1. select all (by pressing Ctrl+A)
  2. click "Insert/Remove Bulleted list"

A JS error is thrown and the first line of text is deleted.

#2389 Merge Cells removes attributes from tr in table Confirmed DataLoss Bug closed Normal
Description

When two cells are merged the class attribute on the tr(s) in the table is removed.

Steps to reproduce:

Click on the source button and remove the existing code and paste in the following 

<table>
    <tbody>
        <tr class="sample_class">
            <td>Test cell</td>
            <td>Test cell 2</td>
        </tr>
    </tbody>
</table>

Click the source button again to exit source view and click in the two cells. Right-click and select merge cells (or merge right). Click source again and the class attribute is removed from the tr.

This is reproducible in either the demo on FCKeditor.net or the nightly build. It reproduces in FF3, FF2, IE7, and IE6 and doesn't seem to be dependent on platform used.

#2394 Split Vertically - It blows up Confirmed IE Review+ Martin Kou Bug closed Normal
Description

Steps:

1- Add a new 3x3 table. 2- Point your mouse on the last corner cell (3,3). 3- Right click, and choose "Cell / Split Vertically".

The error "Invalid Argument" appears. The cell is not splitted.

#2395 InsertHtml() can prefix an additional annoying blank paragraph with IE Confirmed IE Pending Bug closed Normal
Description

If content being inserted is not being inserted into a block level element, but itself begins with a block level element (e.g. <p>insertion</p>), then this results in the extra blank prefixed paragraph.

Following are lines 165 through 173 (as of 07/19) of the InsertHtml() function in the 'internals/fck_ie.js' file. 

	// Using the following trick, any comment in the beginning of the HTML will
	// be preserved.
	html = '<span id="__fakeFCKRemove__" style="display:none;">fakeFCKRemove</span>' + html ;

	// Insert the HTML.
	oSel.createRange().pasteHTML( html ) ;

	// Remove the fake node
	FCK.EditorDocument.getElementById('__fakeFCKRemove__').removeNode( true ) ;

This 'trick' is what I find causing the extra beginning blank paragraph. I suspect that pasteHTML() is making the HTML valid by putting the span inside of a block level element (namely a <p> tag). Then the removal only removes the span thus leaving the extra paragraph. ( <p>&nbsp;</p> )

I'd prefer having to embed a beginning comment in a tag due to omitting this trick [which is what this ends up doing in this case anyway given <!-- comment --><p>insert</p> to get <p><!-- comment --></p><p>insert</p>] than have this paragraph added when inserting a block with no comment. In other words, this 'trick' semi-fixes so few cases (none in my case) with annoying expense for many use cases.

If preserving such comments is important, then replacing 'span' with 'p' (or 'div') works in this particular case, but unacceptably breaks inline insertions. Perhaps the appropiate way should be determined by looking at the parent element. I've tried using elements that can be either block or inline elements (e.g. object), but without success. They always get treated like inline elements. (also work like span) So, unfortunately a good solution for this problem isn't as simple as merely changing the tag.

#2396 SpellerPages can lead to Permission Denied errors with IE Confirmed IE Review+ Frederico Caldeira Knabben Bug closed Normal
Description

One set of steps to reproduce with IE7:

  1. Have an anchor tag in content.
  2. Use SpellerPages to correct at least one word.
  3. Press 'Link' button.

You then get Permission Denied error on line 357. This isn't a problem with FF. I've reproduced with IE7 and several FCKeditor versions from SVN back to version 2.4.3.

One way to work around it is to replace the SetHTML() [or SetData()] function in 'fck_spellerpages.html' with: 

oEditor.FCK.Commands.GetCommand('SelectAll').Execute();
oEditor.FCK.InsertHtml(document.getElementById('txtHtml').value);

(but with extra prefixed blank paragraph noted by ticket #2395)

I have NOT been able to reproduce by using SetData() in a much simpler, but very similar scenario (plugin) that replaces content containing an anchor tag. So, there seems to be more to causing this than just simply using setData() with content containing an anchor tag.

#2401 Croatian language file updates Confirmed Review+ Wojciech Olchawa New Feature closed Normal
Description

Updated hr.js file

#2402 Catalan language file updates Confirmed Review+ Wojciech Olchawa Bug closed Normal
#2405 japanese language file updates Confirmed Review+ Wojciech Olchawa New Feature closed Normal
#2406 Vietnamese language file updates Confirmed Review+ Wojciech Olchawa New Feature closed Normal
Description

Completed Vietnamese language file.

#2407 Applying the div tool from the toolbar to a list screws the list up Confirmed Review+ Martin Kou Bug closed Normal
Description

Applying the div tool from the toolbar to a list screws it up.

Type and select:

  1. foo
  2. bar
  3. roo

Then apply the div tool. Give it an inline style "border: 1px solid blue;".

Result:

paragraphs are added with contents of the li items. The list contains only spaces. The paragraphs are wrapped in the new div, but the list is outside the div.

tested both ie7 and firefox3

#2409 Language updates for Norwegian (no and nb) Confirmed Review+ Wojciech Olchawa New Feature closed Normal
Description

Updated language files for Norwegian (no) and Norwegian Bokmål (nb). It includes missing translations and corrected incorrect translations.

"Nummerert" (numbered) was misspelled (as 'numrert'), and has been fixed.

Some of the terms for form elements are incorrect, and I've replaced them with the established Norwegian terms for form elements.

All properties (line 134-148) have been changed as they are more correct in Norwegian. The word "Finn" (Find) has been replaced with "Søk" ('search'), as this is what is currently used in nearly all programs with Norwegian interface.

Some longer sentences have been rewritten as they were poorly written and I've also made some minor changes in other places.

#2410 Hindi language file updates for FCKeditor 2.6.3 Confirmed Review+ Wojciech Olchawa Bug closed Normal
Description

Added a few strings for the Hindi translation. SVN patch attached.

#2412 InsertHTML inserts at beginning of selection Confirmed Firefox Review+ Martin Kou Bug closed Normal
Description

This bug may be related to Ticket #2376. In FireFox 3 I see InsertHTML append to the beginning of a Selection, instead of replacing the Selection. Using FireFox 3 go through the same steps in ticket #2376.

#2417 Dutch language file updates Confirmed Review+ Wojciech Olchawa New Feature closed Normal
Description

Update of the dutch language file

#2419 MoveToAncestorNode does not return the correct node Confirmed Bug closed Normal
Description

This seems to be a problem in IE7 and Safari. FCK.Selection.MoveToAncestorNode does not return the correct node, or SelectNode doesn't properly select.

Steps to recreate:

  1. Edit source and add 
    <div><p><b>bbbbbbb</b><br /><i>iiiiiiiiiii</i></p></div>
    Switch back to the regular editor view.
  1. Select "iiiiiiiiiii".
  1. Run the following via the browser address bar: 
     javascript: alert(frames[0].FCK.Selection.SelectNode( frames[0].FCK.Selection.MoveToAncestorNode('DIV') ));
 javascript: alert(frames[0].FCK.InsertHtml('abcd'));
  1. View Source
    • IE7 has the following: 
      <div><p><b>abcd</b><br />&nbsp;</p></div>
  • Safari has: 
    <div><p>abcd</p></div>

Output should look like: 

abcd
#2420 Add SaveUndoStep() to SpellerPages Confirmed Review+ Martin Kou New Feature closed Normal
Description

After changeset 2286 from ticket #2396, inserting the following line before line 56 of fck_spellerpages.html could restore a feature omitted by the fix. 

  oEditor.FCKUndo.SaveUndoStep() ;
#2422 Czech language file for FCKeditor 2.6.3 beta Confirmed Review+ Wojciech Olchawa Bug closed Normal
Description

Czech language file for FCKeditor 2.6.3 beta

#2424 API to destroy instances Confirmed Bug closed Normal
Description

There must be a way to easily remove editor instances from the page, completely freeing resources used by those instances. This feature should be able to restore the <textarea> replaced by the instance, or remove it together with the editor.

← 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 →
Note: See TracQuery for help on using queries.
© 2003 – 2022, CKSource sp. z o.o. sp.k. All rights reserved. | Terms of use | Privacy policy