Custom Query

This is an umbrella ticket. It points to several tickets that must be completed and reviewed to properly move the CKEditor prototype to the CKEditor trunk.

Prototype SVN

The prototype can be checked out from the following URL:
​https://svn.fckeditor.net/CKEditor/branches/prototype

The Review Process

Each ticket will identify a set of files that are under review, or even specific functions. We'll not have the usual patches on those tickets. The files are to be grabbed from the prototype branch.

The review keywords (Review?, Review+ and Review-) will continue to be used here. The ticket will be closed on Review+ (by the original developer), just like a usual commit operation.

The reviewer may make direct changes to the branch code if he feels it is ok. In such case, he should point out that some parts of the code are ok, but changes should be made, pointing to the changeset that included the changes, explaining them. At this point, the ticket must also have Review+, but the original developer must review the reviewer changes to ensure they are correct before closing the ticket. If anything is wrong, further changes are to be committed and Review? is called again, here again pointing to the changeset with explanations. This process should be repeated until all parts are satisfied with the results.

Things to Review

• Specifications: the idea behind the feature must be good. The ​ODE documentation may be used as a reference, but can also be questioned.
• Functionality: the code must do what it's intended to do.
• Coding Style: the syntax must respect our ​Coding Style Guidelines. Don't be afraid to correct small things, like a space before a semicolon, or extra tabs.
• Performance Optimizations: our code must run as fast as possible. Here again, micro-optimizations are welcome.
• Code Simplification: less code is (usually) better. If something can be done in a simpler way, we must do it in that way.
• API Documentation: our entire code must be properly documented. The reviewer is invited to enhance it if needed.
• Tests: each single piece of the code must have well written tests to ensure its efficiency. If the present tests are not enough, the reviewer should explain that the code looks good, but the tests are not. The reviewer is invited to write missing tests.

Current Development

The prototype will be on continuous development during the review process. It will be moved to the trunk as a whole, as soon as this ticket gets closed. The development over the prototype branch will end then.

If the development touches code that has already been reviewed, its relative ticket must be reopened and the review must be requested again, possibly pointing to the changeset that introduced the changes to be reviewed. If the review request is open, changes must be added to a comment, so the reviewer can get notified of it.

Tickets Under Review

Several keywords will be used to identify tickets that are under review. These keywords will group the tickets in the following lists:

Structural and Development Features

Base Features

Core Features

Plugins

No results

Other

Currently, we are placing all language entries into a single object definition in the main en.js file. We are ending up with a long list of keys with strings associated to then, just like we have in FCKeditor.

We are again using prefixes to group related keys in this long dictionary. So we have things like dlgTableTitle, dlgReplaceTitle and dlgFindTitle, each one being a reference to the specific dialog title.

We have now the chance to review the way we define this dictionary. We can make it easier to maintain, simpler to read and even smaller in size by grouping things inside an object "tree". For example:

CKEDITOR.lang['en'] =
{
	link :
	{
		button : 'Link\u200b',
		dialog : 'Link',
		info : 'Link Info',
		target : 'Target',
		...

		unlink : 'Unlink',
		...
	},

	specialchar : 
	{
		dialog : 'Select Special Character'
	},

	find :
	{
		dialogFindReplace : 'Find and Replace',

		find :
		{
			dialog : 'Find',
			button : 'Find',
			...
		},

		replace : 
		{
			dialog : 'Replace',
			button : 'Replace',
			findLbl : 'Find what:',
			replaceLbl : 'Replace with:',
			...
		}
	},

	...
};

Note that I've used the plugin name as the main grouping object for each set of entries. I think this is the best way to do that, even if we have a single entry for each plugin (avoiding issues if we need further entries in the future).

We should be then able to simply call things like editor.lang.link.button to grab the relative string, instead of {{{editor.lang.linkButton))).

Also note that prefixes like "dlg" are also to be avoided. Most of the language entries for dialog based plugins are dialog related things, so there is no sense on prefixing all of them with "dlg".

Artur says he needs it for completing the Flash dialog, I should finish it on Monday by porting it from v2.

To reproduce the bug:

1. Open replacebyclass.html in the samples in Firefox 3.
2. Also open ​http://gplv3.fsf.org/ in Firefox 3.
3. Copy everything in FSF's page into the editing area.
4. Click "Source" - the browser freezes.

This is not a performance problem with the new code - I've tried pasting the long text of GPL v3 in the editor area and the speed of switching to source mode is noticeable faster than v2.

Preliminary tests showed that the infinite loop is from the HTML data processor plugin.

To reproduce:

1. Open the replacebyclass.html sample in IE6.
2. Add a default 2x3 table there.
3. Switch to source mode.
4. The HTML source for the table is seemingly not there... but it's only because the source mode text area is too small and is having s scroll bar.

To reproduce:

1. Open replacebyclass.html sample in IE6.
2. Click anywhere in the paragraph within the editing area.
3. Switch to source mode.
4. You get something like this, note the _cke_expando attribute - it shouldn't be there:

   <p _cke_expando="125">
   	This is some <strong _cke_expando="124">sample text</strong>. You are using <a href="http://www.fckeditor.net/">FCKeditor</a>.</p>
   

Sharing CKEDITOR.plugins.fakeobjects as a namespace means the fake object types are shared across editor instances, which isn't desirable. Instead, CKEDITOR.plugins.fakeobjects should be a class which is instantiated for each editor instance.

This bug cause image invisible when switching between two modes,witness on IE7.

1. Open an editor instance and insert any visible image
2. Switch to 'sourcearea' mode
3. Switch back to 'wysiwyg' mode
   • Expected: nothing changed
   • Actual: image invisible, because of attribute 'src' was converted to 'url'

Run the following code in Firebug, with replacebyclass.html sample opened:

var editor = CKEDITOR.instances.editor1;
var o = new CKEDITOR.dom.element('object', editor.document);
o.append(new CKEDITOR.dom.element('embed', editor.document));
var i = editor.fakeobjects.protectElement(o);
editor.document.getBody().append(i);

An object with an embed tag inside is inserted to the document. Now switch to Source mode. The HTML output reads like this:

<p>
	This is some <strong>sample text</strong>. You are using <a href="http://www.fckeditor.net/">FCKeditor</a>.</p>
<object><embed></object>

Note the <embed> tag doesn't have a closing tag, and it's not self closing.

The default configurations for each plugin must be defined inside each plugin.js file, not into the core config.js file. Just core settings should go into that file.

The motivation behind it is that the core config.js file will be always part of the compressed version of CKEditor. So, if I reduce the number of plugins when building the compressed version, I should not have plugin specific stuff being included in the process.

Several of the dialog based plugins have been created with a standard "defaultValues" setting, which defines the default values to be used on dialogs.

The idea behind this is quite nice, as it makes it easy to set such values. This is a common request we have. But, the implementation took the easy way, which is not the best unfortunately.

The critical fact around this solution is that it makes our code bigger, and we must always keep in mind that our compressed code must be as small as possible.

But, we still need to support such customization. This is something Alfonso has described in #1099.

The nice thing is that it's already possible to do that by using our new API. Martin is working on a new sample for #2790, which will show how to do that.

So, we should remove this stuff from the configuration to benefit our code size.

Just like in #2792, we should not have specific setting to hide dialog tabs (like showAdvancedTab). We have inherited some of them from FCKeditor, but those should not be necessary anymore.

To reproduce:

1. Open replacebyclass.html in Firefox 3.
2. Double click on the empty area to the right of the first paragraph to select the whole paragraph.
3. Try to apply any style, e.g. press the bold button.
4. It doesn't work.

The skin.js file for the default skin makes references to CKEDITOR.dialog, assuming that it will be always loaded, which is false.

Anything into core should depend on a plugin.

Into the default skin.js file, we can find references to CKEDITOR.dialog.setMargins and CKEDITOR.dialog.on( 'resize' ). This is bad, because it assumes that all editor instances are using a single skin, which is false.

All settings must go inside each single editor instance. Also, events like "resize" should be fired by each instance. The event could be named "dialogResize", for example.

The current implementation of insertHtml and insertElement could be simplified. Also, it includes the insertion logic inside the editingblock plugin, which is wrong.

Line 395 in _source/plugins/dialogui/plugin.js refers to an unbound "this" in an inner function. This causes errors when the dialog system is creating radio button groups in dialogs.

To reproduce:

1. Open replacebyclass.html
2. Run the follow script in any JavaScript console or in the URL bar:

   CKEDITOR.instances.editor1.openDialog('testOnly');
   

3. JavaScript error.

This is something we though would be good, but I've just found out that it's evil. We must not use namespaces to organize the configurations under CKEDITOR.config, like CKEDITOR.config.dialog.magnetDistance.

The reason why is that, if you try to change this setting in a custom configuration file (like the root config.js), the namespace (CKEDITOR.config.dialog) will not yet be available, because the dialog plugin will not yet be loaded. So, the execution breaks.

We should still organize the configurations in a meaningful way, so I'm opting to use a "prefix", instead of a namespace there. In the above case, we would have CKEDITOR.config.dialog_magnetDistance.

Steps to reproduce: -Open sample.html?sample=replacebyclass -Click Source -Click Smile button

Result: JS Error and cancel button doesn't work.

this.document is null
http://localhost/edytor/CKEditor/trunk/_source/plugins/selection/plugin.js
Line 219

Steps to Reproduce

1. Load the editor.
2. Select some text.
3. Switch to source.

In IE, and error is thrown. No problem with FF.

This feature request came from Senthil Kumaran of Oracle.

It is possible for some CKEditor users to have a lot of custom plugins written inside a single plugin.js file. Right now it is impossible for CKEditor to do so because even if you've defined a number of plugins pointing to the same path, like:

CKEDITOR.plugins.addExternal( 'my_plugin_1', 'file:///c:/my_plugins/' );
CKEDITOR.plugins.addExternal( 'my_plugin_2', 'file:///c:/my_plugins/' );
CKEDITOR.plugins.addExternal( 'my_plugin_3', 'file:///c:/my_plugins/' );
CKEDITOR.plugins.addExternal( 'my_plugin_4', 'file:///c:/my_plugins/' );

And instructed the editor to initialize all of them:

config.plugins += ',my_plugin_1,my_plugin_2,my_plugin_3,my_plugin_4';

The editor would still only initialize one of the plugins, because it thinks it has already done the initialization for ​file:///c:/my_plugins/plugin.js after the first init() call. Subsequent plugin initializations are ignored right now.

This feature request came from Senthil Kumaran of Oracle.

At the moment CKEDITOR.plugins.addExternal() is only able to load plugins whose filename is plugin.js, because the plugin.js filename is hardcoded into the plugin system.

It is requested that the addExternal() should be able to load arbitrary .js filenames as plugins, e.g. "/my_plugins/abcde.js".

There is a common repetition in the current code:

var command = editor.getCommand( name );
command.state = newState;
command.fire( 'state' );

This logic could be encapsulated inside the CKEDITOR.command class, so we can achieve the same thing with:

editor.getCommand( name ).setState( newState );

If you define the initial command state into the command definition, it is not currently respected when loading the editor and rendering the toolbar buttons. All buttons are always in the "on" state.

The buttons should instead reflect the command state.

Event delegation registration with CKEDITOR.event.implementOnis currently incorrect, when this method is invoked on prototype object of a constructor, then instances of this constructor will share the same private _.events model, which is wrong. This would result in duplicate invocation of event listeners from two different object.

Functonal TestCase

Tested with test-events-duplicate.path

When adding a new numbered list at the end of the document, the list item is inserted correctly but the carat is positioned before the first list item and it is not possible to navigate to the first list item within WYSIWYG mode.

Steps to reproduce:

1. Open nightly build. Currently (​http://nightly.ckeditor.com/3105/_samples/replacebyclass.html)
   
2. Add new line to the existing text in the editor
   
3. Insert numbered list
   

Expected behavior: The new list is created with one item and the carat is positioned just after the number of the first item.

Actual behavior: The new list is created as expected. The position of the carat is placed before the first item in the list. It is not possible to navigate to the first item in the list.

It is not possible to modify a table after it has been inserted into the document using the editor.

The panels of toolbar combos must have their upper left corner perfectly aligned with the lower left corner of the combo when opened. Currently they are a few pixels mispositioned to left and top.

In IE6 the toolbar combos panels have horizontal scrollbars.

When opening a toolbar combo for the first time, it's possible to briefly see its contents with no style which immediately gets re-rendered with the styles applied.

This is noticeable in Firefox only.

There is a really bad performance in the tasks being fired when the selection changes in the editor. To check it:

1. Clean load a sample.
2. With a mouse click, place the cursor inside any unformatted word, like "are".
3. Open the Firebug console and start a Profile job. Don't do anything in the editor, not even a mouseover in the toolbar buttons.
4. Click inside a bold word, like "sample". Again, don't do anything else in the editor.
5. Stop the Profile job.

The profiler will show you an excessive number of calls.

In IE6 this bad performance is terribly noticeable, compromising the editor usage.

Performance excellence is definitely important for this feature.

This issue happens only after preparing the trunk for release, not with the trunk code. It can be checked in the ​nightly build demo.

You will notice that the toolbar buttons in the first editor instance will not change their state in any way. They will not reflect the context sensitiveness, not even the Source button will remain ON when moving to source.

The second instance will work well though.

IE is not able to manage multiple selection, even cross frame. Because of this, the current selection gets lost when leaving the editing area.

The current selection should be automatically saved when the editing area looses the focus in IE and then reselected when the focus is moved back to it.

By doing that, we can remove all selection hacks we are doing now for dialogs, floating panes, etc.

The current selectable elements( elements which could be retrieved from CKEDITOR.dom.selection.getSelectedElement) below is lacking of other control types like a,input,form.

var styleObjectElements = { img:1,hr:1,li:1,table:1,tr:1,td:1,embed:1,object:1,ol:1,ul:1 };

There exists a large amount of legacy dialogs written for FCKeditor 2.x in the wild that are based on raw HTML sources. CKEditor v3's dialog system is based on dialog definition objects defined in JavaScript files instead of HTML source files. So it's is now impossible to reuse those HTML source files directly for CKEditor v3.

However, it is possible to bridge the two together by displaying the HTML file via an iframe inside a CKEditor v3 dialog. The HTML file would still need to be changed to account for differences in layout and dialog logic, but the changes required would be minimized.

Currently, this has to be done by declaring an html type object in the dialog definition and writing out the iframe's HTML code into the dialog definition. This works, but it is very inconvenient.

Proposed changes to the dialog system to make this easier:

// A new type of UI element definition for iframe
{
  type : 'iframe',
  src : 'http://somewhere.com/someplace.html',
  onContentLoad : functionRef
}

The contents in the iframe should be reloaded for every time the dialog is opened. And the onContentLoad function should be executed after the contents of the iframe is loaded.

After implementing the iframe UI element, one more shortcut will still be needed to directly add dialogs consisting of solely an iframe - because that's the common case for using that element.

CKEDITOR.dialog.addIframe( 'dialogName', iframeSrc, iframeOnContentLoadFunction );

The combo features do not work in FF2.

Steps to reproduce:

1. Go to ​http://nightly.ckeditor.com/3121/_samples/replacebyclass.html
   
2. Select one of [Style|Format|Font|Size] Combo

Results in error.

Firebug error:
this.$ has no properties
​http://nightly.ckeditor.com/3121/ckeditor.js
Line 11

The coordinates returned from CKEDITOR.dom.element::getDocumentPosition is a few pixes shifted.

Because of the introducing of #3003, html parser should be able to take care different forms of abbreviation, e.g. attribute without quote and abbreviation.

With IE6, the following issues have been reported by Martin at #3057:

1. The size of context menus is incorrect at the first menus are opened.
2. The size of separators are incorrect.
3. Scrollbars appear in context menus when the mouse cursor is inside the menus.

The dialogs in CKEditor v3 are currently not accessible to users who have to depend on keyboard and screen readers.

Features needed:

1. Pressing TAB key when a dialog being displayed should never move the focus out of the dialog.
2. Users should be able to switch tabs using Ctrl-Tab.
3. When the user switches tab, it should be announced to him/her that a different tab has been selected.
4. Buttons should be focus-able, and JAWS should pronounce their labels when they're focused. It should be possible to "click" buttons via Enter.

Procedures

1. Open the replace by code example page;
2. Initial the document with the following content and selection:

   ^outter<table><tr><td>text</td></tr></table>outter^
   

3. Apply different fonts three times with the same range.

• Actual Result : The document result in:

  <span style="font-family: Courier New,Courier,monospace;">outter</span>
  <table>
  	<tbody>
  		<tr>
  			<td>
  				<span style="font-family: Courier New,Courier,monospace;">text</span></td>
  		</tr>
  	</tbody>
  </table>
  <table>
  	<tbody>
  		<tr>
  			<td>
  			</td>
  		</tr>
  	</tbody>
  </table>
  <span style="font-family: Courier New,Courier,monospace;">outter</span>
  

This happened to all block style function.

Procedures

1. Open the replace by code example page;
2. Initial the document with the following content and selection:

   ^	<p>text</p>
   	<ol>
   		<li>level1
   			<ul>
   				<li>level2</li>
   			</ul>
   		</li>
   	</ol>
   ^
   

3. Click on stylesCombo to open drop-down, select Blue Title option.

• Actual Result: The second level list item is not formatted.

  <h3 style="color: Blue;">
  	text</h3>
  <ol>
  	<li>
  		<h3 style="color: Blue;">
  			level1</h3>
  		<ul>
  			<li>
  				level2</li>
  		</ul>
  	</li>
  </ol>
  
  

Procedures

1. Open the replace by code example page;
2. Initial the document with the following content and selection:

   ^	text
   	<p>paragraph1</p>
   	<p>paragraph2</p>
   ^
   

3. Click on stylesCombo to open drop-down, select Blue Title option.

• Actual Result: The middle paragraph was left untouched.

  <h3 style="color: Blue;">
  	text</h3>
  <p>
  	paragraph1</p>
  <h3 style="color: Blue;">
  	paragraph2</h3>
  

Procedures

1. Open the replace by code example page;
2. Initial the document with the following content and selection:

   	<ol>
   		<li>level1</li>
   		<li>leve1
   			<ol>
   				<li>^level2</li>
   			</ol>
   		</li>
   	</ol>
   
   

3. Click on Outdent button to degrade list item once.
4. Click on Indent button to arise list item once.

• Actual Result: The previous list item was indented too.

  <ol>
  	<li>
  		level1
  		<ol>
  			<li>
  				leve1</li>
  			<li>
  				level2</li>
  		</ol>
  	</li>
  </ol>
  

When a user puts the tabindex attribute into a text area which is later replaced by a CKEditor instance, the user usually expects CKEditor to inherit the tabindex as well. This is not the case for the current trunk, and the bug is causing CKEditor to be impossible to be focused by TAB key when the user specifies tabindex.

It's currently quite troublesome for external plugins to configure the icon for their toolbar buttons: they must include a separate .css file, an icon file which the .css file points to, and instruct the plugin to load the .css into the editor's parent document.

There should be a better way to do this. Propose to add a function like this:

CKEDITOR.ui.button.setIcon( buttonName, iconPath );

Steps to reproduce:

1. Add 6 text areas in sample.html around the script tag with document.write( CKEDITOR.samples.htmlData ); - 3 text areas before it and 3 text areas after it.
2. Added tabindex attributes to the text areas as 1,2,3,5,6,7 respectively.
3. Add tabindex="4" to the textarea in replacebyclass.html.
4. Open replacebyclass.html in Firefox or IE.
5. Select one of the text areas before the editor, press tab until the editor is focused.
6. Press tab again.
7. The text boxes after the editor are skipped.

The skipping problem occurs also for Shift-Tab.

Regression testing shows that changeset of [3194] has breaked domrangeiterator.

To reproduce:

1. Open replacebyclass.html.
2. Type the following code in the URL bar:

   javascript: void((f=function(){alert('hi!');},body=CKEDITOR.document.getBody(),body.on('click',f)));
   

3. Click on the document body, you should see the message "hi!" appear once.
4. Now remove the event handler with the following code in the URL bar:

   javascript: void(body.removeListener('click',f));
   

5. Click on the document body, you should no longer see the "hi!" message.
6. Add the same event handler back to the document body.

   javascript: void(body.on('click',f));
   

7. Click on the document body.
8. Now you have 2 "hi!" messages - the previous event handler wasn't really removed!

This issue is blocking #3074.

In V2 it worked fine but in V3 opening of the toolbar dropdown controls fires the windiw.onbeforeunload. To reproduce this bug simply add the following JS code and try to open a toolbar dropdown. Probably it happens because the new version uses IFrame for the dropdown content.

<script>
window.onbeforeunload = function() {
	alert("window.onbeforeunload");
		//if(CKEDITOR.instances["content"].checkDirty())
		//	return "Page has not been saved!";
	}
</script>

Loading individual icon files one-by-one over HTTP is a very slow process and should be avoided. So we should allow our users to use icon strips in their plugins for toolbar buttons and context menus, like the following:

{
...
  icon : '/path/to/icon.gif',
  offset : 42
...
}

IE throws an error when clicking on the Styles combo.

The stylesCombo_stylesSet configuration entry is supposed to be able to load external style definitions via a colon separated syntax. e.g.

config.stylesCombo_stylesSet = 'mystyle:/path/to/mystyle.js';

The stylescombo plugin isn't loading the external JavaScript file for the definition, however.

1. Create several paragraphs of text.
2. Select text starting at one paragraph until the middle of the next one.
3. Apply any heading format.

An error is thrown and the style is not applied.

I can't reproduce this problem locally but it's seen in Senthil's demonstration this evening:

1. Give every input element and link in a form, which includes CKEditor as an input element, ascending tabindex-es.
2. Put the focus into CKEditor editing area.
3. Press Tab.
4. The focus goes to one tab index after the element that should receive the focus.

Image Plugin - Advanced tab's Id field is not getting added to the editor area. Ex: I have added id as '12345' but the result in the editor source is missing the id field,

<img align="absbottom" alt="Oracle" border="10" height="41" hspace="11" src="/cache/abc.gif" vspace="33" width="145" /><br />

We have a business logic that is using this id field. Since the id field is not populated, our functionality is broken.Please fix it as early as possible.

Request for multi-language files for all the features available in CKEditor 3.0

Reproducing Procedures

1. Open the replace by code example page;
2. Make document content and selection as following by double click on cell:

   <table>
   	<tbody>
   		<tr>
   			<td>^
   				text^</td>
   		</tr>
   	</tbody>
   </table>
   

   1. Open link dialog to insert a default link.
   • Actual Result : The link is not inserted at all.

Additional information: This is actually a style system bug. The same thing happens if you press the bold button or try to apply any inline style with the HTML and selection above.

External plugin files are often not named plugin.js, so that CKEDITOR.plugins.addExternal() don't work for them.

The current solution is that the web app developer using CKEditor would define a separate function called CKEDITOR_GETURL() that will scan for patterns of his files and output the correct URL.

While the approach works, it is still too complicated and error-prone for many web app developers. A simpler way is needed to enable external plugins with arbitrary file names to be loaded.

When we add any content inside the editing area it used to add a <p></p> tags but it is not happening in our environment. This is breaking our spell-check functionality and it is so critical for us and it needs to be addressed as early as possible for the 20th RC.

To reproduce:

1. Open replacebyclass.html in IE.
2. Select "You".
3. Change the font size to 8.
4. Select "You are using".
5. Change the font size to 16.
6. Move the caret to inside "You" by clicking on it.
7. While the font size is visually 16, a size of 8 is displayed in the size combo.

Similarly, selecting "Arial" in step 3 with the font combo and then "Comic Sans MS" in step 5 would also result in wrong font detection.

Reproducing Procedures

1. Open the replace by code example page;
2. Make document content and selection as following:

   <ol>
   	<li>
   		level1 ^</li>
   </ol>
   text
   

3. Press Enter key
   • Actual Result :

     <ol>
     	<li>
     		level1 <br />
     	</li>
     </ol>
     text
     

   • Expected Result :

     <ol>
     	<li>
     		level1 </li>
     	<li>
     		<br />
     	</li>
     </ol>
     text
     

Reproducing Procedures

1. Open the replace by code example page;
2. Delete all the content within document;
3. Open flash dialog and fill in url with : ​http://f.friendster-tweakers.com/rsc/swf/clock/fsdbp.swf, specify width with '100', height with '100', click Ok to insert the flash.

• Actual Result : The style is been attached to the wrapping paragraph element.

  <p>
  	<p height="100" width="100">
  		<object classid="clsid:d27cdb6e-ae6d-11cf-96b8-444553540000" codebase="http://download.macromedia.com/pub/shockwave/cabs/flash/swflash.cab#version=6,0,40,0" height="100" width="100"><param name="quality" value="high"></param><param name="movie" value="http://f.friendster-tweakers.com/rsc/swf/clock/fsdbp.swf"></param><embed height="100" pluginspage="http://www.macromedia.com/go/getflashplayer" quality="high" src="http://f.friendster-tweakers.com/rsc/swf/clock/fsdbp.swf" type="application/x-shockwave-flash" width="100"></embed></object></p>
  	<br />
  </p>
  

• Expected Result :

  <p>
  		<object classid="clsid:d27cdb6e-ae6d-11cf-96b8-444553540000" codebase="http://download.macromedia.com/pub/shockwave/cabs/flash/swflash.cab#version=6,0,40,0" height="100" width="100"><param name="quality" value="high"></param><param name="movie" value="http://f.friendster-tweakers.com/rsc/swf/clock/fsdbp.swf"></param><embed height="100" pluginspage="http://www.macromedia.com/go/getflashplayer" quality="high" src="http://f.friendster-tweakers.com/rsc/swf/clock/fsdbp.swf" type="application/x-shockwave-flash" width="100"></embed></object>
  	<br />
  </p>
  

In IE:

1. In the sample.html file, set the document.domain to a part of the URL. For example, my local testing url is "dev.ckeditor.local", so I'm setting it to "ckeditor.local".

2. Open a sample.

3. Open a toolbar combo, color selector or the context menu.

An error is thrown: "Access denied".

1. open the Replace dialog and write any word in Find what.

2. Hit the Tab button.

Result: the word disappears.

The dialog system is currently tightly coupled with the default skin, which makes it difficult to change the skin to something else.

Fred has written a patch for fix this. The patch involved quite a number of drastic changes, however, which resulted in some functional bugs still to be fixed:

• Tabs are not working.
• Footer buttons not always get aligned right with IE.
• Dialog size in Safari 3 when tabs are displayed.
• Dialog drag-move, in general, specially in IE.

And then the CKEDITOR.dialog.setMargins() should be moved to skin.js as part of the skin definition.

During some tests with our so loved and weird IE, I was able to, somehow, end up with an innerHTML that I was able to reduce to the following:

<TABLE>
	<TR>
		<TD></TD>
		<P></P>
		<TD></TD>
	</TR>
</TABLE>

I can't recall how I got that HTML (maybe during some block styling task), but the fact is that a user may have such thing while using the editor in IE. The browser simply accepts it.

The big problem is not the above though. The real issue is the, if you try to retrieve the above HTML from the editor, or even feed it into the source view, it will throw you "Out of memory" into the html parser code.

After #3191, the dialogs are not anymore correctly centered when opened.

To reproduce:

1. Open replacebyclass.html in IE6.
2. Open any dialog - e.g. the table dialog.
3. A translucent "The page cannot be displayed" screen is seen behind the dialog.

Currently, it's not possible to have a skin placed outside the "skin" folder into editor installation path.

Currently, the UI doesn't offer full support for RTL.

To reproduce:

1. Add Tab_Issue.2.html to the _samples directory of SVN trunk.
2. Compress the trunk with CKReleaser.
3. Open Tab_Issue.2.html within the release package.
4. Press Tab and Shift-Tab from inside the editing area, you'll see different buggy behaviors described in #3132.
5. Press Ctrl-B in the editing area. You'll see other buggy behaviors depending on the browser.

When focus is brought into CKEditor's editing area in our samples right now, the voice readout by JAWS is typically like this:

"Output, CKEditor Editor 1, type in text"

Output is the outer frameset's title in our sample pages. CKEditor is always read to tell the user that they're in CKEditor. Editor 1 is the editor instance's name.

It is more descriptive for screen reader users if the CKEditor part of the readout is changed to "Rich Text Editor" - so they'll know what to expect, instead of hearing a name which they may or may not understand immediately.

To reproduce:

1. Apply the patch to #3204 to the current SVN trunk to make dialog work in IE.
2. Open replacebyclass.html in IE6.
3. Drag the dialog around.
4. The dialog cannot be dragged out of bounds on the top and left - which is correct.
5. But the dialog can be dragged out of bounds on the bottom and right.

The default skin, "v2" for now, is not being properly loaded once the editor gets released.

To reproduce:

1. Open replacebyclass.html in IE.
2. If the focus is inside the editing area, click outside of it to defocus.
3. Copy some random text into clipboard.
4. Click the "Paste as Plain Text" button.
5. The text is pasted into the parent document.

The _samples/samples.js file is support file used by the development version of CKEditor. It's not needed at all after release, but it's still included in the sample files.

It must be removed during release, as well as its inclusion at the samples headers.

To reproduce:

1. Start JAWS 10.0 for Windows.
2. Open replacebyclass.html in Firefox or IE.
3. Open any dialog.
4. Tab until any dialog button is focused.
5. Enter.
6. Nothing happens.

The Enter key works when JAWS isn't opened. This is due to JAWS intercepting the Enter key event.

To reproduce:

1. Open replacebyclass.html in Windows Firefox.
2. Double click on the first word "This ".
3. Click the Bold button - the text is bolded.
4. Double click on the second word "is ".
5. Click the Bold button again.
6. Nothing happens.

If scrolling down the main page, when clicking on a dialog based button the page scrolls up to the top.

Confirmed with FF at least.

Currently, CKEditor offers a way to provide the toolbar definition by setting it directly to the "toolbar" setting.

While that is useful, it would be still nice to have more than one toolbar definitions in the configuration file, making it possible switching them with a simple setting, just like V2.

The idea would be introducing the "toolbarSets" object setting, which accepts several definitions, and then make the "toolbar" setting smart. If it receives a string, its the toolbarSet name, otherwise it's a toolbar definition.

Many times, but now always, dialogs open outside the viewport, over the top of it. I has been easily reproducible with the Link dialog.

Reproducing Procedures

1. Open the replace by class example page;
2. Make the following content with selection:

   <ul>
   	<li>^text^</li>
   	<li>text</li>
   </ul>
   

3. Click on 'Bold' to apply style
   • Actual Result:

     <ol>
     	<li>
     		<strong>text</strong></li>
     	<li>
     		<strong>text</strong><br />
     	</li>
     </ol>
     

• Expected Result :

  <ol>
      <li>
           <strong>dddddd</strong></li>
      <li>
            dddd</li>
  </ol>
  

Reproducing Procedures

1. Open the replace by class example page;
2. Click on 'Link' button to open dialog
   • Actual Result: Dialog is not centered in the screen.

Reproducing Procedures

1. Open the replace by class example page;
2. Make the following content with the selection by click and drag over table cells;

   <table border="1" cellpadding="1" cellspacing="1" style="width: 200px;">
   	<tbody>
   		<tr>
   			^<td>
   				text</td>
   			<td>
   				text</td>^
   		</tr>
   	</tbody>
   </table>
   

3. Click on 'Justify Right' to apply alignment.
   • Actual Result: Javascript Error occurred.
   • Expected Result:

     <table>
     	<tbody>
     		<tr>
     			<td style="text-align: right;">
     				text</td>
     		</tr>
     		<tr>
     			<td style="text-align: right;">
     				text</td>
     		</tr>
     	</tbody>
     </table>
     

In office 2003 skin, Dialogs are not displayed in the center of the page. Also the border of the dialog boxes needs to be removed in Office 2003 skin.

This issue happens in firefox and safari.

Hot Key crashes IE 7. Below the steps to reproduce.

Note: Assume "This is some sample text" is exist in the editor area.

1. Select the first word "This" and press ctrl+B.
2. Select the second word "is" and press ctrl+B twice or thrice.
3. Now you can see the browser is being crashed.

When i change the default language from English to French or anything, drop down menus(Style, Format and Font) are not translated and still shows in english.

Our DOM API currently forces the creation or the _cke_expando property for every DOM object created.

In IE, this property becomes an attribute into the DOM. So, this situation is causing a huge performance impact in the code.

-Put the cursor in

-Hit enter key 3 times

Expected result: 2 new lines in "using" word.

Actual result: 1 line in, 1 after.

In IE, a js error is being thrown when opening the Link dialog.

Currently the editor is outputting HTML code like this for block tags:

<p>
	This is some <strong>sample text</strong>. You are using <a href="http://www.fckeditor.net/">FCKeditor</a>.</p>

The newline after the <p> tag is breaking the HTML validator at Oracle, which is expecting 2.6.x HTML syntax. There should be some option to stop the newline from being outputted at the code formatter to preserve backward compatibility.

checkStartOfBlock is broken, returning "true" for the following case:

<p>Test^</p>

checkEndOfBlock is the opposite. It's broken, returning "true" for the following case:

<p>^Test</p>

1. Load a sample.
2. Select "some sample".
3. Apply the "Strike Through" style.

Result: only "some " get styled.

To reproduce:

1. Open replacebyclass.html in any supported browser.
2. Put caret on the first paragraph.
3. Press Create/Remove Numbered List button - a list is created as expected.
4. Press Create/Remove Numbered List button again - a JavaScript error appears.

The error seems to have to do with recent changes to DOM node custom data logic.

The latest Ajax sample in the nightly build (3350) causes errors when creating an instance of the editor.

Once the editor has been created it is not possible to apply any of the styles from any of the combo features.

When an attempt is made to apply a style by selecting some text and using one of the combo features, another error occurs.

This is issue is specific to IE6 & IE7

1. Having the following selection:

Some <strong>sample^</strong> text.
OR
Some <strong>^sample</strong> text.

2. Press CTRL+B.

The entire work gets un-bolded, instead of simply disabling it (moving the selection to outside the touching boundary).

This issue is more often faced when typing, using CTRL+B to type a word, and then CTRL+B again to continue writing.

When i call the addIframe method, browser returns an error as "addIframe is not a function"

As per the discussion with Martin, to use this function i have to add iframeDialog plugin to my config.Toolbar. Yes, this can be added to the default config file but our customer will be overriding this default config file with their own custom config file. Thus addIframe will not work for the customer since they have overidden the default config file.

Our existing 2.6 plugins are using the following code to render the dialog: Ex: FCKCommands.RegisterCommand( 'CustomLinks', new FCKDialogCommand( 'Oracle', 'Oracle',URL, 700, 600 ) ) ;

But in CKEditor3.0, i couldn't invoke the addIframe method since it is not available by default.

To support the 2.6 plugins, please make this function available by default.

If the editor is placed inside a floating element with z-index, all floating panels (combos, context menu and color buttons) will stop working. Actually, they will be loaded "behind" the floating element (and the editor).