Custom Query

Some more items are added for ko.js

With

FCKConfig.EnterMode = 'br' ;
FCKConfig.ShiftEnterMode = 'p' ; (or same on 'div')

Shift + Enter make <br>

If I click on the button, FCkeditor produce

<td style="margin-left: 20px">text...</td>

So you can't see the indentation.

The layout of floating dialogs are broken when opened in Firefox 3.0 beta 2. Specifically, the bottom button row is broken in FF3.

I've just updated from version 2.4.3 to version 2.5.1.

I noticed that in a table with a thead en th-cells the contextmenu doesn't work when right-clicking in de last (bottom) row.

Example:

<table title="Tabel" cellspacing="0" cellpadding="0" summary="Tabel">
    <thead>
        <tr>
            <th scope="col">nummer</th>
            <th scope="col">Onderwerp</th>
        </tr>
    </thead>
    <tbody>
        <tr>
            <td>1</td>
            <td>abc</td>
        </tr>
        <tr>
            <td>2</td>
            <td>def</td>
        </tr>
    </tbody>
</table>

Without the thead there seems to be no problem.

regards, Koen Willems

In Apache, mod_security is usually installed (​http://www.modsecurity.org/) - it is commonly used to detect and prevent against possible attacks. Quick example from official mod_security site (​http://www.modsecurity.org/documentation/quick-examples.html):

    # Prevent path traversal (..) attacks
    SecFilter "\.\./"

Similar rule is available in a "Apache 2.x rules" at ​http://www.gotroot.com/:

##generic recursion signatures
SecRule REQUEST_URI "!(alt_mod_frameset\.php)" "chain,id:300004,rev:2,severity:2,msg:'Generic Path Recursion denied'"
SecRule REQUEST_URI "\.\./\.\./"
#generic path recurision si

The problem is that ../.. is used by FCKeditor:

http://www.fckeditor.net/fckeditor/editor/filemanager/browser/default/browser.html?Type=Image&Connector=../../connectors/php/connector.php

so it may be blocked in rare cases.

We should avoid passing ".." in urls.

For more info please take a look at: #950

For more info please take a look at: #950

For more info please take a look at: #950

Reproduction procedure:

1. Go to sample01.html
2. Open the Find dialog
3. Type "some sample" in the "Find what" field
4. Press "Find" twice, you should see the no match found message
5. Press "Find" once more, you'll see a JavaScript error

The new CSS class names are breaking existing plugins and also the Template dialog.

The editor must run inside the Adobe AIR platform.

My apologies for cross-posting this from the FCKeditor support site; this site appears to be the more appropriate location for this, however.

We first discovered this issue locally in IE7 (FF seems unaffected), but this issue was confirmed in IE7 in the MediaWiki+FCKEditor sandbox. ​http://mediawiki.fckeditor.net/index.php/Sandbox

The problem is FCKeditor is mis-behaving when dealing with extra white spaces in list items. For example, if you take the following wikitext list

* a bullet list
* anchors
* links

and put three blank spaces immediately before and after the word "bullet" in the first list item then click 'Show preview' or view the Wikitext and go back to the WYSIWYG display. The list gets mangled to look like the following (again in wikitext).

*
* a   
* bullet    list
* anchors
* links

Sometimes I also get a Javascript error:

Line: 88
Error: 'null' is null or not an object

From the following file -- (I had to fat-finger this in, so it may not be completely accurate) extensions/FCKeditor/fckeditor/editor/js/fckeditorcode_ie.js

This is the offending line of code (line 88):

var FCKEvents=function(A){this.Owner=A;this._RegisteredEvents={};};FCKEvents.prototype.AttachEvent=function(A,B){var C;if (!(C=this._RegisteredEvents[A])) this._RegisteredEvents[A]=[B];else C.push(B);};FCKEvents.prototype.FireEvent=function(A,B){var C=true;var D=this._RegisteredEvents[A];if (D){for (var i=0;i<D.length;i++){try{C=(D[i](this.Owner,B)&&C);}catch(e){if (e.number!=-2146823277) throw e;}}};return C;};

The PHP connector DetectHTML function does no error checking to make sure that the file was opened or read correctly. This causes a cascade of errors on systems with the PHP open_basedir set to disallow opening of files in the temporary file-upload directory. See the forums post ​http://www.fckeditor.net/forums/viewtopic.php?f=6&t=8619.

In the file 'editor/filemanager/connectors/php/util.php' starting on line 87 is the DetectHTML function.

Original:

function DetectHtml( $filePath )
{
	$fp = fopen( $filePath, 'rb' ) ;
	$chunk = fread( $fp, 1024 ) ;
	fclose( $fp ) ;

With improved error checking, it should be something like this...

function DetectHtml( $filePath )
{
	$fp = fopen( $filePath, 'rb' ) ;
        if ( $fp !== false )
        {
         	$chunk = fread( $fp, 1024 ) ;
             if ( $chunk === false )
             {
                     $chunk = '';
             }
	       fclose( $fp ) ;
        }
        else
        {
             $chunk = '';
        }

I'm not sure whether it would be better to return TRUE or FALSE in the case of being unable to open and/or read the file. I leave it to the security experts to debate that.

I am getting sporadic errors when loading the editor in Firefox 3.0b3. The problem is that fckeditorapi.js is appending a SCRIPT element to the parent page to bootstrap the API. However, appending the SCRIPT element appears to be an asynchronous action in Firefox, so it's not always possible to immediately access oParentWindow.FCKeditorAPI. (I discovered this because the parent page sometimes needs to load a script that takes a second or two to fetch.)

A simple solution is to remove the check for FCKBrowserInfo.IsGecko19 added in r659, since the ​Firefox bug has been fixed.

As an aside, I don't know if this is an issue in Safari. If it is, you might consider something like ​this approach.

In FCKeditor.LoadPostData() the code that handles reverting the HtmlEncodeOutput changes does not work properly for strings that contain "&amp;lt;" or "&amp;gt;". The current code replaces '&amp;' before '&lt;' and '&gt;' which causes the strings mentioned to be converted to '<' and '>' respectively. What should happen is that the '&amp;' replacement should happen after the '&lt;' and '&gt;' replacement. This allows the strings to be converted to '&lt;' and '&gt;' which I believe is the proper decoding.

Here is a patch that fixes this problem.

Index: FCKeditor.cs
===================================================================
--- FCKeditor.cs        (revision 1585)
+++ FCKeditor.cs        (working copy)
@@ -456,9 +456,9 @@
                        // Revert the HtmlEncodeOutput changes.
                        if ( this.Config["HtmlEncodeOutput"] != "false" )
                        {
-                               postedValue = postedValue.Replace( "&", "&" ) ;
                                postedValue = postedValue.Replace( "&lt;", "<" ) ;
                                postedValue = postedValue.Replace( "&gt;", ">" ) ;
+                               postedValue = postedValue.Replace("&amp;", "&");
                        }

                        if ( postedValue != this.Value )

The inline CSS caching is not compatible with the current AIR implementation (see #1914). As we are using it for our internal CSSs, those styles have no effect in the editor.

two cell mergedown ok! three cell mergedown table broken.

Reproduction procedure:

1. Open sample01.html in IE6 or 7 under HTTPS and domain relaxation mode.
2. Open the image dialog, or the flash dialog, or the image button dialog.
3. Warning message about unsafe contents.

The close button is mispositioned in the dialogs when in RTL mode.

Confirmed with IE6 and IE7.

Trying with beta 2.6 plugin Placeholder to update my plugin based on this one :

On IE 6.0, when you click on the yellow Number, you should get the same number in windows but here the custom number does not come back.

Think that the problem is here : fck_placeholder.html L 46

var eSelected = oEditor.FCKSelection.GetSelectedElement() ;

is something like not initialised because in th function (LoadSelected()) it goes straight to the end. (eSelected does not exist)

Confirmed with IE7. Ok with FF.

Steps to Reproduce

1. Insert an image (like a smiley).
2. Remove the selection from the image and select it again.
3. Open the "Insert Special Character" dialog.
4. Insert any char.

A JavaScript error is thrown in Selection.EnsureSelection. There is no way to close the dialog after it. The page is now blocked.

Note that the desired action was correctly completed though.

The issue I just noticed looks a bit similar as the one described in Ticket #1509

To reproduce it:

1. Type <p>some text</p> in Source View
   
2. select the part 'text'
   
3. hit the button for 'sub' or 'sup'
   
4. move the cursor inside the part 'text'
   
5. hit the button for 'sub' or 'sup' again
   
   

The result is:

<p>some text<span id="1204151324434S" style="display: none">&nbsp;</span></p>

This only occurs in IE

Regards,

Koen

Hello

I want to use Font size, Text color, BGColor... on Mediawiki+FCKeditor

so, I have modified fckeditor_config.js like below

FCKConfig.ToolbarSetsWiki? = [ .... FontFormat?, ....

];

->

FCKConfig.ToolbarSetsWiki? = [ ....

['FontFormat','FontName','FontSize'], ['TextColor','BGColor'], ....

];

It is working well on the Mozila FireFox but not working on the Internet Explorer

Because The Mediawiki FCKeditor replace <span style="color: rgb(255, 153, 0);">Red</span> with <span style="">Red</span> on the Internet Explorer

Please let me know how can i fix this problem.

Thank you

best regards

This bug was originally reported by dCyphr in our forum, at ​http://www.fckeditor.net/forums/viewtopic.php?f=8&t=8711#p22790

We need to provide a set of default values for important CSS attributes for dialog elements exposed to the main window, to avoid native CSS styles from interfering.

When I run spell check using SpellerPages IE crashes (always). Basically, I run a spellcheck and once I get the popup that the spellcheck is complete, I click on the OK button and that's when the crash occurs. I'm using Windows XP SP2 and my IE version is 7.0.5730.11.

Ok I have searched and did not find an entry for this. I have tested this on Windows XP with IE7 and Firefox and it fails in IE7 but works in Firefox. I was not able to test this in the Nightly version and images browsing is disabled.

How to repeat:

1. Load your Demo Tool

2. Delete all text

3. Insert the Eagle Image

4. Add the text "This is an Eagle" under the image (this is just so the image is no longer selected)

5. Exit the Image Dialog

6. Click ONCE on the image (producing the image handles)

7. Click the Insert Link

8. Add any URL (www.fckeditor.net)

9. Click OK.

This adds the link to the code, but the Link Dialog does not close; locking the surfer from being able to do anything else. The only way out here is to hit F5 to refresh the page, causing you to loose all your changes.

At this point there is no way to close the Dialog Box!

People around there doesn't understand the real meaning of <strong> and <em> and are using them indiscriminately for formatting, enforcing loudly that in this way they are XHTML aware.

They are also accusing us to use the good and old <b> and <i> "formatting" tags for "formatting", instead of the new and fashionable <strong> and <em> "semantic" tags (even if those are available in the Styles combo anyway).

So, to shut up the general mass opinion, it seems that it would be better for us to configure the editor to produce <strong> and <em> by default, removing those entries from the Styles combo.

At this point, we should also think about the following tags, which are produced by default with the "formatting" buttons:

• <u> : change to <span style="text-decoration: underline;">
• <strike> : change to <span style="text-decoration: line-through;"> (or <del>?)

We can use the powerful features of FCKeditor to easily configure it to produce the above tags. But... does all that makes sense? Would anyone get angry with us because of it?

Steps to reproduce:

1. Go to our demo page ​http://www.fckeditor.net/demo

2. Insert a table.

3. Right-click inside a cell to activate the context menu

4. Go to a sub-menu e.g. Cell, Row or Column

Notice that the submenu appears not besides the context menu but practically on it.

Expected behavior would be displaying a submenu besides the original context menu.

Tested using 2.6 beta and SVN version on IE7. It works fine in IE6 and FF2.

"FCK.InsertHtml()" function ignores selection/position when executed from a floating dialog instanciated with "FCKDialogCommand", and the web browser is IE7. The inserted text always gets inserted at the beginning. This does NOT happen when using Firefox 2.0.0.12. Furthermore, it does not happen if executed from an IE popup using window.showModalDialog().

Attached is a very simple plugin called 'insertbug' that adds the command 'InsertText' for demonstrating the problem. Firefox has no problem with selected text getting replaced or inserted at the insertion carot position. With IE, "Inserted Text" is always inserted at the beginning.

Tested 2.6.beta and nightly build 18335 (03/09/2008).

Updated Catalan language file for FCKEditor 2.6b with more accurate translations.

Mediawiki auto-converts hyperlinks in [ ] to be numbered links such as [1] and [2] if a link-name is not provided. Whereas any URL not encased within [ ] will be simply hyperlinking with the URL as the link name.

FCK editor converts a ​http://URL into a numbered link by default. Can the default be set to using the URL as the link name instead? This is much more intuitive than using numbered links.

Like the title suggests.

To reproduce, open the editor, click the button to add a table, fill for example the text 'hello' in the title field. click on OK, now you can see the table in the editor with on top the title in bold 'ello'

IE7 introduced native support for XMLHttpRequest, so we must use it whenever possible.

If I have a file with a pound sign # in it, it is not escaped when I upload it. Ticket #182 fixed most escaping issues, but using encodeURI() doesn't escape everything (e.g #). That's actually good since currently it's applied to the whole URI, and for characters like : and / we don't want those escaped in "​http://" for example. See ​http://xkr.us/articles/javascript/encode-compare/ which shows the different encode functions.

My suggestion would be to NOT encode anything in javascript. Rather, update all connectors to encode the file name (and/or url). In php, this would use the rawurlencode() function. Then that fully-encoded file name would be appended to the unencoded domain+directory.

Steps to reproduce:

1. Open sample01.html in Firefox 2 or Firefox 3 beta.
2. Type or paste something really long into the editing area so that the scroll bar appears.
3. Press the maximize button.
4. The editing area is not maximized vertically - the scrollbar is still at the previous height.

Error Message: Line: 103 Error: Can't move focus to the control because it is invisible, not enabled, or of a type that does not accept the focus.

Cause: Invoking the links dialog for properties of either an existing anchor or 'mailto:' when using IE7.

This dialog can open three different ways based on link type for which it'll be a properties dialog; namely 'url', 'anchor', or 'email'. The error is true for both 'anchor' and 'email' since the element on which focus gets placed is specific for 'url', and so is invisible for the other two cases. Replacing line 162 of 'dialog/fck_link/fck_link.js' that reads like:

	SelectField( 'txtUrl' ) ;

with valid (and sensible) places to put focus based on the three conditions:

	switch( document.getElementById( 'cmbLinkType' ).value )
	{
		case 'url'	: SelectField( 'txtURL' ) ; break ;
		case 'email'	: SelectField( 'txtEMailSubject' ) ; break ;
		case 'anchor'	: document.getElementById( 'cmbAnchorName' ).focus() ;
	}

fixes it for me. (SelectField isn't totally valid for anchor)

FF seems not to care, but IE does. (SVN build 18395)

Put it in the docs and present it as a public thing so people can easily access every FCKeditor instance on the page.

E.g. (currenlty)

if (FCKeditorAPI)
{
	for (fckeditorName in FCKeditorAPI.__Instances)
	{
		if (FCKeditorAPI.GetInstance(fckeditorName).IsDirty())
		{
			changesMade = true;
			break;
		}
	}
}

The fix for #183 broken the FCKeditorAPI "Instances" object cleanup. The "_test/manual/fckeditorapi/test1.html" test page shows the problem.

In the 2.6 Beta, when adding a hidden form field to a form, the field is added below the dialog window, but the dialog cannot be closed by ok, cancel, or x. This is reproducable in the demo.

Reproduction procedure:

1. Open sample06.html in IE.
2. Click on the editing area such that the caret appears in the editing area.
3. Click on the placeholder plugin button.
4. Type something.
5. Even though with the placeholder dialog in the foreground, you find that you can still type things into the background editing area.

To reproduce the bug:

1. Open sample12.html in IE or FF, change EnterMode to 'br'.
2. Try to insert a page break anywhere by pressing the Page Break button.
3. You get a JavaScript error.

This bug is related to #1853 as the problem is caused by FCKDomRange::SplitBlock().

FCKeditor is by default set to work with XHTML 1.0 Transitional.

Today we have sample14.html, which is a nice demonstration on how to configure FCKeditor for XHTML 1.1. We should create other two samples that match some important usage cases: Flash and Old HTML.

Flash accepts a limited number of tags. A reference for it can be found here: ​http://kb.adobe.com/selfservice/viewContent.do?externalId=tn_14808

The old HTML sample should be called "Legacy Tags". It should be configured to work with <b>, <i> and <font> tags.

This is a proposal to add a new method in the FCKDebug object to send debug messages to the error console (without an additional window, it's specially useful while debugging in chrome)

Steps to Reproduce

1. Load sample01.html.
2. In the Find dialog search for "e".
3. Continuously click in the Find button to find all occurrences of "e".

It will successfully find the first two occurrences, in "some" and "sample". After that, it blocks on the last found position and don't continue through the remaining occurrences inside "text", "are" and "FCKeditor".

Load sample01 in Firefox2 and click the link button.

An error appears in the js console "element has no properties" called from

 SelectField("txtURL");
 onload();

but opening again the dialog works fine.

load sample09, put the focus in the first editor and press the Ctrl+Alt+Enter combo to execute the FitWindow command, an error is generated (it doesn't matter the browser):

this._UIButton has no properties
File: editor/_source/classes/fcktoolbarbutton.js
Line: 55

We don't need anything from FCKDebug when normally using the editor. We should be able so to avoid including its code inside the compressed files to save some bytes from it. The solution would be loading fckdebug.js by request, only if debugging is enabled.

Our code may have some debugging calls laying around, so the compressed files should still contain the debugging functions, but those should be empty. We could use @Packager.Remove.Start and @Packager.Remove.End to easily achieve that.

the compressed version of fck_dialog_common.css keeps the IE only syntax instead of the W3C value when it compresses this rule

.BtnOver
{
	border: outset 1px;
	cursor: pointer;
	cursor: hand;
}

into .BtnOver{border:outset 1px;cursor:hand}

As explained in #1644 only IE5.5 needs that value and now it will force us to manually adjust the compressed versions of CSS.

The fckdialog.html file has an XHTML doctype but doesn't validate:

​http://validator.w3.org/check?uri=http%3A%2F%2Fwww.fckeditor.net%2Ffckeditor%2Feditor%2Ffckdialog.html&charset=%28detect+automatically%29&doctype=Inline&group=0

This is mainly because there are a lot of & < and > in the inline javascript code. The easiest would be to move the javascript code to a javascript file i guess.

This is a real problem when integrating with zope where the .html files might be parsed before delivery. The parsing breaks because of the invalid html.

It seems like the InsertHtml() function from a floating dialog is getting executed about 10 to 15 times. It is not noticeable using the 'insertbug' plugin as it is attached to #1990. However, if you replace the 'Insert Text' string that gets inserted with content that is taller than the editor window, you can then see the up/down rapid flickering from what appears like multiple re-insertions. Ultimately, it does end up working correctly, but the behavior is strange.

This doesn't happen with FF. However, the ultimate result isn't consistent between FF and IE. With FF, what gets inserted is not selected, but with IE it does end up selected.

SVN build 18515

The fckeditor.py module has a type: ToolBar instead of Toolbar. The attached patch fixes this.

I try to upload a file, but I have this error : ADODB.Stream erreur '800a0bbc' Impossible d'écrire dans le fichier

In English, it means "Impossible to write in the file". Here, the file path generated by fck :
NAS-PROD\wwwsites-data$\demo-modules.cyim.com\upload\file/test.doc

The problem is due to a concatenation of IIS server path and file path. IIS path is like that
cylab\sites\ File path is like that : /file/myfile.doc

I have updated the file "class_upload.asp" to correct my problem : Function SaveAs, I add this line : sFileName = replace(sFileName, "/", "\")

I think i'm not the first guy to use IIS and FCK. So, why i have this problem ?

To reproduce the bug:

1. Open _samples/html/sample01.html included in the latest SVN trunk in IE or Firefox.
2. Open any floating dialog window, e.g the Smiley dialog.
3. Press Tab on the keyboard until the focus shifts to the editing area.
4. Once the focus goes to the editing area, you find that you can edit the "inactive" document again.

This bug is pretty obvious to users who are used to switching UI widget focus via the Tab key so it should block the final 2.6 release.

Install CategoryTree extension: ​http://www.mediawiki.org/wiki/Extension:CategoryTree

Use the <categorytree> tag. Error: style is being stripped.

<categorytree style="border: 1px solid gray; padding: 0.7ex; float: right; clear: right; margin-left: 1ex; background-color: white;" mode="pages">Manual</categorytree>

switch to wikitext, wysiwyg mode and back to wikitext:

<categorytree mode="pages" style="clear: right; border-right: gray 1px solid; padding-right: 0.7ex; border-top: gray 1px solid; padding-left: 0.7ex; float: right; padding-bottom: 0.7ex; margin-left: 1ex; border-left: gray 1px solid; padding-top: 0.7ex; border-bottom: gray 1px solid; background-color: white" mode="pages">Manual</categorytree>

style attribute has changed.

In /editor/filemanager/connectors/asp/basexml.asp the charset ist set in line 33:

Response.CharSet = "UTF-8"

but additionaly the codepage has to be set correctly with:

Response.CodePage = 65001

At the moment an IIS defaulting to another encoding doesn't submit XML-data in UTF-8 and browsing a directory containing files with special chars like umlaute results in an error on IE. Firefox doesn't show an error, but filenames with special chars aren't displayed corectly.

Reproduction procedure:

1. Open sample01.html in Safari.
2. Apply "Red Title" style to the paragraph.
3. Insert a few special characters via the special character dialog in the paragraph.
4. The inserted characters aren't red and come with a strange <span class="Apple-style-span"> tag.

This seems to be a WebKit bug as the problem also appears when adding special characters via document.execCommand('inserthtml', false, $HTML) directly in Safari. But a short term workaround may be possible as well.

I've created separate ticket, because it's probably a different issue than #1919.

1. Open _sample01.html in domain relaxation mode under Firefox 2.0.0.13.
2. Open the image dialog.
3. Click "Browser Server".

Even if there are images in the folder, they are not displayed. In frmresourceslist.html there is an empty body

<body class="FileArea"/>

although GetFoldersAndFiles has been called succesfully.

I hate to be a pest about the same thing over and over again, but the bug as reported in #1990 is back as originally stated for both 2.6 and the SVN.

For whatever reason, the condition put in place to fix #2057, which was the fix for the flashing problem of the fix for #1990, that detects whether the selection has already been restored is always true when running the simple plugin attached to #1990. Therefore, the selection never does get restored hence why the original #1990 problem.

Perhaps the logic implemented by #2057 will only work if the EditorDocument doesn't have focus. This is my guess because if I rearrange lines 152 thru 155 in the InsertHtml function of 'fck_ie.js' such that FCKUndo.SaveUndoStep() happens before setting focus:

	FCKUndo.SaveUndoStep() ;

//	FCK.Focus() ;
	FCK.EditorWindow.focus() ;

that seems to fix it. Perhaps logic of #2057 should be reviewed if needed for other broken circumstances. Putting that save undo call before the InsertHtml() call in the plugin also works around it. (What fun could you have without IE?)

FYI... The FCKSelection.Restore() function gets called a lot, even when there is no active dialog. Not much can be done with the editor per 100 times this gets called. However, the call rate gets drastically reduced after a positive response (e.g. OK button) to a dialog.

State of the cut/copy buttons doesn't work properly after a positive response (OK button) to a dialog. It can be corrected by invoking a dialog and then pressing 'Cancel'. State can also be temporarily corrected by right clicking along with the proper states of the context menu, but still won't continue to work properly until canceling a dialog.

This was not a problem with 2.6 beta (build 18219).

Problem noted with IE7. Not a problem with FF 2.0.0.13.

It would be nice to have again what effectively was a feature before 2.6. In other words, it would be nicer if somehow the vertical scroll bar of the main browser window could be disabled while a dialog is active. This is because the mouse wheel can now scroll away the whole dialog (and editor window) after a scroll bar within a dialog reaches its limit and the parent page containing the editor instance is taller than the browser window. (a little bit annoying) This of course couldn't happen from a popup.

The following:

window.document.body.style.overflow='hidden';

could work for IE, but unfortunately not FF. FF scrolls to the top before disabling the scroll bar. I'm hoping you can think of a more elegant solution.

To reproduce:

1. Open sample01.html in IE6 or IE7.
2. Switch to view source mode.
3. Paste the following code into the source area:

   <p>This is some <strong>sample text</strong>. You are using <a href="http://www.fckeditor.net/">FCKeditor</a>.</p>
   <fieldset><legend>title</legend>Here is some text</fieldset>
   

4. Switch to WYSIWYG mode.
5. Move the caret to the end of the first paragraph.
6. Click "Insert Horizontal Line" toolbar button.
7. JavaScript error.

Set the EditorAreaCSS property:

oFCKeditor.Config['EditorAreaCSS'] = 'some/file.css';

in some/file.css is standard css file. Everything ok, no problems... But if I write into this file standard css function:

@import url('some/other/file.css');

Everything seems to work fine but that is not true. File was imported succesfuly, styles changed according to 'some/other/file.css', but try to do this: 1) Click into FCKeditor area and change some text 2) Click on Source button (the source code will appear) 3) Click on Source button again (you will get back into WYSIWYG area) - still everything seems fine, style is ok but follow the last step 4) Click on submit button The submited text is now 'null' and everything what was really in the FCKeditor area disappeared forever!!!! Even if everythink looked fine...

For reproducing the bug don't do anythink else than what is described in four steps above. When you write something in FCKeditor area after step 3 the submited text will be ok.

When I removed the @import function and copied the content of the 'some/other/file.css' file into 'some/file.css' everything was ok...

Create a bulleted list in v2.6 (no problem in v2.5)

Right-click and select Bulleted List Properties

The following error will be displayed:

Line: 103 Error: Can't move focus to the control because it is invisible, not enabled, or of a type that does not accept the focus.

Dialog window will display after you close error window.

Tested on ​http://www.fckeditor.net/nightly/fckeditor/_samples/default.html

Error does not occur with ordered (numbered) list.

My suggestion is to replace sampleposteddata.asp with sampleposteddata.php in action parameter inside the form. I think that the usage of asp extension is less useful for the users. I don't know what is the most common used server side however I think that PHP is more popular than ASP (more of the users use Appache rather than IIS for example). Of course a user could always use the php examples however I don't see why php extension couldn't be used in html samples as well.

Reproduction procedure:

1. Open sample07.html.
2. Paste the following HTML in Source Mode:

   <!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.01 Transitional//EN">
   <html>
       <head>
           <title>Full Page Test</title>
           <meta http-equiv="Content-Type" content="text/html; charset=utf-8" /><style type="text/css">
   #Gallery {
   	width: 500px;
   }</style>
       </head>
       <body>
           <div id="Gallery"><img height="240" alt="" width="240" src="a.jpg" /><img height="240" alt="" width="240" src="b.jpg" /></div>
       </body>
   </html>
   

3. Switch back to WYSIWYG mode.
4. Right click on one of the images, choose "Image Properties".
5. Close the Image Properties dialog
6. The selection to the image is lost.

This bug happens on IE only.

We need to generate the css rules for each user which are using the fckeditor. To achieve this our css files are parsed as php files. To get correct css rules we send in the id as a GET parameter to the css files.

In this way we get urls like: /styles.css?id=15

This does not work with the new css cache feature in fckeditor. The problem is the regex used at least two places in fcktools.js (FCKTools.AppendStyleSheet and FCKTools.GetStyleHTML) which look like "/[
\/\.]\w*$/"

I have temporary changed the regex to /[
\/\.].*$/ in our solution, but you guys will surely come up with a better solution.

And why your at it, why don't you move this regex rule to your fckregexlib? At least it will be easier to customize.

Scenario:

1. Paste a larger text into the editor (i.e. the gpl license ​http://www.gnu.org/licenses/gpl-3.0.txt)
2. Open the find dialog and search for word not found in the text.
3. The scripts hangs and after a while the browser ask to stop the script.

Tested in nightly build with firefox on linux and ie7 on windows.

In IE7, open the first sample. (​http://www.fckeditor.net/demo)

Call GetXML() by pasting this code into the address bar.

javascript:alert(FCKeditorAPI.GetInstance('FCKeditor1').GetData());

You should get an alert with the source currently in FCKEditor. Dismiss the alert.

Now try making the text that's bold not bold. It doesn't work. (I've tried selecting the bolded text and clicking the "B" button. I've also tried placing the cursor inside the bolded text an clicking the "B" button. These both work fine prior to calling GetData().)

I don't know the exact steps to reproduce, but I've seen a page that it wasn't possible to edit anymore giving an error in both IE and Firefox. The page was edited with full page and it had this included (after the last successful edit):

		<link charset="utf-8" rel="stylesheet" type="text/css" href="chrome://firebug/content/highlighter.css" />

So it might be a good idea to check that the <link>s doesn't point to restricted urls

XHTML is not for everyone. If someone sets a HTML 4 doctype we must assume that he really wants HTML not XHTML.

Hi there

I was playing around with your editor and found a bug. If I use the following code: <fieldset>

<a href="/File/Meg_TechRun1.jpg">

<img src="/Image/001_Meg_TechRun_Thumb.jpg" />

</a>

</fieldset>

and right click on the image and edit the link, it moves the cursor to the first position in the source and the link in the popup is empty. This is happening in my IE7 browser, but not in my Firefox.

If you need more information, feel free to email me at friendly_781114@…

Thanks.

M

When you open a link dialog or a image dialog, the focus isn't placed on the dialog but remains in the editing area.

Steps to reproduce

1. Open the Insert Link Dialog

2. Start to type (without placing the cursor in the proper place.

3. If you type you will see that the text appears in the editing area and the cursor is blinking on the dialog area as well.

In this situation you can't insert a link when you have highlighted a text which should be made a link because it will overwrite your selection.

Testing area

Tested using IE6 and IE7 on MediaWiki 1.12 using the latest FCKeditor SVN version. This bug doesn't occur on FF2.

When the body is fixed to make sure that everything is properly nested, the comment nodes should be treated specially so they don't generate a new block.

given this input:

This is <!-- some comment --> some <strong>sample text</strong>. You are using <a href="http://www.fckeditor.net/">FCKeditor</a>.

with enter mode set to P, if you switch to design and back to source the output is

<p>This is</p>
<!-- some comment -->
<p>some <strong>sample text</strong>. You are using <a href="http://www.fckeditor.net/">FCKeditor</a>.</p>

the paragraph has been broken

it should have been left as

<p>This is <!-- some comment --> some <strong>sample text</strong>. You are using <a href="http://www.fckeditor.net/">FCKeditor</a>.</p>

Text coping by Ctrl+Ins doesn't work anymore. Reproduced at ​http://www.fckeditor.net/demo

Additional info: I have old integration with FCKeditor 2.2 there copying by Ctrl+Ins work fine. If I add [ CTRL + 45 /*INS*/, 'Copy' ] to FCKConfig.Keystrokes problems solves for IE. But under Firefox (version 2.0.0.14) I start getting warnings that copying is disabled by my browser for security reasons. This is incorrect cause using the same version of Firefox and FCKeditor 2.2 I can copy text by Ctrl+Ins without any problem.

When the user presses the Upload button, there's no indicator that something is happening.

Reusing the dialog's throbber seems like an easy solution.

I don't know why we didn't realize earlier, but the filemanager has lots of validations errors that can be solved (most of them) easily.

As ​pointed in the docs site, it seems that PreserveSessionOnFileBrowser is not anymore needed since the new dialog system. We should verify it and clean up the code if necessary.

Gujarati Language file (gu.js)

It would be very useful to be able activate or deactivate this editor with the click of a button like with ​wikEd for example.

I have create an application with fckeditor inside an updatepanel. If inside the editor I insert an image and then select it by clicking on it, doing a postback ie6 and ie7 crashes. The same is also for a table; you can reproduce the problem using the attached project.

This update was originally posted by zed1973.

Here are the missing translations for Italian language:

> AnchorDelete          : "Rimuovi Ancora",     //MISSING
> ShowBlocks            : "Visualizza Blocchi", //MISSING
> InsertRowAfter                : "Inserisci Riga Dopo",        //MISSING
> InsertRowBefore               : "Inserisci Riga Prima",       //MISSING
> InsertColumnAfter     : "Inserisci Colonna Dopo",     //MISSING
> InsertColumnBefore    : "Inserisci Colonna Prima",    //MISSING
> InsertCellAfter               : "Inserisci Cella Dopo",       //MISSING
> InsertCellBefore      : "Inserisci Cella Prima",      //MISSING
> MergeCells                    : "Unisci celle",
> MergeRight                    : "Unisci a Destra",    //MISSING
> MergeDown                     : "Unisci in Basso",    //MISSING
> HorizontalSplitCell   : "Dividi Cella Orizzontalmente",       //MISSING
> VerticalSplitCell     : "Dividi Cella Verticalmente", //MISSING
> DlgFindAndReplaceTitle        : "Cerca e Sostituisci",        //MISSING
> DlgPasteSec           : "A causa delle impostazioni di sicurezza del
browser,
> l'editor non è in grado di accedere direttamente agli appunti. E' pertanto
> necessario incollarli di nuovo in questa finestra.",  //MISSING

The ReplaceTextarea method could copy the tabindex value from the textarea when replacing it. In this way we automate this feature.

It seems that Epiphany browser is getting more and more popular recently. This browser is based on Gecko engine and is compatible with FCKeditor. However, as reported by yell0w at #fckeditor IRC channel: ​http://irc.fckeditor.net/index.php?date=2008-05-23 current implementation of browser detection doesn't detect it properly.

Epiphany introduces itself as

Mozilla/5.0 (X11; U; Linux i686; en; rv:1.9b5) Gecko Epiphany/2.22

so searching for "Gecko/" fails.

Similar issue for FCKeditor.Java have been reported in #1744. There is another example of "user agent" that fails current browser detection:

Mozilla/5.0 (X11; U; Linux i686 (x86_64); en-US; rv:1.8.0.2) Gecko/Debian-1.5.dfsg+1.5.0.2-3 Firefox/1.5.0.2

So far the email address typed in the link dialog gets packed as a href-attribute unencoded into the html source. This is easy for spambots to be scanned and so it is necessary to at least obscure the mail address. This proposal provides a possibility to encode the email address using the simple String.fromCharCode() technique.

We modify the file "editor/dialog/fck_link/fck_link.js" such that the method oParser.CreateEMailUri returns the email href-attribute not in plain text but encoded.

Replace the return statement of the oParser.CreateEMailUri method

  return sBaseUri + sParams ;

by

  var uri = sBaseUri + sParams ;
  var urj = '' ;
  for ( var i = 0; i < uri.length; i ++ ) {
    if ( i > 0 ) { urj += ','; }
    urj += uri.charCodeAt(i) ;
  }
  return 'javascript:location.href=String.fromCharCode(' + urj + ')' ;

As the "protocol" of the link is no more "mailto", we should implement also a decoder that from the encoded href-attribute gets back the email address as well as the subject and the body. This is important if the CKEditor user wants to edit again an encoded email link. This is not yet implemented.

Currently there is no way to create a <div> which embraces a series of block elements. For example, producing the following output:

<div class="MyDiv">
    <p>Para 1</p>
    <p>Para 2</p>
</div>

The current style system always see <div> as a block element, and therefore, when applying <div> based styles, it converts current blocks to <div>.

The idea would be creating a dedicated button for it. It would behave much like the Blockquote button, but it should have a dialog containing the following fields, basically:

• General Tab:
  • Style: a selection box listing all styles defined for <div> elements in the style system. We should create a reusable component that can be used on other dialogs, for tables, cells, links, etc.
  • Class: the "class" attribute.

• Advanced Tab:
  • Id: the "id" attribute.
  • Inline Style: the "style" attribute.
  • Title: the "title" attribute.
  • Language: the "lang" attribute.
  • Text Direction: a selection for the "dir" attribute.

The only thing still pending to understand is how to edit a previously created <div> and how to delete it. Maybe it is the case to leave the edit and delete operations in the context menu only, while the toolbar button will always create a new <div>, making it possible to nest them.

Steps to Reproduce

1. Open the ​nightly build.

2. Paste any YouTube video in the source, like the following:

<object width="425" height="355"><param name="movie" value="http://www.youtube.com/v/1suHskbL1pE&hl=en"></param><param name="wmode" value="transparent"></param><embed src="http://www.youtube.com/v/1suHskbL1pE&hl=en" type="application/x-shockwave-flash" wmode="transparent" width="425" height="355"></embed></object>

3. Switch to WYSIWYG.

Note that the <object> placeholder is totally blank, instead of having the puzzle icon and the border. It is still selectable though, so it seems to be something related to the compressed CSS.

The "unpacked" SVN verstion (trunk) don't have this problem.

Hitting SHIFT+SPACE should insert a &nbsp; in the editor.

The FCK.InsertHtml( '&nbsp;') call inserts a plain space in the selection, instead of the proper &nbsp; char.

There should be a configurable way to not use our custom context menu at all, leaving the default browser context menu to work.

The solution is already proposed at #311. I think the "BrowserContextMenu" setting name is better because it follows the already present "BrowserContextMenuOnCtrl" name.

FCKSelection have 2 methods called: HasAncestorNode and MoveToAncestorNode. Both of theme have input parameter called nodeTagName of type string and as written in comments of this function the passed string should be written in upper case.

But in the code when check is done actual tag name never converted to upper case.

if ( oContainer.tagName == nodeTagName ) return true ;

So if your edited HTML has tags written in lower case (like custom tags) this functions won't find the ancestor tag.

Hope you'll fix this small thing in next revision.

tank's

When I set ForsePasteAsPlainText to true and drag and drop some content from the page to FCKeditor I get the following error:

htmlfile: Incompatible markup pointers for this operation.

It happens in fckeditorcode_ie.js on the following line:

FCKDomRange.prototype.MoveToSelection=function(){
    //...
   D.pasteHTML('<span id="'+E+'"></span>'); //error appears here
   //...
}

text is inserted but it is styled.

Steps to reproduce:

1. html-file:

<html xmlns="http://www.w3.org/1999/xhtml">
<head>
    <title>FCKeditor - Sample</title>
    <meta http-equiv="Content-Type" content="text/html; charset=utf-8">
    <meta name="robots" content="noindex, nofollow">
    <script type="text/javascript" src="fckeditor/fckeditor.js"></script>
</head>
<body>
    <form>
	<font color="Red">drag and drop me</font>
        <script type="text/javascript">
            var oFCKeditor = new FCKeditor('FCKeditor1');
            oFCKeditor.BasePath = "fckeditor/";
            oFCKeditor.Create();
        </script>
    </form>
</body>
</html>

2. contents of 'fckeditor/' is default.

Except, FCKConfig.ForcePasteAsPlainText = true ; in fckconfig.js

3. Drag and drop 'drag and drop me' text to FCKeditor

Note: couple of times I've got "Paste as Plain Text Dialog" as a result. But in most times it was described error. I didn't notice regularity here.

Browser: IE 7.0.5730.11 OS: Windows XP with SP2

I am having a similar problem as described here: ​http://www.fckeditor.net/forums/viewtopic.php?f=6&t=9345&p=24267&hilit=editorareacss+import#p24267

But my problem is a little bit different.
In my fckconfig.js I set the

FCKConfig.EditorAreaCSS = 'mystyles.css' ;

then in mystyles.css I have the lines:

@import "/includes/css/main.css"; 
@import "/includes/css/foo.css"; 
@import "/includes/css/bar.css"; 

html, body {
	text-align: left;
	background-color: white;
	font-size: 12px;
}

I do this because I have 3 css files I want my editor area to show up like. Once I do this, when I bring up my page that has the fckeditor textarea on it, I will do this:

1. click in the textarea - the menu does not pop down - like it should.
   
2. manually put the menu down
   
3. click source button.
   
4. don't make any changes and just click ok on the source popup window (yes i have my source set to pop up)
   
5. you get a javascript error that says:
   

Permission denied fckeditor.html?InstanceName=[mytextarea name]&ToolBar=Basic

If I remove the @imports out of my mystyles.css file, it will work fine.

I also downloaded the nightly build for fckeditor on 6/8/2008 and tried reproducing this bug on that nightly build version too, and the bug is still there.

Please notify me once this is fixed so I can upgrade. For now, I'm sticking to 2.4.2 until this is resolved.

Thanks so much!!! -NS

Click the anchor button and give the name as test.then click source button.then return back from source(reclicking that source button).then click only one time undo button.then click source button.that time java script error is occoured.This problem only in ie. Firefox is having no problem

If I set FCKeditor.EditorDocument.designMode = 'on' ForcePasteAsPlainText does not work

Steps to reproduce

1. Html file:

<html xmlns="http://www.w3.org/1999/xhtml">
<head>
    <title>FCKeditor - Sample</title>
    <meta http-equiv="Content-Type" content="text/html; charset=utf-8">
    <meta name="robots" content="noindex, nofollow">
    <script type="text/javascript" src="fckeditor/fckeditor.js"></script>
</head>
<body>
    <font color="Red">Copy & paste me</font>
    <script type="text/javascript">
        var oFCKeditor = new FCKeditor('FCKeditor1');
        oFCKeditor.BasePath = "fckeditor/";
        oFCKeditor.Create();
        
        function FCKeditor_OnComplete(editorInstance)
        {
            editorInstance.EditorDocument.designMode = 'on';
        }
    </script>
</body>
</html>

2. Contents of 'fckeditor/' folder are default. Except FCKConfig.ForcePasteAsPlainText = true ; in fckconfig.js

3. Copy & paste 'Copy & paste me text' - it is styled. Not plain text as expected

Note: I use FCKeditor.EditorDocument.designMode to make editor readonly and editable.

Browser: 7.0.5730.11 FCKeditor: 2.6

In Firefox 3 RC3, the "paste from word" feature leaves lots of garbage tags behind. Specifically:

• It does not remove comments.
  
• It does not remove <style> elements.
  
• It does not remove <meta> elements.
  
• It does not remove <link> elements.

The comments issue can be fixed by changing this line in fck_paste.html's CleanWord function:

html = html.replace(/<\!--.*?-->/g, '' ) ;

...to this:

html = html.replace(/<\!--[\s\S]*?-->/g, '' ) ;

(Because . does not match new lines, multi-line comments are not removed; [\s\S] does the trick instead.)

To be safe, I recommend making similar changes to all of the fck_paste.html instances where .* is used. Specifically, these lines:

html = html.replace(/<o:p>.*?<\/o:p>/g, '&nbsp;') ;

html = html.replace( /<SPAN\s*>(.*?)<\/SPAN>/gi, '$1' ) ;

html = html.replace( /<FONT\s*>(.*?)<\/FONT>/gi, '$1' ) ;

html = html.replace( /<(\w+)[^>]*\sstyle="[^"]*DISPLAY\s?:\s?none(.*?)<\/\1>/ig, '' ) ;

html = html.replace( /<(H\d)><FONT[^>]*>(.*?)<\/FONT><\/\1>/gi, '<$1>$2<\/$1>' );
html = html.replace( /<(H\d)><EM>(.*?)<\/EM><\/\1>/gi, '<$1>$2<\/$1>' );

var re = new RegExp( '(<P)([^>]*>.*?)(<\/P>)', 'gi' ) ;	// Different because of a IE 5.0 error

...should be changed respectively to:

html = html.replace(/<o:p>[\s\S]*?<\/o:p>/g, '&nbsp;') ;

html = html.replace( /<SPAN\s*>([\s\S]*?)<\/SPAN>/gi, '$1' ) ;

html = html.replace( /<FONT\s*>([\s\S]*?)<\/FONT>/gi, '$1' ) ;

html = html.replace( /<(\w+)[^>]*\sstyle="[^"]*DISPLAY\s?:\s?none([\s\S]*?)<\/\1>/ig, '' ) ;

html = html.replace( /<(H\d)><FONT[^>]*>([\s\S]*?)<\/FONT><\/\1>/gi, '<$1>$2<\/$1>' );
html = html.replace( /<(H\d)><EM>([\s\S]*?)<\/EM><\/\1>/gi, '<$1>$2<\/$1>' );

var re = new RegExp( '(<P)([^>]*>[\s\S]*?)(<\/P>)', 'gi' ) ;	// Different because of a IE 5.0 error

Also, to get rid of the <meta>, <link> and <style> elements, I suggest adding these additional replacements:

// Remove meta/link tags
html = html.replace(/<(META|LINK)[^>]*>\s*/gi, '' ) ;

// Remove style tags
html = html.replace( /<STYLE[^>]*>([\s\S]*?)<\/STYLE[^>]*>/gi, '' ) ;

This bug was discovered while testing for #1614:

1. Enable the dragresizetable plugin.
2. Go to sample01.html in Firefox 3.
3. Create a table.
4. Try to resize its columns by draggable.
5. It doesn't work, FF3 thinks you're wanting to drag the indicator .gif out of the document.

When you insert a table, click to the right side of it, and then add in a second table, it will display something like:

<table>...</table>

<table>...</table>

within the editor, but when you preview (or after saving) it shows up like:

<table>...</table>


<table>...</table>

The reason is that between the two tables, in the editor, there is a <p/> tag, which FF does not render. But when you preview/save, it is transformed into <p></p>.

You can see this in action at: ​http://www.screencast.com/users/DShafik/folders/Jing/media/d4769677-866b-4a5b-8d21-1aa0a31cd14c

This issue affects 2.5.1 (at least) through to, and including trunk

Reproduction procedure:

1. Open sample01.html under domain relaxation mode.
2. Open the image dialog.
3. Click "Browse Server".
4. Click on one of the uploaded image files.
5. Permission denied error.

This bug affects both Firefox 2 and Firefox 3.

We'll be working on the future on a complete reviewed support for the TAB key (see #979). Meanwhile, we should provide some basic features, and the ability to move out of the editor using TAB seems to be one of them.