Custom Query

1. Load sample01.html;
2. Place the cursor at the end of the paragraph;
3. Hit <Enter>.

The cursor will move to the start of the paragraph. The new paragraph is created in any case (just use the keyboard to move to it).

When dragging an image already contained in the editor (like a smiley, for example), it disappears on drop.

Switching to source view shows that the image has been moved to the correct place in the code, and the image reappears when switching back to WYSIWYG.

Whenever I have selected a text and tries to apply a formatting (bold/italic/font etc) the selection is collapsed and the formatting is not applied to the selected text.

Verfied with IE7 in nightly build.

Reproduction procedure:

1. Open sample01.html in Opera.
2. Place the caret to the end of the document.
3. Press backspace a few times.
4. The caret jumps around while deleting characters.

The bug does not occur in 2.4.3.

Steps to Reproduce

1. Load the following HTML:

<p><b>Testing</b></p>

2. Place the cursor at the end of the text;
3. Hit Enter.

The caret will not move, but the new paragraph is being created. It is enough to switch to Source View to see it.

When I enter new paragraph Safari moves to the beginning of the page. See attached video.

In IE6 or IE7.

Go to the FCKeditor demo page.

Click the New Page button. Text is now removed. Click the New Page button again.

If you do this... then IE crashes most of the times.

To reproduce the bug:

1. Go to sample01.html with Firefox or Safari (Popup menues aren't working in Opera 9.50 build 9660 as of now).
2. Insert an empty table to the document.
3. Right click on the empty table.
4. Try to open any submenu (e.g. "Cell") by moving the mouse cursor.
5. The submenu appears, but the original menu disappears.

There are several errors in the console trying to load the editor from a file: uri in Firefox3 beta1

(roughly translated)

Error: uncaught exception: Permission denied to set the property Window.FCK_STATUS_NOTLOADED

Error: uncaught exception: Permission to read the property HTMLDocument.getElementById denied

...

Tested on Firefox 2.0.0.11 and Internet Explorer 7

To reproduce:

1. Go to nightly sample editor
2. Paste into the source the following code:

<div><span class="text">
<table>
    <tbody>
        <tr>
            <td>test</td>
        </tr>
    </tbody>
</table></span></div>

3. Click the source button to return to wysiwyg mode.
4. Ctrl+a to select all.
5. Select Normal from the format drop-down.

The browser will return an unresponsive script alert.

This is a regression bug.

To reproduce:

1. Modify sample01.html so that it runs in domain relaxation mode.
2. Open the modified sample01.html.
3. Open a dialog, e.g. the smiley dialog.
4. Permission denied errors.

Some previous updates to the SVN seems to have broken dialog tabs.

To reproduce the issue:

1. Open any dialog with tabs. (e.g. the About dialog)
2. Click a non-selected tab.
3. The tab does not work.

Reproduction procedure:

1. Open sample01.html in IE6 (must be a native IE6 installation, MultipleIE's IE6 won't do).
2. Open image dialog, or image button dialog, or the flash dialog.
3. Close it.
4. IE6 crashes, and it forced to be closed by Windows XP.

Steps to Reproduce

1. Open sample01.html... the editor will not load at all, throwing JS errors in the console.
2. Move to another site.
3. Move back to the sample01.html page with the left arrow in the browser toolbar. The editor will now load.

Confirmed with Opera build 9812, but has been a problem with previous builds too.

When opening sample01.html, an extra paragraph space is automatically added at the top of the loaded contents.

Confirmed with Opera build 9812.

All element names are uppercased on the output produced by FCKeditor with Opera.

Confirmed with Opera build 9812.

In fckeditor 2.6 beta if you look at the source in firefox (on windows and mac os) and safari it is HTML not XHTML, but if you take a look at the same editor in Internet Explorer it is as it supposed to be XHTML (<br />, <img ... />...). It is not only happening on my implementation of fckeditor it is also present in your demo page, and included samples. I'm using php implementation.

To recreate this yourself, go look at the current FCKeditor Demo (the nightly build does it also.)

If you have text in the RTE with an applied style, for my example we'll use bold, and you try to apply that same style above that previous style in the document, when you close the tag, it removes that same style from the rest of the document below where you closed the tag.

Example: Here is your bold text. It is typically much thicker than normal text.

If you were to move that text down and try to write a line above that line and you wanted to use some bold text, there are two ways you could do it:

First, you could write the whole line out and once the line was written, highlight the part you want bold and apply it. This works fine.

The second was is to, while typing it, stop at the word you want bold, either press the B icon in the toolbar or press CTRL+B to turn bold on, and then continue typing. When doing this, when you turn bold off by either pressing the B icon in the toolbar or using CTRL+B, it removes all style from the rest of the document that matches that style.

This is a very serious usability bug and hampers productivity for our environment. Thank you for your quick investigation and fix to this problem.

This is a very serious bug which is making the full page mode unusable. To reproduce the bug:

1. Open sample07.html in any browser.
2. Switch to Source mode.
3. You'll see fck_internal.css being included inside the full page XHTML source.
4. Switch to WYSIWYG mode and back to Source mode.
5. You'll see the <LINK> tag(s) used for including our internal CSS files are being duplicated!

The issue did not exist in 2.5.1 or any 2.6 code before the floating dialog branch merge. So some changes in between must have caused this bug.

When trying to display a dialog using the new FCKDialog while on IE while in source view an error occurs.

IE says "'selection' is null or not an object"

I managed to track this error down to /fckeditor/editor/_source/internals/fckdialog.js line 112.

I don't understand in internal workings of FCKEditor fully. I have managed to work out that it's due to it trying to access the Editor which isn't about while in source view.

Adding a check for the EditMode and using the EditingArea.Textarea to select the selection seems to fix the problem. I'm not 100% sure this is the correct fix so an FCKEditor core dev will have to read though the patch I've attached.

This bug was originally reported by Wiktor. To reproduce:

1. Open sample01.html in IE7 under domain relaxation mode.
2. Crash! Boom!

It works well in IE6 though.

With Safari 3.1 when I click on fullscreen button of FCK toolbar, my browser screen become all white and I can't write on it. The only things I can do is click on Back button of my Browser.

Browser: Safari 3.1 OS: Mac OS X Leopard 10.5.2

Reproduction procedure:

1. Set FCKConfig.DocType = '<!DOCTYPE html PUBLIC "-W3CDTD XHTML 1.0 TransitionalEN" "​http://www.w3.org/TR/xhtml1/DTD/xhtml1-transitional.dtd">' ; in fckconfig.js.
2. Open sample01.html.
3. Examine the compatibility mode in the editor frame by typing "javascript: alert(frames[0].frames[0].document.compatMode);" - it is "BackCompat" which means Quirks mode. The editing frame should be running in standards compliance mode with DocType set to XHTML Transistional.

Installed both 2.6 stable and latest nightly build. I have problems with IE6. IE7 and Firefox works fine.

In IE6 the dialogboxes for copy text, links etc only works the first time. Second time (or any time later) I only get a grey box with no form fields or buttons. It doesn't matter witch one I click first. After the first time for any box, none of the boxes works.

There is one exception. The dialog box for insert image works.

Source: ​http://www.fckeditor.net/forums/viewtopic.php?f=6&t=9242

I use FCkeditor 2.6Rc in Ubuntu FIrefox 2.0.0.13, when i upload a image file, i get error message in browser error console "Error: uncaught exception: Permission denied to get property Window.OnUploadCompleted",

but when checked the upload dir in my server, the image has been actually uploaded successfully.

Steps to Reproduce

1. Load sample01.html.
2. Delete everything.
3. Type "This is a test" and hit ENTER.
4. Click after "test" to move the caret to the end of that paragraph.

The caret will jump to the start of the paragraph. After that:

5. Double click "is" and make it bold.
6. Click the end of the paragraph again.

The caret will now jump right after "is". It seems to jump right after the last element in the paragraph, if available.

The same thing happens if you try to move the caret there with the keyboard by using both the LEFT ARROW and the RIGHT ARROW.

Confirmed with Opera build 9972.

Steps to Reproduce

1. Load sample01.html.
2. Remove all text.
3. Type some text.
4. Hit ENTER.

The caret will not move to the new paragraph, but to a strange space right after the previous paragraph. When start typing the caret will move to the correct place.

This should be a known bug at Opera. I'm adding it here just for reference.

Confirmed with Opera build 9972.

When creating a new table, it's cells are not being expanded properly for editing.

Confirmed with Opera build 9972.

The PHP4 integration is not working. It throws the following error:

Fatal error: Call to undefined function FCKeditor_IsCompatibleBrowser() in D:\FCKeditor\SVN\FCKeditor\local\fckeditor_php4.php on line 167

To test it in a PHP5 environment, it is enough to change the include at the top of sample01.php to:

include("../../fckeditor_php4.php") ;

Sorry if this is a dupe.

I have four clustered webservers running a single webapp (with a reverse proxy performing round-robin with sticky server sessions). So, whenever I need file upload I use a server-side directory that is a mounted remote file system, shared between all four webservers. This directory is mapped into the URL space (context) of the webapp on each server using their server.xml configuration files.

I'd like to create a subdirectory of this shared directory to store the uploaded files (mostly images) from the FCKeditor.

I imagine a new method on the UserPathBuilder interface, so that I can specify the file system directory (in addition to the URL specified by the getUserFilesPath method).

My editor is located at ​http://static.snelgeleerd.nl/editor/, but the editor itself is called from a different subdomain, namely ​http://samenvattingen.snelgeleerd.nl/. I'm calling the editor via the following code:

<script type="text/javascript" src="http://static.snelgeleerd.nl/editor/fckeditor.js"></script>
<script type="text/javascript">
document.domain = 'snelgeleerd.nl';
window.onload = function()
{
	var oFCKeditor = new FCKeditor('body');
	oFCKeditor.BasePath = 'http://static.snelgeleerd.nl/editor/';
	oFCKeditor.ToolbarSet = 'Admin';
	oFCKeditor.ReplaceTextarea();
}
</script>

This works, except for the floating panels being called from ​http://samenvattingen.snelgeleerd.nl/editor/editor/fckdialog.html instead of ​http://static.snelgeleerd.nl/editor/editor/fckdialog.html, which results in a 404 error document.

My conclusion would be the floating panels don't respect the BasePath correctly, but it's might be something different. In any case, it's obviously a bug, right?

When loading sample01.html with en empty cache, a paragraph space is appended to the top of the contents. Clicking on that space, will append yet another space. Each click on that space will continuously append further paragraphs.

Everything looks good as soon as we have the editor on cache.

This one started to happen recently. Test with Opera build 10057.

This one has been originally reported in our Forums: ​http://www.fckeditor.net/forums/viewtopic.php?f=8&t=10049#p26511

With Opera, whenever you hit ENTER, the page scrolls, making the new line aligned at the bottom of the page, with the cursor blinking on it.

This is much probably related to the scrollIntoView(false) call we use for Firefox and Opera (Firefox is ok with it).

I'll be attaching a test page to make it clear an easy to understand.

OS: Windows XP sp2 Browser: Firefox RC3 Builds Tested: 2.6.0, 2.6.1, Nightly Build 6/15/08

Steps to reproduce:

1) Open fckEditor sample running at: ​http://www.fckeditor.net/nightly/fckeditor/_samples/default.html

2) Press the "Maximize editor size" on the toolbar

3) Press any letter followed by the enter key

4) Repeat step 3 40 times

5) Scroll to the middle of the document and set the cursor at the end of a paragraph.

6) press the enter key

BUG: Scrollbar moves up and paragraph is reposition at bottom of page.

From my understanding "ScrollIntoView" has been changed in Firefox 3 to match IE, I'll bet that is where the problem lies.

Will test will Firefox 3 final when it is released 6/17/08

Steps to Reproduce It

1. Load sample01.html, or even our online demo.
2. Double click on the "are" text to select it.
3. Click the "Bold" button in the toolbar.
4. Click again the "Bold" button to remove the style.
5. Without touching the selection, repeat steps 3 and 4 several times.

The line will keep breaking after and before "are".

But, it is not said that we have a <br> there... just switch to source and back to WYSIWYG and everything will be ok again.

Just like #2279, if having EnterMode='br' and hitting ENTER, or even using SHIFT+ENTER in the default configuration, makes the entire page to scroll.

it would be nice to see <source> tag handled better by the editor. <source> tag is added by the syntax highlighter extension (​http://www.mediawiki.org/wiki/Extension:SyntaxHighlight_GeSHi)

This bug happens both on my personal site as well as the demo FCKEditor at ​http://www.fckeditor.net/demo, so I know it's a editor-wide issue. Also, it only happens on IE7.

When you type any amount of text (longer than one line, and consisting of more than one paragraph tag), try to indent any part of the text, and then either view the source or submit the form that FCKEditor is part of, it removes the indenting that you performed. If you do the same thing as above, but do not submit the form, and simply remove the indentation and re-indent the text, it performs as expected.

Example and How to Reproduce:

Type the following text into an empty FCKEditor window in Internet Explorer 7 (a good editor to test on is the demo editor, because it is a default installation):

Test Line 1 [PRESS ENTER]
Test Line 2 [PRESS ENTER]
Test Line 3 [PRESS ENTER]
Test Line 4 [PRESS ENTER]

Now indent lines 2 and 3. View the source. Notice that there is no "style='margin-left:40px'" as an attribute of any of the <p> tags.

Reported in ​http://www.fckeditor.net/forums/viewtopic.php?f=6&t=10656

I've checked that Firefox, Opera and Safari fail to create anchors since #2263 was fixed ​http://rev.fckeditor.net/fckeditor/trunk/2138/_samples/ works and ​http://rev.fckeditor.net/fckeditor/trunk/2139/_samples/ fails

No javascript errors are generated, the <a> is created but it lacks the name attribute.

1. Edit a new MediaWiki page with FCKeditor.

2. Click the "Wikitext" button to switch to wikitext editing.

3. Enter this text:

<mytag>foobar</mytag>

4. Save the article.

5. Disable FCKEditor on the MediaWiki preferences page.

6. Edit the same page.

7. The wikitext is now:

&lt;mytag&gt;foobar&lt;/mytag&gt;

The wiki parser tag is now broken.

This is an umbrella ticket. It points to several tickets that must be completed and reviewed to properly move the CKEditor prototype to the CKEditor trunk.

Prototype SVN

The prototype can be checked out from the following URL:
​https://svn.fckeditor.net/CKEditor/branches/prototype

The Review Process

Each ticket will identify a set of files that are under review, or even specific functions. We'll not have the usual patches on those tickets. The files are to be grabbed from the prototype branch.

The review keywords (Review?, Review+ and Review-) will continue to be used here. The ticket will be closed on Review+ (by the original developer), just like a usual commit operation.

The reviewer may make direct changes to the branch code if he feels it is ok. In such case, he should point out that some parts of the code are ok, but changes should be made, pointing to the changeset that included the changes, explaining them. At this point, the ticket must also have Review+, but the original developer must review the reviewer changes to ensure they are correct before closing the ticket. If anything is wrong, further changes are to be committed and Review? is called again, here again pointing to the changeset with explanations. This process should be repeated until all parts are satisfied with the results.

Things to Review

• Specifications: the idea behind the feature must be good. The ​ODE documentation may be used as a reference, but can also be questioned.
• Functionality: the code must do what it's intended to do.
• Coding Style: the syntax must respect our ​Coding Style Guidelines. Don't be afraid to correct small things, like a space before a semicolon, or extra tabs.
• Performance Optimizations: our code must run as fast as possible. Here again, micro-optimizations are welcome.
• Code Simplification: less code is (usually) better. If something can be done in a simpler way, we must do it in that way.
• API Documentation: our entire code must be properly documented. The reviewer is invited to enhance it if needed.
• Tests: each single piece of the code must have well written tests to ensure its efficiency. If the present tests are not enough, the reviewer should explain that the code looks good, but the tests are not. The reviewer is invited to write missing tests.

Current Development

The prototype will be on continuous development during the review process. It will be moved to the trunk as a whole, as soon as this ticket gets closed. The development over the prototype branch will end then.

If the development touches code that has already been reviewed, its relative ticket must be reopened and the review must be requested again, possibly pointing to the changeset that introduced the changes to be reviewed. If the review request is open, changes must be added to a comment, so the reviewer can get notified of it.

Tickets Under Review

Several keywords will be used to identify tickets that are under review. These keywords will group the tickets in the following lists:

Structural and Development Features

Base Features

Core Features

Plugins

No results

Other

For example:

Bienvenu?

becomes

{{SITENAME}}:Welcome"&gt;Bienvenu?

which is of course not only incorrect but also invalid.

For example:

image page?

becomes

[[Image:X.jpg|image page]]

I've marked this as "high priority" because the image itself is embedded on the page, instead of a hyperlink to the image description page.

The problem has existed for some time and can be seen for example in version 2.5 SVN build 19965.

Summary:

If you create a form which contains multiple instances of the FCK Editor, Firefox3 will only send updates to one of the instances if you submit the form via javascript (form.submit()). Submitting the same form via a "native" submit button (input type="submit") will send the form as expected.

See sample form attached (modified sample file as detailed below)

Steps to replicate:

1. Open the sample09.html bundled with the editor fckeditor/_samples/html/sample09.html

2. Edit the sample code to add a second button at the bottom which submits the form via javascript

<input type="submit" value="Submit (button)" />
<input type="button" value="Submit (javascript)" onclick="document.testform.submit()"/>

3. Run the sample in firefox 3.0.1

4. Edit the values in both editor regions to "XX" and submit the form using "native" submit button. Notice that the receiving page shows the correct data ("XX").

5. run the sample again and change the field values to "YY" and submit the form using the javascript button. Notice that the receiving page shows only one of the regions updated (i.e. the first region shows "YY" and the other shows the default value)

Notes

• tested in version 2.6.3 and nightly build (2008-09-02)
  
• behaviour not present in IE7 or FF2.x
  
• Inspecting the hidden "value" field at the point where the form is submitted (FF3) shows the value only being updated for one instance of the editor at a time.

It's a bit of an issue if you're using external validation (like qForms) or if the page design requires that the activation buttons for the form are outside the form boundaries.

Today, I've checked out MediaWiki 1.14 alpha and FCKEditor extension from their respective SVN repositories.

Added the following line at the end of MediaWiki's LocalSettings.php to enable extension :

require_once( "extensions/FCKeditor/FCKeditor.php" );

Then got an empty page and a two lines error in Apache error.log :

PHP Warning: require_once(D:
install
MediaWiki phase3/includes/parser/Parser_OldPP.php) [<a href='function.require-once'>function.require-once</a>]: failed to open stream: No such file or directory in D:
install
MediaWiki phase3
extensions
FCKEditor
FCKeditor.php on line 33, referer: ​http://localhost:88/index.php/Accueil

PHP Fatal error: require_once() [<a href='function.require'>function.require</a>]: Failed opening required 'D:
install
MediaWiki phase3/includes/parser/Parser_OldPP.php' (include_path='D:
install
MediaWiki phase3;D:
install
MediaWiki phase3/includes;D:
install
MediaWiki phase3/languages;.;C:
php5
pear') in D:
install
MediaWiki phase3
extensions
FCKEditor
FCKeditor.php on line 33, referer: ​http://localhost:88/index.php/Accueil

Line 33 in file FCKeditor.php just include Parser_OldPP.php :

...
if (version_compare("1.13alpha", $wgVersion, "<=")) {
    require_once $IP . "/includes/parser/ParserOptions.php";
    require_once $IP . "/includes/parser/Parser_OldPP.php";
    require_once dirname(__FILE__) . DIRECTORY_SEPARATOR . "mw12/FCKeditorParser_OldPP.body.php";
}
...

Well, the fact is that revision 43835 (dated from Nov, 21st) in MW's SVN just removed the file with comment "* Dropped old Paser_OldPP class. Only new parser with preprocessor is used. Death to the old parser! Long live the preprocessor!".

I guess the answer is that it is now time to move to new Parser.php ? What do you great people think ?

1. Go to nightly build

​http://www.fckeditor.net/nightly/fckeditor/_samples/default.html

2. Select sample text and change to "Formatted" format
3. Click the Source button

Expected:

Same text in <pre> </pre> tags.

Observed:

<pre>_FCKpd_1</pre>

Note: Marked high as this will garble any existing code snippets using this format.

Currently, we are placing all language entries into a single object definition in the main en.js file. We are ending up with a long list of keys with strings associated to then, just like we have in FCKeditor.

We are again using prefixes to group related keys in this long dictionary. So we have things like dlgTableTitle, dlgReplaceTitle and dlgFindTitle, each one being a reference to the specific dialog title.

We have now the chance to review the way we define this dictionary. We can make it easier to maintain, simpler to read and even smaller in size by grouping things inside an object "tree". For example:

CKEDITOR.lang['en'] =
{
	link :
	{
		button : 'Link\u200b',
		dialog : 'Link',
		info : 'Link Info',
		target : 'Target',
		...

		unlink : 'Unlink',
		...
	},

	specialchar : 
	{
		dialog : 'Select Special Character'
	},

	find :
	{
		dialogFindReplace : 'Find and Replace',

		find :
		{
			dialog : 'Find',
			button : 'Find',
			...
		},

		replace : 
		{
			dialog : 'Replace',
			button : 'Replace',
			findLbl : 'Find what:',
			replaceLbl : 'Replace with:',
			...
		}
	},

	...
};

Note that I've used the plugin name as the main grouping object for each set of entries. I think this is the best way to do that, even if we have a single entry for each plugin (avoiding issues if we need further entries in the future).

We should be then able to simply call things like editor.lang.link.button to grab the relative string, instead of {{{editor.lang.linkButton))).

Also note that prefixes like "dlg" are also to be avoided. Most of the language entries for dialog based plugins are dialog related things, so there is no sense on prefixing all of them with "dlg".

Artur says he needs it for completing the Flash dialog, I should finish it on Monday by porting it from v2.

To reproduce the bug:

1. Open replacebyclass.html in the samples in Firefox 3.
2. Also open ​http://gplv3.fsf.org/ in Firefox 3.
3. Copy everything in FSF's page into the editing area.
4. Click "Source" - the browser freezes.

This is not a performance problem with the new code - I've tried pasting the long text of GPL v3 in the editor area and the speed of switching to source mode is noticeable faster than v2.

Preliminary tests showed that the infinite loop is from the HTML data processor plugin.

To reproduce:

1. Open the replacebyclass.html sample in IE6.
2. Add a default 2x3 table there.
3. Switch to source mode.
4. The HTML source for the table is seemingly not there... but it's only because the source mode text area is too small and is having s scroll bar.

To reproduce:

1. Open replacebyclass.html sample in IE6.
2. Click anywhere in the paragraph within the editing area.
3. Switch to source mode.
4. You get something like this, note the _cke_expando attribute - it shouldn't be there:

   <p _cke_expando="125">
   	This is some <strong _cke_expando="124">sample text</strong>. You are using <a href="http://www.fckeditor.net/">FCKeditor</a>.</p>
   

This bug cause image invisible when switching between two modes,witness on IE7.

1. Open an editor instance and insert any visible image
2. Switch to 'sourcearea' mode
3. Switch back to 'wysiwyg' mode
   • Expected: nothing changed
   • Actual: image invisible, because of attribute 'src' was converted to 'url'

The default configurations for each plugin must be defined inside each plugin.js file, not into the core config.js file. Just core settings should go into that file.

The motivation behind it is that the core config.js file will be always part of the compressed version of CKEditor. So, if I reduce the number of plugins when building the compressed version, I should not have plugin specific stuff being included in the process.

Several of the dialog based plugins have been created with a standard "defaultValues" setting, which defines the default values to be used on dialogs.

The idea behind this is quite nice, as it makes it easy to set such values. This is a common request we have. But, the implementation took the easy way, which is not the best unfortunately.

The critical fact around this solution is that it makes our code bigger, and we must always keep in mind that our compressed code must be as small as possible.

But, we still need to support such customization. This is something Alfonso has described in #1099.

The nice thing is that it's already possible to do that by using our new API. Martin is working on a new sample for #2790, which will show how to do that.

So, we should remove this stuff from the configuration to benefit our code size.

Just like in #2792, we should not have specific setting to hide dialog tabs (like showAdvancedTab). We have inherited some of them from FCKeditor, but those should not be necessary anymore.

To reproduce:

1. Open replacebyclass.html in Firefox 3.
2. Double click on the empty area to the right of the first paragraph to select the whole paragraph.
3. Try to apply any style, e.g. press the bold button.
4. It doesn't work.

The skin.js file for the default skin makes references to CKEDITOR.dialog, assuming that it will be always loaded, which is false.

Anything into core should depend on a plugin.

Into the default skin.js file, we can find references to CKEDITOR.dialog.setMargins and CKEDITOR.dialog.on( 'resize' ). This is bad, because it assumes that all editor instances are using a single skin, which is false.

All settings must go inside each single editor instance. Also, events like "resize" should be fired by each instance. The event could be named "dialogResize", for example.

The current implementation of insertHtml and insertElement could be simplified. Also, it includes the insertion logic inside the editingblock plugin, which is wrong.

This is something we though would be good, but I've just found out that it's evil. We must not use namespaces to organize the configurations under CKEDITOR.config, like CKEDITOR.config.dialog.magnetDistance.

The reason why is that, if you try to change this setting in a custom configuration file (like the root config.js), the namespace (CKEDITOR.config.dialog) will not yet be available, because the dialog plugin will not yet be loaded. So, the execution breaks.

We should still organize the configurations in a meaningful way, so I'm opting to use a "prefix", instead of a namespace there. In the above case, we would have CKEDITOR.config.dialog_magnetDistance.

Steps to reproduce: -Open sample.html?sample=replacebyclass -Click Source -Click Smile button

Result: JS Error and cancel button doesn't work.

this.document is null
http://localhost/edytor/CKEditor/trunk/_source/plugins/selection/plugin.js
Line 219

Steps to Reproduce

1. Load the editor.
2. Select some text.
3. Switch to source.

In IE, and error is thrown. No problem with FF.

There is a common repetition in the current code:

var command = editor.getCommand( name );
command.state = newState;
command.fire( 'state' );

This logic could be encapsulated inside the CKEDITOR.command class, so we can achieve the same thing with:

editor.getCommand( name ).setState( newState );

If you define the initial command state into the command definition, it is not currently respected when loading the editor and rendering the toolbar buttons. All buttons are always in the "on" state.

The buttons should instead reflect the command state.

Event delegation registration with CKEDITOR.event.implementOnis currently incorrect, when this method is invoked on prototype object of a constructor, then instances of this constructor will share the same private _.events model, which is wrong. This would result in duplicate invocation of event listeners from two different object.

Functonal TestCase

Tested with test-events-duplicate.path

When adding a new numbered list at the end of the document, the list item is inserted correctly but the carat is positioned before the first list item and it is not possible to navigate to the first list item within WYSIWYG mode.

Steps to reproduce:

1. Open nightly build. Currently (​http://nightly.ckeditor.com/3105/_samples/replacebyclass.html)
   
2. Add new line to the existing text in the editor
   
3. Insert numbered list
   

Expected behavior: The new list is created with one item and the carat is positioned just after the number of the first item.

Actual behavior: The new list is created as expected. The position of the carat is placed before the first item in the list. It is not possible to navigate to the first item in the list.

It is not possible to modify a table after it has been inserted into the document using the editor.

The panels of toolbar combos must have their upper left corner perfectly aligned with the lower left corner of the combo when opened. Currently they are a few pixels mispositioned to left and top.

In IE6 the toolbar combos panels have horizontal scrollbars.

When opening a toolbar combo for the first time, it's possible to briefly see its contents with no style which immediately gets re-rendered with the styles applied.

This is noticeable in Firefox only.

There is a really bad performance in the tasks being fired when the selection changes in the editor. To check it:

1. Clean load a sample.
2. With a mouse click, place the cursor inside any unformatted word, like "are".
3. Open the Firebug console and start a Profile job. Don't do anything in the editor, not even a mouseover in the toolbar buttons.
4. Click inside a bold word, like "sample". Again, don't do anything else in the editor.
5. Stop the Profile job.

The profiler will show you an excessive number of calls.

In IE6 this bad performance is terribly noticeable, compromising the editor usage.

Performance excellence is definitely important for this feature.

This issue happens only after preparing the trunk for release, not with the trunk code. It can be checked in the ​nightly build demo.

You will notice that the toolbar buttons in the first editor instance will not change their state in any way. They will not reflect the context sensitiveness, not even the Source button will remain ON when moving to source.

The second instance will work well though.

IE is not able to manage multiple selection, even cross frame. Because of this, the current selection gets lost when leaving the editing area.

The current selection should be automatically saved when the editing area looses the focus in IE and then reselected when the focus is moved back to it.

By doing that, we can remove all selection hacks we are doing now for dialogs, floating panes, etc.

The current selectable elements( elements which could be retrieved from CKEDITOR.dom.selection.getSelectedElement) below is lacking of other control types like a,input,form.

var styleObjectElements = { img:1,hr:1,li:1,table:1,tr:1,td:1,embed:1,object:1,ol:1,ul:1 };

The combo features do not work in FF2.

Steps to reproduce:

1. Go to ​http://nightly.ckeditor.com/3121/_samples/replacebyclass.html
   
2. Select one of [Style|Format|Font|Size] Combo

Results in error.

Firebug error:
this.$ has no properties
​http://nightly.ckeditor.com/3121/ckeditor.js
Line 11

Because of the introducing of #3003, html parser should be able to take care different forms of abbreviation, e.g. attribute without quote and abbreviation.

With IE6, the following issues have been reported by Martin at #3057:

1. The size of context menus is incorrect at the first menus are opened.
2. The size of separators are incorrect.
3. Scrollbars appear in context menus when the mouse cursor is inside the menus.

I am using Mediawiki 1.14.0 + FCKeditor. The FCKeditor extension is download from SVN, and fckeditor is 2.6.4.

When I open a existing article to start editing, I find the links in that article has been replaced with "RTENOTITLE". When I click "Wikitext" button to switch to Wikitext mode, the link has been replaced with something like "/wiki/index.php/My article title".

How to avoid this?

Thanks!

Procedures

1. Open the replace by code example page;
2. Initial the document with the following content and selection:

   ^outter<table><tr><td>text</td></tr></table>outter^
   

3. Apply different fonts three times with the same range.

• Actual Result : The document result in:

  <span style="font-family: Courier New,Courier,monospace;">outter</span>
  <table>
  	<tbody>
  		<tr>
  			<td>
  				<span style="font-family: Courier New,Courier,monospace;">text</span></td>
  		</tr>
  	</tbody>
  </table>
  <table>
  	<tbody>
  		<tr>
  			<td>
  			</td>
  		</tr>
  	</tbody>
  </table>
  <span style="font-family: Courier New,Courier,monospace;">outter</span>
  

Procedures

1. Open the replace by code example page;
2. Initial the document with the following content and selection:

   	<ol>
   		<li>level1</li>
   		<li>leve1
   			<ol>
   				<li>^level2</li>
   			</ol>
   		</li>
   	</ol>
   
   

3. Click on Outdent button to degrade list item once.
4. Click on Indent button to arise list item once.

• Actual Result: The previous list item was indented too.

  <ol>
  	<li>
  		level1
  		<ol>
  			<li>
  				leve1</li>
  			<li>
  				level2</li>
  		</ol>
  	</li>
  </ol>
  

In V2 it worked fine but in V3 opening of the toolbar dropdown controls fires the windiw.onbeforeunload. To reproduce this bug simply add the following JS code and try to open a toolbar dropdown. Probably it happens because the new version uses IFrame for the dropdown content.

<script>
window.onbeforeunload = function() {
	alert("window.onbeforeunload");
		//if(CKEDITOR.instances["content"].checkDirty())
		//	return "Page has not been saved!";
	}
</script>

IE throws an error when clicking on the Styles combo.

1. Create several paragraphs of text.
2. Select text starting at one paragraph until the middle of the next one.
3. Apply any heading format.

An error is thrown and the style is not applied.

Image Plugin - Advanced tab's Id field is not getting added to the editor area. Ex: I have added id as '12345' but the result in the editor source is missing the id field,

<img align="absbottom" alt="Oracle" border="10" height="41" hspace="11" src="/cache/abc.gif" vspace="33" width="145" /><br />

We have a business logic that is using this id field. Since the id field is not populated, our functionality is broken.Please fix it as early as possible.

Request for multi-language files for all the features available in CKEditor 3.0

Reproducing Procedures

1. Open the replace by code example page;
2. Make document content and selection as following by double click on cell:

   <table>
   	<tbody>
   		<tr>
   			<td>^
   				text^</td>
   		</tr>
   	</tbody>
   </table>
   

   1. Open link dialog to insert a default link.
   • Actual Result : The link is not inserted at all.

Additional information: This is actually a style system bug. The same thing happens if you press the bold button or try to apply any inline style with the HTML and selection above.

To reproduce:

1. Open replacebyclass.html in IE.
2. Select "You".
3. Change the font size to 8.
4. Select "You are using".
5. Change the font size to 16.
6. Move the caret to inside "You" by clicking on it.
7. While the font size is visually 16, a size of 8 is displayed in the size combo.

Similarly, selecting "Arial" in step 3 with the font combo and then "Comic Sans MS" in step 5 would also result in wrong font detection.

Reproducing Procedures

1. Open the replace by code example page;
2. Make document content and selection as following:

   <ol>
   	<li>
   		level1 ^</li>
   </ol>
   text
   

3. Press Enter key
   • Actual Result :

     <ol>
     	<li>
     		level1 <br />
     	</li>
     </ol>
     text
     

   • Expected Result :

     <ol>
     	<li>
     		level1 </li>
     	<li>
     		<br />
     	</li>
     </ol>
     text
     

Reproducing Procedures

1. Open the replace by code example page;
2. Delete all the content within document;
3. Open flash dialog and fill in url with : ​http://f.friendster-tweakers.com/rsc/swf/clock/fsdbp.swf, specify width with '100', height with '100', click Ok to insert the flash.

• Actual Result : The style is been attached to the wrapping paragraph element.

  <p>
  	<p height="100" width="100">
  		<object classid="clsid:d27cdb6e-ae6d-11cf-96b8-444553540000" codebase="http://download.macromedia.com/pub/shockwave/cabs/flash/swflash.cab#version=6,0,40,0" height="100" width="100"><param name="quality" value="high"></param><param name="movie" value="http://f.friendster-tweakers.com/rsc/swf/clock/fsdbp.swf"></param><embed height="100" pluginspage="http://www.macromedia.com/go/getflashplayer" quality="high" src="http://f.friendster-tweakers.com/rsc/swf/clock/fsdbp.swf" type="application/x-shockwave-flash" width="100"></embed></object></p>
  	<br />
  </p>
  

• Expected Result :

  <p>
  		<object classid="clsid:d27cdb6e-ae6d-11cf-96b8-444553540000" codebase="http://download.macromedia.com/pub/shockwave/cabs/flash/swflash.cab#version=6,0,40,0" height="100" width="100"><param name="quality" value="high"></param><param name="movie" value="http://f.friendster-tweakers.com/rsc/swf/clock/fsdbp.swf"></param><embed height="100" pluginspage="http://www.macromedia.com/go/getflashplayer" quality="high" src="http://f.friendster-tweakers.com/rsc/swf/clock/fsdbp.swf" type="application/x-shockwave-flash" width="100"></embed></object>
  	<br />
  </p>
  

In IE:

1. In the sample.html file, set the document.domain to a part of the URL. For example, my local testing url is "dev.ckeditor.local", so I'm setting it to "ckeditor.local".

2. Open a sample.

3. Open a toolbar combo, color selector or the context menu.

An error is thrown: "Access denied".

1. open the Replace dialog and write any word in Find what.

2. Hit the Tab button.

Result: the word disappears.

During some tests with our so loved and weird IE, I was able to, somehow, end up with an innerHTML that I was able to reduce to the following:

<TABLE>
	<TR>
		<TD></TD>
		<P></P>
		<TD></TD>
	</TR>
</TABLE>

I can't recall how I got that HTML (maybe during some block styling task), but the fact is that a user may have such thing while using the editor in IE. The browser simply accepts it.

The big problem is not the above though. The real issue is the, if you try to retrieve the above HTML from the editor, or even feed it into the source view, it will throw you "Out of memory" into the html parser code.

After #3191, the dialogs are not anymore correctly centered when opened.

Currently, it's not possible to have a skin placed outside the "skin" folder into editor installation path.

Currently, the UI doesn't offer full support for RTL.

The default skin, "v2" for now, is not being properly loaded once the editor gets released.

The _samples/samples.js file is support file used by the development version of CKEditor. It's not needed at all after release, but it's still included in the sample files.

It must be removed during release, as well as its inclusion at the samples headers.

If scrolling down the main page, when clicking on a dialog based button the page scrolls up to the top.

Confirmed with FF at least.

Currently, CKEditor offers a way to provide the toolbar definition by setting it directly to the "toolbar" setting.

While that is useful, it would be still nice to have more than one toolbar definitions in the configuration file, making it possible switching them with a simple setting, just like V2.

The idea would be introducing the "toolbarSets" object setting, which accepts several definitions, and then make the "toolbar" setting smart. If it receives a string, its the toolbarSet name, otherwise it's a toolbar definition.