Custom Query

Filters
 
Or
 
  
 
Columns

Show under each result:


Results (101 - 200 of 321)

1 2 3 4
Ticket Summary Keywords Owner Type Status Priority
#2500 Mac: Context menus always disabled with BrowserContextMenuOnCtrl HasPatch Bug closed Normal
Description

In Firefox 3, and likely in other browsers, too, it's not possible for Macs to access the context menu when FCKConfig.BrowserContextMenuOnCtrl is enabled.

Macs don't have two mouse buttons; without custom hardware, the way that context menus are triggered in OSX is by pressing the ctrl key. Unfortunately, this means that if the FCKConfig.BrowserContextMenuOnCtrl value is set, it *always* blocks the fck context menu on Mac, because e.ctrlKey is always true when the context menu is triggered:

( el._FCKContextMenu.CtrlDisable && ( e.ctrlKey || e.metaKey ) )
One fix is to replace the ( e.ctrlKey
e.metaKey ) condition with this:
( ( e.ctrlKey && !FCKBrowserInfo.IsMac  ) || e.metaKey )

That will offer the ctrl-key option for non-Mac systems while allowing the Command-key option for Macs.

My suggestion is to replace lines 101 and 129 (both identical) in fckcontextmenu.js:

if ( el._FCKContextMenu.CtrlDisable && ( e.ctrlKey || e.metaKey ) )

...with this:

if ( el._FCKContextMenu.CtrlDisable
     && ( e.ctrlKey && !FCKBrowserInfo.IsMac ) || e.metaKey ) )

And replace line 176 of fckcontextmenu.js:

if ( ( fckContextMenu.CtrlDisable && ( ev.ctrlKey || ev.metaKey ) ) || FCKConfig.BrowserContextMenu )

...with this:

if ( ( fckContextMenu.CtrlDisable
       && ( e.ctrlKey && !FCKBrowserInfo.IsMac ) || e.metaKey )
   || FCKConfig.BrowserContextMenu )
#2512 IE8 beta2, contents of dialogs don't fill the width of the container Confirmed IE8 HasPatch Alfonso Martínez de Lizarrondo Bug closed Normal
Description

Sometimes works, and sometimes fails. And sometimes suddenly changes from one situation to the other while the dialog is open.

Check screenshot.

#2515 Icelandic Language File 2.6.3 HasPatch Review+ Frederico Caldeira Knabben New Feature closed Normal
Description

Language file for Icelandic (new). 2.6.3 Compliant. The translator is a programmer and MA in Icelandic Linguistics, who has been using the file for his own website for two years.

#2522 Bug report: no empty value on firefox HasPatch Bug closed Normal
Description

I used on the last ver of the fckeditor(Night build), and when i set the value to ""[empty] on firefox the value become to "<br>".

This bug makes some problems, start by the empty checking(& I have to "igonore" it by php) and continue to char counting.

I hope to find an any solution.

Best regards, Almog Baku,

Israel

#2561 Converted fckeditor.pl into PERL module HasPatch New Feature closed Normal
Description
#  Usage: 

#	1.	Put this command at the top of your PERL program:

#

#			use FCKeditor;

#

#	2.	Where you want to place the FCKeditor in your output,

#		call FCKeditor::create() as follows:

#

#		$html_string = FCKeditor::create($InstanceName,$BasePath);

#

#		This will produce an HTML string which effectively replaces

#		a <textarea name=$InstanceName></textarea> field in your form.

#		Note that there are a few other parameters which you can

#		specify in the create() call, noted below.  Height and 

#		width, for example.

#

#		You can then integrate this HTML code directly into your

#		Output.  For example:

#

#		use FCKeditor;

#		print 'content-type: text/html\n\n';

#		print '<html><body><form method=get action="this.pl">';

#		print '<p>Enter Your Message Here:</p>';

#		print FCKeditor::create();

#		print '<input type=submit name="OK" value="OK">';

#		print '</form></body></html>';

#

#		Or you could send the string to the Template module, 

#		depending on how you output your HTML.  Your return CGI

#		program will then look for a parameter "editor", which is

#		the default (see $InstanceName).


<a href="http://www.unlikelysource.com/perl_demo/html_email.pl">Demo of FCKeditor running with PERL</a>
<a href="http://www.unlikelysource.com/perl_demo/FCKeditor.pm">FCKeditor PERL module</a>
#2589 changing style when typing text works incorrectly HasPatch Bug confirmed Normal
Description

Start typing some text in demo. Switch to some style that is actually span (Marker-green for one), type more, switch to Marker-yellow, type more, switch to Marker-green again - type and see that text continue to be yellow. So we can't swith to the first applied style when continue typing.

#2606 Deleting a button (Safari) adds text-align: center to remaining contents Confirmed HasPatch Safari Dmiry Polyakov Bug closed Normal
Description

To reproduce (in Safari):

All the remaining content in the Fckeditor box is now center aligned thanks to "text-align: center" being added to the <P> tag. We've found this to be incredibly confusing to explain to the end users, even though clicking the "Left Justify" button restores the proper left alignment. Our application relies on a lot of buttons, so this becomes an issue for us more than normal.

#2622 Automatic dispatching of uploaded files to different folders HasPatch New Feature confirmed Normal
Description

I suggest to add an option for automatic dispatching of uploaded files to different folders set in filemanager…config.php file according to the file type. For example, if an image is uploaded as 'FILE', it would be nevertheless directed to the 'images' folder (if set) and if a new file type such as 'PDF' is created in config.php for file extension 'pdf' with a 'pdf_folder' destination folder, then FileUpload function would send it to this folder.

I patched my version successfully by easily adding just the following two lines of code in filemanager…command.php (and moving down a bit an original one).

Before:

	if ( isset( $_FILES['NewFile'] ) && !is_null( $_FILES['NewFile']['tmp_name'] ) )
	{
		global $Config ;

		$oFile = $_FILES['NewFile'] ;

		// Map the virtual path to the local server path.
		$sServerDir = ServerMapFolder( $resourceType, $currentFolder, $sCommand ) ;

		// Get the uploaded file name.
		$sFileName = $oFile['name'] ;
		$sFileName = SanitizeFileName( $sFileName ) ;

		$sOriginalFileName = $sFileName ;

		// Get the extension.
		$sExtension = substr( $sFileName, ( strrpos($sFileName, '.') + 1 ) ) ;
		$sExtension = strtolower( $sExtension ) ;

		if ( isset( $Config['SecureImageUploads'] ) )
		{
			if ( ( $isImageValid = IsImageValid( $oFile['tmp_name'], $sExtension ) ) === false )
			{
				$sErrorNumber = '202' ;
			}
		}

After:

	if ( isset( $_FILES['NewFile'] ) && !is_null( $_FILES['NewFile']['tmp_name'] ) )
	{
		global $Config ;

		$oFile = $_FILES['NewFile'] ;

		// Get the uploaded file name.
		$sFileName = $oFile['name'] ;
		$sFileName = SanitizeFileName( $sFileName ) ;

		$sOriginalFileName = $sFileName ;

		// Get the extension.
		$sExtension = substr( $sFileName, ( strrpos($sFileName, '.') + 1 ) ) ;
		$sExtension = strtolower( $sExtension ) ;

		foreach($Config['ConfigAllowedTypes'] as $type) {	 // #PATCH: automatically dispatch uploaded files
			if($type != 'File' && in_array($sExtension, $Config['AllowedExtensions'][$type])) {
				$resourceType = $type;
			}
		}

		// Map the virtual path to the local server path. #PATCH: moved down
		$sServerDir = ServerMapFolder( $resourceType, $currentFolder, $sCommand ) ; // #HACK: original line moved down

		if ( isset( $Config['SecureImageUploads'] ) )
		{
			if ( ( $isImageValid = IsImageValid( $oFile['tmp_name'], $sExtension ) ) === false )
			{
				$sErrorNumber = '202' ;
			}
		}

filemanager…config.php sample:

// Allowed Resource Types.
$Config['ConfigAllowedTypes'] = array('File', 'Image', 'Flash', 'Media', 'PDF') ;
…
$Config['AllowedExtensions']['File']	= array('7z', 'csv', 'doc', 'gz', 'gzip', 'ods', 'odt', 'ppt', 'pxd', 'rar', 'rtf', 'sdc', 'sitd', 'sxc', 'sxw', 'tar', 'tgz', 'txt', 'vsd', 'xls', 'xml', 'zip') ;
$Config['DeniedExtensions']['File']	= array() ;
$Config['FileTypesPath']['File']	= $Config['UserFilesPath'] . 'misc/' ;
…
$Config['AllowedExtensions']['Image']	= array('bmp','gif','jpeg','jpg','png') ;
$Config['DeniedExtensions']['Image']	= array() ;
$Config['FileTypesPath']['Image']	= $Config['UserFilesPath'] . 'images/' ;
…
$Config['AllowedExtensions']['Flash']	= array('swf','fla', 'flv') ;
$Config['DeniedExtensions']['Flash']	= array() ;
$Config['FileTypesPath']['Flash']	= $Config['UserFilesPath'] . 'flash/' ;
…
$Config['AllowedExtensions']['Media']	= array('aiff', 'asf', 'avi', 'mid', 'mov', 'mp3', 'mp4', 'mpc', 'mpeg', 'mpg', 'qt', 'ram', 'rm', 'rmi', 'rmvb', 'tif', 'tiff', 'wav', 'wma', 'wmv') ;
$Config['DeniedExtensions']['Media']	= array() ;
$Config['FileTypesPath']['Media']	= $Config['UserFilesPath'] . 'media/' ;
…
$Config['AllowedExtensions']['PDF']	= array('pdf') ;
$Config['DeniedExtensions']['PDF']	= array() ;
$Config['FileTypesPath']['PDF']		= $Config['UserFilesPath'] . 'pdf/' ;
#2627 Link relationship (rel attribute) on "advanced" tab for links HasPatch New Feature closed Normal
Description

I have attached a patch that implements the rel="" attribute for link tags.

This may be somewhat a dupe of ticket:2145, but I notice Ben listed multiple feature requests in his ticket, which is shunned.

In any case, the patch is a pretty simple one, however it halves the space in the advanced tab for the "styles" text box.

I'm also unfamiliar with the code base, so not sure if I've missed anything, such as unit tests etc.

#2629 Autogrow does not work with default fckeditor.js file HasPatch Bug closed Normal
Description

Because the fckeditor.js file stipulates a default height here
Line 34: this.Height = height || '200' ;

Changing this line to read
Line 34: this.Height = height;

Fixes the problem.

This was a very frustrating bug to figure out with many hours wasted tracking it down, in the least the plugin source should be documented to note this problem.

#2630 Empty span tags not removed when using Placeholder plugin HasPatch Bug closed Normal
Description

When using the placeholder plugin, which is part of the standard FCK download, empty XHTML-style span tags no longer get removed.

For example, enter the following HTML in de source view:

<html dir="ltr">
    <head>
        <title>Test</title>
    </head>
    <body>
    	<span style="color: white" />
    </body>
</html>

Switch to WYSIWYG-mode and back to the source. Without the placeholder plugin, the span will be removed. With the plugin enabled, the span will stay, causing unwanted behaviour because of a IE6/7 rendering bug for XHTML span tags.

After some debugging, I've discovered this problem is easily fixed by changing one line in the plugin:

Original code:

    FCKXHtml._AppendChildNodes( node, htmlNode, false ) ;

Fix:

    node = FCKXHtml._AppendChildNodes( node, htmlNode, false ) ;

And maybe even better;

node = FCKXHtml._AppendChildNodes( node, htmlNode, Boolean( FCKListsLib.NonEmptyBlockElements[ sNodeName ]) ) ;

Ofcourse this fix is not critical to standard FCK functionality, but the placeholder plugin is an interesting example for FCK customization and would be good to fix it.

Kind regards,

Niels Noorlander.

#2667 DocTypeDeclaration fck_docprops.html HasPatch Pending Bug closed Normal
Description

When using the document property,
the doctype declaration does not work very well.
It is not loaded when using firefox and loaded as other on IE7.

The problem is that a value is use for a select, instead of the selectedIndex.
( And the comparaison must be case-insensitive ???).

Here is a patch

Index: editor/dialog/fck_docprops.html
===================================================================
--- editor/dialog/fck_docprops.html	(revision 2374)
+++ editor/dialog/fck_docprops.html	(working copy)
@@ -204,9 +204,18 @@
 	}
 
 	// Document Type.
+	
 	if ( FCK.DocTypeDeclaration && FCK.DocTypeDeclaration.length > 0 )
 	{
-		GetE('selDocType').value = FCK.DocTypeDeclaration ;
+		var selDocType = GetE('selDocType'); 
+		var dtd = FCK.DocTypeDeclaration.toString().toUpperCase();
+		for ( var i = 0; i < selDocType.options.length; i++ ) {
+			if ( selDocType.options[i].value.toUpperCase() == dtd ) {
+			 selDocType.selectedIndex = i;
+			 break;
+			}
+		}
+		
 
 		if ( GetE('selDocType').selectedIndex == -1 )
 		{

#2686 Input Japanese for Mac Firefox HasPatch Bug closed Normal
Description

=====================================
Macbook: MB402J
OS: Mac OSX 10.5 Leopard
Browser: Firefox 3.04
Input Japanese Program: Kotoeri
=====================================

In Japanese, pressed "Return" decide word-section (Because selected KANJI). Of course, This Return is not "Break".
Now this "Return" insert "Break"(like <br>,<p>) and not necessary wods(maybe after selection).

Both IME and Kotoeri cause this bug. Only Firefox. Safari is OK.

http://positlog.org/tag/Firefox(Site)
http://positlog.org/pages/071212pG/File/fckkeystrokehandler.js.txt(Fixed)
I find this bug and how to fix in the site. The site owner said, report one of the day. But he didin't report yet.

Now, Japanes Enginer fixed myself. Please merge or fix this bug!!

#2713 New translation of preferences messages: Spanish HasPatch Artur Formella New Feature closed Normal
Description

I have make the translation for strings shown in preferences dialog of MediaWiki+FCKeditor User preferences.

This translation is not disponible in the .tar.gz fichier version 2.5.1 offered in main MediaWiki+FCKeditor web page.

#2714 Improved translation of preferences messages: Galician HasPatch Artur Formella New Feature closed Normal
Description

I have added a few phrases to the list of strings for the preferences dialogue of MediaWiki+FCKeditor User Preferences.

The translation in galician was not complete in the .tar.gz fichier (version 2.5.1) offered in MediaWiki+FCKeditor main web page.

#2715 Improved translation of preferences messages: French HasPatch Artur Formella New Feature closed Normal
Description

I have added a few phrases to the list of strings for the preferences dialogue of MediaWiki+FCKeditor User Preferences.

The translation in French was not complete in the .tar.gz fichier (version 2.5.1) offered in MediaWiki+FCKeditor main web page.

#2727 FCKDomTools.GetIndexOf(node) failed for IE HasPatch IE Bug closed Normal
Description

Steps to reproduce

  1. Load following code into source view:
<P><SPAN><P>aaa</P></SPAN><P>bbb</P>
  1. Back to WYSIWYG
  1. Press enter key
  1. Move cursor to the end of "aaa", press enter key

Expected results

Step 3 should create a new line at the page top.

Step 4 should create a new line between "aaa" and "bbb".

Current behavior

Step 3 created a new line between "aaa" and "bbb".

Step 4 created a new line at the page top.

Browsers

IE6, IE7.

Known facts

For IE6/IE7, the following is surprisingly true for above example:

node.firstChild ≠ node.childNodes[0]

Attached test.html can show above effects.

#2733 Changing table cell properties cannot be undone (undoes the previous action instead) Confirmed HasPatch Bug closed Normal
Description

Changing table cell properties does not insert an undo step. The result of this is that the change in properties cannot be undone. The previous action is undone instead (or rather: in addition)

This bug is very similar to #2563

#2813 Deleting a row does not correct the rowspan of merged cells HasPatch? Martin Kou Bug closed Normal
Description

Take a table like this:

<table title="tabel" cellspacing="0" cellpadding="0" summary="table">
    <thead>
        <tr>
            <th scope="col">1</th>
            <th scope="col">2</th>
        </tr>
    </thead>
    <tbody>
        <tr>
            <td>a</td>
            <td rowspan="3">b</td>
        </tr>
        <tr>
            <td>c</td>
        </tr>
        <tr>
            <td>d</td>
        </tr>
    </tbody>
</table>

Now, put the cursor in cell a, right click and remove that row. We see that cell b disappears. Or go to cell b and remove that row: cell b is deleted and cells c and d are left over.

#2844 Make <APPLET> tag act like <EMBED> or <OBJECT> HasPatch Bug closed Normal
Description

It's a very small change in code (i made it in 5 min in packed javascript...).

It's needed to make possible to insert, for exemple, geogebra applet in fckeditor.

in : _source/internals/fck.js: replace :

    sTags += sTags.length > 0 ? '|ABBR|XML|EMBED|OBJECT' : 'ABBR|XML|EMBED|OBJECT' ;

by :

    sTags += sTags.length > 0 ? '|ABBR|XML|EMBED|OBJECT|APPLET' : 'ABBR|XML|EMBED|OBJECT|APPLET' ;

in : _source/internals/fcklistslib.js: replace :

    StyleObjectElements : { img:1,hr:1,li:1,table:1,tr:1,td:1,embed:1,object:1,ol:1,ul:1 },

by :

    StyleObjectElements : { img:1,hr:1,li:1,table:1,tr:1,td:1,embed:1,object:1,applet:1,ol:1,ul:1 },

in : _source/internals/fckdocumentprocessor.js after :

    processElementsByName( 'embed', doc );

add :

    processElementsByName( 'applet', doc );

That's all folk's !

#2848 suggestion: make hidden element actually hide in IE too, x-browser behavior IE HasPatch New Feature confirmed Normal
Description

I think it's a good idea to make the behavior of hidden element the same in all browsers. This actually is doable in IE so I have found after lots of searching:

Setting

FCK.EditorDocument.execCommand('RespectVisibilityInDesign', true, null);

makes display:none and visibility:hidden to be respected in editable documents (contentEditable=true).

(Setting the second parameter to false instead of true will disrespect visibility, the default behavior of IE; and setting it to null will toggle the option.)

See http://msdn.microsoft.com/en-us/library/aa770023(VS.85).aspx (IDM_RESPECTVISIBILITY_INDESIGN)

#2862 plugin:maximize porting from v2 Confirmed Oracle HasPatch Review+ Martin Kou New Feature closed Normal
Description

Related v2 tickets:

#174
"Maximize the editor size" button can't handle relative DIVs
#762
Outside Flash goes over the maximized editor
#1211
Opera & Safari: Editor page can be scrolled even if editor size is maximized
#1538
Maximize command not working in IE
#2002
Maximize editor button is broken
#2233
Maximize editor screen don't show properly
#2474
An editor contained in a Div with overflow:auto can't be maximized.
#2825
When 'Maximize/Minimize' is clicked after maximizing, it does not restore to original size
#2862
plugin:maximize porting from v2
#3433
Restoring from maximized does not work across mode switches in IE8 Standards mode.
#3645
[IE] Editor size change after maximize
#3654
Resize handle should not be useable in maximized mode.
#3916
Maximize does not enlarge editor width when width is set.
#3931
Maximize maximizes to width setting, not screenwidth, when option is given with CKEDITOR.replace
#4023
[Opera] Maximize plugin
#4024
Maximize button is not translated
#4028
Maximize control's tool tip is wrong once it is maximized
#4214
Maximize bugs
#4258
Editor area chopped off on maximize for Arabic language in IE7 and IE8
#4459
CKEditor maximized appears below select element in IE6
#4509
Adding config for maximize on startup
#4519
[IE]Unable to maximize without editor focus
#4541
Maximize adds extra space on non-Kama skins
#4602
IE8 XP SP3 - maximize on long pages cuts off toolbar
#4835
Maximized editor wider than view port
#4854
[FF3] Maximize layout broken in RTL quirks
#4918
FF: Switching to source view when editor maximized
#4923
Maximize layout is broken when main page scrolled
#4958
Combos texts show text cursor when maximized
#5034
Maximize button does not work properly
#5058
Pressing tab when editor is maximized
#5059
Pressing tab when editor is maximized
#5149
Cursor dissapears after maximize in Firefox 3.6
#5178
[Nightly 3.2 Ajax Demo] Maximize button is not rendering the editor correctly
#5265
v2 skin: Editor size would not restore back correctly after Maximize
#5329
maximize will error if button is not displayed
#5579
Rich combos are not re-positioned when going to maximize mode
#5580
Maximize does not work properly in the Office 2003 and V2 skins
#5724
[Firefox] Maximize one editor instance make other instances uneditable
#5740
editor does not retain position in maximize mode
#5752
Maximize with multiple editors breaks UI in Firefox 3.6
#6057
Error when clicking beneath the body of a maximized editor
#6284
Caret placement impossible after maximize and then minimize
#6339
Plugin autogrow and Maximize
#6388
sharedSpaces don't disable maximize
#6467
setState(CKEDITOR.TRISTATE_DISABLED) on 'mode' impossible for maximize plugin
#6535
Combo box list stays after editor is maximized.
#6559
Maximize plugin @ Opera/Mac
#6695
[safari] Popup a dialog at maximize mode and then minimize cause weird styling
#6747
Maximize Issue with Toolbar in Firefox 3.x and IE 8
#6895
Pasting plain text in full-screen (maximized) view does not work
#6904
Safari: Styles disappear before editor goes to maximize mode
#6927
Pasting into the URL field does not work in Google Chrome with CKEditor in 'maximized' mode
#6947
CKEditor maximize firefox bug
#7038
Possibility to automatically switch toolbars on a maximize/minimize of ckeditor
#7253
Maximize functionality in Firefox fails without doctype tag
#7284
Maximize control collapses the editor
#7771
'Maximize' in container with Opacity makes container disappear (FF)
#7855
Clicking 'maximize' shows blank screen in Firefox when the editor is opened inside jQuery UI Dialog
#8271
CKEditor toolbar becomes invisible when using Tab key and Maximize toolbar button
#8307
[iOS] Maximize is broken
#8587
IE7 maximize long delay
#8930
Maximize does not work
#9065
Maximize to percent
#9253
Resize feature should be disabled for maximized editor
#9269
Maximize plugin test crashes IE7
#9311
Vertical scroll bar not appearing in maximized editor with autogtrow enabled
#9319
FF: Editor not expanding to Maximum size, when we click Maximize button after focusing in editor body
#9320
Editor does not autogrow after entering content in Maximize mode
#9321
FF: Vertical scroll bar & toolbar missing in maximized editor with autogtrow enabled
#9374
Opera: Editor displays off-screen in autogrow sample in maximize mode
#9465
Misplaced panels when editor is being maximized
#9680
The "Maximize" feature should not be a toolbar button
#9883
[FF] Maximized and minimized divarea leaks
#9886
[IE8-10] No scrollbar in maximized editor with autogrow enabled
#10084
[Android] Problems with Maximize plugin in zoomed-in page
#10326
Maximize button removes input[name=style] from form
#11020
Same config, different result between minifief and maximized version
#11169
Maximize not work
#11410
[FF] jQuery sample, maximize + minimize framed editor allows to edit whole page
#11436
Maximize plugin with shared space doesen't work
#11745
Maximize should use position:fixed instead of changing entire page styling
#12163
Maximize (and resize) plugin and shared spaces incompatibility
#12357
[IE8] Call maximize command fire resize event twice
#12398
Maximize-Button doesn't work in instances without a title
#12747
IE: Dropdowns become disabled when in maximize mode.
#13033
Maximize pluging would not work with floating tool plugin in firefox mozilla
#13046
Dropdown not working in maximize mode with RTL body
#13190
Maximize problems
#13403
Maximize tool issue - after maximizing, if browser back button used, page layout is messed up
#13481
Nested dialog hides parent dialog on Maximized editor.
#14695
CKEditor maximize plugin issue
#16778
Maximize hides the toolbar, can't minimze.
#16856
Maximize not working on iphone
#16983
Maximize does not work s expected when classic and inline editors are mixed on the same page

#2874 tables: in FF caption seems to be in the wrong place Confirmed HasPatch Review+ Martin Kou Bug closed Normal
Description

FCKeditor generates the following

    <table ....>
        <thead>
            <tr>
                <th scope="col">1</th>
                <th scope="col">2</th>
            </tr>
        </thead>
        <caption>My Caption</caption>
        <tbody>
            <tr>
                <td>...</td>
                <td>...</td>
            </tr>
        </tbody>
    </table>

The following would be the correct markup

    <table ....>
        <caption>My Caption</caption>
        <thead>
            <tr>
                <th scope="col">1</th>
                <th scope="col">2</th>
            </tr>
        </thead>
        <tbody>
            <tr>
                <td>...</td>
                <td>...</td>
            </tr>
        </tbody>
    </table>

Going further with my tests, I just found that the bug doesn't show up if you use MSIE7. My conclusions:

  • the problem is strictly related to the browser and its "DOM engine"

OR

  • the problem is inside the portion of code dedicated to gecko
#2893 FCK table handler bug HasPatch Bug closed Normal
Description

Bug description:

If the following conditions are met:

  • there is another text field on the page besides the editor,
  • the other field gains focus before the editor is done loading, and
  • the editor button set includes 'TableMergeCells' and/or 'TableHorizontalSplitCell',

then there will be a javascript error inside FCKTableHandler.GetSelectedCells

Fix:

After the line:

var oParent = FCKSelection.GetParentElement() ;

We tested whether or not the selection is inside FCKeditor:

if(FCKTools.GetElementDocument(oParent) != FCK.EditorDocument)

return aCells ;

(returning an empty array if the selection/cursor is outside FCKeditor)

This bug was similar to https://dev.fckeditor.net/changeset/827

#2932 AJAX sample fails to populate editing area after subsequent editor instantiations in FF 3 Confirmed IBM HasPatch Review+ Frederico Caldeira Knabben Bug closed Normal
Description

Instances of the editor which have been dynamically created using CKEDITOR.appendTo() fail to properly handle insertHTML(). The first instance of the editor works as expected but when that instance is destroyed and another created in its place, the second instance and all subsequent instances will fail to handle insertHTML().

The behavior can be reproduced by following these steps:

  1. Open http://ckeditor.com/ckeditor/3.0b/_samples/ajax.html
  2. Create editor
  3. Enter content into editing area
  4. Destroy editor
  5. Create another editor


Expected behavior is that the entered content would be populated in the new editor instance, but it isn't.

The cause has been tracked down to the mode of the editor not being set before setHTML() is called.

A temporary fix for the problem is to update CKEDITOR.editor.prototype.setMode declared in the editingblock plugin and explicitly set the mode (see patch).

The erroneous behavior appears to occur only in Firefox 3.

#3012 plugin:format 'h1' font too big to display Confirmed HasPatch Garry Yao Bug closed Normal
Description

The h1 format selection option text is too big and cropped.

#3129 Selection sensitive commands state after switch mode is incorrect HasPatch Bug closed Normal
Description

E.g. RichCombo marked list item state is not reset on mode switch, reproduce by :

  1. Open the replace by code example page;
  2. Open a combo and select a item;
  3. Switch to 'source' mode and then switch back;
    • Actual Result: Still marked selection result from previous.
#3202 Hebrew Translation HasPatch Confirmed New Feature closed Normal
#3358 Optimize 'CKEDITOR.dom.range.enlarge' on block unit HasPatch Task new Normal
Description

After enlarging the range with a block unit with the following input:

<div>text^<p>paragraph</p></div>^

We'll got:

<div>^text<p>paragraph</p></div>^

No we got a partially selected block, it's better to have the 'div' been fully selected to prevent consequence operation like extractContent from resulting in unwanted node pieces, so an optimized result would be the following:

^<div>text<p>paragraph</p></div>^
#3360 Enlarge range by element problem HasPatch Garry Yao Bug assigned Normal
Description

When enlarging a block element with element unit, the enlargement will climb up to any ancestor block, which is wrong.

#3371 Spring based Connector servlet HasPatch New Feature confirmed Normal
Description

Attached is a patch which has a new spring based connector servlet project. It allows the Connector to be a Spring managed bean which is useful in Spring projects. For example if the connector is used to write to a database it will be able to use the Spring transaction manager or Spring events could be issued when an upload/download occurs for files.

I`ve also updated the java-demo project so it uses the new servlet. I`ve commented out the original ConnectorServlet in the web.xml

I had to change the Dispatcher slightly so a Connector can be passed into it. I also had to make the dispatcher member variable in the ConnectorServlet protected as the new SpringConnectorServlet derives from ConnectorServlet.

#3373 Don't show context menu if there are no items HasPatch Confirmed Review+ Garry Yao Bug closed Normal
Description

If the clipboard plugin is disabled, there are usually no menu items to display in the context menu (there are still items for tables, etc).

In this case, it would be nice to simply display the browser's default context menu, rather than showing an (ugly) empty menu.

Attached is a patch that implements this.

#3409 Empty LI's don't render at full height Confirmed HasPatch Bug closed Normal
Description

To duplicate, start with a completely empty editor, then press the bullet button. The bullet will be scrunched up against the top of the editor until a key is typed, which causes the UL/LI to render at full height, shifting the bullet down.

The solution, I believe, is to call appendBogus() on the LI. Attached is a patch that implements this.

This can be reproduced with any of the nightly samples.

#3423 Unable to outdent when editor.config.indentUnit != 'px' HasPatch Review+ Martin Kou Bug closed Normal
Description

If the editor configuration is set to use an indent unit other than px (e.g. 'pt'), outdenting does not work. This is because the indent detection logic uses getComputedStyle, which returns the indent in pixels.

One solution is to mimic V2 behavior and use getStyle instead of getComputedStyle. Attached is a patch which implements this.

#3483 Editor removes all attributes of <source> element except 'lang' HasPatch Bug closed Normal
Description

Hi,

the editor removes all attributes of the <source> element (used for syntax highlighted code), except the 'lang' attribute. While it would be nice, if all attributes could be edited by the FCKEditor, the non-editable ones should at least not be removed when switching back to Wikitext.

You can reproduces this bei adding the following to a Wiki page:

<source lang="java" line="on" start="1" enclose="pre" strict="on">
Hello World!
</source>

Open it in the editor and switch to Wikitext. Every attribute is gone, except the 'lang' one.

A simple fix is to just include the other supported attributes in 'fckplugin.js':

case 'fck_mw_source' :
    var refLang = htmlNode.getAttribute( 'lang' ) ;
    var refLine = htmlNode.getAttribute( 'line' ) ;
    var refStart = htmlNode.getAttribute( 'start' );
    var refEnclose = htmlNode.getAttribute( 'enclose' );
    var refStrict = htmlNode.getAttribute( 'strict' );

    stringBuilder.push( '<source' ) ;
    stringBuilder.push( ' lang="' + refLang + '"' ) ;
    stringBuilder.push( ' line="' + refLine + '"' ) ;
    stringBuilder.push( ' start"' + refStart + '"' ) ;
    stringBuilder.push( ' enclose="' + refEnclose + '"' ) ;
    stringBuilder.push( ' strict="' + refStrict + '"' ) ;
    stringBuilder.push( '>' ) ;
    stringBuilder.push( FCKTools.HTMLDecode(htmlNode.innerHTML).replace(/fckLR/g,'\r\n') ) ;
   stringBuilder.push( '</source>' ) ;

   return ;

Maybe a more general solution would be better, which just includes all the supplied attributes, since you would not have to update this code every time a new one was added. I tried this, but the simple approach got me all the synthetic FCKEditor attributes too.

Best regards, Ralf

#3484 Images don't present at customized size on reload in WYSIWYG HasPatch Bug closed Normal
Description

I uploaded an image around 2000px x 1000px. I insert it via FCKeditor image button. I resized the image via the resize handles within the GUI. This worked great. I saved the content and the image size was correct in the content. I then hit edit to make some adjustments and the image was it's real size in the GUI instead of the customized size.

I've attached a patch to resolve the issue.

#3509 Styles aren't maintained at end of line Firefox HasPatch Bug closed Normal
Description

Under certain conditions, basic styles (bold, italic, etc) aren't maintained at the end of lines.

Steps to reproduce:

  • Open the replace by code example.
  • Press the Bold button, then type text.
  • Press the end button (or click after the end of the line.)
  • Type some more text.

The newly typed text should be bold, but is not.

This also happens under the following conditions:

  • Open the replace by code example.
  • Type some text.
  • Press Home, then Shift+End to select the whole line.
  • Press the Bold button.
  • Press the end button (or click after the end of the line.)
  • Type some more text.

The problem is that Firefox is appending a <br/> at the end, but it is not being included in the <strong> element. The solution is, when applying a style, to include that BR element.

A patched is attached which fixes this problem. The problem can be reproduced in the latest nightly samples.

#3569 SCAYT should stop at form fields Confirmed HasPatch Bug closed Normal
Description

The 'scayt_word' marker should split words separated by form field elements, while it's not:

Reproducing Procedures

  1. Open the replace by class example page with SCAYT plugin enabled.
  2. Insert the text 'wrongword' into editor, waiting for SCAYT marking this word;
  3. Move the selection into 'wrong|word', click on 'Insert TextField' button to open dialog and insert a default textfield.
  4. Disable and re-enable the SCAYT plugin or enter some char to reload all markers.
    • Expected Result : wrong<input />word should not be considered to have spell error;
    • Actual Result : wrong<input />word is marked as spell error in a whole and if click on the first word to open context menu and click any of the suggestions, the in-middle textfield get lost along with these two words.
#3611 Automatic option doesn't work for font and background color HasPatch Confirmed Bug closed Normal
Description

The automatic option for these dropdowns never works. To reproduce type any text into one of the nightly samples, highlight the text and change its color to a specific color. Then click the Automatic option. The text will remain colored.

This is because of a bug in CKEDITOR.style.checkElementRemovable(). The problem is that checkElementRemovable, when called from removeInlineStyle, should match any element with the color or background-color style, regardless of value. Attached is a patch which fixes this.

#3619 Add IDs to the table caption and summary fields hasPatch Confirmed Review+ Artur Formella New Feature closed Normal
Description

CKEditor allows setting the caption and summary for a table. Since these properties do not have an equivalent in many document formats, it would be nice to make so that these options can be hidden. I have attached a patch which implements this.

#3625 Enhanced Internal Link Search for Mediawiki+FCKeditor HasPatch New Feature closed Normal
Description

The users of the FamilySearch Research Wiki (http://wiki.familysearch.org) needed to have the FCKeditor internal link search return the same results as if search from our main page. Attached are two patches one for FCKeditorSajax.body.php which adds two functions and one for FCKeditor.php which adds a few constants. Then by setting two global variables in LocalSettings.php ($wgFCKeditorSearch and $wgFCKeditorSearchType) you can have the FCKeditor internal link search use the same search engine as is Mediawiki or continue to use the default FCKeditor link search. At this time we have not yet implemented the patches on our production system but they are running on our testing and staging environments.

#3627 Performance testing Confirmed HasPatch Garry Yao New Feature assigned Normal
Description

I guess that everybody has this in mind, but no one has written it so far.

In the future it would be very nice to have an automated performance testing system, so that we can keep track of any unexpected degradation of the performance. And also to avoid that little + little + little changed do end up summing a serious problem.

For a reference, this post about Chrome explains the same basic idea: http://blog.chromium.org/2008/11/putting-it-to-test.html and points that some of the tools are based on HTML and JS, so maybe we can reuse something from there.

#3649 Incorrect selected size item on FontSize menu on continous typing and font-size selection HasPatch Bug closed Normal
Description

Steps to reproduce

  1. Clear everything in the editor of "FCKeditor - Demo" page.
  2. Click inside editor, now we are redeay to enter text.
  3. Click "Size" menu, select "small".
  4. Enter "abc".
  5. Click "Size" menu, select "large".
  6. Enter "XYZ".
  7. Click "Size" menu.

Expected behavior

The selected size item on FontSize menu be "large".

Current behavior

The selected size item on FontSize menu is "small".

Browser

IE, Firefox

Attached

A screenshot to show the operation after last step 7.

#3731 Support 'style only' override in style system Discussion HasPatch New Feature confirmed Normal
Description

This's a ticket derived from #705, which provide a UC of the following style definition which we don't support now:

{ element : 'strong', overrides : [ { element: 'b'}, { element: 'font', styles : { 'font-weight' : 'bold' } } ] }

And a more generic UC ( and actually a common case )with 'style' only definition could be inferred as:

{ element : 'strong', overrides : [ { element: 'b'}, { element: '*', styles : { 'font-weight' : 'bold' } } ] }

Which declare that we need to consider bold for the following two cases:

  1. It's a <strong> tag;
  2. It's a <b> tag;
  3. It's any tag with "font-weight" : "bold" style;
#3842 Merge textnode broke by bookmark Discussion HasPatch Bug closed Normal
Description

Currently once bookmark is created, broken text node will be forever stay in pieces, which result in a fracted document, have negative impacts on dom walking performance.
For this reason, possible treatment should be done in CKEDITOR.dom.range::moveToBookmark to merge sibling text nodes.

#3854 Skin loader bug hasPatch Bug closed Normal
Description

Skins are not initialized correctly if they are included in the packed ckeditor.js.

#3903 Unable to override font colors HasPatch Review+ Bug closed Normal
Description

The config.colorButton_colors setting allows overriding the colors that are shown in the font and background color dropdowns. However, because of a bug in _source/plugins/colorbutton/plugin.js, this setting is not respected.

The solution is to check config.colorButton_colors instead of CKEDITOR.config.colorButton_colors. This is similar to how other plugins work.

Attached is a patch.

#3910 Improved spellerPages HasPatch New Feature closed Normal
Description

I've made some modifications to the speller pages script that I thought might be useful and worth sharing.

Changed files are attached

  • By setting FCKConfig.SpellerPagesAddButton to true, the speller pages will include an 'add' (to dictionary) button. Without this setting it's entirely backwards compatible. With it enabled, any words that are added are posted back to the server through the spell checking script with a parameter set to enable it to detect that words need to be added to the dictionary, rather than to do a spell check.
  • The spellchecker.pl script has been modified and has placeholder functions for adding/retrieving words from the dictionary according to the server setup.
  • The control window has been improved to enable/disable buttons when appropriate.
  • The OK button is enabled on the outer spellchecking dialog when appropriate. This means you don't have to spell check an entire document and can finish half-way through to apply changes.
  • The word window has been fixed so as not to try to find mispelled words within HTML tags (see also bugs #2470 #2326 #2158 which also mention this but it still doesn't seem to have been fixed)

I'm not familiar with PHP or CFM but I'm sure it would be straightforward for someone who is to make similar changes in those scripts.

#4128 [IE] Image dialog has scrollbar in quirksmode Confirmed Pending HasPatch Garry Yao Bug closed Normal
Description

Reproducing Environment

  • IE6/IE7 Windows XP SP2
  • Quirks Mode
  • http:// protocol( Works fine with file:// protocol )
  • No Cache
  • language: zh-cn
#4212 Firefox "script stack space quota is exhausted" HasPatch Bug closed Normal
Description

As soon as we include the Full Page feature in V3, we need to check whether the fix provided in the following forum post is valid:
http://www.fckeditor.net/forums/viewtopic.php?f=11&t=14559

#4214 Maximize bugs HasPatch Bug closed Normal
Description

In Firefox 2.x, 3.x, 3.5.x and Safari 4.x (possibly others) the maximize feature is setting the body height/width to 0px which is causing the the iframe to be hidden. Simply removing this 0px setting seems to resolve the issue for these two, however, breaks Opera if they are removed. I have not tested Safari 3.x, Opera 10, or Chrome.

Can confirm it works correctly in IE7/8 & Opera 9.64

Note: One unusual setup in my code is that the body element is position: absolute; (100% height trick)

Also of note related to this bug - when using maximize the existing styles of containing elements are overwritten by FCK. ie: <body style="xyz" is being replaced with FCK maximize code where it should add to it instead.

#4240 CKEditor does not work with elements with hyphen in their ID Confirmed HasPatch Review+ Garry Yao Bug closed Normal
Description

Open replacebycode.html sample, change the ID "editor2" into "edi-tor2", launch it in your browser and an error will occur (and as a result the event instanceReady is not triggered):

invalid assignment left-hand side
javascript:void(%20setTimeout(%20function()%7Bdocument.open()%3Bdocument.write(%20window.parent._cke_htmlToLoad_edi-tor2%20)%3Bdocument.close()%3Bwindow.parent._cke_htmlToLoad_edi-tor2%20%3D%20null%3B%7D%2C%200%20)%20)
Line 1

Note: window.parent._cke_htmlToLoad_edi-tor

CKEditor should support at least this:

ID and NAME tokens must begin with a letter ([A-Za-z]) and may be followed by any number of letters, digits ([0-9]), hyphens ("-"), underscores ("_"), colons (":"), and periods (".").

It seems that the source of this problem is the wysiwygarea plugin: 'window.parent._cke_htmlToLoad_' + editor.name + ' (line 244-246)

#4256 Enable impersonation in aspx file browser connector HasPatch New Feature closed Normal
Description

I needed the folder view, folder creation and upload to use the proper windows domain credentials of the client.

My implemetation is attached - the zip contains only files changed from the FCKeditor.net 2.6.3 or FCKeditor 2.6.4.1 sources.

Note there are core changes only because I found upload error handling to be defective. The new handling is far from perfect, I just "made it work for me".

For further information, please see the readme_rh.html file included in the attachment and do a diff - most should be pretty obvious.

If you wish to include this in your product, I'm perfectly willing to fully pass my rights on to you, but as I have developed this on company time, please ask first.

#4273 TD > UL > SPAN Causes FCKTableHandler.GetSelectedCells() to return nothing on right click HasPatch Bug closed Normal
Description

This is an involved issue, so bear with me:

1) Create a table 2) Insert a List (UL or OL should trigger the issue) 3) Add some text to the list item, and style is using the Style drop down

You end up with something like:

<table>
    <tr>
       <td>
          <ul>
             <li><span style="color: red">Text</span></li>
          </ul>
       </td>
    </tr>
</table>

Then, right click on the span, and go to Cell > Cell Properties and try to set Horizontal Alignment to Right and click OK.

You end up with nothing being changed.

The reason is, FCKTableHandler.GetSelectedCells() at source:/FCKeditor/tags/2.6.4/editor/dialog/fck_tablecell.html#L38 returns no cells.

Attached is a patch to correct the issue.

#4345 Fire a "langLoaded" event after the languages have been loaded. HasPatch Frederico Caldeira Knabben New Feature closed Normal
Description

Currently almost every stage of the loading process will fire an event when completed, like "customConfigLoaded", "configLoaded", "pluginsLoaded".

Only the loadLang() method doesn't fire a "langLoaded" event, which might come in handy for custom language manipulation.

I want to add some custom translation-texts, and need to do it before my plugin loads. Since it is not (yet) possible to add these translations via the config (bug #1032), I want to use the "langLoaded" event.

Implementation is nothing more than adding one line:

144. editor.fire( 'langLoaded' );
145. loadPlugins( editor );
#4351 Dashes cannot be used in attribute names Confirmed HasPatch Review+ Garry Yao Bug closed Normal
Description

The CKEditor htmlParser uses a regular expression to check for valid attributes. This regex however, does not allow dashes to be used in the attribute name.

If I'm correct, dashes are allowed as character in an attribute name, and the "\w" set, does not include the dash. Therefore, the dash should be added separately (like the colon).

htmlparser.js:

- 21. var attribsRegex = /([\w:]+)...
+ 21. var attribsRegex = /([\w:\-]+)...
#4361 Associate toolbar UI instances HasPatch Discussion New Feature closed Normal
Description

Currently it's been difficult to find the relationship of UI instances ( e.g. buttons, combos etc. ), and it's related toolbar instances. Adding more cross-reference among them could benefit the plugin authoring which will manipulate the toolbar.

#4362 Fire event when floatpanel opened HasPatch New Feature confirmed Normal
Description

The opening of our panel system is a mixing of async( iframe loading for first time ) and sync ( subsequent showing ) process, which makes it hard to determinate it's ready to been manipulated, event is always good treatment in these cases, an 'open' event could be fired when the panel is fully loaded and become visible.

#4440 SCAYT context menu incorrect behavior HasPatch Bug closed Normal
Description

SCAYT context menu contains invalid items when there is not enough suggestions generated by SCAYT core.

patch which fixes the problem attached

#4507 Adding a new 'save' event HasPatch Tobiasz Cudnik New Feature closed Normal
Description

Many users are looking for a easy way to override the default save button behavior, i.e. ajax post. A new 'save' event could be fired by save plugin on editor instance level to make this customization happen.

#4556 Html5 and xhtml5 support HasPatch Frederico Caldeira Knabben New Feature closed Normal
Description

When fckeditor encounters an html5 tag, it behaves incorrect. It will wrap the html 5 element with p-tags.

Since it is advised to create every new site in html5 already, (basic) support for html5 would be really welcome.

Html5 is backwards compatible with html4. If html4 behaviour needs to be retained, we could introduce extra modes. xhtml
html4
html5
xhtml5

#4635 Unable to open property dialog for existing table from toolbar HasPatch Bug closed Normal
Description

to reproduce

  • Open CKEditor demo page with IE or FF
  • Select the 'International Names' table
    • 8 squares for resizing appears
  • Click 'table' icon from the toolbar
    • New dialog is opened, and existing table's property is not loaded
  • Click 'OK'
    • [IE]Existing table is overwritten.
    • [FF]On the 1st click, cell text is removed, and on the 2nd, new table is inserted into selected cell
#4648 Support for iframe HasPatch Sa'ar Zac Elias New Feature closed Normal
Description

The editor should provide support for iframes, just like it support object elements. A placeholder should be displayed for iframes. This ticket is not related to the dialog we could have to edit iframe properties, which should be a successive evolution for this feature.

#4662 Added support for adding CSS class to tables and cells HasPatch New Feature closed Normal
Description

Hi!

I added support for entering one or more CSS classes to a table and table cell.

Just copy the contents of the attached files into the pluginsfolder and you are up and going :)

I would strongly suggest that this gets added to the core, since its pretty useful.

#4667 SCAYT autoloading with multiple editors fails HasPatch, Review? Bug closed Normal
Description

If you are using SCAYT and have two or more editors on a page, the setting FCKConfig.ScaytAutoStartup = true will error on all but one of the editors. All other editors will not allow you to enable SCAYT and you will receive the error, "SCAYT is not ready." If FCKConfig.ScaytAutoStartup is set to false, then each editor can be manually set to enabled with no issue. This error ONLY occurs when the autostartup is set to true.

#4688 SCAYT affecting IsDirty and ResetIsDirty. Confirmed, HasPatch Bug closed Normal
Description

Using 2.6.5. Windows NT. FireFox 3.0.15.

There seems to be some kind of timing/race condition that causes ResetIsDirty to fail (or causes something else to come along later, after ResetIsDirty has been called, and flags the editor as "dirty") if 1) SCAYT is enabled and 2) there is at least one misspelled word somewhere within the editor text (highlighted with a red underline).

The specific scenario involves retrieving the editor contents (HTML) from a database and setting it into the editor via SetText. Obviously, I don't want this newly retrieved text to be considered "changed/dirty" (from the user's perspective) so within the OnAfterSetHTML handler I invoke ResetIsDirty. This works perfectly and reliably...UNLESS the conditions mentioned above are present. In the SCAYT scenario, the invocation of ResetIsDirty that occurs within OnAfterSetHTML seems to be ignored or something else comes along after it's invoked and marks the editor as dirty, perhaps as a result of the slight delay introduced by the spell check operation that eventually marks the incorrect word with the red underline. The end result is that the editor says it is Dirty even though no editing of the text has occurred.

Thank you.

#4696 Insert Page break not splitting table and list HasPatch Bug closed Normal
Description

Reproducing Procedures

  1. Open a sample page, load the editor with the following content with selection:
    <ol>
    	<li>item1</li>
        <li>^item2</li>
    </ol>
    
  2. Click on 'Insert Page Break...' button.
  3. Switch to 'Source' mode.
  • Actual Result:
    <div style="page-break-after: always;">
    	<span style="display: none;">&nbsp;</span></div>
    <ol>
    	<li>
    		item1</li>
    	<li>
    		item2</li>
    </ol>
    
  • Expected Result:
    <ol>
    	<li>
    		item1</li>
    </ol>
    <div style="page-break-after: always;">
    	<span style="display: none;">&nbsp;</span></div>
    <ol>
    	<li>
    		item2</li>
    </ol>
    
#4743 Dialog plugin contains a call to console.log HasPatch Confirmed Bug closed Normal
Description

The dialog plugin currently logs to the console if a dialog cannot be loaded.

#4971 Unable to insert <br> under <li> when shiftEnterMode != ENTER_BR HasPatch Bug confirmed Normal
Description

By default, shiftEnterMode is set to ENTER_BR, and Shift+Enter will insert <br> under <li>.

To Reproduce

  • Add following settings to config.js.
    config.enterMode = CKEDITOR.ENTER_BR;
    config.shiftEnterMode = CKEDITOR.ENTER_P;
    
  • Open sample page.
  • Click "Numbered List" or "Bulleted List" button from toolbar.
  • Type some text.
  • Move caret at the middle of text.
  • Press Enter from keyboard.
    • expect: <br> is inserted
    • actual: next <li> is created
#5027 [IE] Standards Mode Selection: Cannot click to select to the right of a control node IE8 HasPatch Bug confirmed Normal
Description

There is a bug with IE in standards mode when trying to click to the right of a control selectable node such as an image.

To replicate Set the HTML to:

<p>
	Line 1<br />
	Line 2<img src="http://www.google.com/intl/en_ALL/images/logo.gif" /></p>

I have attached a patch which fixes this problem. I dont know if it is implemented up to your standards though.

Some things that are bad about my patch are:

  • Its using the CK dom range inside selection (seems a bit cyclic)
  • You cannot mouse down and drag to select more
  • I dont really understand why there are multiple selections / ranges so I have just used "getRanges()[0]"
  • Its using setTimeout() because the selection is not ready before the event
  • I am using a constant of 20x20 pixels to check the mouse offset - perhaps a character size calculation is needed?

There may be some other ways to fix this. Another idea is that we could insert a whitespace text node / span at the end of the block before the end of the mousedown event.

Cheers,
Scott
http://www.synergy8.com/

#5039 Complete Finnish translation Confirmed HasPatch Bug closed Normal
Description

Here's a complete Finnish translation (fi.js).

#5094 Dialog API: Custom alignment of radio buttons and their labels IBM HasPatch New Feature confirmed Normal
Description

I have not found a good way to adjust the alignment of the radio buttons. The radio buttons is outputted as table cells in a single table row, that makes it impossible to use css to display them in an vertical list (Internet Explorer).

It would be great to have the following options for the radio element:

  • Vertical or horizontal display of radio buttons
  • Whether to display the labels above, below, in front of or behind the radio buttons.
#5184 CKeditor flash plugin patch for youtube HasPatch New Feature confirmed Normal
Description

CKeditor's flash plugin accepts youtube URLs, if they point directly to the flash file (youtube.com/v/XXXXXXXX URLs); youtube's interface gives URLs like youtube.com/watch?v=XXXXXXXX.

This patch does a string replace on the interface so that people can paste youtube page urls.

Supplied code reeks of duct tape, but it gets the job done; I don't have 40 hours to spend learning CKeditor internals (it's already perfect, anyway!)

#5218 FF: Copy/paste of an image from same domain as CKeditor changes URL to relative URL HasPatch Sa'ar Zac Elias Bug closed Normal
Description

This issue occurs only in Firefox.

To reproduce:

  1. Go to an instance of CKEditor (eg http://drupal.ckeditor.com/)
  2. Add an image that uses the same domain (eg http://drupal.ckeditor.com/images/logo-ie.png)
  3. Check image properties in CKEditor to verify the full URL is listed
  4. Copy and paste the image
  5. Check image properties on the pasted image - URL has been modified

See attached screenshot.

My limited testing of a couple OSes and a few browsers shows that this issue occurs only in Firefox:

OS: OSX 10.6.2

Issue occurs in Firefox 3.5.8 (see screenshot) Issue does not occur in Chrome 5.0.307.9 beta Issue does not occur in Safari 4.0.4 (6531.21.10)

OS: Windows XP

Issue occurs in Firefox 3.5.8 Issue does not occur in IE 8.0.6001.18702

#5226 mediawiki-fckeditor error on (ajax) listing categories HasPatch Bug closed Normal
Description

On page FCKeditorSajax.body.php, function wfSajaxSearchCategoryChildrenFCKeditor($m_root) line 197 $m_root = str_replace("'","\'",$m_root);

it fails when a category (parameter m_root) has quotes, because it is submitted to this function after (line 204) $res = $db->query($m_sql,METHOD );

which quotes it again, becoming something like "Gender
's issues".

The solution is pretty easy: (line 200)

$m_root = mysql_real_escape_string( $m_root );

which must be placed after the connection to the database. The previous one with str_replace can be removed.

#5308 File browser window doesn't scroll HasPatch Sa'ar Zac Elias Bug closed Normal
Description

I am using my own custom file browser with CKEditor 3.2. When I view the file browser in a normal browser window it scrolls fine.

However, when I click the Browse Server button and it opens the file browser in a popup, the scroll bars don't work...

#5326 Catalan language file updated HasPatch New Feature closed Normal
Description

I have updated the catalan language file that I downloaded from: http://nightly.ckeditor.com/latest/ckeditor/_source/lang/

Now there are no strings missing.

#5329 maximize will error if button is not displayed HasPatch Bug closed Normal
Description

Request for improvement. I would like an option to maximize the ckeditor control by default.

You can simulate that by using

CKEDITOR.on('instanceReady', function(ev) {

var editor = ev.editor; editor.execCommand('maximize');

});

However you'll get a javascript error if the maximize button is not part of the current tool bar. This can fixed if the following change is made to the maximize plugin.

if (button) {

var buttonNode =

editor.element.getDocument().getById(button._.id);

buttonNode.getChild(1).setHtml(label); buttonNode.setAttribute('title', label); buttonNode.setAttribute('href', 'javascript:void("' + label + '");');

}

#5338 Paste from Open Office causes error Confirmed HasPatch Frederico Caldeira Knabben Bug closed Normal
Description

When pasting from Open Office into CKEditor in Firefox, an error is thrown when attempting to save or use the Source button.

The error is in plugins/htmldataprocessor/plugin.js line 192:

element.children[ 0 ].value = element.attributes[ '_cke_title' ];

element.attributes._cke_title is undefined

It is possible that this error is a consequence of the empty title element which Open Office creates.

Note that this error does not occur in Chromium 5.0.330.0, which is the only other browser I have tested in.

To reproduce:

  • Create a document in Open Office
  • Copy some content from it
  • Paste it into a CKEditor instance in Firefox
  • Click the 'Source' button

Using:

  • CKEditor 3.2 (also tested on Nightly)
  • Firefox 3.5.8 (Ubuntu 8.10)
  • Open Office 3.11
#5339 In fullpage mode, document without "title" tag breaks CKEditor HasPatch Minh Nguyen Bug closed Normal
Description

To reproduce:

  1. create an editor with the "fullpage" option turned on.
  1. start editing content in WYSIWYG mode.
  1. switch to source mode and adjust the content so that there is no title tag in the head.
  1. switch back to WYSIWYG mode, note that the toolbar buttons don't come back to being usable.

Patch:

Patch for plugins/wysiwygarea/plugin.js (at least, here's the diff that fixes it for us):

741,744c741,742
<                                         if (title != null) {
< 						title.setAttribute( '_cke_title', editor.document.$.title );
< 						editor.document.$.title = frameLabel;
<                                         }
---
> 					title.setAttribute( '_cke_title', editor.document.$.title );
> 					editor.document.$.title = frameLabel;
#5342 Editor always at least 300px wide on Webkit WebKit HasPatch Bug closed Normal
Description

Webkit-based browsers refuse to create editors less than 300 pixels wide. Following code creates 300px wide editor, even though 150 is specified for all width options. Testcode was made against 2nd example in /_samples/replacebycode.html

CKEDITOR.config.toolbar_Mini = [ ['Bold','Italic','RemoveFormat'] ];
CKEDITOR.replace( 'editor2', { width: 150, resize_maxWidth: 150,  resize_minWidth: 150, skin: 'v2', toolbar: 'Mini' } );

Happens on Safari 4.0.3 (Windows) / Chrome 4.1.249.1036 (Windows)

#5344 Wrong japanese translation HasPatch Frederico Caldeira Knabben Bug closed Normal
Description

The Japanese translation in the search dialog box is wrong. The attached the patch for it.

#5355 Opening a dialog causes silent exception HasPatch Bug closed Normal
Description

Opening a dialog (Image dialog for example) causes exception which is silently consumed by try - catch block but javascript debuggers like firebug still break on the error.

this is caused by access to undefined index (-1) in "focusList" in plugins/dialog/plugin.js:286 and could be fixed by adding:

if (current > -1)

before the

focusList[ current ].getInputElement().$.blur();

line

The bug was discovered with Firefox 3.5.8 (Firebug 1.5.3) / Linux 64bit

#5356 Scayt options dialog doesn't work with prototype.js enabled environments Confirmed HasPatch Bug closed Normal
Description

When using CKEditor in prototype.js enabled environments SCAYT plugin options dialog opening crashes.

This is caused by plugins/scayt/dialogs/options.js:218

for ( i in buttons )

Normally this clause iterates over all items within a array but in prototype enabled environments this causes loop to iterate also over all extended methods thus causing following doc.getById( button) to fail

This problem can be fixed by changing line 218 into:

for ( i = 0; i < buttons.length; i++ )

The problem was discovered with Prototype 1.6.1

#5370 New Faroese locale HasPatch Task closed Normal
Description

Filled in quite some missing translations.

#5392 Complete Finnish translation HasPatch Bug closed Normal
Description

Here's complete Finnish translation.

#5515 Hebrew language update HasPatch Pending Task closed Normal
Description

Updated Hebrew language file. Attaching 2 patches: one contains both the regular language file and the newly translated a11yhelp, and one contains only the regular language file in case the a11yhelp is not to be translated.
Btw, #5513 and #5514 should be fixed so the a11yhelp translation would be correct.

#5517 Extra <p>&nbsp;</p> when pasting in webkit HasPatch Bug closed Normal
Description

When pasting in Webkit, there is often an extra <p>&nbsp;</p> added when you look at it in the Source view. The reasons seem to be:

  1. Webkit adds a <meta> tag on html paste.
  1. Webkit adds a <span class='Apple-style-span'> wrapper to the pasted content.
  1. When pasting onto a new paragraph, if the pasted html contains block elements such as <p> or <h1>, it seems the ckeditor tries to clean that the nonstandard DOM but an empty <p>&nbsp;</p> is added as a result.
  1. When the current selection is on a block element and you paste other block elements at that point, an extra block element gets prepend before the pasted content. This extra block element has the same tagName as the existing block element (same attributes as well) and its inner HTML contains only "&nbsp;".

I've come up with a way to deal with issues 1-3, but not 4. Right now I apply the following clean up code on a paste event when it doesn't contain Microsoft word junk. If you have some feedback or know of a better way please let me know. I am not sure where this would go if it were to be a patch.

CKEDITOR.on('instanceCreated', function(e) {


  if(CKEDITOR.env.webkit){
    editorInstance.on('paste', function(evt) {
      var data = evt.data;
      data['html'] = data['html'].replace(/<(META|LINK)[^>]*>\s*/gi, '' );
      /* If not pasting from word and pasting into a new paragraph,
       * clean up code, replace paragraph element, and cancel paste action.
       * Otherwise continue with paste event. */
      if( !( /(class=\"?Mso|style=\"[^\"]*\bmso\-|w:WordDocument)/ ).test( data['html'] ) ){
        var temp_div = document.createElement("div");
        temp_div.innerHTML = data['html'];
        //remove Webkit span wrapper tag
        if( (temp_div.childElements().length == 1) && (temp_div.childElements()[0].className.indexOf('Apple-style-span') > -1 ) ){
            data['html'] = $(temp_div).childElements()[0].innerHTML;
            temp_div = document.createElement("div");
            temp_div.innerHTML = data['html'];
        }
        var selection = editorInstance.getSelection(),
                range = selection.getRanges()[0],
                    orgStart = range.startContainer,
                       orgEnd = range.endContainer,
                         nextElement = orgStart.getNext();

        if(/^\s*<br>\s*$/.match(orgStart.$.innerHTML) && (orgStart.$.tagName =='P') ){
            var newRange = new CKEDITOR.dom.range(range.document),
              fragment=document.createDocumentFragment();
              
            for(var mynode=0;mynode< temp_div.childNodes.length; ++mynode){
                if(typeof temp_div.childNodes[mynode] == 'object'){
                    if(temp_div.childNodes[mynode].nodeName == '#text'){
                      fragment.appendChild(document.createTextNode( temp_div.childNodes[mynode].data ) );
                    }else{
                      fragment.appendChild(temp_div.childNodes[mynode].cloneNode(true));
                    }
                }
            }

            orgStart.$.parentNode.replaceChild(fragment, orgStart.$);
            //Reset cursor to before next element or end of the editor's content
            if(nextElement){
                newRange.setStartAt(nextElement, CKEDITOR.POSITION_BEFORE_START);
                newRange.setEndAt(nextElement, CKEDITOR.POSITION_BEFORE_START);
            }else{
                newRange.setStartAt(editorInstance.document.getBody(), CKEDITOR.POSITION_BEFORE_END);
                newRange.setEndAt(editorInstance.document.getBody(), CKEDITOR.POSITION_BEFORE_END);
            }
            newRange.select();
            evt.cancel();
        }
      }
   });



});



#5535 Stack overlow in IE6 when pasting strange HTML IE HasPatch Bug confirmed Normal
Description

When pasting HTML that contains lots of nested tags, IE6 throws an error: "stack overflow at line: 27".

Steps to reproduce

  • Open _samples/api.html
  • Copy content from attached file
  • Paste it into the textarea
  • Press the "Insert HTML" button
#5580 Maximize does not work properly in the Office 2003 and V2 skins Confirmed HasPatch Review+ Tobiasz Cudnik Bug closed Normal
Description

Steps to reproduce

  • Go to the skins demo or the skins sample page.
  • Click on the Maximize button on the editors with the Office 2003 and V2 skins.

Notice that there is a space at the bottom and you can see other editor's toolbar buttons.
Tested with IE 8 and FF 3.6.3.

#5602 Using FCKeditor 2.6.4 with Media wiki 1.15.3 HasPatch Bug closed Normal
Description

Hi I'm trying to use FCKeditor 2.6.4 with Mediawiki 1.15.3. After I copy the fckeditor folder to externsion, and add the requireonce code andajax thing to loaclsettings.php, when I run the site, I get the following Strict Standards: Declaration of FCKeditorParser::makeImage() should be compatible with that of FCKeditorParserWrapper::makeImage() in C:\public_html\pedia\extensions\FCKeditor\FCKeditorParser.body.php on line 707 Strict Standards: Declaration of FCKeditorParser::parse() should be compatible with that of FCKeditorParserWrapper::parse() in C:\public_html\pedia\extensions\FCKeditor\FCKeditorParser.body.php on line 707 and the rest of the wiki site is displayed below it. Then when I try edit something, I get the following message Internal error Detected bug in an extension! Hook FCKeditor_MediaWiki::onCustomEditor failed to return a value; should return true to continue hook processing or false to abort.Backtrace: #0 C:\public_html\pedia\includes\Wiki.php(502): wfRunHooks('CustomEditor', Array) #1 C:\public_html\pedia\includes\Wiki.php(63): MediaWiki->performAction(Object(OutputPage), Object(Article), Object(Title), Object(User), Object(WebRequest)) #2 C:\public_html\pedia\index.php(116): MediaWiki->initialize(Object(Title), Object(Article), Object(OutputPage), Object(User), Object(WebRequest)) #3 {main}

#5603 PASTEFROMWORD: Should use the current editors configuration when reading config 'pasteFromWordCleanupFile' HasPatch Bug closed Normal
Description

In the current implementation, the pastefromword plugin loads the past from word cleanup file based on the global CKEDITOR's config object. It should use the current editor instead.

Patch supplied.

#5638 ‘ignoreEmptyParagraph’ configuration doesn't work in enterMode=BR Confirmed Firefox HasPatch Frederico Caldeira Knabben Bug closed Normal
Description

Environment

Firefox, config.enterMode = CKEDITOR.ENTER_BR, config.ignoreEmptyParagraph = true;

Reproducing Procedures

  1. Open any of the sample page and click on 'New Page' to clear content.
  2. Swtich to source.
    • Actual Result: There's one single <br /> left in content .
#5692 Handle file dropping in editor Discussion HasPatch New Feature new Normal
Description

Provide a plugin to detect desktop file dropping into editor, for those support browsers.
The detected file info could be used to upload the file immediately or perform any possible customization.

Edit: Yes that is most correct. Editor should have at least a hook for implementing drag&drop into editor. What I mean is that if editor is connected with file uploader (like CKFinder) it should prepare image information that uploader can use to upload file. After file is uploaded, uploader should send new image path and editor should apply it.

#5700 SCAYT doesn't work with 'replace' command HasPatch, Review? Bug confirmed Normal
Description
  1. Load the following content in editor;
    <p>
    	wrongspell</p>
    
    • Expected Result: The word is red-marked in wysiwyg mode.
  2. Open 'Replace' dialog and replace the word with "right spell", then close the dialog.
    • Expected Result: The red underline is removed.
    • Actual Result: The red underline is still in place.

#5701 [IE] SCAYT wrong status after enter key IE, HasPatch, Review? Bug closed Normal
Description
  1. Load the following content and selection in editor;
    <p>
    	wrong^spell</p>
    
    • Expected Result: The word is red-marked in wysiwyg mode.
  2. Press 'Enter' key at the cursor position;
    • Expected Result: The marker underline is removed immediately after key down (Firefox behavior).
    • Actual Result: The marker will remain for a while until next refresh happens.
#5702 [IE] SCAYT context menu with "Menu" key HasPatch, Review? Bug closed Normal
Description
  1. Load the following content and selection in editor;
    <p>
    	wrong^spell</p>
    
    • Expected Result: The word is red-marked in wysiwyg mode.
  2. Press 'Menu' key at the cursor position;
    • Expected Result: SCAYT menu options are shown in context menu.
    • Actual Result: Context menu opens without SCAYT options.
#5717 SCAYT options must be the first in the context menu HasPatch Sa'ar Zac Elias Bug closed Normal
Description

The SCAYT suggestions and all SCAYT relative options must be the first in the context menu. This is the common behavior on applications, like MS Word and Firefox.

#5745 iframedialog plugin HasPatch New Feature closed Normal
Description

The iframedialog plugin lacks some basic configuration options, like CKEDITOR.dialogDefinition.buttons .

I made a small change (see attach) that should also keep things backward compatible.

#5773 SCAYT: Memory leak in IE IE, Review?, HasPatch Bug confirmed Normal
Description

In IE6 there is a 8MB memory leak every time an instance of CKEditor is created.

Confirmed using Process Explorer, after creating & destroying CKEditor 10 times (using AJAX sample), memory usage (private bytes) jumped from 9MB to 90MB (tested on IE6.0.3790.1830 @ Win2003/SP1, also reported by user using IE6 6.0.2900.2180).

I have attached a dump from IE Sieve.

1 2 3 4
Note: See TracQuery for help on using queries.
© 2003 – 2022, CKSource sp. z o.o. sp.k. All rights reserved. | Terms of use | Privacy policy